From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B77E4C48260 for ; Tue, 13 Feb 2024 09:18:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E8EA6B0075; Tue, 13 Feb 2024 04:18:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 499A36B007B; Tue, 13 Feb 2024 04:18:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3615D6B007E; Tue, 13 Feb 2024 04:18:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2888F6B0075 for ; Tue, 13 Feb 2024 04:18:40 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id EBECD8042F for ; Tue, 13 Feb 2024 09:18:39 +0000 (UTC) X-FDA: 81786230358.10.91D8E58 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf24.hostedemail.com (Postfix) with ESMTP id D3DA5180026 for ; Tue, 13 Feb 2024 09:18:37 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="0RefKy/B"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=lKYqmnyW; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="0RefKy/B"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=lKYqmnyW; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf24.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707815918; a=rsa-sha256; cv=none; b=YwnFWN0lnHDhMR/V+OUb+yg5L5oGQ3zcVeXi71VGtsYRRmR37WTANmzvnhoitY+pkW4sN0 CLtcB1dllBNiGeGmPbhjvvTNj9tLf19Fpn961EuIMr0h6HluOpIR0h0Jj2LuEorHj+pfEL rbEwASfWEp8wLn5wki96HocWSC2P60Y= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="0RefKy/B"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=lKYqmnyW; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="0RefKy/B"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=lKYqmnyW; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf24.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707815918; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ebQ/QBmagH33BuOSYaJpuDXGz/X0XyWgvNd0wEUstmk=; b=fT3Ah6+iSjqo068iGEIQi+IygwA/K8nncLdP2BwaLzrR5H5uu/6IQ+MPJKZ4t21tt6XI5G PxC3RSME/G/1uw1XFCLqBPUwHfTxWwKUU89yH74d+iNXgUN1effQ7brRI9KmBzOSP2yAqx +WnGNkJtkvZ6oE1bQh0ZRJDGPoAGRr0= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4AAE321C24; Tue, 13 Feb 2024 09:18:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707815916; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ebQ/QBmagH33BuOSYaJpuDXGz/X0XyWgvNd0wEUstmk=; b=0RefKy/BFhW6IL4S8ZED0cHTokViyCdUZdXFqd8QDtpPHktN1KHvGTvv3VM2xkCUyXNuFe e16OA0s/AlSETxp2TXJjv/GKqaOvoNidqEYXScRdx4FedhAYfner85CnTqGTHzKPTP173q wq0kG9DCndIAIrrvIWVulYGLMt/jewc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707815916; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ebQ/QBmagH33BuOSYaJpuDXGz/X0XyWgvNd0wEUstmk=; b=lKYqmnyWD/dpwkkLrpGerzGn0YJfZ0bOQhltIjMTlsFCPHmtV4EcU4rnOm8zMVqEcZbEUk Uxpxi7tEy9ygw9DQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707815916; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ebQ/QBmagH33BuOSYaJpuDXGz/X0XyWgvNd0wEUstmk=; b=0RefKy/BFhW6IL4S8ZED0cHTokViyCdUZdXFqd8QDtpPHktN1KHvGTvv3VM2xkCUyXNuFe e16OA0s/AlSETxp2TXJjv/GKqaOvoNidqEYXScRdx4FedhAYfner85CnTqGTHzKPTP173q wq0kG9DCndIAIrrvIWVulYGLMt/jewc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707815916; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ebQ/QBmagH33BuOSYaJpuDXGz/X0XyWgvNd0wEUstmk=; b=lKYqmnyWD/dpwkkLrpGerzGn0YJfZ0bOQhltIjMTlsFCPHmtV4EcU4rnOm8zMVqEcZbEUk Uxpxi7tEy9ygw9DQ== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id C8A7F13A0E; Tue, 13 Feb 2024 09:18:35 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id 7qDHLeszy2VGIAAAn2gu4w (envelope-from ); Tue, 13 Feb 2024 09:18:35 +0000 Date: Tue, 13 Feb 2024 10:19:45 +0100 From: Oscar Salvador To: Marco Elver Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vlastimil Babka , Andrey Konovalov , Alexander Potapenko Subject: Re: [PATCH v8 3/5] mm,page_owner: Display all stacks and their count Message-ID: References: <20240212223029.30769-1-osalvador@suse.de> <20240212223029.30769-4-osalvador@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D3DA5180026 X-Stat-Signature: tjna9ugyophyrc3g7hmpz5sjoa9te676 X-HE-Tag: 1707815917-245664 X-HE-Meta: U2FsdGVkX19OS24RfAjVR4u3ChLK5hESdnJtt0BjQXd/mnR4iN064Wo8i4Z81dDcCjybUuCXYz/nPpWqpN4HBkw+pXvatO7Gpb4em+nkPzH7YuKkIaK6PagFj9nVbvvXcwzcD0lFS34juzMlXKOC00g2s9L2WnxlccZh8dSUX2f5NjkrysIExwoRIBrkFrXVZbOsIMCz9k+hNDp3qWJIxgS8ooJThmPolSZMf96WVn0XuGED+06aeMwyMIxME/EEY38vqcqKXgJ6BdI18uR+AfY/QjGlTNBUBcKA1A1bE3fO6isvJwn8E6bYYfuXaKPlNqZftWbvUTPQayOsblwTNH95qQBeLfNfnIQZ+OtDiAahMUY9AbZl/fnbKshcq34Qxva6ORfnBN223d3xPxqRMiUBWbn0wcHZK6nCR0JHbJatduiAcKkCeKcPKJQZKEpQFk37jIxfS57P+of7tsz4qXxqHwtJOTrgDOQxMWVFgg2615L6j7afCcYXIiLscmA/YsSlhxPYxgNjqgncfCuGFGzbo8HJLrM8GqOxwJLWhwac7mquA7WaDQf7OgBczH/06bLj6NqxInXtzT+wnZ9Mah6yNXfvDeFkKgWWAC3FKMvZqk2aEsOHE2NIavLak+2x+cjmXgzJV+vYr97Ix9MBOQcnTEdtspuht++GH4YP31Whn5EgMC8Hckr2uv/ze8kQ1RCfGkTBPDRvt64THp/m0I+A6xev1ritOKJAWUSQy3HJmbzTV13LdCZHOJPaj+mrcY+foj/xIwg/U6YoC0ZFfdNzGS6bscsLt16uY4i1rffZ6gavQqHMp2tDkJOFbHf8htYIYAsdsMOxMecJ7syjNA7pnHRSuw+qR0sGlHzle+r4afl+iaYzoY6zbWBiHp2BnZpU3DBkFqjC/N25z6DNTzoEuALCasfljOXIDjHt/+0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 13, 2024 at 09:38:43AM +0100, Marco Elver wrote: > On Mon, 12 Feb 2024 at 23:29, Oscar Salvador wrote: > > Signed-off-by: Oscar Salvador > > Acked-by: Marco Elver Thanks! > > + /* This pairs with smp_load_acquire() from function > > Comment should be > > /* > * > ... > */ Yap, fat fingers here. > > + if (!*ppos) { > > + /* > > + * This pairs with smp_store_release() from function > > + * add_stack_record_to_list(), so we get a consistent > > + * value of stack_list. > > + */ > > + stack = smp_load_acquire(&stack_list); > > I'm not sure if it'd make your code simpler or not: there is > for singly-linked linked lists, although the code to > manage the list is simple enough I'm indifferent here. Only consider > it if it helps you make the code simpler. I will check if it eases the code somehow. > > +static void stack_stop(struct seq_file *m, void *v) > > +{ > > +} > > Is this function even needed if it's empty? I recall there were some > boilerplate "nop" functions that could be used. I will check if seq already provides a dummy function for these cases. -- Oscar Salvador SUSE Labs