From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F300CC4829B for ; Sun, 11 Feb 2024 20:41:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41EBC6B0074; Sun, 11 Feb 2024 15:41:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D8DD6B0075; Sun, 11 Feb 2024 15:41:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26F8D6B0078; Sun, 11 Feb 2024 15:41:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 156016B0074 for ; Sun, 11 Feb 2024 15:41:30 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9CECEA19F8 for ; Sun, 11 Feb 2024 20:41:29 +0000 (UTC) X-FDA: 81780693498.11.8D37F7A Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf15.hostedemail.com (Postfix) with ESMTP id 6AA08A000C for ; Sun, 11 Feb 2024 20:41:27 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=MyXTaJiR; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=J7a71SOP; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=MyXTaJiR; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=J7a71SOP; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf15.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707684087; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WcBULlLtnxtGKkTdBEx595CYX4r6oCzp34j9F9t8PSI=; b=4EC2NdZ5ZBx+tPib2VnZ/7/e4t5sXKAAEIJVC1ijB0BdLfFFHhuGIshI+3BkDU95m9g6Ed fjZHC4aGwITxSDeGgjTUtpHla4yBrOj26gf8pgsE9yziWb81Xm1B5vj4JAujfx5IwqQ4t3 SJGOSZXM7PP72isAAKKYOrJvDCq6nPY= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=MyXTaJiR; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=J7a71SOP; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=MyXTaJiR; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=J7a71SOP; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf15.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707684087; a=rsa-sha256; cv=none; b=IDe1GwRhFABrjeyn/2VvQ1KIQ1WDGXT1VdmEkoN9rA1SXVxHihMxxO3gPZ80yXv/IBONbm cUEEtZq/1EeD0JIBPLemfT+TDaGJDXpJbaxZgxIoClAJGglfS5ylyu49tNRSpckZqM0+S1 6JnI3CGnrwWMGfujuPh1Ams7ln/keSI= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 91288210F5; Sun, 11 Feb 2024 20:41:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707684085; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WcBULlLtnxtGKkTdBEx595CYX4r6oCzp34j9F9t8PSI=; b=MyXTaJiRalkoTp+bf2JxHPLrBfP+1XwD2SH3prRHwpdfV85NcIemiGwR0kGjvn/ASCKU13 +D2A82g10t2f/1vQg13JRozSsix2lru7XfugMSrTcfAmZISuFoeVUCeE77cBU2l+czmtHk RSXzQyqzLGy76dabmlruUjeBk9orNsA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707684085; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WcBULlLtnxtGKkTdBEx595CYX4r6oCzp34j9F9t8PSI=; b=J7a71SOPBbU5a015CX+2Ux6ut3dh/FRXuGG88uKovPInErFi3bWcHrUj6fHtSMIbvRHBMj hcXz/beBwt8QzXDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707684085; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WcBULlLtnxtGKkTdBEx595CYX4r6oCzp34j9F9t8PSI=; b=MyXTaJiRalkoTp+bf2JxHPLrBfP+1XwD2SH3prRHwpdfV85NcIemiGwR0kGjvn/ASCKU13 +D2A82g10t2f/1vQg13JRozSsix2lru7XfugMSrTcfAmZISuFoeVUCeE77cBU2l+czmtHk RSXzQyqzLGy76dabmlruUjeBk9orNsA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707684085; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WcBULlLtnxtGKkTdBEx595CYX4r6oCzp34j9F9t8PSI=; b=J7a71SOPBbU5a015CX+2Ux6ut3dh/FRXuGG88uKovPInErFi3bWcHrUj6fHtSMIbvRHBMj hcXz/beBwt8QzXDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 172E213985; Sun, 11 Feb 2024 20:41:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id +t/iAvUwyWXnUAAAD6G6ig (envelope-from ); Sun, 11 Feb 2024 20:41:25 +0000 Date: Sun, 11 Feb 2024 21:42:33 +0100 From: Oscar Salvador To: Marco Elver Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vlastimil Babka , Andrey Konovalov , Alexander Potapenko Subject: Re: [PATCH v7 2/4] mm,page_owner: Implement the tracking of the stacks count Message-ID: References: <20240208234539.19113-1-osalvador@suse.de> <20240208234539.19113-3-osalvador@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 6AA08A000C X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: d7orwortmrfpf54bybrz84trcmbum3nn X-HE-Tag: 1707684087-354689 X-HE-Meta: U2FsdGVkX1/zdoq7MCa8YsYNvT6YDL/wRu86AsKgtFwUdhQzmybKKd531J5p9LNUxtJBwbNemqpNtSIWvYViK+KU5iTekAhV2boKFQ/QuWUo2+1gMp61G5vIL1RGbhkHX6K+kr6GwICon/ZGt5LbYRlh4saf8uXq+lEA4jfMaOM54x8vq3n7bqpSMEDFHsJRkG/JccBDvr6MSyLJxFrH2A9neKnW4Liwy1XTp16led6cK1v3rjEVZVPy/HjMTNU0SAA7BvhXo3vfrXbOzXGTpicfze+fH1j6ewzomsZUrq03ngRRQrIxO8V1/1mX+l2rQtgFxwkky5TkvwxW8I6/xfAAJ8jGa61LKHxWYWOtLZLE0ghZOrYj0VElG0HmqFqpBpjoxMiIHTuHcdbmuN//LJbeKszpxuD5Fs0dpdaZyGdiI4vqxCv+pxdwJfWZSgJgNfVsV7mbWxDdFxjtu2z60vlW0DSOI68PlX+pvcShaJfVC6HPyx2YI8KwyOmrHwHumq0BE1YvkKXElTgYJhhGU02iCA4W3qoL6dPMUtMBg5G66weivha2HfzvEw/T2Q5UdXRk2ZNg2bN3KP6jz+ZD3K8D+mWL3tU2nINRVXJimWcBvX6alkP91sG8bTbv40s4+HUFFStilWX+K5rMpqrriKX0zy1kB5N0cnKRKVGHvJuFGJ85gRKawBeWA35eHAJaACvNob1+RsVlVrPUO6ZRC+AwYxUveEcWclTdQ2nml6CrxPqgoJX/DpaLZF1vYtvE71biD1Lq88MmXH4mPsGdfWCogRXHGWABzAKjvz/WSLfKz3ovyuEYBKgJkcxTCHKdD2s8N2MtBKFlDuZc4lBMVwu3x2l6Hnpyc78YZqpJ7KIjYbyOIBUEIRGPsF/wxUO4igJkZP54FZDb/PyrWpt5YVViNfBVtKr7KhA789Sh0EI/FP4RIvvbrPu//W8F5sO44GSiEuZ+r3kR/hLLNH3 nNko0CkB KUFqY9uaefOVUQQb8BNin588IrbvKFb5oxYzLFgJ+VWkmM1vK0Tc7cNKvL0pEw7gVZ/mCQbQoG7qxcombB/hzs5RYelpMi8mQQx0kTbEmai4G05VDV8EFDGgKjkrDJO1UIUL7gpJDJSoGtNNzDpu4/SmS3rwVZccq+4mPc00+8fFdcxRiJQd+e9IXnQMy2aTpGJ5Lt2FxyP2gPotOix0Ux8MGk0CiT7PdT7I/hBv1tDaRwYArVtmlDuxx6nhd6AlextEf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 09, 2024 at 10:44:23PM +0100, Marco Elver wrote: > > > * set a refcount of 1 ourselves. > > > */ > > > if (refcount_read(&stack->count) == REFCOUNT_SATURATED) > > > refcount_set(&stack->count, 1); > > Do you need to inc the first allocation? Should there be an "else" > here instead of always doing refcount_inc()? Yes, I need to inc in the first allocation, otherwise on the first free op, refcount goes to 0, and when the next allocation comes around, I will get a warning because of going from refcount 0 to 1. -- Oscar Salvador SUSE Labs