From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FCFBC4828F for ; Fri, 9 Feb 2024 23:13:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B134D6B0072; Fri, 9 Feb 2024 18:13:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AC3186B0074; Fri, 9 Feb 2024 18:13:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 98ABE6B0075; Fri, 9 Feb 2024 18:13:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 885AD6B0072 for ; Fri, 9 Feb 2024 18:13:11 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5A0CE4028F for ; Fri, 9 Feb 2024 23:13:11 +0000 (UTC) X-FDA: 81773818182.10.5E03261 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf10.hostedemail.com (Postfix) with ESMTP id 296D6C000E for ; Fri, 9 Feb 2024 23:13:08 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Pd0xpMVC; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=VvSX5hPA; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=UtV1+l5i; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=YfD8xwCX; spf=pass (imf10.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707520389; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S9lpcBV9vzvFNtzllF8vaGWpSfSHINn8hx6gz8lR9do=; b=DG5fooFw+YbGnnnGu7zHGYVcGD1wi/JBJRIkAb/FdCThQPcT7+WqBdemx5jvy9ANz+Jbza Y7jcOfp19X8D1Bn5ppRyc95lMd+JrW24Ry3qRaseamWqbiJTWbt1bRR0yMleKsfZmJImYB sOh+RVwGpdMVG0S+06ubWo2Yex8CK4E= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Pd0xpMVC; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=VvSX5hPA; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=UtV1+l5i; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=YfD8xwCX; spf=pass (imf10.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707520389; a=rsa-sha256; cv=none; b=QVzEXSZ6SMiNpcZJZY5WT4upyidNHX/qzm1XdIhjvYcEAuonIwKPzpPtOAni7rwedw9Y9H aDzONlu1ZaQ8XJME7bd06+0tlVrLcHkgInxC9n44app5J2Y2cxPO4kiv2lnJEtS6st01nj q82P4+TtAY61DushaZ5yDuIK8gKoODQ= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C59FE1F836; Fri, 9 Feb 2024 23:13:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707520387; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S9lpcBV9vzvFNtzllF8vaGWpSfSHINn8hx6gz8lR9do=; b=Pd0xpMVCWk8lLJEwQIwXH9UVn5/spsULRig1/vCnyKM+gdyWu8qf7TV1TMWVRPYEt2YpNj 5o2hsBoU3qlcqwiA+ydpRRoFdcvn8fzlbm+XClOGjDHoNPen9ZydU66ZHa8ZmnjxfncEW0 FDNFgaIjXU4txDcbpQUnHP+ICFObajk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707520387; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S9lpcBV9vzvFNtzllF8vaGWpSfSHINn8hx6gz8lR9do=; b=VvSX5hPABaCgbXERSDBgxqWrEGkLFEvlaLRpTTGYlQnBYHwa/j/YvFEZPXTLiGxD/Ith4T 32PXNvM0j+3KbfCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707520386; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S9lpcBV9vzvFNtzllF8vaGWpSfSHINn8hx6gz8lR9do=; b=UtV1+l5iQa1XiClMk8rQKdiMwA+cUmzLzaThRsKzj+Rvw9veDnV4BUEr0seDDT48d1k1QM Sj5yD6FyEYlvIJPLgUs/4hqjnKlE7RxcqOgR8HL2VyKtNv+R/rnHOZOddcEixosunJMKwj vtSfBGFFD/LlXuvuHO7/F50NJnIZ/xw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707520386; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S9lpcBV9vzvFNtzllF8vaGWpSfSHINn8hx6gz8lR9do=; b=YfD8xwCXfxRTiyKLP33cUiRHKI4NdUAugrEAqxccd/IWuhcAn74QwKOPuS8MuBIFjuPrR0 jm6W1nFU5QpkCoCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4758613353; Fri, 9 Feb 2024 23:13:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id JZl0DoKxxmVKfwAAD6G6ig (envelope-from ); Fri, 09 Feb 2024 23:13:06 +0000 Date: Sat, 10 Feb 2024 00:14:13 +0100 From: Oscar Salvador To: Marco Elver Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vlastimil Babka , Andrey Konovalov , Alexander Potapenko Subject: Re: [PATCH v7 3/4] mm,page_owner: Display all stacks and their count Message-ID: References: <20240208234539.19113-1-osalvador@suse.de> <20240208234539.19113-4-osalvador@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 296D6C000E X-Rspam-User: X-Stat-Signature: xeypuawad3zute6m1mpxi1j4yiqj43wi X-Rspamd-Server: rspam01 X-HE-Tag: 1707520388-501338 X-HE-Meta: U2FsdGVkX1/JPvydg5DM2GF9UlBEWiHxEK/Zne0y/HeGiaOZ1T0ekDnVTiOdXqlWgOCOJ7E2TsFxp6MNXIz4DguUzYWIhg0yy8gcLbbHu6SwLz0IKR42/5+z15mCa79sDSEt/6XJ/JWitgZ9kT9YCJwvuhLHWCJecgQWcZN2Psy0CrT157K2LgTByrd7DI/RW1+BLBqnuOosNEZQkitBrJM98gnDqbg1fP0JRmk9GO3JMWQi5bku5NLRMdLIw6JHXUm8CFwyOdpNRnnH3AewA9RO31t6rsgfpOviu6CTiUTkxmEcG0eYQpAad+03vi8mIQ6ZnDC+XP1xibAGKkzlIvxHwyrusyfGNqmYUy/EFxXuiG3fF6ONqRVeG8JVeBsgqpIiU+12aqFuwzFfoobc1iyLi+9FTpuJ/QBZPK+WzPDHmLtPmlQst/DVLuH3U4EAihvLAZU418B3kMPstXqvQV1MxfGtX84q6cvc9F1ZAogEMAKa54uHewe8us45CestVLJEsD9p26IqgXzWYAWvZLqjNHQPVJMdKudwLImaLOvu3blyrACYyEntn8f286vx8S8B9jzhxgut73lSX5cOTAyatCSZcZBlgH8Vhxz+wANQsvA5LmEMCD2RjWXmI7NqoQwYs2rKpAZy+pCLUamfxX4K4Lcx+xQR9u0v2AoNr4nyrQ4tCqNQV508ncZiitZGaodR56NouLLkUFfRALBHTgryJuq9wMcOR3bbpxF8ba+i/HGvtme0RQLWNTmmoo0M5c/KWm3PqvYer0P7LvbTyA0bSatotr2ZQLrlHEsPo7goS7/rczosMTsC/ZrSBBNOIWjSXRAMv15wmQjiQz9RphLNs8hYkZQKGzcYipdI0bYRq/iPc35AiT7bKTppLCYl+++JtplDzX9W6qbol3qnueZ2rmjAiYcvnRiROdgSTQY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 09, 2024 at 10:52:48PM +0100, Oscar Salvador wrote: > Thinking about it some more, I think I made a mistake: > > I am walking all buckets, and within those buckets there are not only > page_owner stack_records, which means that I could return a stack_record > from e.g: KASAN (which I think can evict stack_records) and then > everything goes off the rails. > Which means I cannot walk the buckets like that. > > Actually, I think that having something like the following > > struct list_stack_records { > struct stack_record *stack; > struct list_stack_records *next; > } Or, I could use the extra_bits field from handle_parts to flag that when a depot_stack_handle_t is used by page_owner. Then __stack_depot_get_next_stack_record() would check whether a stack_record->handle.extra_bits has the page_owner bit, and only return those stacks that have such bit. This would solve the problem of returning a potentially evictable stack , only by returning page_owner's stack_records, and I would not have to maintain my own list. I yet have to see how that would look like, but sounds promising. Do you think that is feasible Marco? Thanks -- Oscar Salvador SUSE Labs