From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46004C48297 for ; Fri, 9 Feb 2024 21:32:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC2776B0071; Fri, 9 Feb 2024 16:32:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A72996B0075; Fri, 9 Feb 2024 16:32:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93AD56B0080; Fri, 9 Feb 2024 16:32:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 83B666B0071 for ; Fri, 9 Feb 2024 16:32:37 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 66DA3A243D for ; Fri, 9 Feb 2024 21:32:37 +0000 (UTC) X-FDA: 81773564754.08.55788DE Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf27.hostedemail.com (Postfix) with ESMTP id 2C2984001C for ; Fri, 9 Feb 2024 21:32:34 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=tissuEUV; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=4nUJ5Nsr; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=tissuEUV; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=4nUJ5Nsr; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf27.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707514355; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4ZvmyKdHVxJ/thojldSl4lvPiTjCgxInTW7G7s2pny4=; b=rFXDUL7ci4HkeLP5eumN+djp9HbIap+VZiaMwa5CZkQAXwTARVgv+5FYN5R8j5c2FCHAg4 MHhWEuI7fLoAi7+RVaZlt9ZHxjYrSZRjiT/eWg2Nu+xgxYPA13cjgKdBU7+tnP7FstWRap 26oEEkRcxCowmJ7E6xS5iotlR/MNP34= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=tissuEUV; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=4nUJ5Nsr; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=tissuEUV; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=4nUJ5Nsr; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf27.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707514355; a=rsa-sha256; cv=none; b=3n5W0szgbIjr5j3QFtbcocOKlRqcNmrcvrMJCRvWsNGmxXoVfG60s76H2N3/F8/Pddh3Z2 9i43sdPUq0eLKEg5lqctjqaqeW7l1Dsac/ShUNCphGIZyWG6H1v0VSd/AYW37svdWKgbbP FomieB3aFZ/zNHbG/Bqd8PQeBmA8tCc= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B44221F831; Fri, 9 Feb 2024 21:32:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707514353; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4ZvmyKdHVxJ/thojldSl4lvPiTjCgxInTW7G7s2pny4=; b=tissuEUVVKmNHAbiDR5CBTOnY3E0hBDLiiZmu8Rqo2W5UdesCWb3PC2NZQoGs6JYrm1xBB /CKqqSKgUGPyz1/TtvzQTLVje0D33EiCO3yrASvAVfJQWqXNCL2/ZnVdP1W5wbgb8/f/Gi 2P3RtSlK6DMm9DygNba5bJLfUAerDRU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707514353; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4ZvmyKdHVxJ/thojldSl4lvPiTjCgxInTW7G7s2pny4=; b=4nUJ5NsrpYpJPCqqQLkywTHUlmItn4kNSJg+9ImroxMcrnyv2PCKXQsnus4MGnUNi11jzz oKGhPSFeLT6gBECw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707514353; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4ZvmyKdHVxJ/thojldSl4lvPiTjCgxInTW7G7s2pny4=; b=tissuEUVVKmNHAbiDR5CBTOnY3E0hBDLiiZmu8Rqo2W5UdesCWb3PC2NZQoGs6JYrm1xBB /CKqqSKgUGPyz1/TtvzQTLVje0D33EiCO3yrASvAVfJQWqXNCL2/ZnVdP1W5wbgb8/f/Gi 2P3RtSlK6DMm9DygNba5bJLfUAerDRU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707514353; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4ZvmyKdHVxJ/thojldSl4lvPiTjCgxInTW7G7s2pny4=; b=4nUJ5NsrpYpJPCqqQLkywTHUlmItn4kNSJg+9ImroxMcrnyv2PCKXQsnus4MGnUNi11jzz oKGhPSFeLT6gBECw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3B5DC139E7; Fri, 9 Feb 2024 21:32:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id RZjHC/GZxmV3aAAAD6G6ig (envelope-from ); Fri, 09 Feb 2024 21:32:33 +0000 Date: Fri, 9 Feb 2024 22:33:32 +0100 From: Oscar Salvador To: Marco Elver Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vlastimil Babka , Andrey Konovalov , Alexander Potapenko Subject: Re: [PATCH v7 1/4] lib/stackdepot: Move stack_record struct definition into the header Message-ID: References: <20240208234539.19113-1-osalvador@suse.de> <20240208234539.19113-2-osalvador@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 2C2984001C X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 9qos8xg318sxqfawdcx66w4mh699dcsx X-HE-Tag: 1707514354-922597 X-HE-Meta: U2FsdGVkX1/K/Yk3HsBIIspjuuROdeG9+1iMyaolZ45RAm8k1zOg0X5O+vHLoLKkXrScjgqsikUzTMkdtUKNxq5yougB1Zb5sqDDBhdPzmAKyFW81gsTUbjhziY2b+Ifhyc1+75fyePmkqSs/CP9XV1umMzQUTevzDLtJFg/7qVT/YujbuBmc57s5ZpIaDS4pJPFPiNuxcpQXLaVNNy3UFWdKYAEn3m0fvrKUIZ1CX6KMZeG6liTNh4YT2t/vCBF3fbDG6gBkJmXu73mtP5sza+iTUDcprYx9n9Pqx+PbSNf2dbx9AxUj0mDSwvGW8tU5bkKohFAYkgD3PYF8QL1A/tEn7lrTkyQg1Xv6FvkCVxhLxSTkckp6kaP1PDUuCNnxDJSEvJ0ofFw+TFmfaztJVyBJFPjgQ4QAXpfsI9eYD+h0fe6MPk9fXHWVzYFBUzeoqqg/3MXo3+/+uJzZt2N7wgOZUm68rVbabdlsRgnjs7Dtf2Rj2YSIofmIDXig/7EoY7qIbRGWMAABJEyn7d5/0rb3/M/UGIqL/suMVH7c5pXfaXF8N453/k1lrrphHRkCxp/COIJoRL/XdUNC5ZgW8m8bMh1KCLQywhHifDJTH9mBD9gjZoQxqcsSgNjNl4cnIRSDSIowUkCwXx7zBtWSUf8sJz5NdtlfOi5xR1ZFA8eGZFI4SuWRyLoGmVoIaiE9SNgmgIT5WiwNy7c6J5Jlwgj7FH7YXkdZTKPuv4KKLGEPENJQO3S3A5ht/7G9qYw09ekMtjQbKMaxsRr+4MSkcWczRlxEwoI1ELIfuNKPL8K1Zcc1mvN+uHKy9HG3TSmkcA0V3lJkKQM81PJbVr22TbE/Tw1kiTJrkkViDUmfbHFs03g7UjbB4lObQfFY78DW1YoO6To9Gs+w7ZGl+wL+icNgDafTHc8WhFKaGwT0c2ts1+nogZNy82PhEGNkhsmKCPfFVtfUZIFrnfer3g ZPmtfXDQ uQX8E8hrNMEoyS97QuF3lmU3weW8oNo4XTChcTEtYc0GdO5+2TS8T7yjwpS+NzzHB0LhOaLQA0NNSZNmIiXvIIS1zYQm/8mSB7bRBsoBvNCg4MlxlYYKVvovXBfNZit8A7wBgowi7ewoTGhGMc1zAqESvRn4Qoe2VQhF0uN8nbd2MyT65yJoxw/1NaI+EHWoBk+JYLM36bkFj2gmDkN4zTUpkNqowHAM/3M8k+qUerfy4Pu6DAE0i0qS4yMXg6wgzF1I8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 09, 2024 at 08:45:21AM +0100, Marco Elver wrote: > > -#define DEPOT_HANDLE_BITS (sizeof(depot_stack_handle_t) * 8) > > - > > -#define DEPOT_POOL_ORDER 2 /* Pool size order, 4 pages */ > > -#define DEPOT_POOL_SIZE (1LL << (PAGE_SHIFT + DEPOT_POOL_ORDER)) > > -#define DEPOT_STACK_ALIGN 4 > > -#define DEPOT_OFFSET_BITS (DEPOT_POOL_ORDER + PAGE_SHIFT - DEPOT_STACK_ALIGN) > > -#define DEPOT_POOL_INDEX_BITS (DEPOT_HANDLE_BITS - DEPOT_OFFSET_BITS - \ > > - STACK_DEPOT_EXTRA_BITS) > > #if IS_ENABLED(CONFIG_KMSAN) && CONFIG_STACKDEPOT_MAX_FRAMES >= 32 > > /* > > * KMSAN is frequently used in fuzzing scenarios and thus saves a lot of stack > > ^^ This hunk no longer exists, try to rebase against the version in -next. > > Other than that, this looks fine. Yeah, I noticed it later. I already synced the last -next and I have rebased it on top. Thanks -- Oscar Salvador SUSE Labs