From: Oscar Salvador <osalvador@suse.de>
To: Marco Elver <elver@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Michal Hocko <mhocko@suse.com>, Vlastimil Babka <vbabka@suse.cz>,
Andrey Konovalov <andreyknvl@gmail.com>,
Alexander Potapenko <glider@google.com>
Subject: Re: [PATCH v7 1/4] lib/stackdepot: Move stack_record struct definition into the header
Date: Fri, 9 Feb 2024 22:33:32 +0100 [thread overview]
Message-ID: <ZcaaLKeKADD5L2cr@localhost.localdomain> (raw)
In-Reply-To: <CANpmjNOHchgjgJbM8OGQTTxE5wiAjt5rJE8UZYJgcF0y1EtBZw@mail.gmail.com>
On Fri, Feb 09, 2024 at 08:45:21AM +0100, Marco Elver wrote:
> > -#define DEPOT_HANDLE_BITS (sizeof(depot_stack_handle_t) * 8)
> > -
> > -#define DEPOT_POOL_ORDER 2 /* Pool size order, 4 pages */
> > -#define DEPOT_POOL_SIZE (1LL << (PAGE_SHIFT + DEPOT_POOL_ORDER))
> > -#define DEPOT_STACK_ALIGN 4
> > -#define DEPOT_OFFSET_BITS (DEPOT_POOL_ORDER + PAGE_SHIFT - DEPOT_STACK_ALIGN)
> > -#define DEPOT_POOL_INDEX_BITS (DEPOT_HANDLE_BITS - DEPOT_OFFSET_BITS - \
> > - STACK_DEPOT_EXTRA_BITS)
> > #if IS_ENABLED(CONFIG_KMSAN) && CONFIG_STACKDEPOT_MAX_FRAMES >= 32
> > /*
> > * KMSAN is frequently used in fuzzing scenarios and thus saves a lot of stack
>
> ^^ This hunk no longer exists, try to rebase against the version in -next.
>
> Other than that, this looks fine.
Yeah, I noticed it later.
I already synced the last -next and I have rebased it on top.
Thanks
--
Oscar Salvador
SUSE Labs
next prev parent reply other threads:[~2024-02-09 21:32 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 23:45 [PATCH v7 0/4] page_owner: print stacks and their outstanding allocations Oscar Salvador
2024-02-08 23:45 ` [PATCH v7 1/4] lib/stackdepot: Move stack_record struct definition into the header Oscar Salvador
2024-02-09 7:45 ` Marco Elver
2024-02-09 21:33 ` Oscar Salvador [this message]
2024-02-09 17:39 ` kernel test robot
2024-02-10 9:59 ` kernel test robot
2024-02-08 23:45 ` [PATCH v7 2/4] mm,page_owner: Implement the tracking of the stacks count Oscar Salvador
2024-02-09 7:37 ` Marco Elver
2024-02-09 7:45 ` Marco Elver
2024-02-09 21:39 ` Oscar Salvador
2024-02-09 21:42 ` Marco Elver
2024-02-09 21:44 ` Marco Elver
2024-02-11 20:42 ` Oscar Salvador
2024-02-08 23:45 ` [PATCH v7 3/4] mm,page_owner: Display all stacks and their count Oscar Salvador
2024-02-09 8:00 ` Marco Elver
2024-02-09 21:52 ` Oscar Salvador
2024-02-09 23:14 ` Oscar Salvador
2024-02-10 7:52 ` Marco Elver
2024-02-11 20:39 ` Oscar Salvador
2024-02-12 10:47 ` Vlastimil Babka
2024-02-09 23:14 ` kernel test robot
2024-02-08 23:45 ` [PATCH v7 4/4] mm,page_owner: Filter out stacks by a threshold Oscar Salvador
2024-02-09 0:28 ` [PATCH v7 0/4] page_owner: print stacks and their outstanding allocations Andrew Morton
2024-02-09 21:31 ` Oscar Salvador
2024-02-09 8:03 ` Marco Elver
2024-02-09 21:32 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcaaLKeKADD5L2cr@localhost.localdomain \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox