From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDEDEC4828F for ; Fri, 9 Feb 2024 21:30:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4CE5C6B0074; Fri, 9 Feb 2024 16:30:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 47BE96B0075; Fri, 9 Feb 2024 16:30:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 343CE6B0078; Fri, 9 Feb 2024 16:30:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 266256B0074 for ; Fri, 9 Feb 2024 16:30:26 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id F2CD2160931 for ; Fri, 9 Feb 2024 21:30:25 +0000 (UTC) X-FDA: 81773559210.09.86B5D03 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf12.hostedemail.com (Postfix) with ESMTP id A3A6940010 for ; Fri, 9 Feb 2024 21:30:23 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Q+aQmEMh; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=esFzffAk; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Q+aQmEMh; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=esFzffAk; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf12.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707514224; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Kp0dxQbFEUpfqMPPcFXAyGBEsa9A8LuelYecqqm//04=; b=EmFyN9H8TIbZIMOSOROp+h5jNg+aUu5L+RRmy41lsIC5wSyQflpQLV3bb9ke1LpAnP+0Tj 6R7H8q+hUxN+ArPVbmWKeMmO6rmG02TVnpnLrUn/wX1ltx5HNM+pev02yeJKF+OYQM0lSl tvBhrKZizc4ZVN0F0BD0Rilr+2qSXNc= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Q+aQmEMh; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=esFzffAk; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Q+aQmEMh; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=esFzffAk; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf12.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707514224; a=rsa-sha256; cv=none; b=kHjlKqZ9jFHcvXXRaHK1kZjD18wrO5ZgHZ4MJwbnpCE7o0sE+Ww6y11FCAaS5X/MAivxXF 0MxmTERGqxyW2QnzpCa6UA4uOVguavhb9r7r8PvARrQF9BAH7Yf5UzbJJ9AJdOzxt/ABh2 1vUwvIpf2VEmh6n+hxYY5HY5YXB4woI= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 028B721C7A; Fri, 9 Feb 2024 21:30:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707514222; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Kp0dxQbFEUpfqMPPcFXAyGBEsa9A8LuelYecqqm//04=; b=Q+aQmEMhWPNZ+MVf1/zqwNdjgWSFK9m4lLZYkTw2naW4Ww7C2cgj+26ZRcv6t1zNwsahhm U3fLCM17taU6ay/+92ijFp0+9md4RPhu5JI+t45evBEWUZDGpinZXabfZuAL4JsiJLiDQY PtX+lpAmHp/b1ulMOA3QAhlGF0Bx1jY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707514222; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Kp0dxQbFEUpfqMPPcFXAyGBEsa9A8LuelYecqqm//04=; b=esFzffAky6mwPhZoT0CLJ8Mo0JIa2Kgaxg0vpx0gjrFImdcBbUOZLOf9Td2Y/iH/43XVtV kBEfgFmjRsUyEnCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707514222; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Kp0dxQbFEUpfqMPPcFXAyGBEsa9A8LuelYecqqm//04=; b=Q+aQmEMhWPNZ+MVf1/zqwNdjgWSFK9m4lLZYkTw2naW4Ww7C2cgj+26ZRcv6t1zNwsahhm U3fLCM17taU6ay/+92ijFp0+9md4RPhu5JI+t45evBEWUZDGpinZXabfZuAL4JsiJLiDQY PtX+lpAmHp/b1ulMOA3QAhlGF0Bx1jY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707514222; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Kp0dxQbFEUpfqMPPcFXAyGBEsa9A8LuelYecqqm//04=; b=esFzffAky6mwPhZoT0CLJ8Mo0JIa2Kgaxg0vpx0gjrFImdcBbUOZLOf9Td2Y/iH/43XVtV kBEfgFmjRsUyEnCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 75154139E7; Fri, 9 Feb 2024 21:30:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id SkfYGW2ZxmUCaAAAD6G6ig (envelope-from ); Fri, 09 Feb 2024 21:30:21 +0000 Date: Fri, 9 Feb 2024 22:31:28 +0100 From: Oscar Salvador To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vlastimil Babka , Marco Elver , Andrey Konovalov , Alexander Potapenko Subject: Re: [PATCH v7 0/4] page_owner: print stacks and their outstanding allocations Message-ID: References: <20240208234539.19113-1-osalvador@suse.de> <20240208162818.369c7abc3ecb06d49adaeebb@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240208162818.369c7abc3ecb06d49adaeebb@linux-foundation.org> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A3A6940010 X-Stat-Signature: gacizooimh9g5ot98aiy6nop19wxrt8s X-HE-Tag: 1707514223-618409 X-HE-Meta: U2FsdGVkX19bDingcTkMoaunYlMiNdL9oiqgEHb2qYhugVJlOJabHmkJwsW25kWHLcXy9bc45uKpZral9E86sxQmyZa7+rCqmJ8sOuEI4Q/QFqnGKVx/kek1aSfXCHoVVpCQ4ie0/ouxa01XhFPoloPzZHfG3Hau/vn386md3aEzaveuEILxdCPFnZhio0qY1PMMijbevz5rOfbZZ2i7rvW05E0NNrK7f9OU67aE36Gu9E1IUjF8xULeYIJLh62TnicVGZRIpAIVah01Vh3UcutxA9vJl1AOl25T1zqjJewvopStUxijsTQzeNrxeiJscd+ncYiqHz1a0EUH2gGR6j6aZtzJtWFaYtPL4dokDBb70SAdQ0Wc1w4kyqfyBH9Y4ftMolCHx3m069KTUH7iCO5D1UkASDRsH+Hy1Ae1udeAyPv4IDyRdW0UrNKU5PPSA3rEY9wpzmIMH8wmwuf1/G+KDQtV5m3dn+9hBcewzQvvDMWtTDwElrnFWSPNhdeTJu1Q2HXwyTlXjTyO+hnXbsoAMJojdw+hmbDK+ZoeSaj8fn23rEMvtPiG7v8R+WWcWZTGpgecNFWBC/zvzAzVmZ5dmQ9WkIGDWxuZgqSMCDbeGYRBh8m8V+hPL5qwIg+hHcx6JJkBbmXE6yy7a5ftAM6YBmR2ti845F0uDhK7J1kcMOZCEFOXjBnyYlpmtZPKzBLX+KPSQGGgj5qT+rSQB/1RtCCo7GSeG03jJs0vPKibtNb3VY1rvAHxC72UrRI8g/WhNG9SR2q52yYyucRJN9t43Hpi4BrCZ+cWwFqJH7xsRzJr8FFJNb2bZJfYhaVdcR6cVmFP7+uYj1jjfGuWKfuNVqUyf43iHkh1ODhkYqOxGsU5RABpMo8UecS3QZkk5CYQGignHqlGbS9pmaaUBLkTPP+HO1e+4VlWrSLzLIQoRTTWOoUI7R/k1jtdCceu47UuRtYFZormpiQH+3o mtOG4QTr 1jscFUUFel3JffkJi2yCrprpbs9RAe71+lG6ebDMioPzrgc8lCFiZNLY3DSOrBkvOuwko0DHsldCXqHn7alJN5AH3Wp3V6JkmHvTlkpCOZRz2s635sN/7GWk4+wtEXwpLGicdi1iPpm15vPeHHAA87amgBQYKWDRi60pJcb1ZCEdBft6d+rOIAV4SGYxPOzztMC64sMwC6aypIjYoOKF+CfGlsJzzrJasrQBgqCSeXVBnTaaX1bWyuqrHxW7wRWQGsosV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 08, 2024 at 04:28:18PM -0800, Andrew Morton wrote: > Oh, there it is. I wonder why we didn't use /sys/kernel/mm/ I just followed the convention we use at the moment, which happens to be /sys/kernel/debug/page_owner_xxx. > Would a new /sys/kernel/debug/page_owner_something/ be a good idea? We > might add more things later. Then it can be > /sys/kernel/debug/page_owner_something/full_stacks. > /sys/kernel/debug/page_owner/ would be nice, but it's too late for > that. Well, we could certainly do that, so we do not scatter the files in /sys/kernel/debug/ but rather gather them in pagE_owner directory. Let me see if I can come up with a proper name. > > Oscar Salvador (4): > > lib/stackdepot: Move stack_record struct definition into the header > > mm,page_owner: Implement the tracking of the stacks count > > mm,page_owner: Display all stacks and their count > > mm,page_owner: Filter out stacks by a threshold > > > > include/linux/stackdepot.h | 72 ++++++++++++++++++++ > > lib/stackdepot.c | 97 ++++++++++++++------------ > > mm/page_owner.c | 136 +++++++++++++++++++++++++++++++++++++ > > 3 files changed, 262 insertions(+), 43 deletions(-) > > Documentation/mm/page_owner.rst? Heh, we are definitely going to need some documentation. Let me prepare something. Thanks Andrew -- Oscar Salvador SUSE Labs