From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BF0DC48260 for ; Fri, 16 Feb 2024 21:50:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0B81E6B00AD; Fri, 16 Feb 2024 16:50:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0407E6B00AE; Fri, 16 Feb 2024 16:50:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4AE26B00AF; Fri, 16 Feb 2024 16:50:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D21FE6B00AD for ; Fri, 16 Feb 2024 16:50:13 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 90944801E6 for ; Fri, 16 Feb 2024 21:50:13 +0000 (UTC) X-FDA: 81799010706.19.9C5F7ED Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf30.hostedemail.com (Postfix) with ESMTP id E6A378001B for ; Fri, 16 Feb 2024 21:50:09 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=IUmM3Oul; dmarc=none; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708120212; a=rsa-sha256; cv=none; b=n135nup2I2Xaw6opKX857CkJkWXYG23x8AyZVWC8fJwoF2FpmPaWb1rp+nrzuG/R/im4eY 90YEMjTkmIoaOW8w8SprXPm3wy201heXvMxhxxe9IWuSGUlDxH10U3h3cBCVXoQCZmA5Vn HWNY3F0qN1DYE9nJAcDVuVFEi7yT2hk= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=IUmM3Oul; dmarc=none; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708120212; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6ImZiREhBrMq4AWnxqY5yboGSGsxPSUPiaLAI0+rRZ4=; b=GksP8PxYEqObMQIG6UW3WPufnH34Px6ooInpbGoG2652lAgVC4XKPAXDj5aa8d7CJoJZIH NlNUvbvLk6RAWuHEqAQkZPkWfHkLIdCVCjnv2eJXRkQdWaiyzezJ+TLvlCpUG20Q9p95sv 1NP5Hn9imNqhXZE+TMEw51go88JfWXo= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=6ImZiREhBrMq4AWnxqY5yboGSGsxPSUPiaLAI0+rRZ4=; b=IUmM3OulO6dKlT1g/3V5IkgGUE OegQwcNeGt+ZwWOg5bUgzPREhD/4t6JHicocHj7dGDXK++NKAuYVviF4+nUQUI//1FJfzrhQ6dJk8 cU/yU8Ju9mALmHZFFixRvRuF2c45t7t0Yr9hgdlOAQ6BWXMwV+AlbOURTG0uySseoQ58P/9uGoV6r jVOdw2ERDbNe3Jz8zKW6RXZFpPavpfHX8/xzSfaWwuYbJS+7nEMQnXbRF3IgKhRiRY1VdGsjbWtxo GQ7JJlkutKfNUwCA+54iwhhYlaVSu/n9GJ01SAzU9Zk3GOdHAENpJ0LN51jMz4gugTm4k7l7D8xwh pkniriAA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rb65p-00000005kPR-1ZGg; Fri, 16 Feb 2024 21:50:01 +0000 Date: Fri, 16 Feb 2024 21:50:01 +0000 From: Matthew Wilcox To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, apopple@nvidia.com Subject: Re: [PATCH v2 1/6] mm/migrate: introduce migrate_pfn_to_folio() Message-ID: References: <20240216211320.222431-1-sidhartha.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240216211320.222431-1-sidhartha.kumar@oracle.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E6A378001B X-Stat-Signature: q8nn5ez17sgf3njseqapo38589uec3k4 X-HE-Tag: 1708120209-897141 X-HE-Meta: U2FsdGVkX18RoV6MUmte+V6Zoexigi5x2fcR5KmiEb0hQiWyuGLNQWNEuxfno/sZcP1DtcpGPgfvPuoLNA27nxxV6OzubdejF8p+z6dQ6LRYpHUhQPdAXstgVRhwY9DhXTssMAve9f466FjgTohQar94GTSzGOtbNxWwH6eVwe2hBwwWiS05LWXIzaX1fy3rQE13n93k747voMSRryd5KMTueH6dkdCPQzwREb4buzc+Xjzd6IvCPkvO0cn31T6o/DXDRxFJHQjIUr57Wxy1kE1iYrxSF/ZstYg58fSimgYYSURvvYoKphmi0qVgldluytkTnEPB1vlqrGHSbJVuSImpcEbqbZiHgPkyjPsNqz6HOXWrF1qJho1negV1HV5y1jEsLypPPYhaC95/4QeulMzeE8h/VJs7Ckk8XuVRZKDkhcsGwM9Ip73yvqISrQSdgjYWGX1c6LESEc+uZjTy15U4NMdb2rlG90JQmEG3OPCS3Zb6cPR0iAOvpzo+Kfp9ajKRrFlApN0R5FNHkTEUVwco06RDv0C4YrlL12ML9phHZB6YNAMNpQgYuHaFGpRHUuvQYAEAEmrx4R+KSGU0Sc2/AcS883tuih+f9KdO5LgzG1YIROFW5KblJvt5Obk4tkq55Ohqb7ZhlJFIBH0IgIYth+mWkT6UqTXmeuzNl1BLnTMWXarioyxA50jmPQGF9U4us69gcJX/qllymeusshadgjKsWzTH/Da4V7hHspXE9dAykI9N4BPC/hXnW8wjtKg7lQ6MXJtmm4Nc67xYzVmJ32mAdZvK8FknV05wK6Fi4yiTYDmshB9CvX+9qZEGLGs1l8CBPk2CMF9Eb5cUj9vpTiZ+ImKWmhBCaHvy8okwQiHumqRHZ7VqlaKXQiJn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 16, 2024 at 01:13:15PM -0800, Sidhartha Kumar wrote: > +static inline struct folio *migrate_pfn_to_folio(unsigned long mpfn) > +{ > + return page_folio(migrate_pfn_to_page(mpfn)); umm, no. struct page *page = migrate_pfn_to_page(mpfn); if (page) return page_folio(page); return NULL;