From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C730C48260 for ; Fri, 16 Feb 2024 21:51:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A08946B0092; Fri, 16 Feb 2024 16:51:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B7476B00AC; Fri, 16 Feb 2024 16:51:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A6AE6B00AD; Fri, 16 Feb 2024 16:51:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 78F786B0092 for ; Fri, 16 Feb 2024 16:51:37 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4AE62C0184 for ; Fri, 16 Feb 2024 21:51:37 +0000 (UTC) X-FDA: 81799014234.14.3D68EBB Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id CD7F4180018 for ; Fri, 16 Feb 2024 21:51:35 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=FWsU4Mnn; dmarc=none; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708120295; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F/d77mOZpymq/QjhDN4sQI8qnbKDDHBwnLdqx/RJq80=; b=z+vk8IDKU6mWKSvuRfduNEeF+mwgpjxLU5j7DjMcT9kIKOchuXDLHo60Zxg5oNYPeFt2dS lieg0UUjgxpQ7GHv0FFOTo23y02WhwYDJdt4Bn3od1Q/decRStkp1GM17M/lGCSjMbhm6o 5u09MEN4d9xM8iRWMjm7kAe322L/yoc= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=FWsU4Mnn; dmarc=none; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708120295; a=rsa-sha256; cv=none; b=NsQvvgY/0zkdKnODhjlZTDIYAD3+GUkxqMmDn1cAWhu+0wS7tgYtPa0d6E7bb1MMBVMBsd 0mKquu3J0T6ChZ3mAJ5gkMaQ+IpRg4Rmf9hVjeb9/5/WeoK/PvarWgSgQ5kySIz3KvPBBk KdaX7VCiv1HYsYQZqi1ffaghvv509ac= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=F/d77mOZpymq/QjhDN4sQI8qnbKDDHBwnLdqx/RJq80=; b=FWsU4MnnWkT180rHy8EX4JrqFI W4B/fytKg4dXU+KXkHiYbWv0N2PTHkneBwk/SlyeCPfpLYIeOMA46mkoMijUct9jTh1vAgJnSK8jO dQ+tiwmk2D94Wv1EoJ6MkhN4HzalJ6VOZxvJTXixnmlRWJDOaylVBm2rMyFQcD0Z67qi6rPbxeyhb IWSS3J1r7uEuRcR1CUcT9HxQGTQ9Y+S2TlgduQ6AGBR3H5e7YUXMryUzxvL76gXxDvOrYdp01iclx qT8abDeyqaQ5jMG+5FVDP5+tjWxr6kRUvDpk8RnAth2Ao2HHg5UWou0Foy8ltSBfAWrIM2c7tXzXh 11jWZXoQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rb67H-00000005kZ6-0hkK; Fri, 16 Feb 2024 21:51:31 +0000 Date: Fri, 16 Feb 2024 21:51:31 +0000 From: Matthew Wilcox To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, apopple@nvidia.com Subject: Re: [PATCH v2 2/6] mm/migrate_device: further convert migrate_device_unmap() to folios Message-ID: References: <20240216211320.222431-1-sidhartha.kumar@oracle.com> <20240216211320.222431-2-sidhartha.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240216211320.222431-2-sidhartha.kumar@oracle.com> X-Rspamd-Queue-Id: CD7F4180018 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: rqhxpuw5ur4x9o5ocfkrsqipujh1ct6i X-HE-Tag: 1708120295-140260 X-HE-Meta: U2FsdGVkX1+KzoNvBiQxW+brN25olTwdA2SQgCSr0739l6CSz3fEgjCRkhUZI+e5wCA63XFqQiixaL38tVPdaGlOiKKZs+5II4Bq64X7zalMHXcFH7+P6hN/MoRjFf8rnXLRJVKZZE1KXasiOUSD4dTs1NKYtfSr581TmYt5uEov2RuyCHkCjJxXXSRlowCYhzTKBUVdu36GcLJLGnrUk4cqg6m3h+MlQ+A0rgl8uHpuQF15MSP6TmiKH+pam79KHU9s9dejguKsczNjiawJXbN66Tir/7/D4pNc9o9xaSJbfDqUqED/5tFXZYOEhtHMlyw6zfgl5ocXaKTlVYU+gXfr3oYnHfa334GWd3GIbQdrlYTuKuISAZcKjzpZ+8B3CyyjY1e+C3MbyMBB5A0BqYidVqjGR0xrHN6elNwLlKlKWyMT9M2Q6OLYgO52WphfX9KFu8xX00/M7SPROwtvXMHjVHlQevOwdmJZXKlNoeELkJ77xjkd8Br74KEt2Rv3+RcBpO2rZ5Sr3xzOKwmi9z7MhJOjm7xcMN7rE79+v+GqnyufgRfEFm7uPdnDViCibXYld77xRQB3hyNYHMRRfFt57HCXm6TmQnNbxT8gRbyPFr20aJAwUvfLrQuKB4994C0WAiQAeobzLB25LKFSMXjYil+LTwBLV88fV0aasmSd+guIU8YbYL6uBLISTAZEZ1UVPQ3dQZpYDdMwS5CDMZAnzb43vEzAUB9nqi/c/J4DXqjgUl7xlyPRWAr2WUmd2g0ynvPnkl98MaO56DbIWNrLeNOC2PWu/qzPQ22+9sjTKSeOyvdSKjY75o3lgjev3Dgq/MEYYCDXIHMSdeN1cC5rMKTJktDUGUivCVdohvG/jtOcVQmi5EsBt2OmhOeV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 16, 2024 at 01:13:16PM -0800, Sidhartha Kumar wrote: > migrate_device_unmap() already has a folio, we can use the folio > versions of is_zone_device_page() and putback_lru_page. > - if (page_mapped(page) || > - !migrate_vma_check_page(page, fault_page)) { > - if (!is_zone_device_page(page)) { > - get_page(page); > - putback_lru_page(page); > + if (folio_mapped(folio) || > + !migrate_vma_check_page(&folio->page, fault_page)) { > + if (!folio_is_zone_device(folio)) { > + folio_get(folio); > + folio_putback_lru(folio); page_mapped() is not the same thing as folio_mapped(page_folio(page)). please include some argumentation about why this is a correct transformation to make.