From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29E7DC48260 for ; Thu, 8 Feb 2024 18:27:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 91C4A6B0075; Thu, 8 Feb 2024 13:27:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A4416B0078; Thu, 8 Feb 2024 13:27:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 745546B007D; Thu, 8 Feb 2024 13:27:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5E3B96B0075 for ; Thu, 8 Feb 2024 13:27:48 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D18721A045F for ; Thu, 8 Feb 2024 18:27:47 +0000 (UTC) X-FDA: 81769470174.18.16DFA2C Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by imf18.hostedemail.com (Postfix) with ESMTP id B0F431C0017 for ; Thu, 8 Feb 2024 18:27:44 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="m4edi/6y"; spf=pass (imf18.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707416864; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MhiQCIizSoOoGlOJh1aEc+Kedwwy9bu+6Ox2q8gZmik=; b=YLe9wZEYBYMAwOFGnAzm8PBvGf3Op8TD+drZILrRzZZV5TFUlvQsh6JfveSWGCV1VD+avn j26BdsAV4kag0IgrM5u5ouLkrJR0HHbjUki4ByKgPNekp13oI7vWnBxRlrjFnSCFu/UgTW gQ35M5ozrtvjE+lNlsTYDnSj+rraIic= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707416864; a=rsa-sha256; cv=none; b=N06Wo5YWmt4rddxGS5WTw5o3z0ortxdRIfqACadmlXDi3XonPA7IWdBvXHfZjhST57HsIT S0PjHEeeWHpkjUc/a2rh6MtECtXpKl1mikxP3PBO6aeCW+jCGle4LRBnf/XAjNBRwq9nzN QloPMnUqheA931t3hqOaf8BmWkLJpUA= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="m4edi/6y"; spf=pass (imf18.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-50eac018059so146517e87.0 for ; Thu, 08 Feb 2024 10:27:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707416863; x=1708021663; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=MhiQCIizSoOoGlOJh1aEc+Kedwwy9bu+6Ox2q8gZmik=; b=m4edi/6y1GFT6e+NeiAe/27hTCOTkCDEHZzn8kFhw7OLXxok0iiWlVUmuaxfA+naC/ f5cSJEXo091maHse/XvWXtnlitZqL39zHGsJNid4D5rxXV2PXysF/zzlFy5cDWJplCeA anPBTPspZOUs1y6H/uzIFM+wirnP7ooCQVkDiYCASQM8OROfPwlLzyBJLC1hHyYnaTtb B55tdFo0+3Fr/CMQEGbRfgvYxj+SpCPY7lZ6kC1bK8/tVf/ilhA6iHSMnMo/qMelysbC K1r65YL7zpwJGu8zyCudss3BQPZSqVPA4x9D3y6umOmsVHTdtfiWSW7r+epxxrIj5GaP o9iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707416863; x=1708021663; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MhiQCIizSoOoGlOJh1aEc+Kedwwy9bu+6Ox2q8gZmik=; b=OWLijXL/3AVjZNbCVcxy/hNgFH7oYOBG0PgeyYHUhLiczOaFc1gEhTkJeXH7fNRFs0 /J5acelxwIPG6cbO4hrZOPPszEzGZ5+umxVRKuchEkR6BrI9ic3FDj5TijZU2Avub8Wk Lbk4nLEPTrJ34wqiEuAaDM55218NFBMNOkBvx1Uyqz8XR9a680oVGuPtPEaWwh1fVE5Y Fb70t7rnek3aIt7wZBYBrC/b+n8Zl2f8ghzl1bO0Vfby4uiOEE9YGH5If2BHSa8vV04v YKYelUi4e13v7b9B6e++89taE9ChELNmOlL+OHGfy4LgNvcrm+TkMeGQRxxTFw90l/1R suTg== X-Gm-Message-State: AOJu0YwJ1Qbm0pu0fiTcO0AvAmQY8ARjJMKLfdjHoAFk5VPtxnd0ovpD aFbqdX44vTAMPudrKwzAUtqg9KyR8HLyCnSoXgSpqNXT7vf2C1wR X-Google-Smtp-Source: AGHT+IEt1TA9WaZV161QOsVJTKIO45dwFrmr5lsjYI1a2PuuFU/uotVfRvKIQ12At8iMiW8KxfJUKw== X-Received: by 2002:a05:6512:3ca3:b0:511:4fb4:94f4 with SMTP id h35-20020a0565123ca300b005114fb494f4mr46153lfv.53.1707416862702; Thu, 08 Feb 2024 10:27:42 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCW73WLa6OSXt77bWdX/B/C6TGTeT1GCQPBjP9edjIgotYXUWF9+OyugsyGpxeAbsI1Qa7ibGuUaCMI1fgW7xbP2ZnhjXPqLApJwox89/312sbZI/9/NLizNPLJwj3ZJ7qTQfHZ3C/DvcYaVhsiZMSxEjwxHi6Vg3W7SNpMbGaOA4BbkPgSj2CSNDUi6fNWjYsOlNmTrmaStBrrLUBSKT6N3q6TJCXS6YrrazEBXzSXx46MjBkTdWPROUHw3RtSULg3F+BxX5hZKA7YLjAU8DoXj6jIh3vRvFW16i58N5fObGPpcrnuAu8xn8q+GSdLPfHQ9/JSm/x2PTLlMT5cjoDSZapNi+42P1EqwdgQBKeZUgUm2+6fIn3etemm1PgnaxJZN1pmnyr8TKZ/MR6X5B3m3Vst3IbIwODfIpuqdQsT62z9Ia/jNPnaRFfQTYATfWWVkfKzRSxw1jwYmPYKAzOzXVGBeFwmKmaL4tekmgheOOsROPWrQKW0e Received: from pc636 (host-90-233-221-0.mobileonline.telia.com. [90.233.221.0]) by smtp.gmail.com with ESMTPSA id w6-20020a05651204c600b0051151e07c01sm28780lfq.36.2024.02.08.10.27.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 10:27:42 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 8 Feb 2024 19:27:39 +0100 To: Andrew Morton , Kuan-Ying Lee Cc: Kuan-Ying Lee , Jan Kiszka , Kieran Bingham , Matthias Brugger , AngeloGioacchino Del Regno , casper.li@mediatek.com, chinwen.chang@mediatek.com, qun-wei.lin@mediatek.com, linux-mm@kvack.org, urezki@gmail.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH] scripts/gdb/vmalloc: fix vmallocinfo error Message-ID: References: <20240207085856.11190-1-Kuan-Ying.Lee@mediatek.com> <20240207155623.a943328ba0b77859246e0d9f@linux-foundation.org> <20240207155929.cc107bcc14b982789bdc9fab@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240207155929.cc107bcc14b982789bdc9fab@linux-foundation.org> X-Rspamd-Queue-Id: B0F431C0017 X-Rspam-User: X-Stat-Signature: ema1t1zgotyfws5tw9x9epukqmprrrp8 X-Rspamd-Server: rspam03 X-HE-Tag: 1707416864-10919 X-HE-Meta: U2FsdGVkX19s+FSL3NmvqsiNN1eKWe9OabkUg+2IfzCFvDokcGfmVo8XECypatLi/BfB0YJUEr8lH2HNx3ONF9srG/FHhFdx/mJMZAttWC4UiptBcEzYFZ8LLi2YzVjcHJf+zBr0cJ0Rrh2eNYPlT3bjN4ox3CJKO7cIhS02XOgJHawz4yhUt2avhGpXAltck1yk/4pHtxlnVtj8p1amUUWUN+DJALL7gsDfAw5YvVbNAkXFOMGwhs0uCI13+IeXROFPWGLmd/NAKRiqd6Ze1nBEVXfVZuxoDgUDeAlyc8oPBNYb+S9f0B/vj3RT4pjMYbug/l9xu0JRT2udVD9RXzp4Up6MY9DI/bULw2cs0gZj3I2IaVY3jaRsuO/L/N7nbkZMQ2DqqHre3dAaq3EEBGCaJqHFohpAYw+u7wxfdpVsocan7pslBPbbrlykA2YwUuLe+h1w2h5GnRO4OXIzgGncHg953lt1MA9EVK5Lt2bywCaXyAmvd0bHaZ3ZoWB+0W4luHOpI19fgiI5o+MU0rRy0J5Uzwe1QkKGQqf7m2NNFIRkTd0ojaxs5SGzQxfnPTjY12xfjioI3ZYPu2baJ1e2riK44aJjn3qZBjgr5h9wWRz4ismqhCqSQd34/sQhAGD7EIPXmCRBTMQ1cnROdZMaC0KMj5Mt9IRKkP8FIthDk63PjxK39ksHHf+ndzjICe1Z9gFr7cI2ElgS70pJi8k/LR6lafYTetKoXCuIHm517i6ABiURlgYgCkpdv0SuX3GFMfwt4tIriP3+PzVsZUDEM98pLcz2LiHXSa0NyOn+mZBnYXhYd891BNXBdolVEdXxirbW0awv9dSStrolwqm77pKvWjPWafDcy2xj9OyW7jKc70iA31aUGIAPPG8stOoV4LKe5YIDdTVeMhfWA2VpAMP8AX/qPAjif08C6/Qp4lUPvrgBh4TucmZX6S6bFcOoc/bn1p+ESR9m+C4 +7/HiwIe 6F9PnIdEOBuMRSorZIASQGjHoniVAZtgHYeWldjXuVPJccUXbz751CsdFYIQggC043Tn7MD9ZR1IkaUVY/RK+Re18W/6DJ1b7rclOQIz+e9zVAsK2Lpo/kLCG/mQTCiYweTocD4p+FtciiPFaoeV5I/h5D46HHUORWWmVnrqUpFlgzUjvuLt4U+oMlCqDDktCFlGDRbbPb28Xx5EshHdDU7cGWH/yRImFUu9xU8wUVmuBoT1Yz+ltHU6cPwyRxrDQy4Hq4TQMmb2Yp1ZC2VCSsXcICArDeClKZh799mJAv9BTqqKGK6QgLPAX+fVkr9lEuY2Zh0jOxbTgRzmyYFEJrUioefOz8QLZZ5GAJkV18jr3LR+lX9JoewviTj2s+vxQ55ZuWk5UTSDOHN+Is3GbZ9Nau30voTREVA+Mg1Y+r37EJ8kRkeV0OYoMAZDFdm6yezWzmmAlG/bbDgadVn4WlB3DQd5pPWh5bVIqHaTcVT+tlcdqG5IHrw423kcP1C8RXJKOuOBu2gEYU1vaK/wjdC8uCzlDCGZT5dVuTEwXugR/80M5ICt/IWYBt3VNrQrO05OhRwEZvb0K5ibxMiT58S0OBmVbxOhMW5UpRAnXnF8oJBSUDYzVjkc03P/6HzjDQSfKw0B9hVDwU46RQhldy3BXpKp3cEgwqSZOSc6k3zW98wL/eg/ugXO/A57ZjlhUvccp+LwmxKBRR0IzNVHfCUfjzneonoZ2duMgsKh/C6hsp1m60wIi9L1P5ZnllGLWG5KIVRXZpVco2G7t7L/EIBmxdhvTkUnfgeS/LNw1B3IsWTN9wRUwq+deDg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 07, 2024 at 03:59:29PM -0800, Andrew Morton wrote: > On Wed, 7 Feb 2024 15:56:23 -0800 Andrew Morton wrote: > > > > [1] https://lore.kernel.org/linux-mm/20240102184633.748113-1-urezki@gmail.com/ > > > > vmap_area_list was removed by https://lkml.kernel.org/r/20240102184633.748113-6-urezki@gmail.com > > > > So I think this patch is actually a fix against mm.git:mm-unstable's > > mm-vmalloc-remove-vmap_area_list.patch? > > > > However this gdb function was probably probably broken earlier in that > > series, so perhaps this patch would be best staged as a predecessor to > > Ulad's vmalloc series. > > ie, this: > > > From: Kuan-Ying Lee > Subject: scripts/gdb/vmalloc: fix vmallocinfo error > Date: Wed, 7 Feb 2024 16:58:51 +0800 > > The patch series "Mitigate a vmap lock contention" removes vmap_area_list, > which will break the gdb vmallocinfo command: > > (gdb) lx-vmallocinfo > Python Exception : No symbol "vmap_area_list" in current context. > Error occurred in Python: No symbol "vmap_area_list" in current context. > > So we can instead use vmap_nodes to iterate all vmallocinfo. > > Link: https://lkml.kernel.org/r/20240207085856.11190-1-Kuan-Ying.Lee@mediatek.com > Signed-off-by: Kuan-Ying Lee > Cc: Casper Li > Cc: AngeloGioacchino Del Regno > Cc: Chinwen Chang > Cc: Jan Kiszka > Cc: Kieran Bingham > Cc: Matthias Brugger > Cc: Qun-Wei Lin > Cc: Uladzislau Rezki (Sony) > Signed-off-by: Andrew Morton > --- > > scripts/gdb/linux/vmalloc.py | 56 +++++++++++++++++---------------- > 1 file changed, 29 insertions(+), 27 deletions(-) > > --- a/scripts/gdb/linux/vmalloc.py~scripts-gdb-vmalloc-fix-vmallocinfo-error > +++ a/scripts/gdb/linux/vmalloc.py > @@ -29,32 +29,34 @@ class LxVmallocInfo(gdb.Command): > if not constants.LX_CONFIG_MMU: > raise gdb.GdbError("Requires MMU support") > > - vmap_area_list = gdb.parse_and_eval('vmap_area_list') > - for vmap_area in lists.list_for_each_entry(vmap_area_list, vmap_area_ptr_type, "list"): > - if not vmap_area['vm']: > - gdb.write("0x%x-0x%x %10d vm_map_ram\n" % (vmap_area['va_start'], vmap_area['va_end'], > - vmap_area['va_end'] - vmap_area['va_start'])) > - continue > - v = vmap_area['vm'] > - gdb.write("0x%x-0x%x %10d" % (v['addr'], v['addr'] + v['size'], v['size'])) > - if v['caller']: > - gdb.write(" %s" % str(v['caller']).split(' ')[-1]) > - if v['nr_pages']: > - gdb.write(" pages=%d" % v['nr_pages']) > - if v['phys_addr']: > - gdb.write(" phys=0x%x" % v['phys_addr']) > - if v['flags'] & constants.LX_VM_IOREMAP: > - gdb.write(" ioremap") > - if v['flags'] & constants.LX_VM_ALLOC: > - gdb.write(" vmalloc") > - if v['flags'] & constants.LX_VM_MAP: > - gdb.write(" vmap") > - if v['flags'] & constants.LX_VM_USERMAP: > - gdb.write(" user") > - if v['flags'] & constants.LX_VM_DMA_COHERENT: > - gdb.write(" dma-coherent") > - if is_vmalloc_addr(v['pages']): > - gdb.write(" vpages") > - gdb.write("\n") > + nr_vmap_nodes = gdb.parse_and_eval('nr_vmap_nodes') > + for i in range(0, nr_vmap_nodes): > + vn = gdb.parse_and_eval('&vmap_nodes[%d]' % i) > + for vmap_area in lists.list_for_each_entry(vn['busy']['head'], vmap_area_ptr_type, "list"): > + if not vmap_area['vm']: > + gdb.write("0x%x-0x%x %10d vm_map_ram\n" % (vmap_area['va_start'], vmap_area['va_end'], > + vmap_area['va_end'] - vmap_area['va_start'])) > + continue > + v = vmap_area['vm'] > + gdb.write("0x%x-0x%x %10d" % (v['addr'], v['addr'] + v['size'], v['size'])) > + if v['caller']: > + gdb.write(" %s" % str(v['caller']).split(' ')[-1]) > + if v['nr_pages']: > + gdb.write(" pages=%d" % v['nr_pages']) > + if v['phys_addr']: > + gdb.write(" phys=0x%x" % v['phys_addr']) > + if v['flags'] & constants.LX_VM_IOREMAP: > + gdb.write(" ioremap") > + if v['flags'] & constants.LX_VM_ALLOC: > + gdb.write(" vmalloc") > + if v['flags'] & constants.LX_VM_MAP: > + gdb.write(" vmap") > + if v['flags'] & constants.LX_VM_USERMAP: > + gdb.write(" user") > + if v['flags'] & constants.LX_VM_DMA_COHERENT: > + gdb.write(" dma-coherent") > + if is_vmalloc_addr(v['pages']): > + gdb.write(" vpages") > + gdb.write("\n") > > LxVmallocInfo() > _ > Thanks for fixing and helping! -- Uladzislau Rezki