From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 623D3C4828F for ; Thu, 8 Feb 2024 14:51:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C23A36B0074; Thu, 8 Feb 2024 09:51:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BD52B6B0075; Thu, 8 Feb 2024 09:51:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A9BB96B0078; Thu, 8 Feb 2024 09:51:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 96F3D6B0074 for ; Thu, 8 Feb 2024 09:51:45 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4CFFF14096F for ; Thu, 8 Feb 2024 14:51:43 +0000 (UTC) X-FDA: 81768925686.10.F0AB088 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf14.hostedemail.com (Postfix) with ESMTP id 7D225100016 for ; Thu, 8 Feb 2024 14:51:41 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707403901; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rjxVTd/lhtVUyQkE9wilBb6WoxZG/kxpethkmNsq7ZE=; b=GV12fiaFNxejzdpRrgjzWYzsRGunQfedb2td9ynABpY02Yfj7Zxbc6EHTVbuWJVv1PI7z4 TAxmDhZOF6UhIfj3LqOCrcEUO/NNwbSVtCrBKYu/yNuVco+WitfHUnCD1AYbUyJHUCkkNo bMVJS2HP8Pix6KpvW55fZEpnu4M8P4g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707403901; a=rsa-sha256; cv=none; b=l/MxqpW/MC0eyWgGc2ABDOjT5TNBbZ4K27Dh6biz0cZcjrLUeVoo+qdpB7LU+XTcVYvK2o qlbptQvuTnnktBKNcL4Na89kOYVl1EGE+z8tmuP2cJNxACkesKaBunb5eL+KaP9HzmIupO TZJ+U4boUp9ROWj6xKqzeL277qxRcYY= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 76A8D61DD0; Thu, 8 Feb 2024 14:51:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA3BEC433F1; Thu, 8 Feb 2024 14:51:32 +0000 (UTC) Date: Thu, 8 Feb 2024 14:51:30 +0000 From: Catalin Marinas To: ankita@nvidia.com Cc: jgg@nvidia.com, maz@kernel.org, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, reinette.chatre@intel.com, surenb@google.com, stefanha@redhat.com, brauner@kernel.org, will@kernel.org, mark.rutland@arm.com, alex.williamson@redhat.com, kevin.tian@intel.com, yi.l.liu@intel.com, ardb@kernel.org, akpm@linux-foundation.org, andreyknvl@gmail.com, wangjinchao@xfusion.com, gshan@redhat.com, ricarkol@google.com, linux-mm@kvack.org, lpieralisi@kernel.org, rananta@google.com, ryan.roberts@arm.com, aniketa@nvidia.com, cjia@nvidia.com, kwankhede@nvidia.com, targupta@nvidia.com, vsethi@nvidia.com, acurrid@nvidia.com, apopple@nvidia.com, jhubbard@nvidia.com, danw@nvidia.com, kvmarm@lists.linux.dev, mochs@nvidia.com, zhiw@nvidia.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6 3/4] kvm: arm64: set io memory s2 pte as normalnc for vfio pci device Message-ID: References: <20240207204652.22954-1-ankita@nvidia.com> <20240207204652.22954-4-ankita@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240207204652.22954-4-ankita@nvidia.com> X-Stat-Signature: hcw9iat7tnc37ntm8kq5p49jzkah3ab1 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 7D225100016 X-Rspam-User: X-HE-Tag: 1707403901-172553 X-HE-Meta: U2FsdGVkX18xn+8aDb6qzHThbhYUDQCXm8ma4zKAH6k9WijVQAtiOtLGT2efL7YZ0qZIbEAlzgqpEke9e/ki6qMJO5nLN0lJ5l/cjm/9nhjfm3XsONxzCZVt6UHHgkORhP3i4DYiGVkXPOxmRfMRl/si94Hccaa/fk7/xFG9frpwZZ3fsTwaIl3qg/shgwo9MyjE11DddkVfalv7lkkqTLpF895uHbrgB16UVlk7uXu25KQDGhXIdGPHexcvjRVmoq2q0gP6PiRw1II5OHdBhTGfYhOAipIfdFFMVS8BZDrCTa367Xs5xW9zYNUMRi/cpDs+2+36M4yHmYPh+pueVH3hLNJSobLV/XkcJtfALRIDi1t3PJDr5BiaKK+5wGawzZap5Gp5MzNfgTpFcQFigH4fBRBM0W3bIFOBXBsmJzrcwiRwP25E3Cpl8FyzFXevPMBUIo1XtDnoEkx4tDYL1gF74TpIduPcXe4+EsYuDKWdZ6+BNP8TXwFzudaSdp+7fegKq2nv14l6axgOJkbiqmLRoCLs6vB8/HO/fbRgTrPvCMYFbp3+SiUSxqZ9i9GiJiIisgteXpccLV/+7G0VFtDGhhYrv0WE3V6diLgYTm3Tn2ESRN/SjCjoUxgfdNKGr/y2SutBKqE9AuOFFfO8DPlDhYhIs0TGeIvfVOmjVBkL0u0/8231u1ymHYXh6skFKrwzfMeJPBiAS0mBBFKvDM8zr01lhMitWCcqfoHYPXnI3IgDsCbVGtiPBGc+Vsf3l2k0dOv0Zz2yc/jAw0pY+t8fTfI/2NPC0R+0O+DPfG8Ka1HIYsHeuQFPK89hQBOAzrj0TF/TXP0+5aprNUgnKOikCqqaG6Ic/4tf86K3MDI3QsSRYWnY15hdkFf7uFJXj2zfXEydWVTwLbwOj6Ecr5DiondHMFy6gW1KgvFnTeb3oI60eiGi3KB5DYg8IU3LOuKTY6hmJW8W766o6sB UhrBp722 zkVsWWwabw9114G+ODxCFkjtc9G7jSBexCFffD66c3S8VLfmVUyngVWEadeGL7h0+FqdRq7VRJpg1Xsa8VmhqnAhF1qDCpVXnE/Y2ZHtXxYbSoQ9+K3of1UHzlFje3GUaXpV+xSFmXI2Kr2vOO/0Ls4Oolauu2C5Dx5CXc3sL9Ny8LXOyMkdKH2HYg84j3JdPldU9ylGjgOCnvUc57mreVxrkQLm4ZhiYDeIABisARSerLW34X3Q1iIx1YgA6ZUBoOvj2LMNwbhLpwBQyeyWKgwlnQZJeEzx3vpcJBUDo4VIxwRGNoADOLpbnRFVBa2z5tHn986r0KrB+sThFdtMzQ11foGNv+ygkhFjTcQyYdszb+YxWF7af1gqjy7Jq9oQ+6MWDmiBNRfU1HkY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 08, 2024 at 02:16:51AM +0530, ankita@nvidia.com wrote: > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c > index d14504821b79..e1e6847a793b 100644 > --- a/arch/arm64/kvm/mmu.c > +++ b/arch/arm64/kvm/mmu.c > @@ -1381,7 +1381,7 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa, > int ret = 0; > bool write_fault, writable, force_pte = false; > bool exec_fault, mte_allowed; > - bool device = false; > + bool device = false, vfio_allow_wc = false; > unsigned long mmu_seq; > struct kvm *kvm = vcpu->kvm; > struct kvm_mmu_memory_cache *memcache = &vcpu->arch.mmu_page_cache; > @@ -1472,6 +1472,8 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa, > gfn = fault_ipa >> PAGE_SHIFT; > mte_allowed = kvm_vma_mte_allowed(vma); > > + vfio_allow_wc = (vma->vm_flags & VM_VFIO_ALLOW_WC); Nitpick: no need for brackets, '=' has a pretty low precedence. Reviewed-by: Catalin Marinas