From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33408C4828F for ; Thu, 8 Feb 2024 14:54:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B3CD66B0074; Thu, 8 Feb 2024 09:54:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AEB376B0075; Thu, 8 Feb 2024 09:54:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B3F16B0078; Thu, 8 Feb 2024 09:54:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 888336B0074 for ; Thu, 8 Feb 2024 09:54:03 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2F20A40EDC for ; Thu, 8 Feb 2024 14:54:03 +0000 (UTC) X-FDA: 81768931566.09.FDC14E4 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf24.hostedemail.com (Postfix) with ESMTP id 1DF6D180005 for ; Thu, 8 Feb 2024 14:54:00 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707404041; a=rsa-sha256; cv=none; b=tjpLSHv3Lwpmc4OxbrF0ZzeHrQTw6oEqV1fpZDiYfad9W6LvwFFFFoL1RpsisEm3ct8Xne ec5AQlUaRk1lA0xyAV9LMaTIa+7lEgvdS+365UUtGhH2PL7H6PpMUwULIIg44aJGQEM3dZ H3MrLhyzoU2pSUEGlaJhM+prZL+97S0= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707404041; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=66QDV+E2Er6w8oh1oGud0tl+BK8KP1oQ+z/ek6lz91w=; b=wq0dq1IO+IR89WRr/FgHppDGTDIPHOszfQQD9bsMa3REMN7X69GnbH3EKtYq6xq9RFOD6r gHZe5T9YGvI7fhMscxRZL5UtW15Be9Ov/sVZPFibh0LAoGWRPZ/z9XYdi11OpQC08ZnFEW d9sCa+OfcVSxugoBc0M9PyOkIFgbQck= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id DAC56CE1D3A; Thu, 8 Feb 2024 14:53:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95689C433F1; Thu, 8 Feb 2024 14:53:47 +0000 (UTC) Date: Thu, 8 Feb 2024 14:53:45 +0000 From: Catalin Marinas To: ankita@nvidia.com Cc: jgg@nvidia.com, maz@kernel.org, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, reinette.chatre@intel.com, surenb@google.com, stefanha@redhat.com, brauner@kernel.org, will@kernel.org, mark.rutland@arm.com, alex.williamson@redhat.com, kevin.tian@intel.com, yi.l.liu@intel.com, ardb@kernel.org, akpm@linux-foundation.org, andreyknvl@gmail.com, wangjinchao@xfusion.com, gshan@redhat.com, ricarkol@google.com, linux-mm@kvack.org, lpieralisi@kernel.org, rananta@google.com, ryan.roberts@arm.com, aniketa@nvidia.com, cjia@nvidia.com, kwankhede@nvidia.com, targupta@nvidia.com, vsethi@nvidia.com, acurrid@nvidia.com, apopple@nvidia.com, jhubbard@nvidia.com, danw@nvidia.com, kvmarm@lists.linux.dev, mochs@nvidia.com, zhiw@nvidia.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, David Hildenbrand Subject: Re: [PATCH v6 4/4] vfio: convey kvm that the vfio-pci device is wc safe Message-ID: References: <20240207204652.22954-1-ankita@nvidia.com> <20240207204652.22954-5-ankita@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240207204652.22954-5-ankita@nvidia.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 1DF6D180005 X-Stat-Signature: uszrc7q1tx9a9jq3yt6xf5huo565chs8 X-HE-Tag: 1707404040-626408 X-HE-Meta: U2FsdGVkX1/kAOMJpj8ig30V6Wk2CcMr2AQPAeaE3Ni1qZhdyxNHhbShcO+eqriiPtNiF1qdHBLvVvchzwlPwNJe9L0lvv5PloehzHGmAd7j4Y1ua050eKEidjmsnp5PXQeUlCb17ihA6Q9fdRG6XWGezVfRPy0Cxc0Zxa+fGzFkg0IfuJo3nqVYvg84NdcR7dz0HWGhU10C+/hN7TsvWnQsF11bWhw/yFPWFb/x/bwu0sCnintJxGlO8obf1VcmNUmC1OeX4BPfzeSRG3nZME/NUOfN+Y1cJ3Zcm/AtUk8fLsFgRQYzYeh56eIMy0lDhwSz2oc9CqP6LbEc5D1mCdUE5dRWZbDjl9q4oQ/ivtoFfLUoVM8cSGFJAEJDLstpg0VArd5hyGFNwBkyw3l3crCeo2A8TJTNqg1JFvWjTKaf5c+IA+TXfZ+SJPV01bVbNZmTct0vkWeBQ/qlky6vJap2lu1/XTHcE+79w79dAwGeybIzD8dK3h1NnquAdqZtg8N4ubWIB6YIea7xG5IyDoBaJChIepD+pFkT9qjN/gVL7FEkOdZEaM1y49NDF1AYdkrxszWlZ3TOuAkxeIjquejEyzPp+AKFAyBrqAXYBcZNlAbGBZPQfoFMw/12VKu00d0K+Lg+8cnnKVvG5gGaLPLhstifzCl0pv5N8IpxTcNGUJbCmgwxOR2DGKRWQx82tfbqbff7PBKsz4uvGXzpiiD4Qw9s8zhWhjtiXyZcnOOCIh7xDcwkVkUr36WsM/463Jk9Gi3DF5n/tquX0a0H5+JUlI1u3Y8tBskUZaEaMdV/VdKpZTtIWbCKwfiNF0sOt45kba9RlCr0jtXhKwiKpAN1u8G09uQRpa+73mHRyOq0pbiKtxuW3wKhIsO5EcZkgFH14YYCC5cO+c2bF4POwa57EUFNK2M/bFShIHr5b5WXwgQcIdVWej+0GxQUshtixJMQ0kOoFjoXnLElfNX /6Pr8uZb x48ubcsoImBPvZAWukMnBcUefwBxRvBlTcqCkARAr4Z6eK6EgkS4oOzPDCoL4uOkhYkgBIgeHEwKEsku1ME38NubhjDkZYELd4sT8phw7m/PvyUzE6e4pQHpjK8kBNzdHZauu//vX/Tmnw8Usdix+khpBVSKgEfJIGIdqaWm7OPBsthX6ITCZoz5p0eoKhB/ohgKEibrhpYBuBL0/fyTJgiEwSuTqUk+zluG8KKLJIGaZ4mmyjrA2JVECu6x2ki8SMxOTcJycegmatRp37VFO9p8eNdpQOtUkJtLOOMIZjXY1mgWXqbiZrwhdstU3dDojwvQRoF+WXB/U1lJSsneUHILjGjRhFz2WMofLLxxgHnAa59B4cuDveL09qM1iavYbh+OVl1PBZUpnvGQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: + David H On Thu, Feb 08, 2024 at 02:16:52AM +0530, ankita@nvidia.com wrote: > From: Ankit Agrawal > > The code to map the MMIO in S2 as NormalNC is enabled when conveyed > that the device is WC safe using a new flag VM_VFIO_ALLOW_WC. > > Make vfio-pci set the VM_VFIO_ALLOW_WC flag. > > This could be extended to other devices in the future once that > is deemed safe. > > Signed-off-by: Ankit Agrawal > Suggested-by: Catalin Marinas > Acked-by: Jason Gunthorpe > --- > drivers/vfio/pci/vfio_pci_core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio/pci/vfio_pci_core.c > index 1cbc990d42e0..c3f95ec7fc3a 100644 > --- a/drivers/vfio/pci/vfio_pci_core.c > +++ b/drivers/vfio/pci/vfio_pci_core.c > @@ -1863,7 +1863,8 @@ int vfio_pci_core_mmap(struct vfio_device *core_vdev, struct vm_area_struct *vma > * See remap_pfn_range(), called from vfio_pci_fault() but we can't > * change vm_flags within the fault handler. Set them now. > */ > - vm_flags_set(vma, VM_IO | VM_PFNMAP | VM_DONTEXPAND | VM_DONTDUMP); > + vm_flags_set(vma, VM_VFIO_ALLOW_WC | VM_IO | VM_PFNMAP | > + VM_DONTEXPAND | VM_DONTDUMP); > vma->vm_ops = &vfio_pci_mmap_ops; > > return 0; Acked-by: Catalin Marinas