From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8444EC4828F for ; Thu, 8 Feb 2024 13:27:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1CE8E6B0082; Thu, 8 Feb 2024 08:27:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 15BCD6B0083; Thu, 8 Feb 2024 08:27:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EEC9E6B0085; Thu, 8 Feb 2024 08:26:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DF2EC6B0082 for ; Thu, 8 Feb 2024 08:26:59 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8864B1C18AF for ; Thu, 8 Feb 2024 13:26:59 +0000 (UTC) X-FDA: 81768712158.18.E7DA8D8 Received: from out-184.mta1.migadu.com (out-184.mta1.migadu.com [95.215.58.184]) by imf08.hostedemail.com (Postfix) with ESMTP id A2435160013 for ; Thu, 8 Feb 2024 13:26:57 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=VBGy007K; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf08.hostedemail.com: domain of oliver.upton@linux.dev designates 95.215.58.184 as permitted sender) smtp.mailfrom=oliver.upton@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707398817; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ms5mFNmc1YMSRaq/hZ06PJ/xdlihfdaV0iwPXV9EUh0=; b=Fd4D8SDaJZX/6rvnt36TmTSG3eZvaX++lkvBCnNch/gJQecuOLANyIVHN5CBcH3mBuLCAj jv2kCl8e5MKHLtOoK7Jh6X1ts/mauSu6C45cWaC9jWuTNMN5QECoP2AvlWhtVcp3+aIdRI zzHsGKcY+EPgCJzF1r870J996srzPJU= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=VBGy007K; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf08.hostedemail.com: domain of oliver.upton@linux.dev designates 95.215.58.184 as permitted sender) smtp.mailfrom=oliver.upton@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707398817; a=rsa-sha256; cv=none; b=QebDv/gH9972Bj3L+rxhSszeXJ+VrVZRdpCEYf1uOh84q9H/ELWGgojP/q3a59H+uNYuhg xzxI84ODZooJoP4qlG9B8A9xxjG7bifqWEp/fWOcfAdjgg3EP58Tym8eOYJrGUZ+wef9nH VDvbCVaoZJdIIhI/tTs48OLSz8uBprM= Date: Thu, 8 Feb 2024 13:26:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1707398815; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ms5mFNmc1YMSRaq/hZ06PJ/xdlihfdaV0iwPXV9EUh0=; b=VBGy007K7zBFgwgCxeFZ4SXk6PdZiZTc0tqb3bI2yQMJ7Z2A+kGk90xpqHkE9gimClA3RS X/7EJvUS9J4SRcNS+Bx+l/1gh/zZBcvKHb6xnQ5dItLai7Ke9fS5K/4LrgY6EDqAD5tMVm U6G4BKNaFadn1bI1zuZfy9erbnfSf28= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: ankita@nvidia.com Cc: jgg@nvidia.com, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, reinette.chatre@intel.com, surenb@google.com, stefanha@redhat.com, brauner@kernel.org, catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com, alex.williamson@redhat.com, kevin.tian@intel.com, yi.l.liu@intel.com, ardb@kernel.org, akpm@linux-foundation.org, andreyknvl@gmail.com, wangjinchao@xfusion.com, gshan@redhat.com, ricarkol@google.com, linux-mm@kvack.org, lpieralisi@kernel.org, rananta@google.com, ryan.roberts@arm.com, aniketa@nvidia.com, cjia@nvidia.com, kwankhede@nvidia.com, targupta@nvidia.com, vsethi@nvidia.com, acurrid@nvidia.com, apopple@nvidia.com, jhubbard@nvidia.com, danw@nvidia.com, kvmarm@lists.linux.dev, mochs@nvidia.com, zhiw@nvidia.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6 3/4] kvm: arm64: set io memory s2 pte as normalnc for vfio pci device Message-ID: References: <20240207204652.22954-1-ankita@nvidia.com> <20240207204652.22954-4-ankita@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240207204652.22954-4-ankita@nvidia.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: A2435160013 X-Stat-Signature: 9op3j5971ptspgsxpn8s3itc85c5xagj X-Rspam-User: X-HE-Tag: 1707398817-680779 X-HE-Meta: U2FsdGVkX18ZX7vg4eldrozY84hKDTNr7/yl/jaKibtp106HiIETmizifPaAwyRmc5IHjaQ5+V17yljLpwxzuS5OpL6MWNirXVdrjdW+VMc6aoIou/s80MZ41BB0ncggllpSjRAcP1TUHd0WolhNKUFyR7NpGr2WcpThbO/aERTrU8JbSo/KevwfkaVvq2qREaRZdlO8+b7KZ/X7glhIaHY3l4eNwt2Gbo2yctARIj8qb4afOrFPZgb8NlDDW06FXUrpG/Di9adJuifGLFifYv2+LOkLv4M/mrjwL+VzhTiGoMKJ3ISmRnCqyYoAjmu65XlzYs8lE/Y6tqejwxVRS+Y+v8Hpf6+xyLfNGl+OFXQaRnbT19ayy0HGCe+MdO+FU0dnCGTzcCoiUU4nMP7FVw4CjXwQN2IgJ0J0t0BSoY7zb1X/mw8etpQM1sCf1imtVSR+PMAiiRAP+BEEks+8IOAJOXsn1zeONjo8GeHJxdvLDXEuZT2ZpCecCzXWLgZMrB/uODQ7YLzyfmlk9oF5KyJ2vEe+6jOGizVWltBzQsf2M7w1KviFfKyIcpxmhAblDOygElll05d8FrsTZgAS5s3YZ0M3mddvtuTx+lwecT6I2PajzJcbye8RM5zPFq8ExszFyV0XOhdx3DqyQVcDxrmNWYRqluTZtf5RKcoOUavbZ5Xnje6IgGzPt50cQkF3jzPfh3gSDmC2gDXEovbFJ9zrfWz/WicnYpPpm5HmejH7KSERd576JHaVfktI8CxSYbIz3XBX4YNPFGtxB9Vv6OiDYRaPtPd7nihJG85ChsfH37TNQVBRM9PANjShvOn6Z1xdV38PtpZ7Tu1uQgxLhNApBSnEHcmN5L1p3D2VvufgL0ixPVEryTsw6LY0Q+8HVF9enEXQx+AcUzvHqtOvzybO8vCNkCRIoZ/dO1KnxuH+JY6ES+1ZQD1TcgTzGPVgSyVWLl4oaIua5nFAG4m VRb5W3gn T2Gih6dup7e9RA+w3/gZTHIyQXilaaquO37OKLRZ15FpMVHf0qleOz/nKv07N1S7VsAVokuZPW4lGqtR8UenBGOKDBtiKY8O0jpf8yaVfZL0ZSk+5YTWCtHsTrg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 08, 2024 at 02:16:51AM +0530, ankita@nvidia.com wrote: > @@ -1557,10 +1559,18 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa, > if (exec_fault) > prot |= KVM_PGTABLE_PROT_X; > > - if (device) > - prot |= KVM_PGTABLE_PROT_DEVICE; > - else if (cpus_have_final_cap(ARM64_HAS_CACHE_DIC)) > + if (device) { > + /* > + * To provide VM with the ability to get device IO memory > + * with NormalNC property, map device MMIO as NormalNC in S2. > + */ nit: the comment doesn't provide anything of value, the logic is rather straightforward here. > + if (vfio_allow_wc) > + prot |= KVM_PGTABLE_PROT_NORMAL_NC; > + else > + prot |= KVM_PGTABLE_PROT_DEVICE; > + } else if (cpus_have_final_cap(ARM64_HAS_CACHE_DIC)) { > prot |= KVM_PGTABLE_PROT_X; > + } > > /* > * Under the premise of getting a FSC_PERM fault, we just need to relax > -- > 2.34.1 > -- Thanks, Oliver