From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE0C1C4828F for ; Thu, 8 Feb 2024 13:01:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5AB796B0075; Thu, 8 Feb 2024 08:01:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 534006B0078; Thu, 8 Feb 2024 08:01:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D56A6B007D; Thu, 8 Feb 2024 08:01:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2C7C86B0075 for ; Thu, 8 Feb 2024 08:01:10 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C3583160265 for ; Thu, 8 Feb 2024 13:01:09 +0000 (UTC) X-FDA: 81768647058.15.FDEAC7A Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf30.hostedemail.com (Postfix) with ESMTP id B62308002B for ; Thu, 8 Feb 2024 13:01:07 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of catalin.marinas@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=catalin.marinas@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707397268; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uqLc+JThqpHDfFFGxNfvIFQm3IlIB1Kdmxi7eSJIYKk=; b=yUxgVYDVrXYjLSMdJ2+6wBDr8wfWyfN4Q252xyrzttvGNMmUOCxvwEMdLe4bCTPXtGpH5W jIv/IpBCaroeWC9CTYWyG63nsHYrAlZ1ZTeHqUcpS547FTsYfCb64agAD1zXbbf9dos+pR ZEYQYiXPD0Pe/9LndsScfeZRdHnFvtI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707397268; a=rsa-sha256; cv=none; b=5KeHXeFNshjQWpSIpmISJ8kYT4JG2Drtarmt99CLzoH4ySfZlGHmVXb2vgeU5v8Q4VVpDk POsDZKLcqcQ63wW9vssuf0B9bZkycnDr4nbKXXBwSDJ1rbwMP2+ojkbf7c2u5500rARRmv lFAejzHgHTo09dhXHzvcCsAprTP1R3g= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of catalin.marinas@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=catalin.marinas@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D4C6F1FB; Thu, 8 Feb 2024 05:01:48 -0800 (PST) Received: from arm.com (RQ4T19M611.cambridge.arm.com [10.1.31.53]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CF6FB3F5A1; Thu, 8 Feb 2024 05:01:01 -0800 (PST) Date: Thu, 8 Feb 2024 13:00:59 +0000 From: Catalin Marinas To: ankita@nvidia.com Cc: jgg@nvidia.com, maz@kernel.org, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, reinette.chatre@intel.com, surenb@google.com, stefanha@redhat.com, brauner@kernel.org, will@kernel.org, mark.rutland@arm.com, alex.williamson@redhat.com, kevin.tian@intel.com, yi.l.liu@intel.com, ardb@kernel.org, akpm@linux-foundation.org, andreyknvl@gmail.com, wangjinchao@xfusion.com, gshan@redhat.com, ricarkol@google.com, linux-mm@kvack.org, lpieralisi@kernel.org, rananta@google.com, ryan.roberts@arm.com, aniketa@nvidia.com, cjia@nvidia.com, kwankhede@nvidia.com, targupta@nvidia.com, vsethi@nvidia.com, acurrid@nvidia.com, apopple@nvidia.com, jhubbard@nvidia.com, danw@nvidia.com, kvmarm@lists.linux.dev, mochs@nvidia.com, zhiw@nvidia.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6 1/4] kvm: arm64: introduce new flag for non-cacheable IO memory Message-ID: References: <20240207204652.22954-1-ankita@nvidia.com> <20240207204652.22954-2-ankita@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240207204652.22954-2-ankita@nvidia.com> X-Rspamd-Queue-Id: B62308002B X-Rspam-User: X-Stat-Signature: c9zf1t7pb174rxjgkto4eojf88wz697a X-Rspamd-Server: rspam03 X-HE-Tag: 1707397267-252183 X-HE-Meta: U2FsdGVkX1/jnpRC45oEai3ktx2vcX8x9giSZmH5wUIy3nsS7vPWsDQHqUNB1bdJxSGw0Pe4cRp1NgOkudyGbS43s27eOlilyBDn9zv3LFljWhjvH0ohHPga9QsYkkMlp2rJV4Sa6dNJYMoed2eVamK5Y1Vkqf/xa2NTsbUpKAq0p4C5Y95FKBjG1KJIIiKXL4ZdEcyxZjihECWzX5Ht5vMBZTfa/Vp6Ds4htT46klFMRVoO32AmilA6icgkvftkGPSi3qApoyOg7Qh0qgnpFwbQXmB5u7tHZtTPuK9EySuHoqnyojsltGeMc1ZLkmTw78goLau40A9Tc2nU4MFp6vuDrL0Dn8TaGxqXPKX3pJVg6IkftUcSE68B7w/w5qJTSgSWIBK+1Oh9NeF6QxxhCmtE9U0IJEBx0Njm9gE/ZCZR21n9xrHhcLms5eU5PkdLdFBfO4RJmc0XMPXEqSeqUX60F+2fBiqY4t4+jqqHBllKKZyCVZsHr+IRvOt0/tGM3zzDkHukSZftxVUuN00gkc0arHrudVUSvfRMLRO1EKkgwaLc/M+N4Uz91NJnlFVKKRtlG4n4XALj3O5mikOKf+qAx5O+yoMMSJkEsm0CCjWLDphkQ/+8Z9SbbURzsf6nbQp/6y4/2tZ/rkxR86xa3DxbvugOnwJgp3XsmbJtjHwJI/ui4+6DnhZs9QkZsGCATpKpKrV8VcrmPgONMHzcYKNisBopIJs9e5cHf/5DJupte7CrOmcObnCTjhvJwc5g/6ODoxy/SUtUetM0Wvz+qn5O7tMvoiF6932A2QDbRDGT/+dEAfizbci7Xzzhj950j5VDBYWsiPafsYff6PBlavfixQOvKc3VXPENQfpKQLIsuweMd3SqD23BZ6gGpe//SHWs2qgjf8eqHNPQGDHJ2Z4t7Odq6oyAryZn6MnStgMOo7x/+mo7K2hfmXrXyAJDtuttOGh8Vhuh7763iiW 5rVTLDjQ Tg0W4HXY5tKabpaQejirVKQo5nCPNIWtm0qPp7kAwGe12UAP6EKM044b7G1URcufT1nL3eqmFIAbvMTwn3Ydq/AfypxIxGizDWHWwFjkxRPf2nZjK0wOgDOEih9ysWieeofxX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 08, 2024 at 02:16:49AM +0530, ankita@nvidia.com wrote: > diff --git a/arch/arm64/kvm/hyp/pgtable.c b/arch/arm64/kvm/hyp/pgtable.c > index c651df904fe3..2a893724ee9b 100644 > --- a/arch/arm64/kvm/hyp/pgtable.c > +++ b/arch/arm64/kvm/hyp/pgtable.c > @@ -717,15 +717,28 @@ void kvm_tlb_flush_vmid_range(struct kvm_s2_mmu *mmu, > static int stage2_set_prot_attr(struct kvm_pgtable *pgt, enum kvm_pgtable_prot prot, > kvm_pte_t *ptep) > { > - bool device = prot & KVM_PGTABLE_PROT_DEVICE; > - kvm_pte_t attr = device ? KVM_S2_MEMATTR(pgt, DEVICE_nGnRE) : > - KVM_S2_MEMATTR(pgt, NORMAL); > + kvm_pte_t attr; > u32 sh = KVM_PTE_LEAF_ATTR_LO_S2_SH_IS; > > + switch (prot & (KVM_PGTABLE_PROT_DEVICE | > + KVM_PGTABLE_PROT_NORMAL_NC)) { > + case 0: > + attr = KVM_S2_MEMATTR(pgt, NORMAL); > + break; > + case KVM_PGTABLE_PROT_DEVICE: > + if (prot & KVM_PGTABLE_PROT_X) > + return -EINVAL; > + attr = KVM_S2_MEMATTR(pgt, DEVICE_nGnRE); > + break; > + case KVM_PGTABLE_PROT_NORMAL_NC: > + attr = KVM_S2_MEMATTR(pgt, NORMAL_NC); > + break; Does it make sense to allow executable here as well? I don't think it's harmful but not sure there's a use-case for it either. > + default: > + WARN_ON_ONCE(1); Return -EINVAL? -- Catalin