From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97945C4828F for ; Thu, 8 Feb 2024 06:21:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2DA166B0099; Thu, 8 Feb 2024 01:21:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 28B756B009A; Thu, 8 Feb 2024 01:21:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 179986B009B; Thu, 8 Feb 2024 01:21:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 07C026B0099 for ; Thu, 8 Feb 2024 01:21:26 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A3ADCC01F3 for ; Thu, 8 Feb 2024 06:21:25 +0000 (UTC) X-FDA: 81767639730.23.ABE596A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf17.hostedemail.com (Postfix) with ESMTP id 07DD34000F for ; Thu, 8 Feb 2024 06:21:23 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kOuzsSbB; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707373284; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5JRxrmAtTR5bS9y6pVFv8pI49A9aY4dC1xtw8EYFYb8=; b=gRC+0YVr07l7dyQ4jmsX/bm0J0TSGbpjFyLMxHcS9PZ+yNBJ1mOG2QC20pDGiVsknlagU3 YHksu/pv3st7FEiadMYBjc8+5RMlE515RwVg0tBcE4RMK6f96Sey0mAvU/hL7tA6WAL7Ug vFBVdUNl+/X6Qz8m89mlUCzux8932t8= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kOuzsSbB; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707373284; a=rsa-sha256; cv=none; b=bT4VY5yVld9yWqvsl7IH+foKySMpHnFoTnPuaF+QV8NeRPZhNayaeTxsR718RfcLodtx2A xuMyeWN43QexuV4uTtTzro9UfjSBv2xgzJyf8q9V1ARp6bIHvjGJYQv9pUyFAhixis8FjQ Sj+GG3lnDE+WwZG7dUfRE82Zcz7L01I= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 347BF61B29; Thu, 8 Feb 2024 06:21:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9FA67C433C7; Thu, 8 Feb 2024 06:21:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707373282; bh=lD1lrtMMdOBpkeLYHTDECguSxgees/c78w0lL7yv0bw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kOuzsSbB27uwSEFp6QnBBwF4c8wSiOnHMBpoT0jJuV3IEfQ/f661CpCyRQBuvLibE lLQXgNR3XCQOOP5nvA2vnYrZmZkM/dZXQxbM9FSzlFF4YpKjZv+hycd+20Elp8ywEL LAv0lEURquSyS6AsBFqOIDxwSjBdh4LEyqj78PHMjfRFx1Z2x+WKh2zG2BJ8sNyFaF HujNOdc0xlfRqZUvzM5o9jvnfWteYJRjhw62WISYKo869NMnlPw7V7xJ1+fXv/PF/u pHUOw3YaYaqgO8HS3ztmkMy9JMAmPt1+mxKkvDu4Ht04n+bkQbqIzXeGeuiFUFesQd NG/ZDh6p/DJXg== Date: Thu, 8 Feb 2024 08:20:57 +0200 From: Mike Rapoport To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Matthew Wilcox , Ryan Roberts , Russell King , Catalin Marinas , Will Deacon , Dinh Nguyen , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Aneesh Kumar K.V" , "Naveen N. Rao" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , "David S. Miller" , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org Subject: Re: [PATCH v3 10/15] powerpc/mm: use pte_next_pfn() in set_ptes() Message-ID: References: <20240129124649.189745-1-david@redhat.com> <20240129124649.189745-11-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240129124649.189745-11-david@redhat.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 07DD34000F X-Stat-Signature: hepegj4nw74usctsqaa9p8usyzcxhuoi X-Rspam-User: X-HE-Tag: 1707373283-13675 X-HE-Meta: U2FsdGVkX1+fjQ71BjjgTw1fe9bFG8X0F730Qny3ialNM1eKJzSYbLcptI6PRoz8bFU17F2CJNrz7fx1pyxH3+sctTiwmC8MFN8WVSYOjQU7zulIyS0GbW2qnQkUBDbck7KFHpkfi9XTDE3jFmpvfh+qitoj4sK04S34hKgsGpbbyTnuU0+1SeecqS9FlxIvCp8VerBXa7mMLuXcG+xGgdniE5h26Kmwi9rl4Kxj0GAx1Y6FH+n+ozyPt5/iRYRvY5f2lb42SkvtqL3PsMr0K/qqdLdbnPPK4ZOlc8yLyJYVRMUXQ/LydxWkGuEvrfC8khTYK5jMIeUa9p2p3eAy/8dKlUeyQaDeipytz2q/McLGB8gfM27SnFvkKo/QfqaJsdZlwHxes5fMgGDafL1JdMzhqCJI6mxOG40agzisvVrkcq4qkJ3KkQsHxRt8XYFaFTy+11CRXyZPaOp6pmzMakDiVWJv9KQSG355LMLRx+So0cp/RnS08zx5X6+QTzlGcKqDT5GNb8fOcWY6+8dxkJYgzUEMXdj3wZDPBzGzPuDRYXylGuxv0Zo9Waz60iA9wSE7UU0+4xqfWK3GIbWzSCqTPud9WGZzqRoxiZYQMWBvlM+lVTWXfPZgHtxoKuqMrp4Ap2/CGOtCLmf9Dkj9NlrLQH3f8C8TVGlf8fWw0aTQMI9sz0NDvcNvitxxXV9orDs0owyvkWFd/wKdAGnqsFsDiXGmXSfEMTUd85XTYsBmqNo2TSBkxOLv8SJqF/m3gb5lhPVZOH00kZyB2prb4EZR4TeolNOZ1DtfEfJvW682XPrObWWawrlbtXEiiajOwlE7XdgM62KxSrTnWsAqwlNHmrAiCdm3gCG5lEVDDvOg+wNfqnhDz6fMzO4gT7UasaxaoBrfmZueClTiF1+MF6kG/AblCnpjwgsRMTz4XTRdr45Z55GN7JWNH2IX1zn8zDtPWFY858uSdbO/zaO FzGalvpq 9YNo57o0SbGRCl0wmgtT70eRoD/SP807LoYNVwH0ul7gIpILakxkGW7XSsRHcRUMrKS/edqaxwC2CLnuwkSRxC7Fsr8hHBrAb3xaU3HA9k9o8OoS3l6PSLyK0qhK1yoa3JfcrinidI+T97gYT/sfUOeVGOY1pBcepZB8LKILREGqmDVEsJ4KNIfBNKUuSKtLtseJ6CVZuUfR/98Sp9GwsyNZuNsALrDPz6Oba8Xu1tUul/V6D4NkuJjnHyOIkDKVtnORO5Mk4hrSwCf0wMEKFiUYyUFgSbBAA5kVmoqvKoHQXiu+B65cgawDdMdF/wMm/u7U2QXiHmUjz7O7WD0TqrMbUyWSM7Ou4FqcrpsmAKUEJhEUaCvO62sE5poYyNQ16gw9E X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 29, 2024 at 01:46:44PM +0100, David Hildenbrand wrote: > Let's use our handy new helper. Note that the implementation is slightly > different, but shouldn't really make a difference in practice. > > Reviewed-by: Christophe Leroy > Signed-off-by: David Hildenbrand Reviewed-by: Mike Rapoport (IBM) > --- > arch/powerpc/mm/pgtable.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/arch/powerpc/mm/pgtable.c b/arch/powerpc/mm/pgtable.c > index a04ae4449a02..549a440ed7f6 100644 > --- a/arch/powerpc/mm/pgtable.c > +++ b/arch/powerpc/mm/pgtable.c > @@ -220,10 +220,7 @@ void set_ptes(struct mm_struct *mm, unsigned long addr, pte_t *ptep, > break; > ptep++; > addr += PAGE_SIZE; > - /* > - * increment the pfn. > - */ > - pte = pfn_pte(pte_pfn(pte) + 1, pte_pgprot((pte))); > + pte = pte_next_pfn(pte); > } > } > > -- > 2.43.0 > > -- Sincerely yours, Mike.