From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E6D4C4828F for ; Thu, 8 Feb 2024 06:27:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D1A9D6B007D; Thu, 8 Feb 2024 01:27:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CA4B36B0089; Thu, 8 Feb 2024 01:27:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B44826B00AD; Thu, 8 Feb 2024 01:27:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A30716B007D for ; Thu, 8 Feb 2024 01:27:52 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8542616077B for ; Thu, 8 Feb 2024 06:27:52 +0000 (UTC) X-FDA: 81767655984.25.0F00634 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id DD04D20015 for ; Thu, 8 Feb 2024 06:27:50 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kOdTKonu; spf=pass (imf03.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707373671; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sAB3TJNJOJZ34vmKrSA1LdxGzcf1TUHQ+PjOH50ktWw=; b=2eG+EaDODstnfQ/xodEXJe6ZwNmMkWoUr/zNKlicZKnzpX8J7FfDFXRpFMJiYqVoeH8fUY MEhQb8MpQyuyEAF0ymKW4KyIZkjlcde05BOeA6jIaHHYNMg50hnVloIiYgMR9DSTQavdO+ sqlR9/O27JxS9pnegadzdOUm3Riu44I= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707373671; a=rsa-sha256; cv=none; b=pvz8ChhfRzzQyBiDf/6qZL9njHxeI8q2z1gipt7iAMZv23IyCcWY4aCn7Hf1n6BkyQ0v8S dU97sO/oXXmPnhH3YPJmExB3cM07s6u3Vipm1vWQTUAKm+pl/CdiNneZ0u07p2tHNLCGzS a5Ku70YKBah8FoAdDHxHKJgVcWZr+9o= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kOdTKonu; spf=pass (imf03.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E94BB61B13; Thu, 8 Feb 2024 06:27:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F0D4C433C7; Thu, 8 Feb 2024 06:27:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707373669; bh=wxaBvjOQruR4Ppe5iBXVeEd+wF2Ez98jfGSuez99hUI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kOdTKonuPOHT47MMueyUa62BOnNiiM/wNlezDtex/q6A6C+C0/4I75w1hs6HgvTcM 6hzU/xNlN2o7mllZJQrfNN8OS6yllsdwkypMwhdT9Zppi/oCLVm5oi0rjh8531W++l VyhzaLbe16SPL0h9xcRPSV+cCkOkyBpKxf4y5KkH108vuZcpzPDikPbUG6HlcbyEC6 jTwJS9vdlSE+DGYuaJ63tvvk0g/PUUXVgtbv8Zylz7Hox9kBt886iEEM3kege/8EOf NJ+pl0uRULV4iQ598Nv8XuegThQZaF4ao5iEmjzKtdYeRjwmfPMTOqKkZ7RotF7fHW dTB19Ug9MhA4w== Date: Thu, 8 Feb 2024 08:27:24 +0200 From: Mike Rapoport To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Matthew Wilcox , Ryan Roberts , Russell King , Catalin Marinas , Will Deacon , Dinh Nguyen , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Aneesh Kumar K.V" , "Naveen N. Rao" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , "David S. Miller" , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org Subject: Re: [PATCH v3 12/15] mm/memory: pass PTE to copy_present_pte() Message-ID: References: <20240129124649.189745-1-david@redhat.com> <20240129124649.189745-13-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240129124649.189745-13-david@redhat.com> X-Stat-Signature: 3tryn5icuzaw5wi49x5b7zca45y7y3ah X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: DD04D20015 X-Rspam-User: X-HE-Tag: 1707373670-485090 X-HE-Meta: U2FsdGVkX1+L0pn1gnUmkzKtCtFLDE0Vouq6PCX+ESz2ajTvbg0rv2F3M+7f35NCFp1rQiwccLCgKml/qNioHhM1qbkLQhcDra4vvTzDARy3cwU11JUL/fL2QRicaO3rzDlY/mPpXlKfAEHz4WopPv57yvdysCG7On2OXsXXwDYXIvPhdb+0sTqDYsO6aLdXXZX48w6tAoBaEcIIp2xn+SJ71ugQ2nlXy+D7BvvTspqSm7vy9NKBh+/3ivHqENKhwVuaQDCCMyjuXcLoRDb5LhNg3J9w1czru9+RkLMv5WMeU52CD+bB8PqvKSh8v2SU1KqwRuQHNXs5gpLHsySpw83YR1vxbIOqaC593DPDWWxyTchgSUukBeguNEdy7325/Wv4y73idKztrhzaS/MeO7NF/SN8z3F6uVK4efr3jAOS3oCIFqJXcRGsWDPOf4KLen50aJOPJlhvDNhHwkGT6u6+jmQa2sqTmFJVoiUvpnHhqBGwcsqLGs4APL84p5a+p5hMKMofz2l2/S2+ms++l8SBX87RFcCiJVApRzlcBtp2AQfTbx5fZLqBsiMp/5yCWmOMHP03cFg1jxGFbxzfnipvndZMvWFJs42+PxqP3LLbIdmDAabohVhrXuhepc9pgvRrbuy7P6HwdVxKejmgy2fGizIJf+6vMH8f+4XlJ7Y3OMrKDQVsIEuKmExIBuI5pLjX599HFkR6p427hMFhSF5MqeHN39vOrozE8H82bYBlyhDyWO50EHDTAvs44fenYXblo+mQSJP0cgF7MEl1gpsBq/F14QRCVjg+V4dADv6NEo9MHT1+ksRVzaQtBptrcRmqK5f6IDhIMB2Q2te4YhV9CC9jwUwi3TpBs3knyd5tE+eFoZG2RgHSz1NcGvQHdtcPddOu5GPBhY6KhldoFVs4IoAoxqV4fJQQnNqMEP+HelaVotnTFZtqeI539Zzgl9cep6ayuq8WiVXHHku xtsvX+rb SpGQUlPNIeOMdKf3ldFe20b4ark12ZlhI2ekLYIzcC+T4T1h9/+gdZC6kgQ0e7jqCSZuUTUEO8pB0DX25VWa4htsTC/sxa1r+bPx1S+V2PaA3qVk6DhT8FUKMCsnX2ttz4FZrbLHsg/cGR+xdt/OWuhFG+4egu9itlIVauaSR9uEQB3lT31+kP3ny6g7HmK5ZhuE9DeBQa2bECabG3K7YrCTsmBCjtkU1Sc7kfRV8zqlnoy9sKzGl+K7Mv1hxmHEPikgOxrWa7FgKcQFM6eZC6QbFmLdVMHr4mvR2YOl21t9cXavWohL5GMtKPzfO+e4XDNYszzatbv1ZggZaW4y4CSAjz7yjfAQR8+3GdRr5x4aism8OeAo/fq6CujEKxJZUhMVq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 29, 2024 at 01:46:46PM +0100, David Hildenbrand wrote: > We already read it, let's just forward it. > > This patch is based on work by Ryan Roberts. > > Reviewed-by: Ryan Roberts > Signed-off-by: David Hildenbrand Reviewed-by: Mike Rapoport (IBM) > --- > mm/memory.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/mm/memory.c b/mm/memory.c > index a3bdb25f4c8d..41b24da5be38 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -959,10 +959,9 @@ static inline void __copy_present_pte(struct vm_area_struct *dst_vma, > */ > static inline int > copy_present_pte(struct vm_area_struct *dst_vma, struct vm_area_struct *src_vma, > - pte_t *dst_pte, pte_t *src_pte, unsigned long addr, int *rss, > - struct folio **prealloc) > + pte_t *dst_pte, pte_t *src_pte, pte_t pte, unsigned long addr, > + int *rss, struct folio **prealloc) > { > - pte_t pte = ptep_get(src_pte); > struct page *page; > struct folio *folio; > > @@ -1103,7 +1102,7 @@ copy_pte_range(struct vm_area_struct *dst_vma, struct vm_area_struct *src_vma, > } > /* copy_present_pte() will clear `*prealloc' if consumed */ > ret = copy_present_pte(dst_vma, src_vma, dst_pte, src_pte, > - addr, rss, &prealloc); > + ptent, addr, rss, &prealloc); > /* > * If we need a pre-allocated page for this pte, drop the > * locks, allocate, and try again. > -- > 2.43.0 > > -- Sincerely yours, Mike.