From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5786C4828D for ; Tue, 6 Feb 2024 20:52:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B4E76B0072; Tue, 6 Feb 2024 15:52:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 164748D0001; Tue, 6 Feb 2024 15:52:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 053CD6B0075; Tue, 6 Feb 2024 15:52:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E921A6B0072 for ; Tue, 6 Feb 2024 15:51:59 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8AAF08051F for ; Tue, 6 Feb 2024 20:51:59 +0000 (UTC) X-FDA: 81762575958.17.ACFC416 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) by imf29.hostedemail.com (Postfix) with ESMTP id D4AAC12000C for ; Tue, 6 Feb 2024 20:51:56 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=hpNE3quY; spf=pass (imf29.hostedemail.com: domain of 365vCZQYKCGISEANJCGOOGLE.COMLINUX-MMKVACK.ORG@flex--seanjc.bounces.google.com designates 209.85.214.202 as permitted sender) smtp.mailfrom=365vCZQYKCGISEANJCGOOGLE.COMLINUX-MMKVACK.ORG@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707252716; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JwbhYZHR4hW4due82eTme97f04XbIaf6d9EPvYJz5x8=; b=XqFhPYN8jKvRK9sgGHApJ3S+z6jh7CK2TpCSvPu7l68sjaQuZrWOFD4nXvMsmCZDwrVJqW kQetPCI/xHc7h0myaXAmpw/pqXDOZrXP/4TqtvfHptmDR1qqnrIgp8OQnEtmExl4Ozzs1D +vHT6khVBi6l5jwRXCsoGQyw71WKrYs= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=hpNE3quY; spf=pass (imf29.hostedemail.com: domain of 365vCZQYKCGISEANJCGOOGLE.COMLINUX-MMKVACK.ORG@flex--seanjc.bounces.google.com designates 209.85.214.202 as permitted sender) smtp.mailfrom=365vCZQYKCGISEANJCGOOGLE.COMLINUX-MMKVACK.ORG@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707252716; a=rsa-sha256; cv=none; b=zjHfXHNSTSag3EWKZT4ihKcRCieDLFHBidkGCAeQ3TmI9XPg+2t2HPG2aButnvq/uUCHdZ i7zAcL1enEebFaKCONhaUbaZKCd9AdGaAMoBuf62rjQyYgj4aSZAqidLotHzjqS+G46oz9 QqBs1euLKLg88oOel8SLrSfHyVH7vDQ= Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-1d932f1c0fbso53373685ad.0 for ; Tue, 06 Feb 2024 12:51:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707252715; x=1707857515; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=JwbhYZHR4hW4due82eTme97f04XbIaf6d9EPvYJz5x8=; b=hpNE3quYUOLLZDc/7rZUJOM2HFHXDB5I+hAQ5D912OujzSWtCoKLX8nYhNiff5hLa1 3VFGlIHp77GXrH60ZclbwkE4FLFkzreTYeHvmnwjqnqOtFd8JV/kJjX2GzaAhpDONCJN SPehNL30dxq1xwV6E86+jdPlEC9AbL7NJ07JIfVz7a9cKGOTWJOnsqMCyISn6BqnWe14 ov6USxtCfaq9jkYRJH1MNU2OXZr+B5qU/T7jInpYW//YnyqW9GRlrEZFxefd+pA4b826 KWJ0Jf849e6uoOCsmM6j0yulECQTTjvghugZMmbT5fzMkSfyYNmUKYJ/lu0tSDovhMqx 0jaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707252715; x=1707857515; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JwbhYZHR4hW4due82eTme97f04XbIaf6d9EPvYJz5x8=; b=vkw/JYYYy9qrH33guL4mMer9SN75m6WeOTeRAeY9wtZt320o/ESE7Nn4kguqwCKrL5 TpEnZhjE8VD9LXN3RD3aneMOy0GEeP7btgptNrfia/Yyi0S4IM8ssa598IhdADo8OpZU VSlZQ6mB03vg3EKnFO9MBlfcPeuewsdQKvV1AW4Dyy70KPUvInuL3NbDrJAkaTj9dHsz I87bGpZR2GTWUCT0oLJKIoI8mj2vSX6HEA2IuE8DxIvp0ku6XMyMrXRTL+64dWvnUDj7 HmZ96G5J7F4cySWuSbFrv8eQv8CS8BPs4DjgOtFcBvKbDnp4AZRqzeVA5rzz2JsIB1ZR Schg== X-Gm-Message-State: AOJu0YwxPHhpj7rBMggLp9UqbtzBafvsZgMxd0PePBUbr7w07MJaBIVE HlV9E4aiPRkkh+ZCjapL9hiqDyNuzy7AhEJmIdzTZZ/rB1gaBBj23GU46sRioy27lt3FIqimMmJ ZJA== X-Google-Smtp-Source: AGHT+IEj5phGVut6P7UH0HGT2jn7IqSaGP6JthmOgqjg9ZskUGjauEK3HLRpFSTg5biILz4Q+Ty+BMdRsZg= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:902:d510:b0:1d9:ae91:7b50 with SMTP id b16-20020a170902d51000b001d9ae917b50mr8028plg.7.1707252715474; Tue, 06 Feb 2024 12:51:55 -0800 (PST) Date: Tue, 6 Feb 2024 12:51:53 -0800 In-Reply-To: <20231230172351.574091-7-michael.roth@amd.com> Mime-Version: 1.0 References: <20231230172351.574091-1-michael.roth@amd.com> <20231230172351.574091-7-michael.roth@amd.com> Message-ID: Subject: Re: [PATCH v11 06/35] KVM: x86/mmu: Pass around full 64-bit error code for KVM page faults From: Sean Christopherson To: Michael Roth Cc: kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com, zhi.a.wang@intel.com, Isaku Yamahata Content-Type: text/plain; charset="us-ascii" X-Rspamd-Queue-Id: D4AAC12000C X-Rspam-User: X-Stat-Signature: paeejfr1xfk6wyrd6hx5qsrzj11q5i7x X-Rspamd-Server: rspam01 X-HE-Tag: 1707252716-683586 X-HE-Meta: U2FsdGVkX18tuYPmcHMoe0JH7Mq49m6r/s1KuSuDr7KWaFIPgOmw9s5L7p4LKJBv8xxhwQTd1771ifaEv26MGPmV2VMJ0yNP3oARCktMRO3AEcP+GF5E3Xa7tRZEQN6JmSsvw8qdDdaxuRmBo3npvS/MG2vPfSCW94M27plx8EaVwN4jiyvD5cAE3wLUcayv52lw9jjokKDeLOGUrRDH37gSj77pBgE3lXF4DgWfYdswcoyVp1qQfkd65Y7EZdcP6Yn+cFdFY7uiB6glJX0a/UTdeSTEtDlyohmpbnor/PAEwyY1HkpeAErkJl0RK7yfce5aD11nhOarfYmYV65SZQw0lhYFP2Toq4cLkxXv7tUQrcJPli2McerAWyH/hrLhgXfcwxwPEcxkPULkUcUfU2MUYZFsZSUN3w7fzvvUqexQOeZDv/Nx7BV9B6aeX5Ur5KJ6dPXW7rJjJ2NzaBzPZtHuf5HNFOqlAWw/0NE2RkNgKzYB5VerdOxMrn7KBFxMBfpu5H7QpVjvxIuP4fr3XY7DDokZeUGRTAv9xmfLh7fOO8/aZ07GzwITGNB2aPAhjEH4TxonOSi4QNc0FNloD/V0BlvGh+z56bVor/hEFL37vYvRhHumzy9A0RM0vH2BkgrwO7cenWnKk2OHoNdev0NQEiygps8nv3Dc1j77JWhU6d4SkJIw3f8b+2xzccz57lJXvfCWuc9mNad7xx+bmXeanp2G3/D5TcLmQAGNeVYYXV6mMwFyR6rTwg5XqkH/GeHW1S0ysKPJ1iFOhF6ch+yrsyyt1Jw8uo/Hr2UgOkIuPUfj0x+e1qx4ObE0GS0Z1QF20CDj4McL1Rr/Y08+1yjsTtvZi1OGrZF5yVi33LET60vYMu7aB5VdSxi50vG57+8cqOaIAe7docmlABEVkbU/DQhhM8f/AIvYPVDPmWsOTC5ClXJjN2/pHsGzIxC1guB27bxpC59tz391qz5 bIuDJR7O k88HnO6DJilQ3Lc+slwPOB2Fkj908aBJWAlsnOQh00iR+R7GSVczcJijSbnwRTgK09UuHtwCo12oCY03wN5AKUcWbHsQeC7ov8nt84LmVrDyIdiWHsuTgHo7TnQq+QR+FB3CGPtgSjDeCZXkwLAN28R7GY7pKxhaxCMoSqOoeLc1d/wcMCEvcGhAR/IvoRIi9tYEOGR4qshur71khLm24LgUKbbgYiPb49lCVYLEmSEFXkaAUSZRcwzYqME9TQQjpl8mIpoULWYvxjIZqbVioz1uLjRhahP8rKgSoWgRyWikc62TNhznYbYlXuMWb9P/ZaVYBPrXOl4c9ZU+YoCDKb2F9NOGCjuoFFRM5i5DZLkhmNg4LSTsWPbt1Z+Xs4PEqCWg2a90k13VUJlDY0i2ve+vGVdUiteCMroyTb1mB1sXJSzODnbUX6OJ9s8ophqwMzTM4bgfOKVDvMH547AOKxglaJIrebyWqXwBPn3FqlOMYUmzWGKoqZDG1ttDt1ZDtzGiBcVHQa3Pb4N1fBfHQIpDklC8pPRww2F3c1b/LivSSbOH2YY07Bk96C9Xr+H2SPY6DYbeFPiz/r/EqW4v3VH++UrnTBriNrR1Jb25gj3beJRKjsZVyZga3ojTsZLPx+km3hYBNAKHnwIeKpYU/1sSjuh1MaXXvODH55fOUV5qZf2OreWd1LQQQvrsUw7/+9EdY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000390, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Dec 30, 2023, Michael Roth wrote: > In some cases the full 64-bit error code for the KVM page fault will be > needed to determine things like whether or not a fault was for a private > or shared guest page, so update related code to accept the full 64-bit > value so it can be plumbed all the way through to where it is needed. > > The accessors of fault->error_code are changed as follows: > > - FNAME(page_fault): change to explicitly use lower_32_bits() since that > is no longer done in kvm_mmu_page_fault() > - kvm_mmu_page_fault(): explicit mask with PFERR_RSVD_MASK, > PFERR_NESTED_GUEST_PAGE > - mmutrace: changed u32 -> u64 > > Signed-off-by: Isaku Yamahata > Link: https://lore.kernel.org/kvm/20230612042559.375660-1-michael.roth@amd.com/T/#mbd0b20c9a2cf50319d5d2a27b63f73c772112076 > [mdr: drop references/changes to code not in current gmem tree, update > commit message] > Signed-off-by: Michael Roth I assume Isaku is the original author? If so, that's missing from this patch.