From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E3FDC48297 for ; Tue, 6 Feb 2024 16:01:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 73EC46B0071; Tue, 6 Feb 2024 11:01:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6EE646B0072; Tue, 6 Feb 2024 11:01:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B6866B0074; Tue, 6 Feb 2024 11:01:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4CC586B0071 for ; Tue, 6 Feb 2024 11:01:55 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7EF24120C5A for ; Tue, 6 Feb 2024 16:01:54 +0000 (UTC) X-FDA: 81761844948.24.4C8B435 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf17.hostedemail.com (Postfix) with ESMTP id D6A0840084 for ; Tue, 6 Feb 2024 16:01:33 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PV0B3eTO; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707235294; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vEAzZD/rUh6xj/N0fpWrsrVKzT8PBTtHERAYd5rS3SY=; b=ESfawgAD+E15npyKCGmH3zs9618DIaS9/NnfvHSWr59vvK5hWbMIgeJGUpqcfuqsoocF1t 6GDZncxjkgfViRLATo+kNbNGmWa/KOPFFnXUakgS7j01F3cRHXnJKiY1SczufDd0UMvqdS CzMlr5rHf3fc0Q9EH3yM/Y2xVwWc/xE= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PV0B3eTO; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707235294; a=rsa-sha256; cv=none; b=04mxLWx6FBEjHSj12072w6cGdTLpUz/ds+PxRDKV3hsZD30jLbmBA6NT7IGPyA94DiK4+Y kcrtHtEIKEcvC85UASxhRrvftNsAyB6FDaYRJym77Xapkp7rS80LwYSGuQ94pLzNx+CJlg sKSFozYcBVcbsVnB7c4R1JF242CMqCM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 0B76A615B2; Tue, 6 Feb 2024 16:01:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E2BAC433F1; Tue, 6 Feb 2024 16:01:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707235291; bh=aRQxl0C0V0705HuiquTkhHHqPboA18NaqgotYv9rCA8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PV0B3eTOaNjzcvWs65Me6RDLhFj8YGByJ83V31ytWUnS8qhWSmRMRl0l5zr6Ky/HI V8VB3bU4h1IvUqAnjW+GixZAPSitutZKlnNNQsb3zhPpetctNotMxhcs+16kpERvcI QJlKVt1MUAwmmTLtRKPv+7kMaAaYKnrgHOiLqelYjBoBJh2c90qyMuKpsBQaLV4ixc x4u/dAvjHm8aNECN3GpgyoQDyFjLJi59680J1T/oC03fzuisXQvW2y2jFqQGwm715y 2X7DJSP2x6Oz8DlvjQGm4xWPmxiPaAXHidpqbvV2Qg4SWxurgjdXViSVHc8zyfhu2V +S947qR7PCFqA== Date: Tue, 6 Feb 2024 16:01:28 +0000 From: Mark Brown To: debug@rivosinc.com Cc: rick.p.edgecombe@intel.com, Szabolcs.Nagy@arm.com, kito.cheng@sifive.com, keescook@chromium.org, ajones@ventanamicro.com, paul.walmsley@sifive.com, palmer@dabbelt.com, conor.dooley@microchip.com, cleger@rivosinc.com, atishp@atishpatra.org, alex@ghiti.fr, bjorn@rivosinc.com, alexghiti@rivosinc.com, corbet@lwn.net, aou@eecs.berkeley.edu, oleg@redhat.com, akpm@linux-foundation.org, arnd@arndb.de, ebiederm@xmission.com, shuah@kernel.org, brauner@kernel.org, guoren@kernel.org, samitolvanen@google.com, evan@rivosinc.com, xiao.w.wang@intel.com, apatel@ventanamicro.com, mchitale@ventanamicro.com, waylingii@gmail.com, greentime.hu@sifive.com, heiko@sntech.de, jszhang@kernel.org, shikemeng@huaweicloud.com, david@redhat.com, charlie@rivosinc.com, panqinglin2020@iscas.ac.cn, willy@infradead.org, vincent.chen@sifive.com, andy.chiu@sifive.com, gerg@kernel.org, jeeheng.sia@starfivetech.com, mason.huo@starfivetech.com, ancientmodern4@gmail.com, mathis.salmen@matsal.de, cuiyunhui@bytedance.com, bhe@redhat.com, chenjiahao16@huawei.com, ruscur@russell.cc, bgray@linux.ibm.com, alx@kernel.org, baruch@tkos.co.il, zhangqing@loongson.cn, catalin.marinas@arm.com, revest@chromium.org, josh@joshtriplett.org, joey.gouly@arm.com, shr@devkernel.io, omosnace@redhat.com, ojeda@kernel.org, jhubbard@nvidia.com, linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [RFC PATCH v1 15/28] riscv/mm: Implement map_shadow_stack() syscall Message-ID: References: <20240125062739.1339782-1-debug@rivosinc.com> <20240125062739.1339782-16-debug@rivosinc.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3ywwgCSX0zhXuCNZ" Content-Disposition: inline In-Reply-To: <20240125062739.1339782-16-debug@rivosinc.com> X-Cookie: You might have mail. X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: D6A0840084 X-Stat-Signature: siejj4dcp364fw8emrrbhztgz7dhkwqu X-Rspam-User: X-HE-Tag: 1707235293-584354 X-HE-Meta: U2FsdGVkX1+N02OV6d+dxNoiu7DvcL3+/ErH97/GIt8eehelFzDRz+6jqHAwx/wT0wU3DzhKh08Z/bvzMVVTkbku4kVoL6zz2EgN2NQQ2lDsKdN325IewRI2TjLISMsyWVUH09I9nwDHL7KhfcE4FOI6vOuE8L35xNAOiOsn4VL97BM9wmYz6neSKdojxssUPW/Ft1v1E6bNZvqmxKdUEjCzTaJALaQgthov/w8M0oVPBeHjptPOdfJ5bOIKCBiVdTRJ3fOxuTuGLalwCTZSTUGBR3a/AGQDcj7ZCdIdoe1uayVUpBkWDI2EE78KxLiEJuvnA/ChRlRbzO8C3BSgaUsZ29hi+e1jh07nIbwam8d7kgds8PK5DPtnMc+0199nhbCZqntLmQEd5s/HSWE/U6l3UD61I+VbUK2b3F6GbLd5VeOlmZnogDMQojOPa3aFAKXCn8C2EH5I/kgVZOkEvgwqAmVZUf3m67wNuMsDdWCmGDTLnUfvBVPdjAFmrzJRYXQZm3KALUXyzLpXDCOUhajzc5g5OiSBIm0K8G7Pp5O72a//RJXwV3gqJ5RGbY0v+chF6VEq8RFvMDcMRXfpUCbQYgrna79fEsGJc3QK1HLoihQlFwni8B/aj6lWBa1PN26RYElhY4bFRTC3r97mdRmPVm4AIGRLMJ19HaFjPg3ezpFClNGTZrcDdZIBU4ffflwWHX4e62Ptyp7GfDZNUp94ciRb2WBRPkTyoYSADq28qW2X9442A+u0ZKu9xBRYr3VjbNsHRfxHAAURoDRjA3hlWoSBrC0aUtJ6e4B+7n8nVTim6aVB32FFtyjW1t37vQFCzW+qC32Sn98b2bFIa91S+SXlg952xYiYV6ARtqTVxZRi3bUZ7jNysTu5682Z6zlqSioA9DjzftywugAzmFGjAXMAGXP2d+6p3S5rR40oJ3i/ua+no0f0Dd7UG+7l1Zvjb8E8uB9ICMDmzMp foffi9NZ LJt4/MWp+LIoRZVyYQIyWzFZW19MKBL9pTqTXLTsBIx98WbOfzTl9VZ73VNV9VQwZHquP4AAFnVTorjVdnw2Zuhlkw7XhoqO6wdsT7+P4DYx16U94PfxCqurWpuqbo4r7fz+ifKbBoQTZ7RcdAonuCGkLHvtyDpakqtxE8pdqiWz9/f+GZfT62waFzYtqUijXvnIe6TCY958mGAP/O7JOSnvAb6Nl0XtGZWY1NQpFRZ2lq2qfZcN6i+C0IyEVIAXatJUoP1DE0yb0xNxd79FMfx+Zd7Pa4XEQyzGiZxL1MJqZVJq+GlXwk0Dfj5Z74M4P6kEya0WTN7W4yCUlNUp0zC+QftM7nXa+DIn7FuY5a4zwoUA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --3ywwgCSX0zhXuCNZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 24, 2024 at 10:21:40PM -0800, debug@rivosinc.com wrote: > As discussed extensively in the changelog for the addition of this > syscall on x86 ("x86/shstk: Introduce map_shadow_stack syscall") the > existing mmap() and madvise() syscalls do not map entirely well onto the > security requirements for guarded control stacks since they lead to > windows where memory is allocated but not yet protected or stacks which > are not properly and safely initialised. Instead a new syscall > map_shadow_stack() has been defined which allocates and initialises a > shadow stack page. While I agree that this is very well written you probably want to update the references to guarded control stacks to whatever the RISC-V term is :P > --- a/include/uapi/asm-generic/mman.h > +++ b/include/uapi/asm-generic/mman.h > @@ -19,4 +19,5 @@ > #define MCL_FUTURE 2 /* lock all future mappings */ > #define MCL_ONFAULT 4 /* lock all pages that are faulted in */ > =20 > +#define SHADOW_STACK_SET_TOKEN (1ULL << 0) /* Set up a restore token= in the shadow stack */ > #endif /* __ASM_GENERIC_MMAN_H */ For arm64 I also added a SHADOW_STACK_SET_MARKER for adding a top of stack marker, did you have any thoughts on that for RISC-V? I think x86 were considering adding it too, it'd be good if we could get things consistent. --3ywwgCSX0zhXuCNZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmXCV9cACgkQJNaLcl1U h9DovAf+LgWdOKedTbffoEJgm3iDVrzzlW/jko7UF4Sjg6Gv0ngCJGWQIzvYEk/w B/3v/8xatJ9n+VbKX606intt/LsnRYDNTB3OVDKogBCeRo6NPl26QjEqt8lQQtSa po1FZcEIfdjmxWOCphm0MYLR97sxtDs+07Y6SOdoEFyowqDP9y7VIHR4juOy0RyJ tpKpA1fORTVxP50RQT+V9GZ9zuV6FL2C5ULfahB+o6W6r/wmVlSWdsFkwdnayCKv 9DqlaPDQoklRZRy6bgUPTHyc1b6suEgg2G6Om/Pzd7Z3snoiyeDBoqMgMWOhAa1r XYbr9H4oCPUEs0ONOGZmAcXzGu7kIQ== =mDMz -----END PGP SIGNATURE----- --3ywwgCSX0zhXuCNZ--