From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F522C4828D for ; Mon, 5 Feb 2024 21:20:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD3EE6B0071; Mon, 5 Feb 2024 16:20:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C5BA76B0075; Mon, 5 Feb 2024 16:20:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFD8F6B0078; Mon, 5 Feb 2024 16:20:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 995046B0071 for ; Mon, 5 Feb 2024 16:20:52 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6C61B120AF8 for ; Mon, 5 Feb 2024 21:20:52 +0000 (UTC) X-FDA: 81759019944.08.C4CF2D9 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) by imf30.hostedemail.com (Postfix) with ESMTP id CC6678000F for ; Mon, 5 Feb 2024 21:20:49 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=iCMS25qj; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of 3MFHBZQoKCA0B154Bnuzrqt11tyr.p1zyv07A-zzx8npx.14t@flex--yosryahmed.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3MFHBZQoKCA0B154Bnuzrqt11tyr.p1zyv07A-zzx8npx.14t@flex--yosryahmed.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707168049; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jNIvfpTU2Fpa4ge5KnuIotPD5KC6q3mmjxvezR8AkOo=; b=4y2gUgMHFQsUd9DyN+LOYkTXKjHP8zjUaFw1yQOKjpB9yhFO5RK95ohj/uKLeDTWuJ1vSz 8g9Ib3fj9T4iyNI/vTI9M1+o66Dp0KihBTg3hqV/3BSmoFwshGImJ0bRxjRflUVi/jispM WFPwO7z4ZpboRJbAYzdaBOkoMIjOL+4= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=iCMS25qj; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of 3MFHBZQoKCA0B154Bnuzrqt11tyr.p1zyv07A-zzx8npx.14t@flex--yosryahmed.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3MFHBZQoKCA0B154Bnuzrqt11tyr.p1zyv07A-zzx8npx.14t@flex--yosryahmed.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707168049; a=rsa-sha256; cv=none; b=Zz7MLbAHFI00rGvA/pogS6EY7tot31KC8Pjgmw46Z9z97Y0OKA3SnzOiZ6rPN75nylfztd AtQ841XRq5tZvXxvvj/qLF1G1eVgFLThWFz5xQDZlugF4R+64daMkQCe37xYYA3innLmry cYCzlKPTPTB6QZfLmcj+dZZfJ2/F6Yg= Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-60444884b7dso2471967b3.1 for ; Mon, 05 Feb 2024 13:20:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707168049; x=1707772849; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=jNIvfpTU2Fpa4ge5KnuIotPD5KC6q3mmjxvezR8AkOo=; b=iCMS25qjtNyd82vjAGpyTucR16IK1dlqY76pEyJpssGPJAdcgknpoiTbSh3LWJ1hXV zqt3QUeuu4Ed5PHIoKQQU9O74PheMgltN66YbRiyPnkVJINrL0SwzMcrwbMFG0or88yc r5ZtBFEEHSXiqGrBdhsolr+QsnoXSP9PXGmptUr4cZBugd0vTgC68eWNBo2i4xyr9QYx 0/PvhabdToywaWF5kr5PYA0/tlRDxH1BFM402m7DoosK9GYXfkeeS8yVV9KCTyAPMtn6 VGn1y/RynWSxOJvZRxgAYtZLJYw1AocwAYVXZu4FEJziEErte6mMurfe4175Gr2657QH KYdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707168049; x=1707772849; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jNIvfpTU2Fpa4ge5KnuIotPD5KC6q3mmjxvezR8AkOo=; b=WZJtyTzUU2y/arzO+TQyLQ7B/p0qMOXg8jBDWbK7U6j/YT5UIdj0Til5NdZzSMltL3 vbNTbOFXRseVP6Cvifhv3sMtgilMoJtp7jHHruOemRmna9/GiLTNM9Wv48Nszahnj41E hl9gVTY9oJzkx4gJrZbYaRkbPLdtq4b5046S+yKA2uTRXU6UYhgoTDLFipsuDVJClQ8L lycviWenOoiColc/aDuUGzTCgPS8dNC68wt2xykzxLLXl9Gfm6IJmiVmX/yzch5iO1mI ENFnvH/1/9XpDHB5GbX//WzBrtggVn/m4bPMOsbm/24zUGcJSN7WmP65y/yW0RNq1E29 IPRw== X-Gm-Message-State: AOJu0Yw70G9MTqeqks10RW564+AGI2Dk2s9Rfa7BgeW2/ZQfy7rL5yek JKjFqYKrD+PazOvj7ifoc1Z6D7aQICDf4ZSjZdgvtO9yFOG3q7RY/woEYPFiR0wQ3CrU9mIEGq+ bYTIs4hICGZetnT/0Ow== X-Google-Smtp-Source: AGHT+IG3rtxQ30HFoMYrB9CwJEYIFwygob6z+BpBr6JkE2L81EEy5Naj69geg9TJ7LPf+Bv75g4pLQO69lQDNu4M X-Received: from yosry.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:29b4]) (user=yosryahmed job=sendgmr) by 2002:a81:4cc7:0:b0:602:d83f:bf36 with SMTP id z190-20020a814cc7000000b00602d83fbf36mr150466ywa.0.1707168048867; Mon, 05 Feb 2024 13:20:48 -0800 (PST) Date: Mon, 5 Feb 2024 21:20:46 +0000 In-Reply-To: <20240201-b4-zswap-invalidate-entry-v2-2-99d4084260a0@bytedance.com> Mime-Version: 1.0 References: <20240201-b4-zswap-invalidate-entry-v2-0-99d4084260a0@bytedance.com> <20240201-b4-zswap-invalidate-entry-v2-2-99d4084260a0@bytedance.com> Message-ID: Subject: Re: [PATCH v2 2/6] mm/zswap: invalidate zswap entry when swap entry free From: Yosry Ahmed To: Chengming Zhou Cc: Nhat Pham , Andrew Morton , Johannes Weiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" X-Rspam-User: X-Stat-Signature: n68so79bhi36htethm35h7ffpfkqkxqj X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: CC6678000F X-HE-Tag: 1707168049-283418 X-HE-Meta: U2FsdGVkX1+K5JhL+Dp2g19rr4uXyjzeS6VVSGn23QhDZD7NT/RJvPnXJcrv3739CsLbM0L4BL0Hof3sYejxII5WaOOieMmGuw3QiUHZqTEu4fe3EvkHGG3uCiYyfVmjntZi2UQi7jubtzQmwlwf0NQNDF4FYB1mM+nN+Mzrnuh6udrc7PigXfUDz+efCKtctjU1K4R4/dfrjvEQ4LoQcA8ei1Yb9wQynGSa35ZcOAr7Rl/UIoQ3rDfQUkOXOqi5yMpdokDbd4rizpmV64VfTqHxVZgZubjR4F7tg9JpNA42Y5GTQBWktYoQy4NsqLW3qAc6Kywzl3ZFnz9XK5P7IOM52iPQvL3jZ0dmJry7x+pFaEn1kXc5KDThjuYUBTyo5CteU01rsu/b9n0u45f9gdNsRkpZUySMVKf/jR0Euja6ATtO00R2YdHCX/6QGq/XQO7h/ZhYyLZEAP8OppvJ1zlaCg/KL9D7bciz1OagsO07G1Vq+9SJTT9ryWG9+6GLut8rBds40ciqH3ZQKU2i0qwdYVVW19Obc8vvNVNbVav/P1S7D5CSkocKvTbNtBc2NBWgG86o/4ysGk3M32Lo42IDFfTcNtepI+Dkt7BReNDojUL1e6JSHoafWUnXRIuz9znGP8EC2GIP+0t0pfnD7iASQ69WsewIlY7t7S8+XCnqGV8nmIl7jEXBKR1RHrkxXAiqkNmC1eHpQrzusF0dddi2Asnv9mPJkaX6M59usd88Mv9pG1O5VJ4+9cxgZaf5X4LPEPNEfBT+R4sKvmvVeNZzIPvxr8crB9zmoHv3f0esbxTxkMUffdBnpg/fen0Ar8XnP4fkYWYSj8KWJVbDiBFJqpJOW913phfe9U3Fo0K+XDLdgwy2BDUnibdfdq3/BhutZUzC+qXW2lmjvTX9gpuGwFA2CTa5e0OUoTqY9lJ0GfIzUMEtkdd+2FjDE2UCjujHmZ5p9MWpibnfRgK dyZOO73C hY5U6nAXoNEePThJ/ReW5k1BZOAeAvI+HB/jgT8fWQTeJEziP4UYxfrZwRAEQnKx6cnuuCUivu1HaMx7rmCSSDHA4x3Lb0v5FvKBt14Mo972xgvaI6rIXG8ZVWVhsuni27vokBXU9lkhV1znRPoMm7u2qreNecbuzJDyDehYxe4Vmz0C1OkVNM3Ii18bheLIGkZ58lu1VTOGOhDS97lWobDVeah/nJJF5zjle43A6Tr5Yph/IlUTzzGjSKIWr8srLal7o05/cVIrThCan98INnmbQGUiMopk/c4nbPNMkvIhcSCkDurda8o7boMZGzF91lchBpFrdySksTh58sXLGJSE2d32/W3rmePURpyJks0gi1J6PgjPwSGbihA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Feb 04, 2024 at 03:06:00AM +0000, Chengming Zhou wrote: > During testing I found there are some times the zswap_writeback_entry() > return -ENOMEM, which is not we expected: > > bpftrace -e 'kr:zswap_writeback_entry {@[(int32)retval]=count()}' > @[-12]: 1563 > @[0]: 277221 > > The reason is that __read_swap_cache_async() return NULL because > swapcache_prepare() failed. The reason is that we won't invalidate > zswap entry when swap entry freed to the per-cpu pool, these zswap > entries are still on the zswap tree and lru list. > > This patch moves the invalidation ahead to when swap entry freed > to the per-cpu pool, since there is no any benefit to leave trashy > zswap entry on the tree and lru list. > > With this patch: > bpftrace -e 'kr:zswap_writeback_entry {@[(int32)retval]=count()}' > @[0]: 259744 > > Note: large folio can't have zswap entry for now, so don't bother > to add zswap entry invalidation in the large folio swap free path. > > Reviewed-by: Nhat Pham > Acked-by: Johannes Weiner > Signed-off-by: Chengming Zhou Acked-by: Yosry Ahmed