From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DA03C4828D for ; Mon, 5 Feb 2024 21:16:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 075466B0072; Mon, 5 Feb 2024 16:16:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0250C6B0075; Mon, 5 Feb 2024 16:16:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2F906B0078; Mon, 5 Feb 2024 16:16:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D30156B0072 for ; Mon, 5 Feb 2024 16:16:39 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5F1D8C0558 for ; Mon, 5 Feb 2024 21:16:39 +0000 (UTC) X-FDA: 81759009318.24.3CED458 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf16.hostedemail.com (Postfix) with ESMTP id 108CF180010 for ; Mon, 5 Feb 2024 21:16:36 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=k2QTPAlp; dkim=pass header.d=suse.com header.s=susede1 header.b=k2QTPAlp; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf16.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707167797; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UqjQ8uzPWkoXvaP3jSmRX0mX+6vg7iSnhNElmOf67RA=; b=KNlHDeN1YBm+TCkg7zamzmkerpkKA2JhAOJUXqybAPdklp33yiH8zmUjiRYSgTHMtdhOiz ehFYheUu8TarCnkoVtxEcDB8/TvAfwVPOAUplGNRy2nLyilVx6cF4rpCA+n90vBP6G7IvE OmCz7c7xg60GFUfPK9xIjTaT7LSvOyY= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=k2QTPAlp; dkim=pass header.d=suse.com header.s=susede1 header.b=k2QTPAlp; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf16.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707167797; a=rsa-sha256; cv=none; b=BAF8jEYo7NykDCB+mo0SmbsLEVWkVtX/b6by6lJn0qeWxrlHJJOWy6kZLaO7GK1LYcdNVt qa3+Sscb0D23yhJQSSaI7Dgnz3lt0zsrmI1Km0AyJXT1APziUwIwQTxEZN0wGlYyId0/vf RyeBLgrFuOXbdU/3ayQYeJEiDQwA2vM= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 52B1021FB3; Mon, 5 Feb 2024 21:16:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1707167795; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UqjQ8uzPWkoXvaP3jSmRX0mX+6vg7iSnhNElmOf67RA=; b=k2QTPAlpUZx9xWdcIwXtXXDq0RS18tpEXYVMAwgeXgBnBYJefWMYQ93JLDFkCalSq3ycUy VZAEpeop+Dxd1H2y4UYD/k2bR0lxrH87nVnAGgfJdz4CSRW/671XL7U+K2ActeCA0IKwI6 nBokQeUPwfSSneyy/npR/ngpYbv+j+0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1707167795; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UqjQ8uzPWkoXvaP3jSmRX0mX+6vg7iSnhNElmOf67RA=; b=k2QTPAlpUZx9xWdcIwXtXXDq0RS18tpEXYVMAwgeXgBnBYJefWMYQ93JLDFkCalSq3ycUy VZAEpeop+Dxd1H2y4UYD/k2bR0lxrH87nVnAGgfJdz4CSRW/671XL7U+K2ActeCA0IKwI6 nBokQeUPwfSSneyy/npR/ngpYbv+j+0= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2F00A132DD; Mon, 5 Feb 2024 21:16:35 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id tIwCCTNQwWWHUwAAD6G6ig (envelope-from ); Mon, 05 Feb 2024 21:16:35 +0000 Date: Mon, 5 Feb 2024 22:16:34 +0100 From: Michal Hocko To: "T.J. Mercier" Cc: Johannes Weiner , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Efly Young , android-mm@google.com, yuzhao@google.com, mkoutny@suse.com, Yosry Ahmed , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] mm: memcg: Use larger batches for proactive reclaim Message-ID: References: <20240202233855.1236422-1-tjmercier@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 108CF180010 X-Stat-Signature: wr1mjg9841oj3tws8scx1k3agi6b9zwg X-Rspam-User: X-HE-Tag: 1707167796-559581 X-HE-Meta: U2FsdGVkX19OcWsCFOcehH6B0KFnxTqP0jUlvSsZq2PhWdWfVoN6TIhA5KL24jsJwKB5WTm4148qCAa3K6lToYEhCZh13nExzKD5MhWxrbHnE6kneorZp5b4UQ6/5SkOhfuSNH+thOcGI+Hjml0pQaeBqTK8IOOAmGAIVlN/tmOZaHzRoT0Qulsg13UDeVv3TvjhSJytOWO9T7Mjo68XLMTTtytfspXhaKh+kRSPgf8RBerTAF4dw+If6eWeIF5TCuV2/SMCKTH52T1hVDwdH7z/sHV9V2TCIyeeOZ7lr/njkFSY6fkdz2LdQOHIF0SqM42Q7KJiZiQCC3ao1gfFYMKtDu5nCGDFnryPZ7iy6hSGk+A2tjiFB2Ilmha9uKPAWp/O9P5oBpTOhe2v05/fNUEX9ryFizPJe2+M/M2v9CQzDicnm6w6T3AnRAlJfd/DOdhLIQf+iRt9VnRm0Yn32qWceGGVgTCgNFaxq7ZXo0ZeG0tpMpUMaI6JWGo4agTEfhWhtpduxNHFaq0Ix5Inp02jGNDsE1dXsb8uBlHE2gKvpd3IUqhYyHp5NXe57yJwjmxBFdp5uFowxQBywsY3DIejeyegHwGJjaWxZAfBd1t6sQMVKTeGNDxyNTLfD0q1sOt9S8ifWFuQW4dhtLwCYv0nPpzKKdZQWXWpXAgoVNdznx6hx5cNTjXJyJYVkViffxCnTidOVzUz8vu1vMlLf2Tahk1ZC3rNZvSKeWuYtGE4xzrnS6uyXU1w+wSuXy9zYmLXSNh1QqAloyRjPOAL1EP7Ee1BH9bJdD5fD3DsKlczi2OFezUMnhYCAcB5WVWryaxqO7KWI3Hlwjb4ZALEC+iq6DCuqzPSc6y1VrTiA/hlDS1/d+5BU97lAwqN6qvXD1wCmmRykFEYwo6st8wBS08mgint1isH9IfXEwy7zv8Iam8L2g99eVZKXDWlEAUOAZU0r479kC3pxgF3HGv rmCQDdPr 4GJh40Q05Fr7/kuZZeIYOjn76pya1aZttMSX/sHLwR1leceTZPfnPII2rh86Va3YWQY+3SzgVFFMedO6LS/rrrOyuHctCaPYHf7ARmBMgDMqEWBpyZBawBawv1C0bQOOAXYM+HgcKx850UbM90Z0eP0r7ot80FFwm1sju8dKng/AKYP7cM7o4YFw1dwuVN36949lym1vX80PtS92v519KzSo1ez/3WG5CGvffccnmsvXJ/xAofrC9OjVm6TQOWIxN18m1b8mnF0i/I314eWzSyCJ6bM51kcASoysQ9wFyAhE8bEw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000895, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon 05-02-24 12:47:47, T.J. Mercier wrote: > On Mon, Feb 5, 2024 at 12:36 PM Michal Hocko wrote: [...] > > This of something like > > timeout $TIMEOUT echo $TARGET > $MEMCG_PATH/memory.reclaim > > where timeout acts as a stop gap if the reclaim cannot finish in > > TIMEOUT. > > Yeah I get the desired behavior, but using sc->nr_reclaimed to achieve > it is what's bothering me. I am not really happy about this subtlety. If we have a better way then let's do it. Better in its own patch, though. > It's already wired up that way though, so if you want to make this > change now then I can try to test for the difference using really > large reclaim targets. Yes, please. If you want it a separate patch then no objection from me of course. If you do no like the nr_to_reclaim bailout then maybe we can go with a simple break out flag in scan_control. Thanks! -- Michal Hocko SUSE Labs