From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA825C4828D for ; Mon, 5 Feb 2024 23:54:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 242BF6B007D; Mon, 5 Feb 2024 18:54:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F2CE6B007E; Mon, 5 Feb 2024 18:54:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0BA6C6B0080; Mon, 5 Feb 2024 18:54:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F1C5A6B007D for ; Mon, 5 Feb 2024 18:54:00 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 77F02160B60 for ; Mon, 5 Feb 2024 23:54:00 +0000 (UTC) X-FDA: 81759405840.21.0CA28B8 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf18.hostedemail.com (Postfix) with ESMTP id 7CD881C0002 for ; Mon, 5 Feb 2024 23:53:58 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=tEaAIVpA; dmarc=none; spf=pass (imf18.hostedemail.com: domain of charlie@rivosinc.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=charlie@rivosinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707177238; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hmrdDifKn+uVsNlfDzCvuZfjS7ayNWNTt2suseO1un4=; b=6gMCBYuk8+IoEKrllGloX8GwMFsKWU74S1OALWPwHt3aCPEqCfBlf94KjgcElu/tFLXPlI NnqTgy/xQRHXrOzmgG8UfeJdKZ46u+NExz4WPchSQbNbCo5C7Fb84WGAMgmC2iHYk2nwaG ARubfnbUBvC1mU+JFVX43XMeLl+yGyk= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=tEaAIVpA; dmarc=none; spf=pass (imf18.hostedemail.com: domain of charlie@rivosinc.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=charlie@rivosinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707177238; a=rsa-sha256; cv=none; b=rwNRn+M7qMUmGh7+J29wUgitTQxU6ESlO1U1q6TINkQ1NIU0C9aCME9NsLRVrFpWStd6x4 5+jFlfphy/5fl2jB2OfANqTmIQg4bpy+qOYb3Qyg5ACjI+snUPeuJof3O9cPQtT0EaAaic hGrD1oQOiTyOo6rYg+Y7ttSBjrKOqe4= Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1d934c8f8f7so40333955ad.2 for ; Mon, 05 Feb 2024 15:53:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1707177237; x=1707782037; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hmrdDifKn+uVsNlfDzCvuZfjS7ayNWNTt2suseO1un4=; b=tEaAIVpALGYxlVxc2N/FETU65nDG1OzUsKYKIe+1ae5XrNBxyoF47rW8rx94EUT+3e DfDb3YENfCaCM44btw8R3GGVomktGBWKiMzwjlk+PL0bgmD5JmNeLgovCov6nQ+oo7v3 mUde7fb2NHo8trtPF0aTfsnjUGYxolGti263nE4VlCMJbpAILmC1Kkb2tgDoQcQ3j6Wl EQkx0xGdQ6v87we2KFF9OqXh6DDUSlJIfol0EYU0u8oH69zt8rDd2RhDWn5IU47vEkcn gzhvBGzF4ff5BIouEUFprIESx6E7LpFfNep+8b9naS15P8BMC8Ra8+fpZI6RAye9aMWM gDdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707177237; x=1707782037; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hmrdDifKn+uVsNlfDzCvuZfjS7ayNWNTt2suseO1un4=; b=Pf1orUw+A3gyxfP31ojiFDtgFjOlSwyHZn4hXS4wr8nlfT2LzUSK9wy+cvdiHv8SrM VgVYQ8HKXoNDEYpVHkBmyZuqDmQAbm3QDmayp8kHyAB40WPc/e58n1fGsnbxBOtFDYF9 06stF2uxRyh7kJ2WsYa2PwX/+qQ7CFAYhmYcYPje6EDwfrf2ynJ2agxWGeY9yF5m/r51 gGRP5tDZ2ldbfHd7QsDvSnPV5eASp5BXj4TIaaSD5B3ManoAw6ldihFJ6WTIYahgTiBx toLzCLW/RyuTnSOEaQnuvWQnmTKN91ct75RwyV0SyfDhX+F3S23I/zNcv43/zv4DFGxZ 1Tdg== X-Gm-Message-State: AOJu0YwZnfJaiohu70bhb1E2l7N4UnrsIv+23kteEic/xk1GsJQIMfY4 A6EbbBvEvhKvyxhNqtCkYokDBCT+XzXLDbJfLtQtiXMJUhMynjEswloStaR5rw8= X-Google-Smtp-Source: AGHT+IHeI/+Sp824UroO/mDYidk3cFb94YOApkQqYdkLtM9PHmtd5rblgX/GhroclrmfDZVRJjAJvQ== X-Received: by 2002:a05:6a21:2785:b0:19e:89ae:9b52 with SMTP id rn5-20020a056a21278500b0019e89ae9b52mr51387pzb.7.1707177237249; Mon, 05 Feb 2024 15:53:57 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCVwcZhTk4c0u0np/uhoHXLwPQ/Wcj2MaeQOM9FqkgxTj2vuWoI/YVq71BO5+lhQYk5e3bISfbaGFDwsMYle96R7byvptgPpHlcZishruHbiB2ER4cRLKUlSlSasxMzD1Asz14TVXCdqBFQGhWo0gN5hQcCmHn1noPYecH0xtKK6GttXmIn4v/8Z3JF41HtMi0WjDjq5Gj2Nv/KL4aEAO6D3s3OGA7wAtbIdL04MZdkkF2CmOjQQvL8jlAJQUqHONWA/1DPJdI0imC15vjTHcmrkvgr7TEDqVli0Mlg9oQnxUwoZXAO1VedoHrNEPmI64j11xtnv2+MgUEhwUUjFpcaFUjralvHAUvXcA5fPQc2628t1uCSBbOcw3jy7ESMZhGUDpplvpP7R7VHdhx+GVMTxtl7eE5RKZQfmkoU4KkGTOYG2+pYJWJumzly5fwvjX22/7ZOWnO5JAcWy1+RlzpyruTNclkK+EwLEI6X/GyAOPAFqnt7d5A== Received: from ghost ([12.44.203.122]) by smtp.gmail.com with ESMTPSA id e12-20020a62aa0c000000b006ddc7de91e9sm444758pff.197.2024.02.05.15.53.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 15:53:57 -0800 (PST) Date: Mon, 5 Feb 2024 15:53:54 -0800 From: Charlie Jenkins To: Alexandre Ghiti Cc: Will Deacon , "Aneesh Kumar K . V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Samuel Holland , Andrew Jones , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -fixes] riscv: Flush the tlb when a page directory is freed Message-ID: References: <20240128120405.25876-1-alexghiti@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240128120405.25876-1-alexghiti@rivosinc.com> X-Rspam-User: X-Stat-Signature: c5qmw3ux6zn61ffbrz7cjnsp3nt5c44j X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7CD881C0002 X-HE-Tag: 1707177238-963132 X-HE-Meta: U2FsdGVkX1+i6MtPu6WZN/20QC7q/Hak9pO3eL9g8oNuhUeOfrcNJdxdiEi3WzMjlWxU6LPDhk4kz4oicH3hfRq/TAQ5S+FtKtFj7Jwl7rWB4tu+LUoAvZdN+LCQRDJWwu6OBvaHo6yEiNOf6yDvwPlxwaRx67gXU8OSE61z6a+uQdv/79d+s1OmAGe/zD7HzvYJ+NgCufK83eWZZyp69aqGwmKmQcPhMZEVdJayo/GGiIPSAtc6vv9k/R5HrqJR/t6zI7rKn06Ocr4+xYhngHNQRXRLnXaOWNWV+LYyuA8H+EEM6k1KeKVM4kFai1FeUSHhBSly+3oFJnNE3+/w9wMjVfMAhiPwYxPMPbalDA104tHc1Fnp1KKLWyyn6mo/cwifjyhdihEqsdP341+Kweupy5Eyn4VqUVzZHi70nfdQNKDboNTTeBoyBSdx5ntFzd8xKcoqZQjlx9QpVbsQOGFgi1r/1pQFD7SIbZz6J5YYOM6ERHUTW0d80b3aIajWzrwlyR4Tx3UMxZWqPyctJbKYwtA3fkYob3UU31AWRDg8yWg28ZbEBcwkwTxGZOUqJFI3nF2vwn0UDhUIfZDSnu/51z3ov590F/fsltDLOiGYH1NW3KReoYunM7plrJDZmJlAmqeFtsz8iPqsM7g6htZ16w9XCAI1NJmLfQv5YPns5GsuQU3VW/n/+GD+oCj1Zzq41ob5HCtvF67mIXSsUFsKikbn9hRmC/RSq5VPMEdFRCtNBkmpg1FS4hnp7dCIpcm6RH0F0mvAobCAXO+TysNdBj+syrf6PnY45125C5rfIpAcEjxi/Sx3Z6PnXJ6/uV+TNuMmnMNlvIbFTKtb0IqMzFZC5vgv42/IYBzm2xjWCA5wkXkZRAYV6RckBbLi6K9eIFyQRG26DbP8viD/yf359chf6X4G5tMhi0NAZBNLtHwGya+iA87/5KlOOwXLhBPas3q/HGPJVbO4sIX 6bsC90s0 qFPeceqEZzYUPjwDG3huERPHas3yt2NA81p0loySzKH1M+Bl1v76VCfzLCJiLVXPXsyYW3a4QFNLVhmh8rWu0WgYEBaIReG/X2NwPVsK2S+rifUnV1dM+vWSMVIH8Ww9Q7VJ/O+1yVbcK2gvYebYwjBVMYAaukfwu7JNi0klWlxHzGsKO0xI8sWJW0QDF6T/nf+TGRWHbghDmXy4H3zprXH7qWCkEN30hkbEzYnHB2WOon2Q6jUintplh8ka7kaInW/loYzLb7Yl9bXs3LeLi8Pdil6R5SUExhaeITbzLfMEbHZsErXgvRoRFh+gFLnR+wXUNnZHeSQ1UcGj9t9kZsij4VdRqFmrBLsStaL/dZll/8p5LLs4dFDAtBfhJ+z+E1R3nZ+zsE78gmumsqgEYyxR+xLL0kVLtz/rdsllTGC6AtAfWJzpozUcNalfC0+2PsLj9rd/tZUV+kjQoPh6dGJS94MJEaJdlooGdZYzbD8jPt+Br6LEQFbxKnydCjylxn1F2ybzdI8k/nj4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000022, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jan 28, 2024 at 01:04:05PM +0100, Alexandre Ghiti wrote: > The riscv privileged specification mandates to flush the TLB whenever a > page directory is modified, so add that to tlb_flush(). > > Fixes: c5e9b2c2ae82 ("riscv: Improve tlb_flush()") > Signed-off-by: Alexandre Ghiti > --- > arch/riscv/include/asm/tlb.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/riscv/include/asm/tlb.h b/arch/riscv/include/asm/tlb.h > index 1eb5682b2af6..50b63b5c15bd 100644 > --- a/arch/riscv/include/asm/tlb.h > +++ b/arch/riscv/include/asm/tlb.h > @@ -16,7 +16,7 @@ static void tlb_flush(struct mmu_gather *tlb); > static inline void tlb_flush(struct mmu_gather *tlb) > { > #ifdef CONFIG_MMU > - if (tlb->fullmm || tlb->need_flush_all) > + if (tlb->fullmm || tlb->need_flush_all || tlb->freed_tables) > flush_tlb_mm(tlb->mm); > else > flush_tlb_mm_range(tlb->mm, tlb->start, tlb->end, > -- > 2.39.2 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv Reviewed-by: Charlie Jenkins