From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81E17C48292 for ; Mon, 5 Feb 2024 17:20:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ABFC56B0085; Mon, 5 Feb 2024 12:20:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A6F276B0087; Mon, 5 Feb 2024 12:20:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 910E06B0088; Mon, 5 Feb 2024 12:20:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7BFF56B0085 for ; Mon, 5 Feb 2024 12:20:48 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C68FE140504 for ; Mon, 5 Feb 2024 17:20:47 +0000 (UTC) X-FDA: 81758414934.05.533D8B1 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by imf09.hostedemail.com (Postfix) with ESMTP id BE8C3140035 for ; Mon, 5 Feb 2024 17:20:45 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=cDhZpVTl; spf=pass (imf09.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707153645; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aG4tUT3lHaMLFEjxeD8AYZy4cfDkV2X5VzQR/NYYshw=; b=AXrqUgwYOneX1VlK55ISjvI9i8/EjbOTqKNmI9v1eHx4oCwfSwXB1c7IMfNq05YEg6wBjS R29yvUWfjQhYG/KZon7ovuTNe3YOqiPiSSODfqL7j5/k0wT1ZvjAxo/fsmO9cIOfxZ4FK8 cL1t8KCQZOIsE1n+3bsrzqWf/5X4uPM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707153645; a=rsa-sha256; cv=none; b=tygjUDGZYk2u1FkjztyZscvFYg3XAj3RucooqjJ2f3WLm4jEzPthmdT8ScB5ZLbOHx9Fiv mSfXmekipFIwsHHHEAbl3/dnZDQ/8Yz0xPWQcIWqNbaYoNwo4wTiUeub7UVp7GVOhekK0T PmLurFxaRp0AAIgtMPSWnw2F2HPCT8s= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=cDhZpVTl; spf=pass (imf09.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-5113303e664so4899084e87.0 for ; Mon, 05 Feb 2024 09:20:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707153644; x=1707758444; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=aG4tUT3lHaMLFEjxeD8AYZy4cfDkV2X5VzQR/NYYshw=; b=cDhZpVTlp5M+CziMrfau7qagzxclMOhVFInJNNcTz5XdZrjkerJupnpJU5MdCcRRJB BiZHY8e6FxmRYN+osfNW9LG9ludEBP+XsZRVxMr4cR0MXShFl3t2c+Rz5cHBiRwcTU4K 09EfS//Kmji2BiBZui0fqOLDSRoyEb7t0IleU4XUsXmyctEICe/r1Saq7dE8QG8Jyd9c TrKzjxXCAtNsyKkox38gmX8o5Hvg+DQ3NTBJaey1KFVGFg9irSd1cABRsEHG9PfLPYWu fm3liFGXtvekeRakj6yGHu+7bZ7qK+XJ+AtBlhlcsA4BSDU9Nu4CUTrcvGEhPRWAewUH BQ8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707153644; x=1707758444; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aG4tUT3lHaMLFEjxeD8AYZy4cfDkV2X5VzQR/NYYshw=; b=JGzVEOxJKdeB2zmYWQdK8Cq3spsubqADhYopGzLcqUAowYxPQm6wK/Yp7BjYxoXKr0 BU/Tm91vjOshfGdd8zXU5ON2Y7clp0L8t5NMR9MVG2eikS71bkRNUrqs4ZDd+V2vEJ/Q ZdJC/UT7GNI4KkWUBpxROD16mU0/NsDiyNADLq6ZVXApBtnCZpDMq5gtiMvnppxUQa29 5nzYbnAopDppDytHBZtKiRZ0s7rS63GeP76TFjTOPqpuACTAbO65uMfGggLL7XrUcUrQ vF4jRSRBkzbbyNkcVbO93X6Ce6pbTKiKdFypDfIBt8Tq6Se5y2u6SoIcHClkwegsVy7z HMcQ== X-Gm-Message-State: AOJu0Yzhbjsl/8sVqzkMyMh7NjGLoCX4oQyUbUC6GyVZKkCiGKiAEYjO EobL0EuC0J9nUb/hkXbzd830G3vOSBET49EsFnkYgBaLv6tlKuvC X-Google-Smtp-Source: AGHT+IHBfuTpMKunVkbNFq+t0Jlc+3UenKYMKydVkNh0nKnDorXd0XPWQrbcuKoVCBcbIveTCL2fNA== X-Received: by 2002:a05:6512:32a9:b0:511:4f00:45b2 with SMTP id q9-20020a05651232a900b005114f0045b2mr177437lfe.25.1707153644019; Mon, 05 Feb 2024 09:20:44 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCUCTBkSmuKMbc/++9kbkskzZcICPaSQR3u3/T/Z8Z4ztlu33Rrd7Z1XYXEj4Zw7DBkp5kOt0yiWQCtENFkEVBFpu8clhvYD2ZFB3MFO02232yoQ+x0PRRygI1J+pK72nv1K6vwn17rJSbVVakq2KEmN9fYjrX/kIp2OsSsJEeXVsJeCd1BmHQP4jV824KTi8BwwO3nEwhVBYGfVgKVab5LpIWcdPs7JznvV2mcxXYnynPbRI+QnoWK+DhTJy+8VCB9TLFziR+C3PYwVNLoAmIQ48L8Zh2kMryIfhaulo0Ig2NjepA4hNA== Received: from pc636 (host-90-233-221-0.mobileonline.telia.com. [90.233.221.0]) by smtp.gmail.com with ESMTPSA id b10-20020ac2410a000000b0051157349af3sm13348lfi.47.2024.02.05.09.20.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 09:20:43 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Mon, 5 Feb 2024 18:20:41 +0100 To: Lorenzo Stoakes Cc: "Uladzislau Rezki (Sony)" , linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He , Christoph Hellwig , Matthew Wilcox , Dave Chinner , Oleksiy Avramchenko Subject: Re: [PATCH 1/1] mm: vmalloc: Add a scan area of VA only once Message-ID: References: <20240202190628.47806-1-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: BE8C3140035 X-Rspam-User: X-Stat-Signature: nt4pfutcywdcia5dikecacj85mcqqc94 X-Rspamd-Server: rspam03 X-HE-Tag: 1707153645-67657 X-HE-Meta: U2FsdGVkX1+Qccvb3d3Eabd9lAdV/2OJ0o1oFsSZR0pdscx8zWQsn85up8UgveN3gejGlKv7kDdZSqCFqQEJSPt+3cwCixnJkPsbTmt1M8hEiA/Goyx2IpS0DFjCX3wwOBcUvvR/bVPpG2OmfAxczNa6/dEJsN7yBb0dAD0e0/5i0/OO8KmGk7+wPH3LQOeb+3dKDBO36rq3dNP1gRLd3Je8m4r57N80xY92+PngJyI1gKEbVS0p/j2xKAQ2BISR/piUDfhzTKYeAmIGZ7MLDSGXMlPWj1DxM3hxut6NXENcJNhB8NkmcOX5sru5YMF/4qS4b7UTfBZnObAkwY2Bpbt00Oh96OaPNjmVxRJq7VkxpIMJmDP9V8oS5bYUYddj5ztCDYbHcxOm+C8AN9Q/uL/6XA6RzBahFApQ9ITLJA1RzcRIDjlLJx0KTQykL7321a8WDMVTcyv0bOIudaqaFqyqQ7CFPn9JVgMRe/llBNbGS1D6q2BK1yj+jN7Fb/rAA97qb9Xvipov1TuBwEZd6syuu9QL1C1NlgqF1fYiCquQq6nOthUvexuJjr3Bh4jFJYfIxOlCeddbcWnFpeQE0PbyruqiOOmRZijewfdHV3Iga583y/HHxauj8WUj6EGJhbHBcCiopI+rU8L8n0PQGNSfbfFm0DzyQDasOTuSWwrJHzy0OqMqdGWN7APsetGrPBNnpVI9TVXprF2vXaqpNfwL8I9Nh2/azE4NlsPvbp1+7+KjSlrCVRVsVZVtw4XC/VFknyvRdadAEnTvuWP7wGV8k3B8RAZbGOGtK5MLnqtfcAndxHVE4wXIZvTbiEpTaqIkQd807+mconqnvoFMr889QfXP9edNTFbNmBJcUickn1DqP+jl1NMxywYTLjkVxX6w51eUxcna/1IPluaK2/Nj0ieJMzPRksdD2anezJDRLiEdN+oQrYa+AIkVAzzcspNTDY8gFfP6x8+PlpP AbCeGF87 CT+ii3osCD61JYqfQ7PHquudpWg5MZ9dsFqlaSsTPdozVMXQzQnizjy6M9VEXQMLZrspxvpX3gNH0qF7WD7JDdbXyF8y8kSyRbsysK1DtIurXzUCMeqs5HD95wKKysYNRolc323hfOE7aPUfpSYET6QuGsBGc7lXhoMt+Uq2FVr1lV1aCeWDaVYO3tk09Ry/wyreANhf+mO73nlv2EeSCVH0EAxqw2/eJX7P2n0l6UqMyJhE3LcOHPSRFUOEUoi0LywICyLMfrPy2z/DgF6FydlhN6PQeQBk4+YPMbknvJJcTuMXnOZhX/90IRG26j8Wk1QByCk2i5F4tYnu79WUnRQtVK0KruKjZ51uSdrK+JtwLnUBwHBVE3ZmeGqD5vanzcLst4v2spaJaQvmev2a+f1vW11y+IMk0jZ+JyM5niyJI3oXAEAo03+7cthSZzE8c6ljQnr0yyOGwTs0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Feb 04, 2024 at 07:44:55PM +0000, Lorenzo Stoakes wrote: > On Fri, Feb 02, 2024 at 08:06:28PM +0100, Uladzislau Rezki (Sony) wrote: > > Invoke a kmemleak_scan_area() function only for newly allocated > > objects to add a scan area within that object. There is no reason > > to add a same scan area(pointer to beginning or inside the object) > > several times. If a VA is obtained from the cache its scan area > > has already been associated. > > > > Fixes: 7db166b4aa0d ("mm: vmalloc: offload free_vmap_area_lock lock") > > Signed-off-by: Uladzislau Rezki (Sony) > > --- > > mm/vmalloc.c | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > index 449f45b0e474..25a8df497255 100644 > > --- a/mm/vmalloc.c > > +++ b/mm/vmalloc.c > > @@ -1882,13 +1882,13 @@ static struct vmap_area *alloc_vmap_area(unsigned long size, > > va = kmem_cache_alloc_node(vmap_area_cachep, gfp_mask, node); > > if (unlikely(!va)) > > return ERR_PTR(-ENOMEM); > > - } > > > > - /* > > - * Only scan the relevant parts containing pointers to other objects > > - * to avoid false negatives. > > - */ > > - kmemleak_scan_area(&va->rb_node, SIZE_MAX, gfp_mask); > > + /* > > + * Only scan the relevant parts containing pointers to other objects > > + * to avoid false negatives. > > + */ > > + kmemleak_scan_area(&va->rb_node, SIZE_MAX, gfp_mask); > > + } > > > > retry: > > if (addr == vend) { > > -- > > 2.39.2 > > > > Looks good to me, feel free to add: > > Reviewed-by: Lorenzo Stoakes > Appreciate for review! -- Uladzislau Rezki