From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 804D4C48295 for ; Mon, 5 Feb 2024 14:23:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 10CC26B007D; Mon, 5 Feb 2024 09:23:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0BBD16B007E; Mon, 5 Feb 2024 09:23:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9E816B0080; Mon, 5 Feb 2024 09:23:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D53A36B007D for ; Mon, 5 Feb 2024 09:23:21 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A96FDA1F1A for ; Mon, 5 Feb 2024 14:23:21 +0000 (UTC) X-FDA: 81757967802.17.6E0FEE9 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf07.hostedemail.com (Postfix) with ESMTP id 5E26540017 for ; Mon, 5 Feb 2024 14:23:19 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=u7cNB4RY; dkim=pass header.d=suse.com header.s=susede1 header.b=u7cNB4RY; spf=pass (imf07.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707142999; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XalqDAiHZdL3jRZo3gAv/IjBfwZgDQ2tWTGMS7xw7ls=; b=YzqQkEoXBEjrs0ireerwual4PO7qa5jrrbjNJ0L8NjVv6n6lqrHlQEBw+askJH6XklsZSK MHib0y0IsiCQ15GenOlAocafzEOeX5lqiPPobDuu6+k5i9DzB/qvdIx/3UM97kt31earNz 9hIKt20o/23mz1AYwqPrZ3Qjglc9c4s= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707142999; a=rsa-sha256; cv=none; b=0N7dSaHthDj0HYj9vBy9M09myzRRPlpqutKyet5nbXvfN3EWddvC6r7xWBQdczCdDyS389 Wk5HRdIkAQFhIHSpWSouI/eQZkqfM10JNN2ZLTlLkHO4eYpezrMgRiPhzRGBX3lBhyuqPM jHyv3gefbjPsUN9u3ZCNq8KWyMUev7o= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=u7cNB4RY; dkim=pass header.d=suse.com header.s=susede1 header.b=u7cNB4RY; spf=pass (imf07.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9C00122290; Mon, 5 Feb 2024 14:23:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1707142997; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XalqDAiHZdL3jRZo3gAv/IjBfwZgDQ2tWTGMS7xw7ls=; b=u7cNB4RYq2h6IZdXCao8Ifa0Uypsx37FSVptVegd4d2+hqtvGecMv9IECKcdcMwUYuqnhL ILO305eTznMRcDxf4yuBle5Zt2g/tyJmqCYcPjI7xFabdooso6v5iNATEi6Q+Ejj8XzqQl 1xNZ6N7MTM5SJNpZDKt2YenSxsT5DNQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1707142997; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XalqDAiHZdL3jRZo3gAv/IjBfwZgDQ2tWTGMS7xw7ls=; b=u7cNB4RYq2h6IZdXCao8Ifa0Uypsx37FSVptVegd4d2+hqtvGecMv9IECKcdcMwUYuqnhL ILO305eTznMRcDxf4yuBle5Zt2g/tyJmqCYcPjI7xFabdooso6v5iNATEi6Q+Ejj8XzqQl 1xNZ6N7MTM5SJNpZDKt2YenSxsT5DNQ= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 81D95136F5; Mon, 5 Feb 2024 14:23:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id kqW6HFXvwGVbbQAAD6G6ig (envelope-from ); Mon, 05 Feb 2024 14:23:17 +0000 Date: Mon, 5 Feb 2024 15:23:16 +0100 From: Michal Hocko To: Baolin Wang Cc: akpm@linux-foundation.org, muchun.song@linux.dev, osalvador@suse.de, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] mm: hugetlb: remove __GFP_THISNODE flag when dissolving the old hugetlb Message-ID: References: <6f26ce22d2fcd523418a085f2c588fe0776d46e7.1706794035.git.baolin.wang@linux.alibaba.com> <3f31cd89-f349-4f9e-bc29-35f29f489633@linux.alibaba.com> <909cee7d-0201-4429-b85d-7d2662516e45@linux.alibaba.com> <2613b670-84f8-4f97-ab4e-0d480fc1a3f8@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2613b670-84f8-4f97-ab4e-0d480fc1a3f8@linux.alibaba.com> X-Rspamd-Queue-Id: 5E26540017 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 7yx514ye7fx77b4cqmo5i6hsiduib4na X-HE-Tag: 1707142999-901135 X-HE-Meta: U2FsdGVkX191QlZ5dZy6tIlKK7VkDmWqR1oib59xzb2igmYNl3evuS8O9K9EnFOOx+sTFj3O4Q9Z3tJP6Y66DMN86ZTW4gScNzE4UqoInNW4s+2mYaLFbnF8e0yeya0IsXX7L2HV2o6jNuidliJG5POh+xdWxzgA0JZez5FvkKrtX1KiMHqyl3/jkJx9TPFsxRnkwSyZrA0FXcWlyV2tP1fzSsBKfyex+jSC5IiEaARW61zUNwrrHop6PxAylajJUoMKwfKITeYvNxlJC9Kmk399+BXV6yqK5Si5kaQS69+B6Llw7f5bbigvyw0lA71jtPKJ9jnyjyq7sJPi1KTSH+r1/HbOxqmnXwygqA47ux1u/Xoob5YG0iwGgzsY6vxI/O8vfQqwezvTkvZ06KIp+vH3+LT7WtdNoMPYn+DBEifpC1ukfjgR4OqEpoPLxSJ2AW+/SHqP/1Ca0r7zhomEqgr8J1Gr+MhW6xDDGiaHiY747fEw6vVPNn5QnQ0+K24Bfw0msX8i6U/mBfI/U/tRikQyA0oqugOcOc559qIexdkWkZ2pkocrxEA2XHkIFK77qKMfQlel9sDTw4BxgPjDZe+Az3RLAb1RG8pXxeJ4fsqrWKLFTTEedStm9ZDkO9aOXCxKT4EV7WSl20RAWD2b9nvJtGV2DNg7a+gCyU+qUtDmInnVO8GiFcB+aTjy6JFIfvnXtuBcK5teIb+1umpDL69aNVhsShC9STXJjUKyAYFN4f5STqLNrEXlWp+jl0h1CUQch5I8RV7nqTFARZ10OrRaVePV1gaOXTtdiZyIjrBugRVd9GuWR4inLeipKK/59vpcKzOxuyyQ19hKUjfF3OLw/qVB581HzAWhzDYSDCIb+3D3C1GfeeM5qpJdDl7Xmqtyc+W3mXyOAFyqzd+QBo79U1Do3PBNQeGtFnLqXvfMIEqbiArcRo8Q1ozGQ129rrzRhPtCkpTNw9l8eDi wLZTWi5z +ct3KeJ4MSq95DE1Q7w1ZH+SpBWMpd/aDuwqifh7R0FxQuiQK6i03QQDgcjBglvp/doGDDD420M57hKqMwUyV8+U4OM2aWdsNC3xK4C+VWqcBKYvmSvDPXxUIH1o0+HFr+i0WdWGjeR1EnAULu08jFmiEEHFfauKhadLw1+qIRJJapjgtCQ+YsXEAWGXMhmN3gNUTufarGz6igNexnvMkyMoeB+6uwSYlNubsxLEywywaDav1GQAAQxtUJoowJLrOpArpRxrL3HaPR8Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon 05-02-24 21:06:17, Baolin Wang wrote: [...] > > It is quite possible that traditional users (like large DBs) do not use > > CMA heavily so such a problem was not observed so far. That doesn't mean > > those problems do not really matter. > > CMA is just one case, as I mentioned before, other situations can also break > the per-node hugetlb pool now. Is there any other case than memory hotplug which is arguably different as it is a disruptive operation already. > Let's focus on the main point, why we should still keep inconsistency > behavior to handle free and in-use hugetlb for alloc_contig_range()? That's > really confused. yes, this should behave consistently. And the least surprising way to handle that from the user configuration POV is to not move outside of the original NUMA node. -- Michal Hocko SUSE Labs