From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 090B2C48BEB for ; Fri, 16 Feb 2024 12:34:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 921E16B00A7; Fri, 16 Feb 2024 07:34:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D1F76B00A9; Fri, 16 Feb 2024 07:34:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C2106B00AA; Fri, 16 Feb 2024 07:34:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6E4946B00A7 for ; Fri, 16 Feb 2024 07:34:38 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 94A09160345 for ; Fri, 16 Feb 2024 12:34:37 +0000 (UTC) X-FDA: 81797610594.10.F707CD2 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf06.hostedemail.com (Postfix) with ESMTP id 982C6180018 for ; Fri, 16 Feb 2024 12:34:35 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf06.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708086876; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jcK6Iv3QWlziWC6wCXOhAjbzsWkcCw53R9vniONp1iA=; b=ROKcYMsfflF8kY4nj/5wLhrx+fPL2mslLmFbaQwlFJsxf0MBh03rtRNEXssPw57cvr0j+L ve8D6qYgCYhPByHdeDvu09mEuDvsAu/gIoYy6b/IDC5gqgr+A83uMxQvKBsVVs3LC9p6wC EU443m1bI2Itn/2BrQjHsDg2q3HS9gA= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf06.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708086876; a=rsa-sha256; cv=none; b=BuiuxLvC+/K07vdCyflSXO92H8GFvkQvbBzY/hWvCrUzwBWMqtMtt0Bivto4+ziUdDJDo/ 7OAUThG7bk0eKEhL6nQKATofnwwje9q2VOWqKO5FUswnev/WrQnx3r0rexGVs314Ih3DV6 8rFojc8r7PQEEK2ABq+IcVXwujjBlHI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id D755ECE2920; Fri, 16 Feb 2024 12:34:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9663DC433C7; Fri, 16 Feb 2024 12:34:25 +0000 (UTC) Date: Fri, 16 Feb 2024 12:34:23 +0000 From: Catalin Marinas To: Ryan Roberts Cc: Will Deacon , Ard Biesheuvel , Marc Zyngier , James Morse , Andrey Ryabinin , Andrew Morton , Matthew Wilcox , Mark Rutland , David Hildenbrand , Kefeng Wang , John Hubbard , Zi Yan , Barry Song <21cnbao@gmail.com>, Alistair Popple , Yang Shi , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , linux-arm-kernel@lists.infradead.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 17/18] arm64/mm: __always_inline to improve fork() perf Message-ID: References: <20240215103205.2607016-1-ryan.roberts@arm.com> <20240215103205.2607016-18-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240215103205.2607016-18-ryan.roberts@arm.com> X-Rspamd-Queue-Id: 982C6180018 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: q5pykw3go4jfyd8xe7c6akkb4jaq3bwa X-HE-Tag: 1708086875-965883 X-HE-Meta: U2FsdGVkX18+FL6Ot5LBVJYhX7SmBrCu+9VXznMzItkxIf1vPu7908/KqfqNmiIyzDVDkYbFZdE5ZUdjbhq2HYK80i6grBsKKigK3Igayn+YHqs4Wx5c48W6H7oPNwK1BUgsCdOzFK0ex0Tbetj1yJA5PFw/uvd0VpqWGD2LR7eZuDFPdz/bA7g2WInHbk0MqOWg7ISLpqS+To94ODH8hNVs+EP5uj/DVq3DnhS94Ntsmz0fzfnr+TONY7ySuGh1ApVfxsDShhlVE9fHahhfGCXPOVnrkzkCaKyB2JbceUUS//zTRlBLtBWiR0utFnYue6M0OKT8Rx7LIPIrAiYI1Guogcn+RUNXblpbbBy3509cq6dsLCBe0C748Oil6eHQEhzSxdyYTU0h07C3FYHyr20HiOwhE24jHKbNK4w8fCo14UkQJWgC055q87wzzQ+llWBwLda2V7yGmxWXlKkQZGUGxVVFM8hG3GpGJ9mrMphuMsLUOY80FpypEGr9W3dM6O9Lpwgw8vRXDHWqvT3HiJa0GIinWDP/j+u1qHosvX+6T8lnQ24neAmfx+2RehZcLzDsptwsF9i34B8kHVcqxbjrgbmOrlNAD4Pdb2gl3uo4PDIvqJlj6gmrn9pCpyk4hRFU7ld+oYHO3wPEDKOkmWrzb2aaCwz+d7KCrmvd/zVmll2K2Kij/CrYm78D033zeWuOY81i631u0846xSFTeEDAdtUrC/CgZJ78Rg0uUsPEgdkT5nUDaQ3arTQBCIOi+zHcUzS+oxZe6iBEKiwOHhhI6YQ/EwtP2cfv6jNQpg+FtrgOPQzQ7ZQQpc5qT8LJjYc9+sEu7STuEs3pCNH17NQKGZksWJk2dnjEMf8R1tQW8em8SiUbcT7dtaRe/bDa6rIxm/EQI+5jSN/r+R4bXQVDGZYrMwMASc4qeqE3CZ3lmUjMkW78aAN+0r/A9Cpy5IoBk2b3FuYcsLFtKxo G5EWX/1c BSpzVJ2FYOuNLshHR3n8dOPPvIr6DzIQyyZm6RliB+HV8Eac6P7XXocFCwxBEpzAmkMYFwn16leT7HLIiiIkwqifkb53qXG+V06Oh0oGh0/0bB4ZCWGOXViY14HKKiNgnYsscybwVdVUjTlbdrDbU3HAFGyCPEOUIzu5mYWZMzJv733oi4fnnKx2tUNGuZrdy5JGoajG1CAPZmyJeF/MstxJDrXiiNwbDOpnJjtezTO8tLQvVPI5C6t6c8hMbM6GERcmEuVHj/HR40SuiQHVBVPVMsF75tcruloPH1/fxek3Cpo9GkvpU+yIdS2DX07mj2OF60axZ4kuCz5q+jvC4183V9a/FIHgj+PgyrkWjxeLFK8JoT+Hubl1Ocx0KhnVZhu62sGfOAuwsze5uucsJUArPj9HQEJwATuQkypLmfR+NcN+iV+AAyk5fJCChEMKyu1OOnN2W0kv1zmm6mqLy5tA3ZvQ/EIp+Iu/irweuDCBKkYA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 15, 2024 at 10:32:04AM +0000, Ryan Roberts wrote: > As set_ptes() and wrprotect_ptes() become a bit more complex, the > compiler may choose not to inline them. But this is critical for fork() > performance. So mark the functions, along with contpte_try_unfold() > which is called by them, as __always_inline. This is worth ~1% on the > fork() microbenchmark with order-0 folios (the common case). > > Acked-by: Mark Rutland > Signed-off-by: Ryan Roberts Acked-by: Catalin Marinas