From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0399C48260 for ; Fri, 16 Feb 2024 08:30:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C6F236B0093; Fri, 16 Feb 2024 03:30:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C20FF6B0096; Fri, 16 Feb 2024 03:30:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ABEC36B0098; Fri, 16 Feb 2024 03:30:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9572A6B0093 for ; Fri, 16 Feb 2024 03:30:15 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5275BA02FB for ; Fri, 16 Feb 2024 08:30:15 +0000 (UTC) X-FDA: 81796994790.25.4BA322B Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) by imf25.hostedemail.com (Postfix) with ESMTP id 8A2D6A000D for ; Fri, 16 Feb 2024 08:30:13 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=s7dqdpTl; spf=pass (imf25.hostedemail.com: domain of 3FB3PZQoKCL83txw3fmrjilttlqj.htrqnsz2-rrp0fhp.twl@flex--yosryahmed.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3FB3PZQoKCL83txw3fmrjilttlqj.htrqnsz2-rrp0fhp.twl@flex--yosryahmed.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708072213; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E+T406awSm0PZWvamxb/O4glPc/yswynyie5XG4DmHE=; b=6t2Vjc0Yn2sBs4AlXwUvCnHDxHgYj1E6+CYXDD0Aez9cFf6OK9E5catu/oAS370knTZV+q JJRu/Anr3DwRFEjuaq9B3IxeywqPqtrHS5GW/aLeQNZRZ6P7mohx0xpAK58CfDiSQjBo2X lEM/KmuhtdrxOMBi7jmiXwLnKK38Flk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708072213; a=rsa-sha256; cv=none; b=WZsmPrczmuSsROESRCphm/3eDe6L52P/gmqjmOcK0dNEdyYDNOOi7zsnO4ar+pQqbw6nPC n0ishyKEHy76tqJ0oE0J1vy6SIdRD6N8lxOIY7v+HOtdGQO5EHJw6/dp3v0TcP9eB5vhD4 TApMzLh45WpY1jEeH+2sUzdnPKQ1cUs= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=s7dqdpTl; spf=pass (imf25.hostedemail.com: domain of 3FB3PZQoKCL83txw3fmrjilttlqj.htrqnsz2-rrp0fhp.twl@flex--yosryahmed.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3FB3PZQoKCL83txw3fmrjilttlqj.htrqnsz2-rrp0fhp.twl@flex--yosryahmed.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-dc746178515so3028263276.2 for ; Fri, 16 Feb 2024 00:30:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708072212; x=1708677012; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=E+T406awSm0PZWvamxb/O4glPc/yswynyie5XG4DmHE=; b=s7dqdpTlqmY1E1zwJ6IkPzqJGM5OsNeA715bSoO2oWacDyJjfC2BSWCqj3H0/fMePm OrYhZK70QNPWWbIaloO+/YtgXSDMtrSHzjrGpZWVjFa47kobwasTqxvStD1Ntb9QkO3v 5mjiMAA+C5cYyeKBpHrviKmanLFYfOA2g3Mi3YnhaOiQ6nzet1iwnZ/dXaMGp3DSusgk 8+xMj6HE+NReSSRm5aeuAFXCoY3LusE2g02ljldgmBlE8VMZX26Y0jJf3pQcDKxNMs+t /N9bwgA5wTb1tutprvRs5kAuGMvM1TD1r3DdT/bEagM1YCKaVrg8/Hvm8XuaeDcuvryO bwtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708072212; x=1708677012; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=E+T406awSm0PZWvamxb/O4glPc/yswynyie5XG4DmHE=; b=eo14QmnVWNEJzdoACqpi3wcx1OtdCJ9JKJ+lOcTen94CcaUtvT+DLGbYNm8ffsgDfe ttjumxALjeSI1TP1CJofi90NEHgSo3Mw2VexH+o3whQBlzgf6VwMezUxDUvi8k13ghNz oTSy7B0QsFrQ+YoqfU+wm/J2lLX+EQr/KpOlHl7zCH4LJHeKTe6jPbzqMp9aL7uw2wlz 4IKLsD/nkT9Ce9859fKDqEujRsM9ZyiUUzJz8H5dRY2tfL1zHdvy43ibtvm6S+BsxzYE 4b3d9E7JaaoGgYa9WHxzsZNJkE/FMJJ2QjmiUp4doMr2sOIgUM4bre46ulAzZl5zQnf0 DH6g== X-Forwarded-Encrypted: i=1; AJvYcCVRvUDZyq2r8KO/3mjY3SuWkA6iXSkjzt192+FEp4T0vf88kzmHivMul39NCG+aZBKzRyTHMXsYzeeNr/bjpZ552Qc= X-Gm-Message-State: AOJu0YyRvj10ivvVxuQ4XYRcpq03bDHVMGBzBSd7+G0jh5xI3eaNE15v bJHhrmguz6tltKpTcQNBis2HRhuuIgk120nFQWdgrMykc0kCifTzk/0Lo1Je9sEwDI3orE9qhat dOs78OHOW2GBNil4NSQ== X-Google-Smtp-Source: AGHT+IF3trf13BJQXu17kJIafk/jn8S7KsSWkMDfarAi4KXYdoqAcTw5cjuzS+fWLBF6eBz3av4bvJ/YSiMvk+Xj X-Received: from yosry.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:29b4]) (user=yosryahmed job=sendgmr) by 2002:a05:6902:728:b0:dcd:ac69:eb1a with SMTP id l8-20020a056902072800b00dcdac69eb1amr950084ybt.12.1708072212743; Fri, 16 Feb 2024 00:30:12 -0800 (PST) Date: Fri, 16 Feb 2024 08:30:10 +0000 In-Reply-To: <20240216040815.114202-3-21cnbao@gmail.com> Mime-Version: 1.0 References: <20240216040815.114202-1-21cnbao@gmail.com> <20240216040815.114202-3-21cnbao@gmail.com> Message-ID: Subject: Re: [PATCH v2 2/3] mm/zswap: remove the memcpy if acomp is not sleepable From: Yosry Ahmed To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, davem@davemloft.net, hannes@cmpxchg.org, herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org, linux-mm@kvack.org, nphamcs@gmail.com, zhouchengming@bytedance.com, chriscli@google.com, chrisl@kernel.org, ddstreet@ieee.org, linux-kernel@vger.kernel.org, sjenning@redhat.com, vitaly.wool@konsulko.com, Barry Song Content-Type: text/plain; charset="us-ascii" X-Rspamd-Queue-Id: 8A2D6A000D X-Rspam-User: X-Stat-Signature: ioou7sb16yoqiyymwui6i9ycybzuwxb9 X-Rspamd-Server: rspam03 X-HE-Tag: 1708072213-236359 X-HE-Meta: U2FsdGVkX19J4kdcmqLghb8CtKEgclcSOxI/uh3hvf/E0j6vCBeymwk5Wj3PJws0xA7fDSUzWU0JGfV8C1nOsL4EX2N7BmlQtpRPd6y8gnwudhe1FxskrPesBxl9rK4r/heQ8P/8tsMOCtDXZHy1ZWK0PhvjC5Y3MJCUynWp36ELLn+O5IaEF1rMjnKI48wSn3qVncdauhrxiutBt3sqeULgyIlVTBvb121Yg80oEoOTfQnPSnujgQcjW8HHt8p1qP6PpKYWgoM0/jy859J8t6SKp23pgpi7/mYpbW+VT8NGL4H1RX2US8q5Svd215Qr1R6JmHulZqRAkPvrxbBDYImbZ867+re9XSTL53MuAmt+9obzUnJ5on71PnryiK8n6CS2XtfbEoqd4M3RhyEWVQrXXyJXJ2Eahcfn7ZoR7xraE+EItJf6fu8in/dowxtd1C4oPK6cvSPuLc87V0PHteBmom/6ukrQpzRjWUES2wy//t8oSZF+V5zm7sMmsPtj+SxdKpx7dBo/CTPbeqb6/HHPMmaBsOLIEw9M/M2FtDMb7FlY9sK2e2bMq/lKtCXOTNaHdN2qkq7HpSa12+MKngkkQMLKFvF2Nb0hKidmiS9GEJ2F72itqbSs7hTHkQnBj/dbCCTjyYwMFqNhob8LD1Mz92AaJDHwXqETQ1ZViU9oweVWtvXhhv+60zj+R59pvLh0iFwxAyXGm24ECm80h3iXqUdvCQz95j9QEZYaFO+lu2XRyUE5RPozPmBYHEDsdoAyWtFYApp1Ojy6VQ4kLBSWnqOAhvrm5cdo/86kArucRKqY1c87TATmM74xShrRpSikDBJbPzyyPRe+obgv84LO9UhzGIGuNhNadjp/dxdw0BJt0McJQswYbAEiDoSVIYO6YJdGSl4ggJat5c1IfvkVdCmE89CUi7msilokEyLo3iO7lI/gQ6gr0WOWC9HcXRcct7cWDdJUe1KdTrz 17r14Kxv RoNmhX0kFKJjkoChB9Lv8XwKDcWelDatQIqqEFM2GHts2+qeG8p0colkzq5nbIHUeoZ0B5+n8SGv7tKw2GEG4K0XnhSjhahF79VKaqH5f6nZAlG65o6xCxgzCpW+twowp9yuuSyZOPQ63I6HFRA2LHYv6oQh5Vb1Pe3GThohsk/91JvW1CC7AqF2OYrg1TO3nXOpUHQ7s3YCZaWHAvhKJ+FvRP59csgiu6WIPE2ROMxK/JoXNHql35pz34wCnfw+gKHZ8KkKuwp9sikSW5PKWq0mDMrGibQzBfTgd6yY4yqMBwa+uo+XK18HGX9NlQsIu21crkif4hIm2yfDJlO71glJlqPYoMh0cvu4LKQFLYNcadbpWa8k7Bal8uVSoirfNfefxHjyub0qB34iKP61lSjnENYsRrJWgo6xOTRuwDJ0zT9zqj6qkV/Rdxp5OXIaCPyOFvMASRpTj36hR5xmWwBSPlirS9/pOHzWV3zs04Dv17qANGCjZOfDeW23+k9j5chZx/yGnZHMnGUVFm0L1PG8eblq0OMEyDxYj6yNeXoUp2Z/haFCbTTBHJ7gY5MEWJ7dXo9I9NsrQND6T0wROqjUelcIJTfe1Ojqy8WWDHLUJH9QT1olkhmzzhHBYCXO81YVl7usIr1nhPFqAzNS4EOS6pPAzQ1NB74N77a9xJEyrqMbmFeai2Rx301jAcbyGSZr8jZv655hYjH7akdOVfya2aeHNxjKj1nUOJKdAzt87phrwI/JVR6qe62xtARoT91CFSlt7pJr12IhrHEJaHKmQQw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 16, 2024 at 05:08:14PM +1300, Barry Song wrote: > From: Barry Song > > Most compressors are actually CPU-based and won't sleep during > compression and decompression. We should remove the redundant > memcpy for them. > > Signed-off-by: Barry Song > Tested-by: Chengming Zhou > Reviewed-by: Nhat Pham > --- > mm/zswap.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index 350dd2fc8159..6319d2281020 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -168,6 +168,7 @@ struct crypto_acomp_ctx { > struct crypto_wait wait; > u8 *buffer; > struct mutex mutex; > + bool is_sleepable; > }; > > /* > @@ -716,6 +717,7 @@ static int zswap_cpu_comp_prepare(unsigned int cpu, struct hlist_node *node) > goto acomp_fail; > } > acomp_ctx->acomp = acomp; > + acomp_ctx->is_sleepable = acomp_is_sleepable(acomp); Just one question here. In patch 1, sleepable seems to mean "not async". IIUC, even a synchronous algorithm may sleep (e.g. if there is a cond_resched or waiting for a mutex). Does sleepable in acomp terms the same as "atomic" in scheduling/preemption terms? Also, was this tested with debug options to catch any possible sleeps in atomic context? If the answer to both questions is yes, the change otherwise LGTM. Feel free to add: Acked-by: Yosry Ahmed Thanks! > > req = acomp_request_alloc(acomp_ctx->acomp); > if (!req) { > @@ -1368,7 +1370,7 @@ static void __zswap_load(struct zswap_entry *entry, struct page *page) > mutex_lock(&acomp_ctx->mutex); > > src = zpool_map_handle(zpool, entry->handle, ZPOOL_MM_RO); > - if (!zpool_can_sleep_mapped(zpool)) { > + if (acomp_ctx->is_sleepable && !zpool_can_sleep_mapped(zpool)) { > memcpy(acomp_ctx->buffer, src, entry->length); > src = acomp_ctx->buffer; > zpool_unmap_handle(zpool, entry->handle); > @@ -1382,7 +1384,7 @@ static void __zswap_load(struct zswap_entry *entry, struct page *page) > BUG_ON(acomp_ctx->req->dlen != PAGE_SIZE); > mutex_unlock(&acomp_ctx->mutex); > > - if (zpool_can_sleep_mapped(zpool)) > + if (!acomp_ctx->is_sleepable || zpool_can_sleep_mapped(zpool)) > zpool_unmap_handle(zpool, entry->handle); > } > > -- > 2.34.1 >