From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 137AAC48260 for ; Fri, 16 Feb 2024 07:51:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9634E8D0007; Fri, 16 Feb 2024 02:51:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 913548D0001; Fri, 16 Feb 2024 02:51:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B3708D0007; Fri, 16 Feb 2024 02:51:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 688848D0001 for ; Fri, 16 Feb 2024 02:51:25 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3EE73A02C0 for ; Fri, 16 Feb 2024 07:51:25 +0000 (UTC) X-FDA: 81796896930.25.88E7ACA Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf01.hostedemail.com (Postfix) with ESMTP id EF90240011 for ; Fri, 16 Feb 2024 07:51:22 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="t9/LzMl2"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=eExjU4mE; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="t9/LzMl2"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=eExjU4mE; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf01.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708069883; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T3kSRMNvYqoD1Oew8jvkJgmFhy+2180XepdgpQuG9JA=; b=PaaXbspyvHGc7u3M+PWVnLwOG2+oLatdte56dF1el7GTj9kwDmWOSf07b7MX1Lzb3uVloA ycJFXKQss2ErskuB/0q99qXJR1u/sQ8D9qmtaYOZIdV36Z7uV08IZ32BQp4Lvlkaa6fsTb CMftqdS6RYDe/SLpr8X66hnmFbE24bI= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="t9/LzMl2"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=eExjU4mE; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="t9/LzMl2"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=eExjU4mE; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf01.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708069883; a=rsa-sha256; cv=none; b=F0ue9JyLS/uikaGmDsDNn8teaOsPnJxTnFhORDqq6FMmTdRkSJoJof9tgF0GF12D06ezyd AtFwnNraZdyb4uPfsDiDKwIU86PkEAX82Jf4cTGtiwTfwGEvKLPG5+47D6+xbnuQVnrF8m fdP6mSmDIn34OjiiQIJbITFCY6fGKog= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1CE9A21EF8; Fri, 16 Feb 2024 07:51:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708069881; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=T3kSRMNvYqoD1Oew8jvkJgmFhy+2180XepdgpQuG9JA=; b=t9/LzMl2CRtI/GwuTpbOZMw4MT6i2J2aZ5B+3sChAPt+vTv+R3FtsRTLN2EYo09OVMTzze uIBGQ0HX65xwCYkD1JIjYGi8O1Miu2w68ujiuyVjMwIAZo3Kub9PiwuXSgkFguaKEZlAic JV6KyavyjYKa6bBzR5dAuhEHbGY7R64= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708069881; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=T3kSRMNvYqoD1Oew8jvkJgmFhy+2180XepdgpQuG9JA=; b=eExjU4mE/PaJBmGZBUFFnwsmW/luxQEN4/qZ+UkFMcowV1HFpIpx+pUlRTwK6fioN6Z9mU sXTSABZrHG9yewDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708069881; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=T3kSRMNvYqoD1Oew8jvkJgmFhy+2180XepdgpQuG9JA=; b=t9/LzMl2CRtI/GwuTpbOZMw4MT6i2J2aZ5B+3sChAPt+vTv+R3FtsRTLN2EYo09OVMTzze uIBGQ0HX65xwCYkD1JIjYGi8O1Miu2w68ujiuyVjMwIAZo3Kub9PiwuXSgkFguaKEZlAic JV6KyavyjYKa6bBzR5dAuhEHbGY7R64= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708069881; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=T3kSRMNvYqoD1Oew8jvkJgmFhy+2180XepdgpQuG9JA=; b=eExjU4mE/PaJBmGZBUFFnwsmW/luxQEN4/qZ+UkFMcowV1HFpIpx+pUlRTwK6fioN6Z9mU sXTSABZrHG9yewDA== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 46E7B13421; Fri, 16 Feb 2024 07:51:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id pN+RDvgTz2WmaQAAn2gu4w (envelope-from ); Fri, 16 Feb 2024 07:51:20 +0000 Date: Fri, 16 Feb 2024 08:52:30 +0100 From: Oscar Salvador To: Byungchul Park Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, akpm@linux-foundation.org Subject: Re: [PATCH] sched/numa, mm: do not promote folios to nodes not set N_MEMORY Message-ID: References: <20240214035355.18335-1-byungchul@sk.com> <20240216070754.GB32626@system.software.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240216070754.GB32626@system.software.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: EF90240011 X-Stat-Signature: odd83nzh3zn8x1hue3x945w1keh777qf X-HE-Tag: 1708069882-855373 X-HE-Meta: U2FsdGVkX18uByv7r5fnCNLRFzdWTFwyZlQW4WsLY3DHWI4A+VlSwynVFA1n8t7bSrHcCNcSGOhTEWl5ShStWII3ZdDg4Ro9TLxY4K2hdbRdFE8Q0bcXBVMdG3Z1Vwsgs+vzo6EE2MWxBSoC110wjizdITWERUxgCJ5MsEh0+PqnV7WPKKzZNf+cI4+OaZYit4Tfa/ERUFsaiwgEv3MSkQ383sUGDVoN68FmwQFjplYBQfbFCnEg0r+KW/HcF8kA8Mb5Xn90OzEHkEsho6i0Fa7YJdWk/p5RnCSh2hX5xSBZg877g9SYR227twsp/YHF+silvdzSlDUudApPeQrzXMdeIWa2q4WPrKYl0bUS3CxeKyWAGZZeevF6OCObOAiWvMsnVc+dcj7YXu4Vs4askjNb/tctCKJygmUKgWK6nyqTVjMTYMUKjLAsKyF2E97PDvB6GF3REUzNQXWMVaLet8riMGqS+AF07Vrlt9Ex1v//K/mLmMZ/zUQiS1X+aYr9LkQIKpkxbH2t5fbFMI1B5qTL8UYp6zw/9n6jX7A7Zzvd50c5gbchky1MVAqLW0yag9Mfb9nZsDrC8YotHKxni3nssHt1m8d+eanuHXLxmsQneiPsSceWjOdvCRlwU3FJAC6yDTIarFDnYrs2uvNUTxMOPI7MuAyUgkiH/qvwAUV9hXe3bJlUIeIgWGddcEy1UbAhzzK+74UDpccJZ6O3GP48HTza1+s4uObkV02m9A5EiSTlI8Uy67brE4gwjv56LayuoX2ozlTG6NxgBnUDsh9HZO2PGuUSpRXGbuocCBcbT1xzsYB/qIEc/aKCqBoJHa49IZ3mGp5FGanqg0IUJcPdVlzVXBNNUqPlc9EIu6AKmoUCc4sDL1RqvXJQAvKwsNMqsm3l1zwhuklXbot+wK8BD6GEZCG0cx/p3q5jHOS3smxQqW/eJmoJAbXleVD787CZ2O4xTK12Tte/ZYc PzK8Z/5K +JTGbwntTXkWE7RN2krOXNzn+KB4Nfjb5991ykSJJgbtptryUqBAfvrnutMhJYnJZn7/dsOmLIOxFEVGIxgU4LPeYXl7hzGXYQbSOHmCtCY80lmtEcEb4bSmxIN4ZeHX5XJVPvfvwK4bl33+KssaUUQLBqmNRiq/S730n8bhngM1a1D8qBR90mgeV8LNeX1bcrsAIrAL/g18eGvERvESxNjAVVvNb+BvpmPgj57AYI/SFkWRHzcVJLxKjieIITxFU8V1I X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 16, 2024 at 04:07:54PM +0900, Byungchul Park wrote: > For normal numa nodes, node_data[] is initialized at alloc_node_data(), > but it's not for memoryless node. However, the node *gets onlined* at > init_cpu_to_node(). > > Let's look at back free_area_init(). free_area_init_node() will be called > with node_data[] not set yet, because it's already *onlined*. So > ->zone_pgdat cannot be initialized properly in the path you mentioned. I am might be missing something., so bear with me. free_area_init() gets called before init_cpu_to_node() does. free_area_init_node() gets called on every possible node. free_area_init_node then() does pg_data_t *pgdat = NODE_DATA(nid);, and then we call free_area_init_core(). free_area_init_core() does free_area_init_core() does zone_init_internals() which ends up doing zone->zone_pgdat = NODE_DATA(nid); If node_data[] was not set at all, we would already blow up when doing the first for_each_node() pgdat = NODE_DATA(nid); free_area_init_node(nid); back in free_area_init(). -- Oscar Salvador SUSE Labs