From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FA72C4829E for ; Thu, 15 Feb 2024 19:26:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D4A5B8D0006; Thu, 15 Feb 2024 14:26:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CFAE98D0001; Thu, 15 Feb 2024 14:26:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC2068D0006; Thu, 15 Feb 2024 14:26:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id ABFB58D0001 for ; Thu, 15 Feb 2024 14:26:16 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 881451403AB for ; Thu, 15 Feb 2024 19:26:16 +0000 (UTC) X-FDA: 81795019152.10.0CCB029 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf24.hostedemail.com (Postfix) with ESMTP id 944E7180021 for ; Thu, 15 Feb 2024 19:26:11 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=jUrJy3Pf; dmarc=none; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708025173; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P4QD/ybns2/Bgpbe3KYdtzHKfNJTrHM+ftFWOfy2J0w=; b=fUE0dD4Mglu1xVnzPanzAyAS9u5wqBcNhOtYmZfyGnVGGFG2Sj1dMf3RAycoU9pyblNgfU ZTvNmK8x7DC8fqC2TrFPc7tipGIKWVSpKzLdpXbg9RXDsmzJY1QsXNVtxWem/hSmUS2dwU EU+JZKLfhuF4JGUz/9OS6ilYAsjZdEs= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=jUrJy3Pf; dmarc=none; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708025173; a=rsa-sha256; cv=none; b=LcfDs/9NK3EISJ7vT4+sBoFVl8O42LZWLRzHAZ5ZkAwIIMb+vrknyKizoH3bqaIl0tuPPz t5C+vdenE/D6E7uD/uHCxTAd82Jd7wLrunreawswX8JNn6LKZzYGQ1IjqVJd+/jq07r5mu UhkgirEYPaqWrNZ2YisojA8BtSBJXks= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=P4QD/ybns2/Bgpbe3KYdtzHKfNJTrHM+ftFWOfy2J0w=; b=jUrJy3PfE4KJcZTW8kZOD25Zu7 nQCYSvKD6rDLOqK3K8s/lEr9mkfz0c0700RMj8KQFIrhROQjqOcfGePF7esPr1gcMqN/n3ptt7jFp m5UNlH+kNMXRv6rXJpIv2YPhU21fWNQ49WpKHzR/1I6GR7gzLnx0lB9xFUJZ4HtaDesKPuFnzGRWq Lt+usireCP1cricIQzDIH+4C1PKBwnGR3+YMrixekZEIZ/2U+yl2PoAiCvDMtsZSb1Su0LjPgh/+9 1mdkmuSKgmyw9jQ2eDe7G1q/1QTnpYCSK2PCF7Ge6z+/Hx5+zo/WXchuU+s3v1fbuPT34h+Soe7sc o0weYslw==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rahN3-00000002ek0-1Ovh; Thu, 15 Feb 2024 19:26:09 +0000 Date: Thu, 15 Feb 2024 19:26:09 +0000 From: Matthew Wilcox To: Max Kellermann Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 06/14] linux/mm.h: move page_size() to mm/page_size.h Message-ID: References: <20240215145602.1371274-1-max.kellermann@ionos.com> <20240215145602.1371274-7-max.kellermann@ionos.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240215145602.1371274-7-max.kellermann@ionos.com> X-Rspamd-Queue-Id: 944E7180021 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: k1tg4xptthwtykrmqghc141dchhesf5b X-HE-Tag: 1708025171-969750 X-HE-Meta: U2FsdGVkX1++cm1iibmvkpdQG/0bbEqwWwiuccmS+R/Vq6yKY+ih8OKFvKB2zGrKn0P0rFr15/SxiaTwrWSkvy3IJw+/1I7Da9MtUyQP8KLUWY1f2Uom7Eyr1AnetxlyZylRzVVt0JBWKtKr0v1ao20bpek5wn5yOKkHUXZC30iHxhib/Rve1b08QnkeEQBBT6GgqO5eO4rHgAhfR4jzmOoS/jFOBkPqnDD+tZgTYHSv/JFCc5k56Xw2sNyM/9RPcYzv2cQUpIw/QGQmkM4rBVueo4W5nL/bYG3ulm77jvz0QyQmoSyu8gVTWwwCDgBtGRgileCd+plToTVcpkg9KJ1e6TcS8Qu1Psk90a8cw5TUgmditkmNK8+V/IMcx0m3Hn9SG6kuR7eizTteAR9vAanY71X/1T9Lt9KhKcpDhWc1urFYriLKosPZLBh31l871ogqV3x3Dlx+cCbfJSVBjwfXUX5BQCWLBxMunbynaWhrZQaxQc11ALId8cy61IIln1UqGNqbnhCQ/C7OzF3kIIZ2S9hZRm3CfDJNINUDAk/9Ei656gpmZBFrHWUDdaEauy/vS5yIOLrmlGzsCTKDwlXwi2UOGLHHrzdbA2LTHmf6y6ByHTssu8FoGGx4gp/mfQr65Qq7/lXH8UiMVwHk60JgeVU0NmzAe+h0j0JgVMKD3X3WwQcpIJoD+VhVhzpfcY4xfDhmiBFWX9CdqJVYYaBX57WoLEOBHWk9HTiY8sW5Lip15ugwMDT3arkN8KrKkyUfUCcA9Zc4w0mjby2Iuoiv/NimeH36/i+qynMCrGigqH5Xa8HMJoxafOULTnV+qXoLgS1ItV4zJ0dPmJOyRGpza3n47DdX7fzL46cPH78Y3wyw4xwlzPgjjm27BjWeUx3le/x4pqQLj3oJhxg1oO5u1GLfWuDOJFD1IPjWckpzsN7LcNIafNfY2NVsODVMStjwQps0eagMZStNzVf tyiYO5Xz c6tCzjEEnOxFgxKDBN778AhGGnIYf5qNdc8YKMMmLdPwAqYKmG/za4DLPoW20/UCr3oG497pE4mLlbXr349OU6INl+9D1egqrYYUgGpOlE+mlqriji6B+8UTdczXCj5pAumPFijPBrPYpuu6rq3VZzm3byoUIiorSHVvar4hzz94K8v5+ORhQhS1BXA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 15, 2024 at 03:55:54PM +0100, Max Kellermann wrote: > Prepare to reduce dependencies in linux/mm.h. We're really close to eliminating page_size(). Just 23 callers left. As such, it would be a mistake to name the header after it. I don't particularly like how you're splitting up mm.h; I think the real problem is all the code that says "Oh, I'm allocating memory, I should include mm.h" instead of including gfp.h or slab.h. But if you must split it like this, at least call it folio_size.h