From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2899C48BC4 for ; Thu, 15 Feb 2024 19:23:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3ADED8D0006; Thu, 15 Feb 2024 14:23:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 35EDD8D0001; Thu, 15 Feb 2024 14:23:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FE8C8D0006; Thu, 15 Feb 2024 14:23:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 09FD98D0001 for ; Thu, 15 Feb 2024 14:23:02 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D2D3B81189 for ; Thu, 15 Feb 2024 19:23:01 +0000 (UTC) X-FDA: 81795010962.13.311E3C8 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf08.hostedemail.com (Postfix) with ESMTP id 45073160005 for ; Thu, 15 Feb 2024 19:23:00 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf08.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708024980; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+g1gM4sigmr50yn9gPId9vBXyalsJLDJ02rVmW4cCko=; b=QwGqvsGT2CSX69oYB91q2npaKiBZ5Zl01Zw6f3azDwQzf/xUlN8in/4aMQ2fM4c/4z2jfJ rC/WhLGSzZgMqj/DRwGrE1WSvNo94DcKvzGqsyyTl9Rw7xOanYmN7S7xCIgU3Gq/deGdOs Kg0MZHLRByf2BmRcPv3u9OFPYt+egDk= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf08.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708024980; a=rsa-sha256; cv=none; b=otcux5C7pUv2Jdx77gq0UlTleWyObnm+0g0cdlE+JyNM2v8x96d8Rd1fSK/jk04T0rp14s 8pupVx6aJafCvOv6vfTWpzJgZx2lWJCBLBhX3uOO94JPDgOFIl1SvUaKk31Qx8XOwgGBYH Wj8nl7HRnzw2ebVI8V+jWa19KnQliMU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 629CD61DF6; Thu, 15 Feb 2024 19:22:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88915C43390; Thu, 15 Feb 2024 19:22:54 +0000 (UTC) Date: Thu, 15 Feb 2024 19:22:52 +0000 From: Catalin Marinas To: Ryan Roberts Cc: Will Deacon , Ard Biesheuvel , Marc Zyngier , James Morse , Andrey Ryabinin , Andrew Morton , Matthew Wilcox , Mark Rutland , David Hildenbrand , Kefeng Wang , John Hubbard , Zi Yan , Barry Song <21cnbao@gmail.com>, Alistair Popple , Yang Shi , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , linux-arm-kernel@lists.infradead.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 11/18] arm64/mm: Split __flush_tlb_range() to elide trailing DSB Message-ID: References: <20240215103205.2607016-1-ryan.roberts@arm.com> <20240215103205.2607016-12-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240215103205.2607016-12-ryan.roberts@arm.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 45073160005 X-Stat-Signature: hgyiomx54us8k5x5ochqumzzqi8mcz1y X-Rspam-User: X-HE-Tag: 1708024980-610733 X-HE-Meta: U2FsdGVkX1+A+oGOyGtBdrcwdW5ImpL2ckEJZvpyJWoxDIqZBMtF0rhtHQlZ+r3KZAFY5Ov+uIrcxPKgRsMWmCTj1gzktge9G2Re4OEkDqwWcj9Y3DDOwwCA+cr+b2d4Sks2P1F8p0nb4Nzc7idC/yk708aYL/kdWa+7euXAUhUBD7zhrqSg38XSMV3NYMdmd7ajzoOJDGLdtI6sxbQxpdC97+Jz0pZL5o8d/g9kth2p3TCgLWsJL/zZXBAfvuzP/ZmIfTV0xxculAkB23cF3oyw+YO5tU+r6iAqnm9AV/Xb8lEggjv4bEYkDtabxN8015QGMhJQ7PVzO+pyBeEsAxD/H/1sZD4XYUXgHSlOxW2GKRJmQZv14/VAc7KIFfZqHeIYM/9SdI6VTpQ5F49kAtXBf9ceclLTQKwVCrTbDvTYmPNtXMrdOomVr9spXdAbUXaso0WgCl+hsVIOWLNtg0gfjt13xWxHDBLuD4Ed6C8/JIsH13F1lG+ZTo6HV8CpJkH4evIgg1HJx+QVDvQznvVPITQ6z32oGu5xMra9Crl8OlpVLWp29n5tT8lDE5AaTXfLgtvglsF2xi1QI3CsVQ2jO+fBr366Y7pCCr6fanhlcxoYhBTiOtK+XrpbFmg+bb+rBQECPWCWvIUZosMMy2cH4HTg2cVNd3YZ9JFp/8YbSPxIaSWeQkS9HaR7j2/8ac4UT7ntARxE/g+QEpVxeqHyYkMY0LShO0B3hXjeQ93QG/CUfW6AqWG1g8ae5ezRrP75IzMGnEdMtZNUTnejipMjSFrdrTRcLYIPFjI1E5OhfsGg2xodzThM165Gdl/QFIvKtD2LG9/i4CvVrYomGLkBHb4kw/jCUYbaVG1VC7ks4OjQg4QtPY7uC0k6OaG/UxbfRQLkGIp4gxNUSa0X2NV7IWAS7nfUVDzMOAcBYL6exMT0DRB9QxF6HzKyYb8xk+5iGujZNVnl2LxQVQT Cu+RonFh L7BVl9JhRsrRwSj7iQ6g1C/ZYJD3DupkzXVNtZ7TOluuVvWIkmeamdE3EYRUDZUJesP4vNWQHGSkFJdMXZQo4jQ5e+w4jZo26jALP6xxCurgMU+9uT695nbySP5TKhui6BZeOYtBCliaUvUCO7+rBvhGm0Vnh6oc6SaoLkTN4GytHO4s5T23D966USGEYUldBSguXZI3JMjb09rBq3aglEHXHRwAZ13UVNbv6WU35K4ohD/OrqU3dKrjTVZqHgZJgygFbSrLJ+uexaY8ZbMAuBmNuviUoZJqxxczcSM69IO3yqMrYFnlV3XSV/7Meuueo7OPPeQOHiu4A+73ojYI/9rLe9J0gucphx4u5kPb5eu1njbCBbDHPP1raGiEyxXWIEGe6HulvqLohGEdXIqmcFUYUmmaBS8Y53ona+vJcFgt/SoFyZvYK/8mi45SQJ0hgjb8Zhw1BIAPO0AhoYEC/rpBQ3mz7OLnmpsR7JwiyDblqrQabb9+BrFTApvkKwlqcnt/n6PdxlSAlH/eonTXu3SSRqeCx30s4++D4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 15, 2024 at 10:31:58AM +0000, Ryan Roberts wrote: > Split __flush_tlb_range() into __flush_tlb_range_nosync() + > __flush_tlb_range(), in the same way as the existing flush_tlb_page() > arrangement. This allows calling __flush_tlb_range_nosync() to elide the > trailing DSB. Forthcoming "contpte" code will take advantage of this > when clearing the young bit from a contiguous range of ptes. > > Ordering between dsb and mmu_notifier_arch_invalidate_secondary_tlbs() > has changed, but now aligns with the ordering of __flush_tlb_page(). It > has been discussed that __flush_tlb_page() may be wrong though. > Regardless, both will be resolved separately if needed. > > Reviewed-by: David Hildenbrand > Tested-by: John Hubbard > Signed-off-by: Ryan Roberts Acked-by: Catalin Marinas