From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB7C0C48BC4 for ; Thu, 15 Feb 2024 18:34:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 343908D001A; Thu, 15 Feb 2024 13:34:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C9FB8D0006; Thu, 15 Feb 2024 13:34:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11B3D8D001A; Thu, 15 Feb 2024 13:34:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 040E18D0006 for ; Thu, 15 Feb 2024 13:34:11 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D45F01A1287 for ; Thu, 15 Feb 2024 18:34:10 +0000 (UTC) X-FDA: 81794887860.30.64D6C36 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id 39D5340011 for ; Thu, 15 Feb 2024 18:34:09 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf01.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708022049; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FzaDe5fBN9Z890F47Lf1hVNiTSujwXbnEnr5H7GLn9g=; b=421iggfuOd7srmuB6Y6lOtxQLD3LGZMja8kwiPnYpPoi7pQFwkvTfP9Lww9V+/IEXKAdd8 JFUk3zWCscpg7fqtozvCTVPYN5Ks60OIfd7t+d7Tzkb+4vVMEgl71l1xG5ZuY+tHbG97lt CNU5SgTgObcWvKU/+09zFAMEEGCN1bk= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf01.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708022049; a=rsa-sha256; cv=none; b=JEyXGDkHU5cEZbXJkOcgKIuTMgZRTdups3nojLGgt6GtL+qdgq+dZbQ+CyfxwBG3RK+yYL c4t85MrCnAWteJBU2QxzJodx63gBA4U6zjSjLqltiztXsnZznfGTkTL/VudM2d8NL4kbl7 UAw1hauNmn8+S2nvGa2MsemCAPJiq9M= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 5567860FC9; Thu, 15 Feb 2024 18:34:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 38715C433C7; Thu, 15 Feb 2024 18:34:03 +0000 (UTC) Date: Thu, 15 Feb 2024 18:34:00 +0000 From: Catalin Marinas To: Ryan Roberts Cc: Will Deacon , Ard Biesheuvel , Marc Zyngier , James Morse , Andrey Ryabinin , Andrew Morton , Matthew Wilcox , Mark Rutland , David Hildenbrand , Kefeng Wang , John Hubbard , Zi Yan , Barry Song <21cnbao@gmail.com>, Alistair Popple , Yang Shi , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , linux-arm-kernel@lists.infradead.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 07/18] arm64/mm: Convert READ_ONCE(*ptep) to ptep_get(ptep) Message-ID: References: <20240215103205.2607016-1-ryan.roberts@arm.com> <20240215103205.2607016-8-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240215103205.2607016-8-ryan.roberts@arm.com> X-Rspamd-Queue-Id: 39D5340011 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 1s8yc6bnbn7wnpamjuswbbhyz7gszzjx X-HE-Tag: 1708022049-818919 X-HE-Meta: U2FsdGVkX19Bh55+vR1qI2+iuTUGWEMzOdZVqtzndZDiqVnzAH6dwdwimxu3fbICanMuncOVaMxn7nHPtzpEq9mZI9Zjp/zKTrMI25dBcBJJbDwukq0c+pgIrwGAeoJPTqW7SGlrVuPFRiZ4fPaw001XV8G4flxceONJsx0MgO5YkPi5ULgyrvewY7bVkYUlQJtKCjsvrhCFfAopEBqptyQSgxaZoP/xwoYH/URsmsqwE2zxeKflABxBzyDrdub9frDLyz2sWV3Texl4MmYkMQzA2JOWWC8C/LEfnFCRn4rZfTnCP7IWVfZ17sHzghvM8z1kaRib9dOo7CIO3NGNb1Nzn1VGN0hVsasKslxOxMbbTCefIU9Msm4XKiaqXhXAoS4z8qplSbMW14HovFDo3yiz4l8zulxoF0FQFHvFoNVJxY0Sscm36LH57Pro9ILkAphs+xlz0ODZ3FNK6d+b5wKsx0hTdeaZtiK8UawMJvW/DArYWb/oWbFhDuWToO9J/0B2pPaDmAobA6MwEpE0aA4X5oaRcyt0ABAzkk8PA8ggxf2uJgJa2UUruuhmLTcH1GVvW58IPheQrgVIeXkl3yh2AnBSS06YcZSgKzB+qGuMyI9ceZS1isaDb5JVu+S8eRNorjxVL6s5YDejc8ZbK6DH43rar8N1nStOhV7yjCBavVpReI7LApSsKsd8visuH0TMs+8lfzE1ClA5n1ebDZr4AYZe6UIcWFKDHqdzujdFSq4Fs7VDZwA2zY8M/ThH9DxJomBZIsjqi6vLvjemu6GzShmSYeb4w7hMHS+sqHtALkfEvxVyhT8iDrO8+r8IPc22Cmn91KQO1UWIWbH6haYLYv7GwPUcLhBFSADQseGjbDeFX+qhckNtLzAJoAOYW/G5uumsdUg4mKigXacrcTR+gH3/ur/3oXmuHiz25zx2Sd6vxeGYJOFkTk7tBL2iiVSzkgA6xBRIyGUS8GK NBnfN0vp o9ypv30N1+mSEBfFW7EjMH/gi5AVwyhT+LbdE92GRGeHycH/uRLiNEqouxXZY80qN4u+yG6kdJxG8YPkOHjZAQkpbsXJT35/B1RM4eqa/QFRSd7SqDa2CuIGFHOYR9Wf0sklqvbbUjziz+Gp2W43CAW7PRITqPkX0RyVskNTTAli8hOBPyRHQwH+yiUyB9mVwCjMUZMvNY1YSHtt7rFyyxMk4TR+34c3iYbCGMlnvSF4mfosb/tXerZ3SwY2Grt2KikD/BIH054WUnA6EkkmNdD51DL7I5ZFj8vwOkj3ht7GujHc/a7D9TW9v8Zm2rsgmPooT66fyDzP67n/XQt/fLLSz9HhSGvIjLU7nr591BJin9hBxBRms3HjArccNiHxsxczvm2BTsOekr8oGrJe2Tfb9pefOSxgKAH7HB8sfIb/uv/y9crZoPchpZRGQp6X+F7meREmTgktQgPrVbbphszEn4guQ0JJlW1dS7aqZ8qzGCM6R/swS9UpOxTMZ0rB65qygS6nuy8wlk4M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 15, 2024 at 10:31:54AM +0000, Ryan Roberts wrote: > There are a number of places in the arch code that read a pte by using > the READ_ONCE() macro. Refactor these call sites to instead use the > ptep_get() helper, which itself is a READ_ONCE(). Generated code should > be the same. > > This will benefit us when we shortly introduce the transparent contpte > support. In this case, ptep_get() will become more complex so we now > have all the code abstracted through it. > > Tested-by: John Hubbard > Signed-off-by: Ryan Roberts Acked-by: Catalin Marinas