From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21EB0C48BC4 for ; Thu, 15 Feb 2024 17:16:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4170C8D0007; Thu, 15 Feb 2024 12:16:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C58E8D0001; Thu, 15 Feb 2024 12:16:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2664F8D0007; Thu, 15 Feb 2024 12:16:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 12B218D0001 for ; Thu, 15 Feb 2024 12:16:26 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7324314031D for ; Thu, 15 Feb 2024 17:16:25 +0000 (UTC) X-FDA: 81794691930.17.8BB0BEB Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf03.hostedemail.com (Postfix) with ESMTP id A32F220019 for ; Thu, 15 Feb 2024 17:16:21 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=J2x03zKk; spf=none (imf03.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708017381; a=rsa-sha256; cv=none; b=Cnp68mmOsdxhfu49AvIpCx4wLjiUyLGKUm5olqO1SyZXZNQMPMQuvx+Xb6KWGvNbqO5X65 UrN4KniVdnHilMRV12HBnb7UVYRCqmL5SvIaoIVlzXz+VSOcQl6G8d9jYFXZbdbt57LHxR eymz3danQQXApgdOISQ9rvRQU5oGLOg= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=J2x03zKk; spf=none (imf03.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708017381; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mjtUPw1XtkanAX7DpRAs9DDb/3wQHhRms0qJ3CAstOs=; b=NaSm0hiOyS3H6wawANtUa4YZ+Fk7XpN1ivJzOJ4Xtq2ytzY1v2+D34pHvMZO0YBIVz2dOn ijxCTojdY+Atnw7XkhI90HvCa7S6zIg/rp5mge25AoKoBKQO0TzWlVA0y0lm0GcQtGhn5s P/ntujWrxffHyXx1jKfTFpQiWIFC6/w= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mjtUPw1XtkanAX7DpRAs9DDb/3wQHhRms0qJ3CAstOs=; b=J2x03zKk8Y+WdwlkSSOo+8lrTP efYt8Aiiw9DGvVxvI3y+UnVYRl4YGh0t0HCkhDsj0sGaRN1YgEnkCTT5GPlOGMM5Btifb8rSwpoqo tzL5CEAHxfdC+Ot7PdSGLya0iNNK68dM1H3nDUzIZSyqET1uVyQjm/NkuviJbeZMhxOuMH5j0Z6xo Yi6ODLJbMvDUqDyUftlDBOWbVbKEPFVzPe6BIU49KLlkuHqOC3hlzF8YZwiH49JZZ6cKHY9q2H8Y2 zRIqlXkIDMDbMQkhwRcx574gUc+VrTG6wHbC7scOevJ2RcFM7gHZlHlB5DAwhq3QCENztXL/zB08U F40o9u6w==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rafLM-0000000H8gW-48qU; Thu, 15 Feb 2024 17:16:16 +0000 Date: Thu, 15 Feb 2024 09:16:16 -0800 From: Luis Chamberlain To: Matthew Wilcox Cc: Hugh Dickins , Jan Kara , Christian Brauner , zlang@redhat.com, Pankaj Raghav , Daniel Gomez , linux-mm@kvack.org, xfs , Linux FS Devel , Amir Goldstein , kdevops@lists.linux.dev Subject: Re: mm/truncate.c:669 VM_BUG_ON_FOLIO() - hit on XFS on different tests Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: A32F220019 X-Stat-Signature: rrfwss8qg76tcjd1iwznfke4y4fp4bpd X-Rspam-User: X-HE-Tag: 1708017381-735179 X-HE-Meta: U2FsdGVkX1/PYR0+Smaiem7Yv7hC9wCapYfNv512JwSxz/uj5ooioN8D8hIZfm/JJOViEKk/RHnzP0h4XHDvIMgs4gp2aJt8OAh+YYQXa/c5H8B40OaP3NKce5bW/8AwfKNSdprJZ2g2aI62f48mmjfaUZPxwLQPjnH34++cROcuUeMu9QmeoEB6dfV/oxsINKsK6xJnhHyoXdN1/yRLmeC2e9U/wte4Y/yNMU33OVvnteCfkdDsqm7NieXaSeVETcJKPrU5zIeRdN5GdOsCObroJq23bJ5rkqnXASKcMgYNQq9vz8+V5EwdKgGj+EIGBm7tTC4sPEfqgKPmZx07vVl6KfJ0WqWSrVglR/XoIgGVcYabWaPrMnQP688zxizWCBZdBVvU6cTI+RIV9hQlR1ESeBCm7NyvI+2WcLlAbB9eYyuI7FGd4pHK6QOjysXlt2ZA1EnNBbTNwnvw3MX5ZPc77MlRxus6Te5hDw+5Ro28P2D8Gsd62SE6SpEDDIx7bnluI663y/E75BCpaJUbouDgSEeDMWVfGnHEjhhlInBlao+Aye5vNnis1Gsur3vUcxrX0skVjevm8opMQ2n6w9tpi2bBL4ANdorJWbKVxZTZkMXV2dtD7+AJgz9SSukbjoujOTClfFfNkAq8khI8jynHlCRHzbg+V15vU81dtQAPNVtu+Gk1SJ48mz6F9ZpnuCY0cbEpWKY9qs7vG/LqkcXNWZa/UpIZsbDIa2fzHwUJSC3s9y40LiJyRTlfsOZOFrfD+VsSdZIyDMIkUq0q50t5P4hmJvkDpXohSBDEP4grhHw7ZgNhjOAEkY485rEadhPUf6mK51wJPdnxOP71e7Uxje6MRum9x5fdrGuTTWV8JcZ9tRg7nzRACDqa2fQjhbc0AF11VqRs/a0QWHN9/oMRhy1ChR3d5bCPXwaPL116lnRQGZPoBQ7b/OvXbtkgGxy/kZg6NnkLCC2TWju cz+6UDl6 dlSv8jf4rq5jFsXEP3hcHzXO8NTc6kAZLw7VrZOkd1Hy9kdZzJUblZRGdkIJ+5nFKFWxlowCtt72KRBtIvs5YnR/BU8Gy13eE9510RQIs3PQYb221NIepyLLVh57ZpmCawjoEhzgMYl1VHU70VP5L98wk/B5ZqCm8s/s/LGt/y4QJv212orpe892jHTpmzDbXw+aeADdJDqwAroE+8fdFKBc10l4psVDjzwkURrv9lWzZTlqguRfe8xxxlGXK4KZ5IF2f8UNLcW7JyCtrwtfBALa2mZdSc5POKfVqtW3wgwl9THQO7qkOR6OXD4oKaYQ7FquejDUuWFOaviNicH6fbqwh8+qIP0GM0EGR70yYljdvJIDffWh0e6Q4+KSeumW85sQp X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Dec 09, 2023 at 05:52:00AM +0000, Matthew Wilcox wrote: > On Fri, Dec 08, 2023 at 02:39:36PM -0800, Luis Chamberlain wrote: > > Commit aa5b9178c0190 ("mm: invalidation check mapping before folio_contains") > > added on v6.6-rc1 moved the VM_BUG_ON_FOLIO() on invalidate_inode_pages2_range() > > after the truncation check. > > > > We managed to hit this VM_BUG_ON_FOLIO() a few times on v6.6-rc5 with a slew > > of fstsets tests on kdevops [0] on the following XFS config as defined by > > kdevops XFS's configurations [1] for XFS with the following failure rates > > annotated: > > > > * xfs_reflink_4k: F:1/278 - one out of 278 times > > - generic/451: (trace pasted below after running test over 17 hours) > > * xfs_nocrc_4k: F:1/1604 - one ou tof 1604 times > > - generic/451: https://gist.github.com/mcgrof/2c40a14979ceeb7321d2234a525c32a6 > > > > To be clear F:1/1604 means you can run the test in a loop and on test number > > about 1604 you may run into the bug. It would seem Zorro had hit also > > with a 64k directory size (mkfs.xfs -n size=65536) on v5.19-rc2, so prior > > to Hugh's move of the VM_BUG_ON_FOLIO() while testing generic/132 [0]. > > > > My hope is that this could help those interested in reproducing, to > > spawn up kdevops and just run the test in a loop in the same way. > > Likewise, if you have a fix to test we can test it as well, but it will > > take a while as we want to run the test in a loop over and over many > > times. > > I'm pretty sure this is the same problem recently diagnosed by Charan. > It's terribly rare, so it'll take a while to find out. Try the attached > patch? Confirmed, at least v6.8-rc2 no longer as this as the commit fc346d0a70a1 ("mm: migrate high-order folios in swap cache correctly") was merged as of v6.7-rc8. I ran the test 400 times in a loop. I'll remove this now from the expunges on kdevops for v6.8-rc2 baseline. Luis