From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 503D1C48BC4 for ; Thu, 15 Feb 2024 16:45:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7CCB66B0083; Thu, 15 Feb 2024 11:45:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 756056B0087; Thu, 15 Feb 2024 11:45:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5CF068D0001; Thu, 15 Feb 2024 11:45:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4B7676B0083 for ; Thu, 15 Feb 2024 11:45:07 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 804841A1188 for ; Thu, 15 Feb 2024 16:45:06 +0000 (UTC) X-FDA: 81794613012.10.679EA8C Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf23.hostedemail.com (Postfix) with ESMTP id 599D9140006 for ; Thu, 15 Feb 2024 16:45:04 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=cs7GGt9a; dkim=pass header.d=suse.com header.s=susede1 header.b=CaMgsam2; spf=pass (imf23.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.131 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708015504; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VRHpwz0jmcW35D6Wb8el2YM1B2vf23RXP7/FUXCRfsQ=; b=biRoh7wr6FXbt7IzdfntrKxgg+GOunbx7CLGeeelUUW2yBR7rVbIaBldoN2vwAByUhsi0o k/1OzmKTdHuGnqWs7toBU54ZpNBAT1yXj+zAhIvd7C564vhz/kAAfUuip/19zNwRkB8gjZ uc0m+4+meb5orDbc+N9UJkh+4tEZfx4= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=cs7GGt9a; dkim=pass header.d=suse.com header.s=susede1 header.b=CaMgsam2; spf=pass (imf23.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.131 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708015504; a=rsa-sha256; cv=none; b=devp3CEK9YB/n4B9kzSLhyaDw5sY8jfq4KxaA8YReOOlJsxXiF18Oc9XiCiF4yWsOQjH2y yaspvsWz84kSo5gNBCcz/AMXkBS7QSNNoi+9b5t458GdaRlHG6lfkJn/qHD/3yTeNUvT9U T9NJ4kv0uiVr3H7H07WNpIwoMb3qG1o= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7CCD21F8BE; Thu, 15 Feb 2024 16:45:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1708015502; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VRHpwz0jmcW35D6Wb8el2YM1B2vf23RXP7/FUXCRfsQ=; b=cs7GGt9a0iaqBa6Ih3HN+XvLdQW/C87yuE97TPyUBpJ7mrSwAalNIB0MUt6lwEo+/koCBU fYaMS6DTIWrFFPmGurBwAPH4Ki0EMIxn5gNnNIYpSAymwuPezuUWLd3zymI57Q3BzPIcE/ fmaFpG8dSc8485NawHFz25CtCTXAbbk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1708015501; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VRHpwz0jmcW35D6Wb8el2YM1B2vf23RXP7/FUXCRfsQ=; b=CaMgsam2Wq0Sy+5TGkRRdIpU+51MJ1joWXAnMU4Z8NDpef4JgM7ikKEDU4+rmgELUx2ZkA pLcSLScJMrI4nuAL18Vs20cwDFykqhko9Df1IlPJOLmdfUrYyjhItpCmzm3G12Jg+p2ukW 1WjmqNlWOosKrYvpCgIB3qAozJT1Ymk= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4C44713A53; Thu, 15 Feb 2024 16:45:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 8HpaEo0/zmW6CQAAD6G6ig (envelope-from ); Thu, 15 Feb 2024 16:45:01 +0000 Date: Thu, 15 Feb 2024 17:44:59 +0100 From: Michal Hocko To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v3 31/35] lib: add memory allocations report in show_mem() Message-ID: References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-32-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 599D9140006 X-Rspam-User: X-Stat-Signature: nenp55qja8hxnnn43bgdrfhpoq19m7am X-Rspamd-Server: rspam01 X-HE-Tag: 1708015504-835305 X-HE-Meta: U2FsdGVkX1+2DeRt2V0dpg95voBHwIsre4yLREvo/pPFn2u4lQmovSKv1klwlY1OaaTHQpG4vu8DMESx+HQQBSK1Slo6fiyQyWnvGpy6opda0y8G+biB9yFNw/rAnHTwaY8WXs3dwJkccqNGNRblAUHph1qRbS1k7PagtMxRQQl8c+Cr16zEuIVImIwo0ANLRf2ck6wmORmzPLqgk4UeKLfzD7vKmptX/wmtbyB3OMmzmJMqIOqqH40M5vhzbG98rLELC4BRhpkAddDdgKuLqgZLygecA7aIXllP579kepFKg8ige8llxrtpYHonCHJ5scgzCpnjUHW9BWdDPiTtLODQoh7QMVFK1obrUZdC7q/DEj10IJuWjljIgictROm1/3KYT8nygyCJUd/lfcbhH4LtM8VCHx2c3vhuv18m/YzqYixhIcgQlz/g7sfPrdodjwtFC40InFTp+p19j1KEqqbWKZxRJSkz31VGmYILgkxkEt0zkjniBv8ehT39h9gaNdK+vFbE497kD3qMhEVMyLRhCBsoJEkPmsVFo3xGxi8myi+hPfcc8pPnzeq4n40PmJnQqU2ZCm3J+78f6x3TbI1baLqVq+Enwlqtp+My+1VdFtbs/9KyG1Fezfg055Z8iFGVIMnRpBA52IAA/fBa6RyMK5v/V9BM0z9AiPqxoZB1vPqPyKy248qd0AlHllmM/fww4mhW80hyXfddUWZX7/9Pxf2jw8T1wKAFmCdMFQcuS7KLyy2gGzP/kAz2FUvJq+J/d+hkOudDrj8CDqW7LtnQ9gRYDvetD4RWyMJNsa9oyvEnhfMNtxvfDif71/wrBm6lhJOLmRRrJ72kht+PV7mbtlzPiTGCRAAOf312p8Ri3wr4bxI+Am5NkpnemkVlZ0tDOeq91x/5qjs4OG5bNwT+R5udomqNT06G9oHBH7pOAz5RpjdbfB+fLf8/cZSZ6H+2DVihRnY9olhYTw8 0FyBT7Eg 2GKPOu1x1YMwmqkNRXqZrh/Dhj4LkMMd3JlbF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu 15-02-24 06:58:42, Suren Baghdasaryan wrote: > On Thu, Feb 15, 2024 at 1:22 AM Michal Hocko wrote: > > > > On Mon 12-02-24 13:39:17, Suren Baghdasaryan wrote: > > [...] > > > @@ -423,4 +424,18 @@ void __show_mem(unsigned int filter, nodemask_t *nodemask, int max_zone_idx) > > > #ifdef CONFIG_MEMORY_FAILURE > > > printk("%lu pages hwpoisoned\n", atomic_long_read(&num_poisoned_pages)); > > > #endif > > > +#ifdef CONFIG_MEM_ALLOC_PROFILING > > > + { > > > + struct seq_buf s; > > > + char *buf = kmalloc(4096, GFP_ATOMIC); > > > + > > > + if (buf) { > > > + printk("Memory allocations:\n"); > > > + seq_buf_init(&s, buf, 4096); > > > + alloc_tags_show_mem_report(&s); > > > + printk("%s", buf); > > > + kfree(buf); > > > + } > > > + } > > > +#endif > > > > I am pretty sure I have already objected to this. Memory allocations in > > the oom path are simply no go unless there is absolutely no other way > > around that. In this case the buffer could be preallocated. > > Good point. We will change this to a smaller buffer allocated on the > stack and will print records one-by-one. Thanks! __show_mem could be called with a very deep call chains. A single pre-allocated buffer should just do ok. -- Michal Hocko SUSE Labs