From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 333D7C48BC4 for ; Thu, 15 Feb 2024 13:45:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4AA7D6B0085; Thu, 15 Feb 2024 08:45:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 45BBB6B0088; Thu, 15 Feb 2024 08:45:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B66D6B0085; Thu, 15 Feb 2024 08:45:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 178046B0085 for ; Thu, 15 Feb 2024 08:45:59 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D485141165 for ; Thu, 15 Feb 2024 13:45:58 +0000 (UTC) X-FDA: 81794161596.23.006EF09 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf20.hostedemail.com (Postfix) with ESMTP id 557871C0021 for ; Thu, 15 Feb 2024 13:45:54 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=C61MpsSz; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b="GVRTPxs/"; dmarc=pass (policy=none) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf20.hostedemail.com: domain of chuck.lever@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=chuck.lever@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708004754; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5x3cakAt53GmBJAaI/WQ2McRDfkB+9VqPm1IodOY7QE=; b=2zAijvFR17oE3AU/P5bbkpvSAy81YRVrrbNFUbn9+wQZohAgPANPyc+n/4fDuUTsJnjpnL 9sOJ82mngs4mcHSY6KLS+8s5qx5DQZ8urYiuGRIgE1t1x1JQuZhpBiNmYtsFLwRIRzTBaZ ZFoGwtIIav0fUf3nNsPJRbfaILr/MS0= ARC-Authentication-Results: i=2; imf20.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=C61MpsSz; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b="GVRTPxs/"; dmarc=pass (policy=none) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf20.hostedemail.com: domain of chuck.lever@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=chuck.lever@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1708004754; a=rsa-sha256; cv=pass; b=5r4MpotcQc/1uOOV30lttBxmSca+sJ30oPJPdt33cOyXKKaODCdMd0yRENkm7mTJGMPuJy fiNtuQnaV+XEvCkPxQASgvxhOcC0i4ShtMuh4iMiRJnWUkDk3gKvFnIIDnkzK4ox93p8IF AOR7vk1l+d5/PqqFUzu7ocwTHXPKv18= Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 41FDIM0N031505; Thu, 15 Feb 2024 13:45:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2023-11-20; bh=5x3cakAt53GmBJAaI/WQ2McRDfkB+9VqPm1IodOY7QE=; b=C61MpsSzIvM+n+3+QJUumij227bk8U4nrFdqHON21suoBRw5D8Pgs4blNfmppSOp9rAL 4uFHLbQe3TYOij6fkkxk9JUGRE4YY527DLe41hhl6R/7xDMXo2BE5pSnC0YgQKy7g2yP MvLwXV6R07DWE/OK2/HpglRN9TOcraqPJgL75rubr2yqIxo//NUdMh5iIp9UEUAYbkhq OOuZJJqoNv5TlzbFcDBmJaerYxP1NezNzUuCvkAefKPLcml3FIlKcFS+aMxDBIBO/GqI 3IW/69zx1vJd3/HXaMzU9T+YLJUihi56w8zUlqgjbY9DimPgJ4oxeAuwnr7gU5rNHi1e RQ== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3w92ppj5tq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 15 Feb 2024 13:45:39 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 41FBwQqO013876; Thu, 15 Feb 2024 13:45:38 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2100.outbound.protection.outlook.com [104.47.55.100]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3w6apdcv0d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 15 Feb 2024 13:45:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YNZIfFAqF2tS1HRr2plv6qDsmd+1TP0gAv26ysg7/9Di9s/hdeEyhOmi5JM+yJTC8D5/mC6s9h1WywmodKf7zYwVH4tsNk0FUurtoxTrlgT6txXKU/5Qnct+QJPsyjTaxwdHde5GcCK4iwl4YObIyVuT9Qq3lPSf5YpKb3y2DfLXQf9s5Kc6H7tPyzflySVZ+mHioF0K8pdJRFVM1L3yDPAj+XS/IbDgvueCCegykq0/rIcO86uuWiESGrzreTzLmb42s/AQOePzPQP8mK/XGYsNiYKffduB0lbirR1IOZcH6uCvv1LNitjLJJVqUGDdFZJmPRISb0t/MQNRKSwh5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5x3cakAt53GmBJAaI/WQ2McRDfkB+9VqPm1IodOY7QE=; b=YbYm7NGJxiV1KxHrR0D71dedtLRl0PDFgWsoBYCD0+ZB61u6TySEdLHF5+uqeRhIrLmRHb5yidAvdYdMJVNSdadqKJsM/9itNJQh5nA0Z1p/fLrvnPm2eeZJB1e0WmE2FJXDDOBp27vtGV34T7UkVz5goQNQ5rtZUmUozgsWjLFdgW2abvUzYTRquaMYjoqeCGyxlTMn3cfQ+u6Rc8TBZqeECVUuA9nJyeMY1frEu2T790TQunFIe9DsGVwD4CzTtlJJdUz0ZzOkj2SvYK9prufe3RauzVibnVFS9SiY9TbJUB+5Ohw/5q2ypqfPPHLD4eIef19mo/SB1CXvZVLaRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5x3cakAt53GmBJAaI/WQ2McRDfkB+9VqPm1IodOY7QE=; b=GVRTPxs/kvV2PyCaHC4F0OEbuG0+2MSyza5C9iDnb1Js4of/+fvIQ5isOXLxM94QEQFNLj0qbWu9INPXfpz0ovtzTn17keEFwTIkfyXznra3eh1H/vP3ut5ZJlV8W6GJEfx27dXh5TDOLiaBFbHICasXp8OQIsjUtxKT3Oh6ytU= Received: from BN0PR10MB5128.namprd10.prod.outlook.com (2603:10b6:408:117::24) by PH8PR10MB6645.namprd10.prod.outlook.com (2603:10b6:510:223::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.29; Thu, 15 Feb 2024 13:45:36 +0000 Received: from BN0PR10MB5128.namprd10.prod.outlook.com ([fe80::ad12:a809:d789:a25b]) by BN0PR10MB5128.namprd10.prod.outlook.com ([fe80::ad12:a809:d789:a25b%4]) with mapi id 15.20.7292.029; Thu, 15 Feb 2024 13:45:36 +0000 Date: Thu, 15 Feb 2024 08:45:33 -0500 From: Chuck Lever To: Jan Kara Cc: Chuck Lever , viro@zeniv.linux.org.uk, brauner@kernel.org, hughd@google.com, akpm@linux-foundation.org, Liam.Howlett@oracle.com, oliver.sang@intel.com, feng.tang@intel.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, lkp@intel.com Subject: Re: [PATCH RFC 6/7] libfs: Convert simple directory offsets to use a Maple Tree Message-ID: References: <170785993027.11135.8830043889278631735.stgit@91.116.238.104.host.secureserver.net> <170786028128.11135.4581426129369576567.stgit@91.116.238.104.host.secureserver.net> <20240215130601.vmafdab57mqbaxrf@quack3> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240215130601.vmafdab57mqbaxrf@quack3> X-ClientProxiedBy: CH0PR04CA0001.namprd04.prod.outlook.com (2603:10b6:610:76::6) To BN0PR10MB5128.namprd10.prod.outlook.com (2603:10b6:408:117::24) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN0PR10MB5128:EE_|PH8PR10MB6645:EE_ X-MS-Office365-Filtering-Correlation-Id: 83f3cd21-d20c-4c15-ed59-08dc2e2c6352 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pwyJjmlJhw/DSIukprIOduhD+siKIZDzFVjLSz4tJz4hZCSMSTMvrh7uNPvuhC4bIt3anrDjqsXkZ8Z6mTXEEkcZ9POn0v2WwU4Du7OMJQHUSLVYzOxSWkIVIPDl+oMhV/cHyTYQ/FGYeVqRfRRtH9w4Zxrvnzuw4Bqkp6PSAMVZN55LjOMS7W1bZeew9u6nA3gUOaSC/LIO7Ei6QGNFchlZNCZQKZY1IA/OpOGcXsN9v5rkLEsGCn5xslqg1ZXh5jd5kAv5FvzVKEcnWh4HUTxcPJV0QdClG92/ZsuspWV7uhc8HvEYI43kxF886IBftIWZMXwbADAbMvFUHI0B0yqDk9MlAUdkgq891I1AiXmcmpkUVjSSeRGU8bH4DEggNuM41qZHNuE+H77EukilHizXKfOj6pMwg9N467XDautFxqQQBzDXfm/i72K4oizQMKdMlqNfd5u2p5QCUAxrKW4Gqw0XJzLKii0r4q7mJMEcJp/w8VvVC0RvoKC998MDTocYj2AzBrCkjOidRr4UcGvv1cZRKUZ8K5S/9mIhXEA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN0PR10MB5128.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(136003)(346002)(376002)(366004)(39860400002)(396003)(230922051799003)(451199024)(186009)(64100799003)(1800799012)(83380400001)(316002)(6666004)(6506007)(478600001)(966005)(9686003)(6512007)(6486002)(5660300002)(7416002)(44832011)(26005)(41300700001)(8936002)(2906002)(8676002)(6916009)(4326008)(66556008)(66946007)(66476007)(38100700002)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tQ814FoLzxSgejTEzjN4zb4tBCM52oW6gNnSsLsHpuw/BIiyK754YYuyAocP?= =?us-ascii?Q?dKHx11IYg64B3g7IEdu23e3JGLh1U2MRdQYPDjK7pzVz+hrhfFNA8gzOURXB?= =?us-ascii?Q?cORSaKKcbSVaooD7gIKtuiLnTmVrd2cBewQFWQrQ271rqinJnYQUfYKZt7cf?= =?us-ascii?Q?uQjkVbv5NU/YBMOeKxhlgSrI/1hesfLcs76LX8fd+NV22n/E3M+hfiphufMV?= =?us-ascii?Q?kN3t7pZl9yhXFUtIsT2zW9ChrSPanC+Gu+keI4E/Ge2tGxa9PdHEmTRr+9Nl?= =?us-ascii?Q?5MO8fxvjmXuRCge7kNZtwxc+K2BEjPZ9RxlFjtbwwEO1/Zxw2cNGW7kh5bTm?= =?us-ascii?Q?Quhg70vvkuUebM6zS4JVFUu/MrgSfLDWupbzBTxKwXGna0Ko/IEjVqlZ8sMM?= =?us-ascii?Q?NDo+Fba7/jjYoQIjiP/9ZcHx9fktetKH77HX5EmVn56fptito0iG3m/obMTH?= =?us-ascii?Q?uw3yIV+mu+ynqYnB3DHcR8OINrsGajHmkv54iTiq/KFWuBMhTLIY5vx+UwRu?= =?us-ascii?Q?jNsNRrDIrOrX+hkq1E72WLeYZM7D9GycEtFzDZa0E2j7W+z7as6MmqnCy4cL?= =?us-ascii?Q?l45zKgCti0mQyxUEqmUVrbo9hq07iaU94KeGZUXOLVsrRT+knaJeCxAsBUpn?= =?us-ascii?Q?zjhDOCe3lk3EFP9NxgH6zxLRyQTOxPqs0lQ6YB4V9I61KBvGkCupQxE+7oLW?= =?us-ascii?Q?elRJ1dSFw7VnHzpVFgpsMCAcNVgu85omte7qE7DfgN9fJiuKn97hxiRV9kwR?= =?us-ascii?Q?svlORNehUTuFmYMCNyWeTvOIJVA33BqGsnked6R6PYdcxhHWsiKaO/iGQuwX?= =?us-ascii?Q?vL10m3D43rqVGj+R/lt+GVBCXhD+6wrC7krif0Y9TkHApRxgoN227Ac2HeIb?= =?us-ascii?Q?ZnHUZu5dRDzHYFCaxIYctjZqk1eBSPUtEjXVuAjQIxBVsaDb4qbQ49A9x+8s?= =?us-ascii?Q?kOqJLobRsZzK6kzmOSMs9WffUXEbx3Yb8t2c/rInpgiVQou0+L83rWc5bMSt?= =?us-ascii?Q?FjzXBv2lZ/LHKRTBxAgOdquo51tn/wM9LGqe/U+RjN7xbEW5wjcHVj2F92Mc?= =?us-ascii?Q?AtO/bLjk3vkn9NYiiGVUG+UimqYEFX7LToGur+C/R6qI8uF/1X/VkbXWhB9W?= =?us-ascii?Q?xucfd5kIz+odS7loOS/0TvmJi+TMR9Y7kT1mgtAR7naB7kftu7DFZUmffp6O?= =?us-ascii?Q?c+XFqKZgkmXV9OU5lUhS0DHOk7UXkjUte+UD+Ifc5Kt4Kvb3owdXoRW9yUbq?= =?us-ascii?Q?xr3PxHFy9ZeUOeZAlXhIw7UiDkZg3uvNppb5buu2G8AFL3eQFAiAL1G5gDxO?= =?us-ascii?Q?sHYAvKFWMM8D9EB5uO4dh1It0dYupl+ymjVsMvza58PCQ++TdYl5l+jHat/C?= =?us-ascii?Q?vhSBx94QDFRo+6hGzj3xU+E3Lr06PEVJynF64t79i5NLMzGzYT291KZ7vRwd?= =?us-ascii?Q?X4R2dJRaegp/J3k/RwQXNhNJSRHgOrwclQxm3dJxOkF/uGcv++cjDx8WNjVn?= =?us-ascii?Q?O0RP91ZqWhime04MHTjABnRncd1U2q6SU36v3s1pyfAGC+0cxJmtl7n4kK6x?= =?us-ascii?Q?sNZWGJ6Uyw1Hk9ghEQ+ldWyMXaB5j2xH8CBMwAqqeouhORCCe6u2wzjDPBba?= =?us-ascii?Q?zQ=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Lr/9Rkc4+GhvJ6GxkyZfTBzy4gRcVhAUhbtb5yLDEpCREETTonTescH9rQnOylj5dbLQ0ewLrrMtKh+Hogu9fY6wkUrthrBM+SSuTVvjcw32jGaddrmB704OyS9r62o6WVMSU2Io5S8nTRf+OttdE71CKhQyPzxigx1arMMuNx9Fn3zOXXuj/6eVApUdOWyAxB36TaAnoeJHXQr9kFp+0OY8VmMy7tJZGhnZ79L1sN0ZndgVCRWBsEfTYSk1y3AmbfRQge0sePC42LAbmmHtSiE4vrLsyh5DVbXSEgpt5lJik9G91BAl4Jp8W5TsdXJ1FQ/GyIdmAvd2iG9XYg26eAGA71v7hJhc+k8MR9tTnp9ud+r09EWnfz1+3t8S8vEK6LNbzmR9FjTGRIZECU3znzovONxKGCY5/PFf51Ov7LR0b/4GTbTxza6ffD4ksr1OqqdfBSC/K2nhelCJXmMX39sdBR5doWF8FVEHLCmIhV3hqRz6nIOiF9otyWWmywLrS8SNRq3+Q40pWnd1JA6LcfinwS9Phu1IJ+ww+AVlU62iaUd1FOJ95y84X70qEy+DlRpsMlVLS2Z59+wnJXyCZ+vuiCuKZevniVubOZTk+3U= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 83f3cd21-d20c-4c15-ed59-08dc2e2c6352 X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2024 13:45:36.1537 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nGan2fAT5BhhrpsNOGENv+O5sy0UPrmh2qwMXVg/n1qxG4krX7qdl/Qj+rKT99G/FwsKQ/kqaukt1NPZb5oqOQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR10MB6645 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-15_12,2024-02-14_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 suspectscore=0 mlxscore=0 phishscore=0 bulkscore=0 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402150110 X-Proofpoint-ORIG-GUID: Bm9Vk1I9WdXTyXqWsCnf_FOrM1PlTkiL X-Proofpoint-GUID: Bm9Vk1I9WdXTyXqWsCnf_FOrM1PlTkiL X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 557871C0021 X-Stat-Signature: t5j3ygfy4b8qpi6rdswqb3p4wf6cj3od X-HE-Tag: 1708004754-416880 X-HE-Meta: U2FsdGVkX18aBn4ohZ2sF1x9rzFgPIi0/t1jypJz0+lylPQolr+2FO8TKUfSJR3RVihB597oPO1AW2sVYIdokMy+0MYEFD1g1ELTdryIpOD9lm0SvXSQlkbXF+8V9af1N4EAgWzy9p9ZxpRmTQAGHOVaS+gopnxAAEf85znh/gjS3aM2cyR1B0bHiZ0qOVCd+LIZZItidPxD52WeELt/0eyM6OWbfAyU3Ydp9rOGbOwynIVdYeI9XHXO95bUM1CcM8uekVgSMZo59Vv6UM1sgPCGgT1PvJ3R7hv9415YO8GmS/adoVocLYK/u3Pr/nptruQLcZgUisYYBWBdclwKxFeQMdfLtJCeODW3eyyxGRgQckgCdr3LpjDHjnLE0vyRc8MuJaepnE1fINQGhC54JtssKYz4S2kTLrNt6lCKM4uTUKp0NYqt9MxbeyDIX/1yBPR3bweUMMiW4++GX+r7pqpycY9F5wFJ8geRGbkm5IHDswfC32VxeMiYnt/Le7NwSJEGVx6bAS4+9y6K+Bm7jA9W4WBsXP52xwFYWMNHExMDEBzzZ69L25GDZLcBTlP2VqWD4N7DPRlxx+1oebpRdYjNSt07v7uXH5mr9E79yj7M8rQT+2Ij6HtGm6R/jBFemqrWHRRxypmPo2XhjEpaVIqxUCDV3Lti9o5USCP3a3elMQ9TgOe0aX7TXhgjMqQ65tZl9HnQXqK7EZQOShxqy+lKI6oSZUzfpbMW2n9bZyKRA22ysD26R8S2yfcU/L6izr69xZOJ3vzZwNRNf5Uyl2URt1xMt0QB7N1R9Et9zWsNFANF7PwEynWTLeiSIn03JzvgFrqLSz6x5jZJjUykMM2WqYCT69hp2GTf/Co4oQixSDwwgA5Ma083cuB2OHk/otUbobC7lbDyH2VdrFReUzl9RhUxu1fmfYY9UK9fIA45vIMFf0cp+T2TGoOiDiiSioPHhy+7MIaPs/Msu64 5FJScgpe dU3Fo4V2znW8CDK9Y2wg9weXTtRdGYYwo9ricRHcBrcLAZv9xD3vjo6uiYoZ4kfvWQgqoL7+BggN4J4WPKLI8o7VwtfhDt4q7Bo0alFRT0r33bZIRWPI0nSgeqEjnZt8LxXLvX37Cj6gdxaDWdAIIEyRYK88mJOWYEGfrBD93gEs7CKAMqq5JlMZThYCKliu7OrFHQUjuvW8xhZnU56gQz+SD1haYzGSzl8Zso9XGIj+iXAX8coRaDCDKbm+t7DXHBzyStNVHJ3KTKDkJPH++QYy7NMhvHdxzRhoGYZrjxfTaCr7QqVJ6kMTdYQDrOLwZw3aiG5TIQgO9DDDOpOMaMA3Tc6ITS03SAmbkVIRRDWdV771hygSZex1YnkOHq8pp1GyXpkP1rnyVTW69fJSTs1CUZi1kcgFRiuprBDRVl68nFJOWFIcaYQ1PiQYVQTJ2oUlJWkBoJpsarMKstQQLyNV5JhHeYCBxP9LBar0QBaC2MVQCA6Q5KjjaL1QLNQuzS1ebw1tSpl0+PgvKfZry4o8Udw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 15, 2024 at 02:06:01PM +0100, Jan Kara wrote: > On Tue 13-02-24 16:38:01, Chuck Lever wrote: > > From: Chuck Lever > > > > Test robot reports: > > > kernel test robot noticed a -19.0% regression of aim9.disk_src.ops_per_sec on: > > > > > > commit: a2e459555c5f9da3e619b7e47a63f98574dc75f1 ("shmem: stable directory offsets") > > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master > > > > Feng Tang further clarifies that: > > > ... the new simple_offset_add() > > > called by shmem_mknod() brings extra cost related with slab, > > > specifically the 'radix_tree_node', which cause the regression. > > > > Willy's analysis is that, over time, the test workload causes > > xa_alloc_cyclic() to fragment the underlying SLAB cache. > > > > This patch replaces the offset_ctx's xarray with a Maple Tree in the > > hope that Maple Tree's dense node mode will handle this scenario > > more scalably. > > > > In addition, we can widen the directory offset to an unsigned long > > everywhere. > > > > Suggested-by: Matthew Wilcox > > Reported-by: kernel test robot > > Closes: https://lore.kernel.org/oe-lkp/202309081306.3ecb3734-oliver.sang@intel.com > > Signed-off-by: Chuck Lever > > OK, but this will need the performance numbers. Yes, I totally concur. The point of this posting was to get some early review and start the ball rolling. Actually we expect roughly the same performance numbers now. "Dense node" support in Maple Tree is supposed to be the real win, but I'm not sure it's ready yet. > Otherwise we have no idea > whether this is worth it or not. Maybe you can ask Oliver Sang? Usually > 0-day guys are quite helpful. Oliver and Feng were copied on this series. > > @@ -330,9 +329,9 @@ int simple_offset_empty(struct dentry *dentry) > > if (!inode || !S_ISDIR(inode->i_mode)) > > return ret; > > > > - index = 2; > > + index = DIR_OFFSET_MIN; > > This bit should go into the simple_offset_empty() patch... > > > @@ -434,15 +433,15 @@ static loff_t offset_dir_llseek(struct file *file, loff_t offset, int whence) > > > > /* In this case, ->private_data is protected by f_pos_lock */ > > file->private_data = NULL; > > - return vfs_setpos(file, offset, U32_MAX); > > + return vfs_setpos(file, offset, MAX_LFS_FILESIZE); > ^^^ > Why this? It is ULONG_MAX << PAGE_SHIFT on 32-bit so that doesn't seem > quite right? Why not use ULONG_MAX here directly? I initially changed U32_MAX to ULONG_MAX, but for some reason, the length checking in vfs_setpos() fails. There is probably a sign extension thing happening here that I don't understand. > Otherwise the patch looks good to me. As always, thank you for your review. -- Chuck Lever