From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C439C48BEB for ; Thu, 15 Feb 2024 11:18:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 06A1D8D001A; Thu, 15 Feb 2024 06:18:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 019DB8D0001; Thu, 15 Feb 2024 06:18:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4AE68D001A; Thu, 15 Feb 2024 06:18:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D11BE8D0001 for ; Thu, 15 Feb 2024 06:18:12 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id AAF6EA041F for ; Thu, 15 Feb 2024 11:18:12 +0000 (UTC) X-FDA: 81793789224.20.B780007 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf10.hostedemail.com (Postfix) with ESMTP id D153DC0013 for ; Thu, 15 Feb 2024 11:18:10 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of mark.rutland@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=mark.rutland@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707995891; a=rsa-sha256; cv=none; b=3Z1Ry0xjB4S8m16NEXqy/SHG93WWnGMGIuzPwsVOKpFBLUgHnVtsjHCMZK3dW+2PpDYrDz U2S74xB3XZLlBhTiZExRNyO++I/fASyZrowziLFhbRW0WgD+kaJTGvc++93KCZX198oRym 9l40aNQzGIwUl5AieJ8sSaA8lN61iNU= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of mark.rutland@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=mark.rutland@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707995891; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BPoSqlhEiUlV4rV1MfC8VrWLxITrY2ksWv8DtS3sCBU=; b=tgn6iDhvhbUP/KbivThnKN09NnQ/wT/WQLiycMI73v89PW/8jZkyf+ozMyoPSAzlHecLyu KOvAtJn+h+QVswHgGYlQIoPO815ThbHl84MO01Hl8g7OW96L8/bqAeeRyu9RMj02o8qtB+ b3KJLfzO6lVgzwE3ZnamWxtovc1QRzg= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C5E321FB; Thu, 15 Feb 2024 03:18:50 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.68.11]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4EFFD3F7B4; Thu, 15 Feb 2024 03:18:06 -0800 (PST) Date: Thu, 15 Feb 2024 11:17:59 +0000 From: Mark Rutland To: Ryan Roberts Cc: Catalin Marinas , Will Deacon , Ard Biesheuvel , Marc Zyngier , James Morse , Andrey Ryabinin , Andrew Morton , Matthew Wilcox , David Hildenbrand , Kefeng Wang , John Hubbard , Zi Yan , Barry Song <21cnbao@gmail.com>, Alistair Popple , Yang Shi , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , linux-arm-kernel@lists.infradead.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 04/18] arm64/mm: Convert pte_next_pfn() to pte_advance_pfn() Message-ID: References: <20240215103205.2607016-1-ryan.roberts@arm.com> <20240215103205.2607016-5-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240215103205.2607016-5-ryan.roberts@arm.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D153DC0013 X-Stat-Signature: eehdfbjk5odrsbhxyzphr6abj7oktenr X-HE-Tag: 1707995890-654047 X-HE-Meta: U2FsdGVkX183qdUV8bH02RdoJ5hCX3HX1Zb+IiDt2H2SYowNemtiIhGNgNJ68Yuivc/JQnUOK75SSicktK7Cc4Q2KK0vq6FgmlpWS8gXUqwAbK65BpdN3h2TXk3n+VNYDY1R/z6BTSLdpMJBXssRD3OP41gFTKgg4me0uxV3BETEJkPsebRHZZsel3v3k5uBWlGE7qAC0ES4e0Trts2mu1sTs2NyfKr9hAUlwrQ4/sucTK01tMFS7Qy5IefZHAAmafQeM/rChEAx613/y9kF5Lu8DIXTmPN2T1MY3zklGW7gwwnIO9re9plqvqSGBR9E5NwrRU3DiTi7eOhOj1vN+lv0ZuzUBr61wEEnXFlQbO+R+y7gJagyWyf+vSS7gchzS0AbwhpWmsjmZDI91w3r2yzKF1Ua6Q1o6GiY/d01SWDnGjuekDQB3WNET46fpQagls8kClOB/miesiZ7M98/4L7kj7RM7J7tNnm2f1IRjyep97HJdFhMtrPcUXG3mv9fWrIv08Y1PwYngeJGMwrhaLagqLhOyMC6cn5kaIPmvfBBEQ+BlROxkKsCBOhWfnICZ4FKPMKySOdq3GHdM4j26LcVMkfNqeNyx50I+L54N+Ug0eukucNgX+YYp72LRKg8sj/ZgofP2KGM3GEykOUtr/5hzbcKBUpN4QmXiQeHRt2PhUEiNmADowcDgd7SVLvJXzcNMvuR8RwHLaGe2T43JC4JfyXyJPK20hYpWpfWUBUdEem5viwWZDLAX6HWtJbd6ed2sPgkBj4ShMgHW2AmvIQ6ABsxcLiki9bUD8ct1DIYnyHSQG+7ondsfyASgIDEKuHOYA8hOeV3n/pkeoOoWR7DmZ6waDWDj8kLmLIKcTkE2uHQVrW1N0Paebx8hU7QIlW7QlV9H+Nsg751n7okM4bDOt1oKOUxYON/gfrZpoUklxbp0mTVyOAZtEgSrvdavn/DCFFXs3fiYjWv0dP q7EC4FH7 x6b0WkOytoTy7HzNOipA7Di9mou/iyQDgGVlnbjg4bvz83w5iVbJz4nHhMjOaHN1yzuUKQP/3nPnEmhTmmfUjGht1rsTfjgqvaRYcTr+XhjHlWtuNg+8gS1cI9exOE58jSj79P8UZxygBelaOBLVJRgSCuD54LdbbaWOtlZIjeC4dUnZrA2Be0G+ecVn4gAocY5hQv6UALd93abF/UbGXZc9WEjir34LCi7kahco76qQuTOj5WHqbSTNt3veck6LHb7Df6A2e8TWGNyEVGPWfW118w/rFULQlmshC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 15, 2024 at 10:31:51AM +0000, Ryan Roberts wrote: > Core-mm needs to be able to advance the pfn by an arbitrary amount, so > override the new pte_advance_pfn() API to do so. > > Signed-off-by: Ryan Roberts Acked-by: Mark Rutland Mark. > --- > arch/arm64/include/asm/pgtable.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h > index 52d0b0a763f1..b6d3e9e0a946 100644 > --- a/arch/arm64/include/asm/pgtable.h > +++ b/arch/arm64/include/asm/pgtable.h > @@ -351,10 +351,10 @@ static inline pgprot_t pte_pgprot(pte_t pte) > return __pgprot(pte_val(pfn_pte(pfn, __pgprot(0))) ^ pte_val(pte)); > } > > -#define pte_next_pfn pte_next_pfn > -static inline pte_t pte_next_pfn(pte_t pte) > +#define pte_advance_pfn pte_advance_pfn > +static inline pte_t pte_advance_pfn(pte_t pte, unsigned long nr) > { > - return pfn_pte(pte_pfn(pte) + 1, pte_pgprot(pte)); > + return pfn_pte(pte_pfn(pte) + nr, pte_pgprot(pte)); > } > > static inline void set_ptes(struct mm_struct *mm, > @@ -370,7 +370,7 @@ static inline void set_ptes(struct mm_struct *mm, > if (--nr == 0) > break; > ptep++; > - pte = pte_next_pfn(pte); > + pte = pte_advance_pfn(pte, 1); > } > } > #define set_ptes set_ptes > -- > 2.25.1 >