From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B760C48BEB for ; Thu, 15 Feb 2024 09:23:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A720D8D000E; Thu, 15 Feb 2024 04:23:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A22658D0001; Thu, 15 Feb 2024 04:23:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C2548D000E; Thu, 15 Feb 2024 04:23:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7B2C68D0001 for ; Thu, 15 Feb 2024 04:23:03 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4D848C011A for ; Thu, 15 Feb 2024 09:23:03 +0000 (UTC) X-FDA: 81793499046.26.B5AF064 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf30.hostedemail.com (Postfix) with ESMTP id 2A77F80003 for ; Thu, 15 Feb 2024 09:22:59 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=sfOAoS4D; dkim=pass header.d=suse.com header.s=susede1 header.b=sfOAoS4D; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf30.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707988980; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P0wAra6NNdsmQy/QOu3XOOm75y+sycyf1CReKWa3x/A=; b=PPDdZFAWxhKAZUmVJUKj0IILBFil9Cj5pMXidOIV76WJMGW/8jCSoPweCx5WqTBXMbyWu6 ezP3B5bzUpEo5OGx8R1cz7hXI9Gu4sDotsC/gsvsR8KCYS8BxPWY+RojEzUdX6OLMkgyWN Ospc9+7kwUpXcSmDzzIfRBJzfbuwDxk= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=sfOAoS4D; dkim=pass header.d=suse.com header.s=susede1 header.b=sfOAoS4D; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf30.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707988980; a=rsa-sha256; cv=none; b=Y4r+C2NcezCRr9nxdMgeqOrcCJ8TtqlsLaeTQunCSPnKDp1quQj6IopHpRYf70Zc6dIG5V rPFSGhOuApyit9BL7X+FqMkup5Q+qbAaYUyRhtI1x8/BzpbosGt8Zh56nzMnkdC8fL3hUV YKzy9TnNDzkRNdU5GffmnZIF1geK/ok= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 09D1621D8D; Thu, 15 Feb 2024 09:22:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1707988978; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P0wAra6NNdsmQy/QOu3XOOm75y+sycyf1CReKWa3x/A=; b=sfOAoS4D29QnYtnKO07SRNn72nriTA9zXXwoZ0RnHp0XHtxokuQn7bDggRyH/dV5bo4PMY m6GbhMwzRlnOtmD5aW0DXlvPon3YpJ50cKwL/qadfxvkMWtOESzhQ0uXkZ1xrF5HxAfde3 KNje8XIUO7zvXrtU2TUsUX4dAPtyxss= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1707988978; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P0wAra6NNdsmQy/QOu3XOOm75y+sycyf1CReKWa3x/A=; b=sfOAoS4D29QnYtnKO07SRNn72nriTA9zXXwoZ0RnHp0XHtxokuQn7bDggRyH/dV5bo4PMY m6GbhMwzRlnOtmD5aW0DXlvPon3YpJ50cKwL/qadfxvkMWtOESzhQ0uXkZ1xrF5HxAfde3 KNje8XIUO7zvXrtU2TUsUX4dAPtyxss= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id CED2B13A53; Thu, 15 Feb 2024 09:22:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id gyDbMfHXzWUfGQAAD6G6ig (envelope-from ); Thu, 15 Feb 2024 09:22:57 +0000 Date: Thu, 15 Feb 2024 10:22:57 +0100 From: Michal Hocko To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v3 31/35] lib: add memory allocations report in show_mem() Message-ID: References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-32-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240212213922.783301-32-surenb@google.com> X-Spamd-Bar: / X-Rspamd-Queue-Id: 2A77F80003 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: fchkdt7kq4ka4socpcfjum9hxrdjog6u X-HE-Tag: 1707988979-763932 X-HE-Meta: U2FsdGVkX1808NlG1qcdfML14+zcDfWSGZ4zPw2tQl4FQS3gIWE0/j6Q0y3kIVrl6XhE78kDUsddnbXlzCeWJJ2qzSzSF55aA8UOeQi1kAZOWZr606XSx2NzGLTiirNWhfeby3kUAF2v032LBISd/00VkrnnsyhfKgQt6IuF3r2J0HZm0W4FOgOyEIqZIg20lHgwQAiJoZRxT7gc6joT015sMkkPF42dMRe3UQWFw3ES9560Z0lKdtOTb/FCyO8sca1E229F0RJV+pT56Ho7rzlYlhSSmtPAHyvo3J9msOqk5ReoNGlBxe11qDUfr5ZvKO8Ha7qWZYNFladJbm7vAdBEHYiVigSTnEnUfsR6lk+3/3vxQBc0K49kauKT6LMe0A92Ea30hCkJbmV1oa7UbjkJPHYi9ZN1F6SPiXqd1Z/QT4n8iCCf5utqpdyDI6AkrUGL9kvZUU/65HNXiN82vuU3Sd6X62RlyOAwu0lMzhtSvLMjYkgU4VgeBxc5CwAuGIsh2vGDq1FJwJ19UulHGDu29POQdKi2YFo7a8Ab3ZZUzdDCRQ/kLsTa4D7An4yAsNtERdLUFeoiqNJZEurAyA7NFnroCkpJXO2WsoISp1wGeHZBm4TeqQ+FvCYG2U3hyBGQWVwHcJQPcuOcRYssaLwReX3Koq0KtqkQMswaC9YLC2jFTe23c0oyNxz3LKktQakFJuKRkxJQRzwpNFMJ+SgUlNIYZhVlTLHKmC74dcK3Q+mpwZB1bS876CO521uj0oFpxpaHwk2mV5NB+xN+vGDUvedw9Z4SuxvW0Qxj8/9dwgRH12v7FXUBU17Xfdfdg9OALyNqP7K8Lfa0pjql84l/ZxUktxZ7REVklu+gC7E/SPXh0/FYLVu6bUUPEa4rNsym+BUpiSqtCaRV9ZI53Qx/2V2xfTMBSaXvWM3mApetBn+V8odOFk5zWfzP9YbCrq9Bj7FrsvGQg9emi9z 0E6pzpZ0 2o2yNallSZJN6w51ZLcLru0UtyPPcL5B+eVHzVyL0wxbmCzblhoN4wdrKD/F/VIrSvLBLQ7DhRlJr15fy0LxQvTkn2acCND18GL4VvlCnTljZ7e7mEoQw3CvuUlJIonVAtk+1nHjcBe/NpNAlEQ9WRo9jkgdCzUwBqDVnDESc/cnUAn1Thma5tDaTZZDQWKPeQsI5mLH5zsQkwMxenPqVVn6Zal4DGQh45Sug94Lr492DDOVDCucDv5HG3+0GSvDy10yvHdFIZisXA95GmK/z7bdLkua8NlX91TTTSS6ZEdlcWNUKi0DOOHhaXziL7b8knGVtQxhnbhAwiYU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon 12-02-24 13:39:17, Suren Baghdasaryan wrote: [...] > @@ -423,4 +424,18 @@ void __show_mem(unsigned int filter, nodemask_t *nodemask, int max_zone_idx) > #ifdef CONFIG_MEMORY_FAILURE > printk("%lu pages hwpoisoned\n", atomic_long_read(&num_poisoned_pages)); > #endif > +#ifdef CONFIG_MEM_ALLOC_PROFILING > + { > + struct seq_buf s; > + char *buf = kmalloc(4096, GFP_ATOMIC); > + > + if (buf) { > + printk("Memory allocations:\n"); > + seq_buf_init(&s, buf, 4096); > + alloc_tags_show_mem_report(&s); > + printk("%s", buf); > + kfree(buf); > + } > + } > +#endif I am pretty sure I have already objected to this. Memory allocations in the oom path are simply no go unless there is absolutely no other way around that. In this case the buffer could be preallocated. -- Michal Hocko SUSE Labs