From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1733BC4829E for ; Thu, 15 Feb 2024 08:21:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 89B6B6B0087; Thu, 15 Feb 2024 03:21:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D6B76B0088; Thu, 15 Feb 2024 03:21:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 627366B0089; Thu, 15 Feb 2024 03:21:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 507B36B0087 for ; Thu, 15 Feb 2024 03:21:33 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3172D1A081E for ; Thu, 15 Feb 2024 08:21:33 +0000 (UTC) X-FDA: 81793344066.22.6CD55A0 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf21.hostedemail.com (Postfix) with ESMTP id CC9711C0019 for ; Thu, 15 Feb 2024 08:21:30 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=gIzYjlVx; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=O9WKxATL; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=gIzYjlVx; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=O9WKxATL; spf=pass (imf21.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707985291; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=62OqNxQVqlW6gW3Iult+OUncmOSdQUww1KVBTXtKUrg=; b=seaUcnV1tSXDQcJ8ePBYp3B8OzgvF1W1XCWDIcxTdivdetKTwK55DTkJdw1bmZgKBctMAa U/A2DrkCMhpxI6kEJ6JBTpr+JSJjEvBkcB7r1NsD6BmncTNeT1IZQDUx7NpJvFLJa3TpUI LV26UMyMygFNqOQhn+9EaUX7AtjgYCI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707985291; a=rsa-sha256; cv=none; b=AZ49mE/SV7DAIi9f7qr7bz8PoIXDwnXhfoI3XYAp0R7AjmTnr1Gh/Owx/Eo3WFeCi0TBlX J6OBs90Nriwm5x+gMaWqpkfEWzT82aUA+yH6kilXkoQIYm4VlkBpwK8YIdkmrF6d4UzbDk 4bmoAZkebcoNkZ4EJSm8hQ0OTZOS9xU= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=gIzYjlVx; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=O9WKxATL; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=gIzYjlVx; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=O9WKxATL; spf=pass (imf21.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 348732200E; Thu, 15 Feb 2024 08:21:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707985289; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=62OqNxQVqlW6gW3Iult+OUncmOSdQUww1KVBTXtKUrg=; b=gIzYjlVxxPEDp7gUbJqZKTbVHz/ot8Wr10BiVCY9N+Cjwx8Eli/umrarcIrqV0tRWEmDs/ CtSAAfcGlQkOj2AdRQC4Y0XVIY2zrL54RHHCriLZCHJ0qoSLa8qbL38rmZu51WkiDy8BIT 4LHqmc/w4qVO4a9rXsi6n7Qlg3AO48M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707985289; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=62OqNxQVqlW6gW3Iult+OUncmOSdQUww1KVBTXtKUrg=; b=O9WKxATL/TWLOiCB0s/HXQm5wRCnL5NEybp9bVw18Cz1n6dE6mYGwUqJ78FfeEKyAphcDF K/KEAaLmgTG1WlAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707985289; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=62OqNxQVqlW6gW3Iult+OUncmOSdQUww1KVBTXtKUrg=; b=gIzYjlVxxPEDp7gUbJqZKTbVHz/ot8Wr10BiVCY9N+Cjwx8Eli/umrarcIrqV0tRWEmDs/ CtSAAfcGlQkOj2AdRQC4Y0XVIY2zrL54RHHCriLZCHJ0qoSLa8qbL38rmZu51WkiDy8BIT 4LHqmc/w4qVO4a9rXsi6n7Qlg3AO48M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707985289; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=62OqNxQVqlW6gW3Iult+OUncmOSdQUww1KVBTXtKUrg=; b=O9WKxATL/TWLOiCB0s/HXQm5wRCnL5NEybp9bVw18Cz1n6dE6mYGwUqJ78FfeEKyAphcDF K/KEAaLmgTG1WlAQ== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 9225A139D0; Thu, 15 Feb 2024 08:21:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id YC7OIIjJzWUsWQAAn2gu4w (envelope-from ); Thu, 15 Feb 2024 08:21:28 +0000 Date: Thu, 15 Feb 2024 09:22:39 +0100 From: Oscar Salvador To: Marco Elver Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vlastimil Babka , Andrey Konovalov , Alexander Potapenko Subject: Re: [PATCH v9 2/7] lib/stackdepot: Move stack_record struct definition into the header Message-ID: References: <20240214170157.17530-1-osalvador@suse.de> <20240214170157.17530-3-osalvador@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: CC9711C0019 X-Rspam-User: X-Stat-Signature: kab7quip4fi4j89k14eo69muyqgh53fo X-Rspamd-Server: rspam03 X-HE-Tag: 1707985290-424001 X-HE-Meta: U2FsdGVkX18px4JHfoK854KJH5EsSWPvpMFmtWCNCKsuV5H11q6nzOYPipuUqdt3tD/yETS7mLgIifMLgpH4+ra5o4YxIQ9r1seMzFKlVzaEwM7sUdKOlsiIIYVIBjckGcenSTybYJmI+RFVGXlwmOVlIme13LTn4/+KECiDlxRRoSt7OS1Bv6h2/LiGK3FlvqGX+w4icdVfLk6Gi+USUpfpIqOEWnOlWX6Wts2OAHXliSdY8fX0rttq3n4GnNUvaiucznOknKA+XyZKfyUnd+mF9iMROI6s51RoOnBLObpV+BTmviaO+mMRYQhMtUa4Y+md1Ugh5B80uS4p1L677pndUhboThmYkS871OcPcexg0/paaBLSv2EKDyPs/+1P2S5rp3Xasf3zEGRGHTrRs4le9ijnvMzX7GKxCfDXY59X69zRDu85QqQY+S2HKMmjfKWUrxDYpyTd5M+9zGcAPWxK4MnWa5AbaNOljrlt4grffZwpsNDGpZR2XMLriThUuvvnVDfKhbTGoO/x9pCAT4pi9ncnm+VQsPC/Rmu+0jGm/v5RRZgNo4cmW/10ecJIXATz5zu28V7zQoKRHgCox5YGSgy8BK4jF5Fyd54yAJXeq4zqg1mhfxpdIuaG6zFGMU000d+VcaN9xXYJwUywlOOSUu1xILg15uQdBm0oEy3aKcdfXpP41hRaBhMfI3cVJ5xLg5p1hNo7E9bbVvTder8Bd8dM9xKKvjwDKcLE0LcNNGgFo0tpGqrfie7mFr3eiirDbu3JJxP49Fm8uHrPsmSrOfiKi174ikl7ahYdegN1kXndTR8It+rYQU634yFjdMYKEFX+rILmCfGa9KecQKo+z/cX7W6/Gpt7OrxZx7qivACLENNFwB2t8Ih4myYDh6n1gsXr/S8r1cIjZIG9XxY+i1sYSWLCUfiYoHBJeylMi4R/+O7V1sBDJGB4l2Og5D7buqnkEZKYQcMKbh3 vQm5MpLy nzWqTbtAdfMzsKZZQOSgYEQU+b7iIQN5Rf0XcWiIdpb095ZvGeza8qYcih8MV6cBtuG9zweUX5QJsNRvhhr/kBXfWZV3n1nmxikQYAsoo8JBhWl9sHNi4cbgb88rXpAKLyN7VyHXv0hDFROp6uIfRC013gCeRViZC7xJx1tqrrSqaWUku7NYXIl/OwG+Q9TP49EGhoW9zyM+q9yDnYSfUwDbghgNhoLGXJNb9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 15, 2024 at 09:16:58AM +0100, Marco Elver wrote: > On Wed, 14 Feb 2024 at 18:00, Oscar Salvador wrote: > > -/* The pool_index is offset by 1 so the first record does not have a 0 handle. */ > > +/* The pool_index is offset by 1 so the first record does not have a 0 handle */ > > Why this comment change? We lost the '.' -- for future reference, it'd > be good to ensure unnecessary changes don't creep into the diff. This > is just nitpicking, and I've already reviewed this change, so no need > to send a v+1. Right, this was an oversight. Andrew, please fold the following into the patch, thanks: diff --git a/lib/stackdepot.c b/lib/stackdepot.c index 4a661a6777da..514b8d40ff57 100644 --- a/lib/stackdepot.c +++ b/lib/stackdepot.c @@ -37,7 +37,7 @@ #include #define DEPOT_POOLS_CAP 8192 -/* The pool_index is offset by 1 so the first record does not have a 0 handle */ +/* The pool_index is offset by 1 so the first record does not have a 0 handle. */ #define DEPOT_MAX_POOLS \ (((1LL << (DEPOT_POOL_INDEX_BITS)) - 1 < DEPOT_POOLS_CAP) ? \ (1LL << (DEPOT_POOL_INDEX_BITS)) - 1 : DEPOT_POOLS_CAP) -- Oscar Salvador SUSE Labs