From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 051E4C4829E for ; Thu, 15 Feb 2024 11:57:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E92F8D0013; Thu, 15 Feb 2024 06:57:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 899268D0001; Thu, 15 Feb 2024 06:57:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73AB38D0013; Thu, 15 Feb 2024 06:57:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6362D8D0001 for ; Thu, 15 Feb 2024 06:57:38 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0FB21A070D for ; Thu, 15 Feb 2024 11:57:38 +0000 (UTC) X-FDA: 81793888596.10.3C73729 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf09.hostedemail.com (Postfix) with ESMTP id 2AD30140010 for ; Thu, 15 Feb 2024 11:57:35 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf09.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707998256; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DQQZ00risznqQY3P+jzZHLbTh2ubc2GWn+hDHP3p07g=; b=Aen0qX0P0ip55klc3X2irewfAvysRm3+45JDbaXxrpE74rCcGk9dRA17RBqyjKtRSecgZ/ ylq1UtEpq5Yh0/4LjsYk443IuvKB5HvPNCPZ+3+VwulYQpC4Wp91hFqsVHDsVxyU6omzI5 ZxP20fEUwGAuljWWrZ6sJ84JfhDiu68= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf09.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707998256; a=rsa-sha256; cv=none; b=YGOMh27JElyAkysDe1dRLkqosxUfKcrAbDaqU2BxGGL6yaOqJp7TEAUGha20JSsgS6qmjf AGWshTJ4rJeYSaYHc6SD+lhR4hlV+ie7eIRM1QgLvSPVSLotx3rZ8I9cSNI6x+agrJedny l1MEuOi33UYTrwuZG/QEPcD21jH1VRA= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CA9F722205; Thu, 15 Feb 2024 11:57:34 +0000 (UTC) Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 53DA21346A; Thu, 15 Feb 2024 11:57:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id sGO6ES78zWVaBwAAn2gu4w (envelope-from ); Thu, 15 Feb 2024 11:57:34 +0000 Date: Thu, 15 Feb 2024 12:58:44 +0100 From: Oscar Salvador To: Vlastimil Babka Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Marco Elver , Andrey Konovalov , Alexander Potapenko Subject: Re: [PATCH v9 5/7] mm,page_owner: Display all stacks and their count Message-ID: References: <20240214170157.17530-1-osalvador@suse.de> <20240214170157.17530-6-osalvador@suse.de> <4f4f008b-bde1-4551-ae24-db2c0778eb27@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4f4f008b-bde1-4551-ae24-db2c0778eb27@suse.cz> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 2AD30140010 X-Stat-Signature: aqooqa9d37nchigxo71pyg4qt3cezozd X-HE-Tag: 1707998255-544190 X-HE-Meta: U2FsdGVkX18kvDs73/xXKwsFUL04PHK9D3M62rQ/Mkvd4Npud2plBu7hB51vq4RXmFFeB8TIyGdYaV6BXkqVS+9NT22HD2cBBZhSkxtsGLEv0nqHYoS47ValnN31eVMtnDoGFn1ImCKBIVQBtzFP8qjXU9bVbi08ksizgW44oFf3OJ7tbTGG2G0LoN956uczLYBo6ajbZ7/valODqPdvcMBcLf+Wq8MoccvxaL6nzsfUXag6TWeV1enqG1sYl1lHANhIwpcbo35yq4v/NxEnTgGSxoIL26ZUTrwgU9/XQGV7vby5SAcfTPgWaNuPjdjKmjK6KlWB51pTROfTY3228XQM77ECLdqr0p1CDWKQwluPWQa4+lxGteRdvquo6fsKmzUwx43NNFMXsbAaKCgd9YCPvAxpX7uEzeqTg4cPwpbL9HM0AGw4vmrXbURSL4/ak8z2mJGk5NbHtriqQiyRHVms0FRpjV/5rx+j5GMloLyJ9iS2w0nZTDv32arKWdrAearkq4PD2vpUE/RYjdXWqUOIYYqLndgrPO4EaC0ZTMm8wPdiL7tR7yivgIZ65xkkFyqDeQiXtYZ+ZTt6Ind/LsK6tpefvjihZeFA22iY19c74fJrUfHcLjvIcHM/ZhOSp0A48jzp96BOgh2agOvtn9WK/brbo5bdP8/ZDs4twIcDwOaoCtMS2MNL02hau9ZNPIrrt+1yYrVLk4uAzXXPl8PxWuT5HTpP9zI17ndFXPk0zS/xsPAepGt8OzhXx7FlILlcGyWbejBqvFIVsio3Z0iulkLs6eeNohlZgPMkOdjeAUrRiAGQqnf8UiU9saLtM2Pr4/l6act/FGQYvo7HnZIbt+PGN0SL66hpGIPQBBn5WyHoi8SB/INIY09RLrhbJtYFsN+BU8bRQSM0U+7Hc+AvrXOWbn6iZsaJd5fCxSGDknsA+hbFT0PiNd/VdV1tg/Yf2g+w0D50596HlQV wamtM59Y 1uax8mgzNaeCsz2MQsnBd2ICtwTWJ+qkLCc0EWo2rhH/Co7tLIpXFbSAvPc1f7Tp5PHTSIGziZXLfNzzxUTJkTUbMesgfWCjf08+tyncuXHJ3tiNCtOHQ344/wKJETI9B+XWAC++cg6zXHb6WktyZNuV0Ol3s8gPW4+eS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 15, 2024 at 12:10:38PM +0100, Vlastimil Babka wrote: > On 2/14/24 18:01, Oscar Salvador wrote: > > Signed-off-by: Oscar Salvador > > Acked-by: Marco Elver > > Reviewed-by: Vlastimil Babka Thanks > > + for (i = 0; i < nr_entries; i++) > > + seq_printf(m, " %pS\n", (void *)entries[i]); > > + seq_printf(m, "stack_count: %d\n\n", refcount_read(&stack_record->count)); > > So count - 1 here to report actual usage, as explained in reply to 4/7? Yes, will do. -- Oscar Salvador SUSE Labs