From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15BE8C4829E for ; Thu, 15 Feb 2024 04:09:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9BBBA8D0006; Wed, 14 Feb 2024 23:09:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 96B4D8D0001; Wed, 14 Feb 2024 23:09:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8326D8D0006; Wed, 14 Feb 2024 23:09:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6FF908D0001 for ; Wed, 14 Feb 2024 23:09:10 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 47B7C40E92 for ; Thu, 15 Feb 2024 04:09:10 +0000 (UTC) X-FDA: 81792708060.24.0BDCC2F Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id 8CCAF180005 for ; Thu, 15 Feb 2024 04:09:03 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=CT1TWM3W; dmarc=none; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707970144; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9fuIbytQEg5hPlOrjPD0SvR4AYugFV4t14iROBoJ0LM=; b=emzzQ16p3OzhYaen+UGQ+ujjFA9abDz9q05rzzwEFt1f90qlzYFqhw4OAsfV5EblttO0UA jBUU1gT1FSwxVdyudmBDZZXyvaKyKVgHQuIh3sIOWnGSYeN1CIFplwfpJOYVr+NxtgSZ+j QwsOn8mGF4F4/4VnE7QtX1Za3Uuog24= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=CT1TWM3W; dmarc=none; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707970144; a=rsa-sha256; cv=none; b=WFSJ5bLZVvqmgZLRmtaj6ZLxGqAomgQKJgSid1WCayD9BcsIWdwdngvfMLg1B4LNf+R2yU WdJsGYDPjZI8z31PDmcHvtcOmLAms0pp52eUkMdIXEZXsqe7HmokY+Pp8xuOe/LnVjMBSy RSgEIffG68BecQnyGHP9mE1sdg7Svc4= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=9fuIbytQEg5hPlOrjPD0SvR4AYugFV4t14iROBoJ0LM=; b=CT1TWM3WnH7FRz+110NSMbcst2 Pf3j/6YqOCJCnOH5qJN0aGDB2OtG7mqxNISlngQydxm6AKdLui6yL2SlCml3FuLzbXUQe680L1SyH RF+wUGjNDzED7pykZgrd5JlkZxHdkoO+zpJMjB3OYxxF5LTdh77jw7UmO2pb6GMPTX3m8W38SHhBs gFb/RlqdeV3j/Yu8n0aWop3e6q1mfyi0EdE1VdOnHzdG9x8ekm40RPiS43Ebn9BrGNgZKKqqgRtGK T30J9/FndGQZZOruQS+u0ZhlJ8gH7sMFFR1mCHbsJHvKaEE6Gxq+WK1sieqZR590aYzmawOopU6MW 6pBnz9bQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1raT3N-00000000rgW-05AJ; Thu, 15 Feb 2024 04:08:53 +0000 Date: Thu, 15 Feb 2024 04:08:52 +0000 From: Matthew Wilcox To: Alistair Popple Cc: Sidhartha Kumar , linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org Subject: Re: [PATCH 1/2] mm/migrate_device: further convert migrate_device_unmap() to folios Message-ID: References: <20240214202055.77776-1-sidhartha.kumar@oracle.com> <877cj67jn3.fsf@nvdebian.thelocal> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <877cj67jn3.fsf@nvdebian.thelocal> X-Rspam-User: X-Stat-Signature: wo1377ifk9zbu7giu7bqxsi8ubqtih86 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8CCAF180005 X-HE-Tag: 1707970143-468598 X-HE-Meta: U2FsdGVkX19eVv728tUlm9QMJQAaJDMneil2yCZKCwPDsqo9lDUzgmBpbc3uGRnnpVN0tUDuxZbyGuxci4My4HGV8ongHAHyR4DDUlm5hN6rFwDifB6PvRttgW/2nouEyvMmvccheKjg6Iqd5vnpREtsUAAFvNpFTOlZQH9jifSTyCJFaW9B4rkhL+ms7Rd+bXU6S8ZqUyJhtT2Yc8ieoozfvdXG4EFsj85VooCvNRlviXFEn85hXSbH/FxFJeZpVi6r1tWUN+8L7I+10lbtCp+/C+gbqN+P6VOOp+MDqfVqehGn0JMnHsnEAzWTiVoHGExiF+00vnZMlj5lXQWZ5HjvQEues9xAvIjuXRsIgUbJxmSdyVw1dRCXEFhuSp0ov68g4Oq+Ghuhr8tWpY3suBrI/qgviHRBU1Yce8DGINZaXE1jFVubkSPvw1nX7MIzukE2DpeplmtdtPOcWBt2IbhBpYuUsCVAhuXlKrbNVWy3QC9TRYUr26+bfxl+lmplAcO40/cY5WvTEMbXSxa1zFv/iSG82uzisTcx2q9qcSuTfGVQ7SGo4dcNFRLh1HlE2D8bFBPT48qWcrx7GI7085pchGE6kB0nCBQCz6ABnJgpEe/oJNZZKD9OhEVb7uZ8OXUC1fFjwhXD22wqBKpBiAqYq5bL8pZ5yWOEzkyvqK3BqrdXI6p71Za+WtR6/Zs7zyMUT/p4PQ2bdCj+GYOwvVcm6LAwhOJVLh3LXKtSq0bfI8ojmTfPFn5cbobLF/sB7ZoNTqK/puGQ4E/fUNqs9ksvox2YDAUubeWonVM1niD7In8wr44mjLkuF9dARgjcVqa3j0ETibt9vXjzT2Z9NP3/7m/SUKQ0kPDn1E9LmcLNtMK/5ZZ7azIPD4bJeTKS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 15, 2024 at 09:38:42AM +1100, Alistair Popple wrote: > > +++ b/mm/migrate_device.c > > @@ -377,33 +377,33 @@ static unsigned long migrate_device_unmap(unsigned long *src_pfns, > > continue; > > } > > > > + folio = page_folio(page); > > Instead of open coding the migrate pfn to folio conversion I think we > should define a migrate_pfn_to_folio() and get rid of the intermediate > local variable. This would also allow a minor clean up to the final for > loop in migrate_device_unmap(). I think we should stop passing pfns into migrate_device_unmap(). Passing an array of folios would make more sense to every function involved, afaict. Maybe I overlooked something ... Also, have you had any thoughts on whether device memory is a type of folio like anon/file memory, or is it its own type?