From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F9B1C48BC3 for ; Wed, 14 Feb 2024 21:12:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E2A4A8D0013; Wed, 14 Feb 2024 16:12:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DB2D58D0001; Wed, 14 Feb 2024 16:12:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C05C28D0013; Wed, 14 Feb 2024 16:12:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AC3C48D0001 for ; Wed, 14 Feb 2024 16:12:54 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 36B6D1204F3 for ; Wed, 14 Feb 2024 21:12:54 +0000 (UTC) X-FDA: 81791659068.02.9CFD93A Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf14.hostedemail.com (Postfix) with ESMTP id E86CF100013 for ; Wed, 14 Feb 2024 21:12:50 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ZRTIFXNw; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=arGAyaHT; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ZRTIFXNw; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=arGAyaHT; spf=pass (imf14.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707945171; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F8wdY0YFKaKjOV8Tnp1nu+NBL4FYahcJXwydnW14Moc=; b=GF0VHRfWRmcNWSpO/q1oFQpN2jJad9VekP/YDXosQPXUzQTrNi1CLIdp8wisdBrDlrqQ0G m2k79pmjmdexzQMHiLzLDnOVDiVTpsBZ2ns0H8xRf7OjKgjpFre7T1hiFiX1E8wrfeLNNh jxa98hAu+2Zgkyps195b8r73Nj3wgGc= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ZRTIFXNw; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=arGAyaHT; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ZRTIFXNw; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=arGAyaHT; spf=pass (imf14.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707945171; a=rsa-sha256; cv=none; b=6flaqAaTSXIOMneKVOfmysVKhU3fIiHnwdneZenFzbSoTAPO5uATHWytkcpVx3fRvpVs6z EjtIbZ9DmXes968WVKUevaAIvDoW8rY/cXLGojHY4Jnl4cU5LTOYOTdkN0HJvGnO9NJzBe gHw46+w2lfvPlVLWxPYhzgvv/Cv6mdc= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0853F2200E; Wed, 14 Feb 2024 21:12:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707945169; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F8wdY0YFKaKjOV8Tnp1nu+NBL4FYahcJXwydnW14Moc=; b=ZRTIFXNwfOtwTZdKWQt1m+4Gej5esIMZqFEblSo3iUXIWBGnBUgcoxmq1V54hJPeOF8IiH +8WdmSNY9K6CelvrLRKw9RN1CoSGivKF8xkyxWC7dvboMMTmQWTYhjELxC2mRZg3BboEeD j7L0AWA3KTeS+C1lX7jOWnAK2q2xP0Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707945169; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F8wdY0YFKaKjOV8Tnp1nu+NBL4FYahcJXwydnW14Moc=; b=arGAyaHTPZWmvDdFeT/H33P/RCAeChCOGvezGpqce3gLz6KWz85yaZ1Fu9dMaEwJ0T1EU+ ZBPgxwPK6dFPqgAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707945169; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F8wdY0YFKaKjOV8Tnp1nu+NBL4FYahcJXwydnW14Moc=; b=ZRTIFXNwfOtwTZdKWQt1m+4Gej5esIMZqFEblSo3iUXIWBGnBUgcoxmq1V54hJPeOF8IiH +8WdmSNY9K6CelvrLRKw9RN1CoSGivKF8xkyxWC7dvboMMTmQWTYhjELxC2mRZg3BboEeD j7L0AWA3KTeS+C1lX7jOWnAK2q2xP0Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707945169; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F8wdY0YFKaKjOV8Tnp1nu+NBL4FYahcJXwydnW14Moc=; b=arGAyaHTPZWmvDdFeT/H33P/RCAeChCOGvezGpqce3gLz6KWz85yaZ1Fu9dMaEwJ0T1EU+ ZBPgxwPK6dFPqgAQ== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 2722513A0B; Wed, 14 Feb 2024 21:12:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id 6chtBtAszWXmYgAAn2gu4w (envelope-from ); Wed, 14 Feb 2024 21:12:48 +0000 Date: Wed, 14 Feb 2024 22:13:57 +0100 From: Oscar Salvador To: Byungchul Park Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, akpm@linux-foundation.org Subject: Re: [PATCH] sched/numa, mm: do not promote folios to nodes not set N_MEMORY Message-ID: References: <20240214035355.18335-1-byungchul@sk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240214035355.18335-1-byungchul@sk.com> X-Rspamd-Queue-Id: E86CF100013 X-Rspam-User: X-Stat-Signature: 11ptpb5ktqt4sekek5i8zkjinm8gnzk5 X-Rspamd-Server: rspam01 X-HE-Tag: 1707945170-323685 X-HE-Meta: U2FsdGVkX1+ZbsYurl1cBZqRjZgrJMaOB4JRTVgNbBOIjn1EHczUj4tfU8xQOTVGQaKVMF523Oyf7KB6hvc+iI+RMNBfpa5iww7y43+OYzQ+gsSNrYDjB73Ad3jHkB7iG+w0F2L+MJPi+q+H2sbNlVy32mCGxshkVegwsEb0Q83nsaVkpXBwfjAws+Ge0oXNjRlGfYc4vuFdFvspZRyMol5JfFt225wbzVEhLkpoRlEC5MK3/1+F4QP+lgUoP+a+20mDMRCE8huJ+qxesRrRUHU1XCyLDzkTjv0Dg3Fl5RjI6v2dj4SN+UhiTPJZ2MzJimpKH8tIvOscVTyqcveHNIHsuniY+2BSUc/wDqCh74OntXimr6CFlSP0iHwFvZ3zzjrgD+sr8pUTLfeRKV6zmI6+LZeW4zeuIwgFCz5svxscq64Pq9rWMKWuX1HW6OcozSROsiFH0v+7hp00dEll8Y4QFIeXm5qYV7HctoHkvgRHupCl+Az2esSKDVjo9cw5cpdKVF/Yu6nthAccFU0wMjMCha79q3ITVFMNH7/tnZGfgW+gQnIn8UiO8t4LWgh2r3cQH2QYz7vVRZKvdKWzy6wHDmHGh+n0Pm5UoAIJriy7kuk0Z7YuMZUmAJzBueFI/CE0sLepXlziyqDjw2cjGykIQU4ywuckybX3t9TQUukOyr4d7QCci4Ob6pdk19ozEAgZutnviAMUjfpuB5nDJEnKPzRo9jz+elEBfL6s+ncyVq6CjOMvJ2hef4CUOIftJxqeRj0rNc5lbtZXy2j21dnlcMXtrUJ16OWLgJMyCIQ8sv2qs85NXRoKXFFPQyJpfp+GBa2FiUV1juN9cX5zJ3vzGUd/vnFXVVCHbY/TRPD08DWON16e3mD20REgHdz4rYiLaUPX2CCEKQ5QoMy2Sh1Hl2bgyIZUNrh8NPGiE0HhqQPPzBAACwTqZTQFHWpXqh/WoPLQwMz1T8me42c qMcZELee A+1BJ6DbhqlVWMYFJ4BwtG2shvUD6YjltnhtlhW0MlF7bvfwo9z7e5oF/1RD24825cWDVNyrLaCx8YN6CM/UTJf75oBOdDlyZga/6nAC2TyEAtVt2zUPgOe5a9lTnsimfARGDDYcFYMwRUx1ovWujzEifcWjnf1YfHyEsFdBjXnPptsgMA477si3sAdKGluF1CIUIYM1EuDQUJlJm1y23jmc6k7vebIPcsfbm5JyYRWSHgqdFg/RVb6m8HM9Rm6Ky9nEnlFjKBISf7OsmuAhDW5bVYg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 14, 2024 at 12:53:55PM +0900, Byungchul Park wrote: > While running qemu with a configuration where some CPUs don't have their > local memory and with a kernel numa balancing on, the following oops has > been observed. It's because of null pointers of ->zone_pgdat of zones of > those nodes that are not initialized at booting time. So should avoid > nodes not set N_MEMORY from getting promoted. Looking at free_area_init(), we call free_area_init_node() for each node found on the system. And free_area_init_node()->free_area_init_core() inits all zones belonging to the system via zone_init_internals(). Now, I am not saying the check is wrong because we obviously do not want migrate memory to a memoryless node, but I am confused as to where we are crashing. -- Oscar Salvador SUSE Labs