From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E2DFC48BC3 for ; Wed, 14 Feb 2024 20:17:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AEA528D0017; Wed, 14 Feb 2024 15:17:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A9A7A8D0001; Wed, 14 Feb 2024 15:17:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 963A18D0017; Wed, 14 Feb 2024 15:17:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 85CF08D0001 for ; Wed, 14 Feb 2024 15:17:55 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5B1D280EE1 for ; Wed, 14 Feb 2024 20:17:55 +0000 (UTC) X-FDA: 81791520510.03.E04F368 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) by imf14.hostedemail.com (Postfix) with ESMTP id 96DD2100024 for ; Wed, 14 Feb 2024 20:17:53 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=M6ORzCX7; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of 38B_NZQoKCJkRHLKR3AF769HH9E7.5HFEBGNQ-FFDO35D.HK9@flex--yosryahmed.bounces.google.com designates 209.85.128.201 as permitted sender) smtp.mailfrom=38B_NZQoKCJkRHLKR3AF769HH9E7.5HFEBGNQ-FFDO35D.HK9@flex--yosryahmed.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707941873; a=rsa-sha256; cv=none; b=A5ygUKscgRwnb++iCtluZCx6/9hVATTx9Gn98Spy4F3u5fpxGYryotbW3NJ4JoX8BVUN7+ aamFNVSw3wETgVkL4Xbflj464g9a+mySChVnkkMuVpesgWSJ4wT17/03XNc/nF56wHc8Y4 Z1OBoRJ6o6kqkHqdr7893fFb7XGBIVI= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=M6ORzCX7; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of 38B_NZQoKCJkRHLKR3AF769HH9E7.5HFEBGNQ-FFDO35D.HK9@flex--yosryahmed.bounces.google.com designates 209.85.128.201 as permitted sender) smtp.mailfrom=38B_NZQoKCJkRHLKR3AF769HH9E7.5HFEBGNQ-FFDO35D.HK9@flex--yosryahmed.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707941873; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DFRgEJKqx8IUK/onZJk4TNjtYloWEJQ2VMeYiwjP0ZI=; b=qE2n17p57pJSLsOt7YVSKL6M/O3K1w9GT/rtCdTP1JPdqUWHObbonGbCTY16/v3MDhhQgr KVthwBZ4hQgq6pKSz9wuVeGIUR5teVUeQdVwFE4p+jYziyt6PRB2Kq5FF5XNWVPdjnrUap 4YWeMS7v0bJCJF4bE7hWlvkkkUPMwOY= Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-607b3038b3fso2170267b3.2 for ; Wed, 14 Feb 2024 12:17:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707941872; x=1708546672; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=DFRgEJKqx8IUK/onZJk4TNjtYloWEJQ2VMeYiwjP0ZI=; b=M6ORzCX72bgWulvdoeGrWfP+pC477ri1PvZWkQLK/psUHtM+s7uUQIFWGXw5j+sjA8 k7iTLXZFofDAt3egrGzdyPuNotwEAg3m+X/8P3mCls/HMkzLTdRvDkwY3ygXOh60tLlc yfU4Q77zJKpUpAvw5e1nElcaFb/eSRq+1J/FNjAWBMy/gpVKQMyryFFXkT0TbqGI/w/q 1koI0beLbkOTY+xcXTW6J2wA1B+Ji56sTKSkD0fU4jS84507/a61VBmja9h9pcQmY4l5 w/hRBzEG7BpAjLsBDwv5JBR2j/4oamfveCYE397x8WafYSSLrQdFx8mbV4H+r2iwLoqe Fgyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707941872; x=1708546672; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DFRgEJKqx8IUK/onZJk4TNjtYloWEJQ2VMeYiwjP0ZI=; b=G5zcR4fjipybvYozh/WkTvFHSZkav3CVnTNcCJUBeMCggodT+dBvIARr+pgdGBeNoE H6FuZrAyRXiiJ6NN0xgpcCNBGG3ZjSfoZWnqhPEyHhK3hiCuyQdJ7klRWiwktKv971Bu LZ/7MKwJ3zM/nuL4B9jTJ4T3b4yepb8QBjlgFmyNcBKgc7wtxea00N+xVFYPYj5DNDnx wZS7+c4u4RAarY9c1zo47V1fDxOzaha5cvOYCLa11Q+Q1xO6IZHpBTwE6asHu8JKKjDw KHpfXYKTE8a4e6/zUaV5NsOSVYT49uQxuiydkQMGY2dS2W0L8AiWelzeg5XKzdFLGDbn dURg== X-Forwarded-Encrypted: i=1; AJvYcCWa2NxmJb0m7ByeX/3mChi4gPO6J/GKGLXCxQL+8wkqH4Qp1UlF2JF0P54c/oKbzvcOQpvxkxBH7QerlvqA1SMZpoA= X-Gm-Message-State: AOJu0Yx9f3mQMGcMJVgqt7mIGEztV+Cny8guroNsOqBfV6ml5mA0p9yq YJLGthdHIC22jZyJQh+o6jE/FW9MD3z1NGuCuDx2QfULsS28QYxLOqhnPWgqJfYIs+7kFEdXtzB pk3DAv50GVwrBzAVCvA== X-Google-Smtp-Source: AGHT+IEEh8/ECloTKF61F6HKam49RgeIZc46jcrBkT8h5W2oQ9+AR1Ak+1Ihvk+tliAKuf+Xfoj/5sdOnEOLcBzz X-Received: from yosry.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:29b4]) (user=yosryahmed job=sendgmr) by 2002:a0d:eac3:0:b0:5ff:b07b:fb83 with SMTP id t186-20020a0deac3000000b005ffb07bfb83mr555354ywe.4.1707941872610; Wed, 14 Feb 2024 12:17:52 -0800 (PST) Date: Wed, 14 Feb 2024 20:17:50 +0000 In-Reply-To: Mime-Version: 1.0 References: <20240212213922.783301-1-surenb@google.com> <4f24986587b53be3f9ece187a3105774eb27c12f.camel@linux.intel.com> Message-ID: Subject: Re: [PATCH v3 00/35] Memory allocation profiling From: Yosry Ahmed To: Suren Baghdasaryan Cc: Tim Chen , akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="us-ascii" X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 96DD2100024 X-Stat-Signature: a7az3u3ctf7jj7y489yk7zswkx64naye X-HE-Tag: 1707941873-374394 X-HE-Meta: U2FsdGVkX18J93C4mksqQbbIo/t/oGGle2QlXwM+lLErdRMZQC9kKGLvvxyn9grGLyYqFUsF6SGmVcNAU0EG2NhgXtcgw2hN2NBFWxnbOf93rhqWYgB8r2Oz6TzrurYdW0LyiN8UTtr1JVcmWLZGAtAlx5ksEly0DF+xjVsl65kPwd9CCWuwJvHZ+2Cru4vDYWdzAAmuGKhFt5HfGuN6Q8v1b//xLOhb9HIe+IBuJwA604Yju4iL8iCMKaZENYVbtCxZbHGRjs01g7CIa6UJt5dZ2qWNRYQeE819ROl7/Ta4proc2JbJYyKkoZQeW5eC5ke4uPGSeLXi6bclaOM8G5vETR5je/6eeqw2ksZoChaMiGnJ857U6lEGDUYMJyWnHxZcm5NFkq/BpbxCes5YW3KJljgzn3DQgCj9VjIBxNdRuUkDrQjvcQ0ZNublp+N+OAnuuQLfLlC9+o8YFGAk+aXzZ4QTOLM3d/e5qlPBcVG8FJwKqbfbDgPOIq1/eWoLWb5CAdJgCtVwGk2pg7X9kAixVDfxYt+1U5ZIsiOLnZGCZaNrN++awWUXEREmf35CnljK/PadR5vkKql4Zgelhzp/v7n1CkwID+5QGy5ZHMV+6vhWoS6u75iBTCxBmHt6g0r2alA6jtICnXrLo/ch+h3EggglNPBZsDxpQZ44MFS48Ttryb8uewI8kFshRF8A++uYRkz39NomQIMsGvPt52wlbOx7bS2tun193XdqTRu3t531TactgN55QfG4U1PA/5B7gYDUPfkWz5HyM69lI7jVNApFKICuSB045rG2fCrnZeS0OkdiCQOik5a5RM6WRUjInCZ123XxiUtgLlp3j3na9rnsaqUEyIx7k4pyXOKYrQwwiDzH3UrKtMfBzO1s+vOi/fmCaMVrN5yuVvV2dEdB9zL8ttH784ejB8DvjqMxzU7g+RJK9cUHemrQ0RPOp78ivM/SX+vJBE/FtVt 5scKsQAb uGRia32ZEAuSCUXW9n3cZT4sxLWxGwJxZDFBYPhF/faFSYylz5FV7zXmlC0KRepIo5UwHhicy5swMGtWfDC5szfoUPDjkaHvEV0yRBFkE8U0VCUcP91hkK60qV29H2MHNAop2+GsYGADS5DXaQQxxxHQklBghGy808r0y0plWFCBuMeV4oUn6gkUyx6Jv6gIFFnvBZn5LHfrxWidJrQySJH0BsFg+9z695uYGLfl30W50k8yK6RGLyofhiLrSL5MmGHu0y2MS2GGU4u2vnFkkSkLmA41JxUU/pF3bg+Tpdtu438Y8UnRpd/axBa1jWI8FkIdpv4nc6GLMGiEujRzzS3RRcYFBQH32v6Y+VzIAmiFSww98LR7OeAvBhpGg3fWsLvw9LNOGnVFnIhc2HWfbUSmDlweIvnIP/3QXvX2k8r/J9paPIj/UWRelydMfjy9z5fp1WtIhnryHup+St8IyOQQf2L3FqjboFUDdj3xmEVMM4yZxHMzQyD/LVVaxYuvj2HyOtgxP1pqD1I5ve36C/WEhS+MGk/xFTTnR+1S0ldlLNc0QR26MS4CFqqW+3DoY4OOgTsN+TvwA/sVKGVWHEl+i0eJpBsb+RCjZjg4W3trO9RgSrr1sGjMXC+BYQp/yHya45Y8H2U5nf5w6UJNmTl5IAgjd/i9El9xuir2SvNMld9q+BscMUyI67w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > > Performance overhead: > > > To evaluate performance we implemented an in-kernel test executing > > > multiple get_free_page/free_page and kmalloc/kfree calls with allocation > > > sizes growing from 8 to 240 bytes with CPU frequency set to max and CPU > > > affinity set to a specific CPU to minimize the noise. Below are results > > > from running the test on Ubuntu 22.04.2 LTS with 6.8.0-rc1 kernel on > > > 56 core Intel Xeon: > > > > > > kmalloc pgalloc > > > (1 baseline) 6.764s 16.902s > > > (2 default disabled) 6.793s (+0.43%) 17.007s (+0.62%) > > > (3 default enabled) 7.197s (+6.40%) 23.666s (+40.02%) > > > (4 runtime enabled) 7.405s (+9.48%) 23.901s (+41.41%) > > > (5 memcg) 13.388s (+97.94%) 48.460s (+186.71%) > > (6 default disabled+memcg) 13.332s (+97.10%) 48.105s (+184.61%) > (7 default enabled+memcg) 13.446s (+98.78%) 54.963s (+225.18%) I think these numbers are very interesting for folks that already use memcg. Specifically, the difference between 6 & 7, which seems to be ~0.85% and ~14.25%. IIUC, this means that the extra overhead is relatively much lower if someone is already using memcgs. > > (6) shows a bit better performance than (5) but it's probably noise. I > would expect them to be roughly the same. Hope this helps. > > > > > > > >