From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D4EDC48BC1 for ; Wed, 14 Feb 2024 18:50:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C5BA18D0013; Wed, 14 Feb 2024 13:50:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BE6448D0001; Wed, 14 Feb 2024 13:50:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AAB278D0013; Wed, 14 Feb 2024 13:50:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 97E598D0001 for ; Wed, 14 Feb 2024 13:50:04 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 45D5F806EB for ; Wed, 14 Feb 2024 18:50:04 +0000 (UTC) X-FDA: 81791299128.09.380A0A6 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id 1DFB6100013 for ; Wed, 14 Feb 2024 18:49:58 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=OvyXhtJ8; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707936599; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0KOsHR0mivN1ZZPk/2uGmtXwkoKyWymL79tieqRNs30=; b=IEfdZFowVtl6RsB/Z7GrtYCV60k3Adyn9RKedVUIyqGg1rzIkf01+Xv8UoV0tJpvRNBsV5 9k57wyOKHI/BjFT/Hki6Rl0rDam5vVpY+w1Qh0mLDzIyIweK2qldEOk9ZFC5PAtPXOb0Ww 1JsdxQj2xuZmPn+4PYK3x5CBR5In1+w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707936599; a=rsa-sha256; cv=none; b=DRtef9reh3O51iztR+fkLmwuZjzPGq6QHdQurPwHiU5L9popU1U4/cGh9hkuQh686CrlXh /+Dm40Xk3oBpdhELr5p897oLsSXTLNby3yRgsRgXQClegrlSwxo5wLIshisq3JfLhcvKk6 TBWEZDSmXS1IYmXQRAn8YE40QaNpW3U= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=OvyXhtJ8; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0KOsHR0mivN1ZZPk/2uGmtXwkoKyWymL79tieqRNs30=; b=OvyXhtJ8mQgx4SgxaUeo7jx9L4 bjPJWNX+T7lTnlXe/fI6JNH3/RIBdDr1g2KQNWbeblnK1FMIf5ZtSM6Y35/vtq8XdW4bld4YqAune mmIuNNz/a9ISDWOwrCc1fJ/MoFgbbE8Fl8sTaU3v58DBQsVo+IU58Lcmvsw3jMMzXkTOrOZZ80hXR BvLXvH+4XHO8oaiaC7ALXQhUU2OTz9jJnaU2xcAvKzuX5/ke82xeUcmPHaa7HS4QdJaEm6kZgCn+R p74VQqWy8sZv/9g+3ejyqe/ugYMLllAZQi3jFyq9CHL0JXL//stNzydkLuK2+14+CcN90N4+tGFNP jdB6FYjQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1raKKL-0000000HKRe-3RpX; Wed, 14 Feb 2024 18:49:49 +0000 Date: Wed, 14 Feb 2024 18:49:49 +0000 From: Matthew Wilcox To: "Pankaj Raghav (Samsung)" Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, mcgrof@kernel.org, gost.dev@samsung.com, akpm@linux-foundation.org, kbusch@kernel.org, djwong@kernel.org, chandan.babu@oracle.com, p.raghav@samsung.com, linux-kernel@vger.kernel.org, hare@suse.de, linux-mm@kvack.org, david@fromorbit.com Subject: Re: [RFC v2 01/14] fs: Allow fine-grained control of folio sizes Message-ID: References: <20240213093713.1753368-1-kernel@pankajraghav.com> <20240213093713.1753368-2-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240213093713.1753368-2-kernel@pankajraghav.com> X-Stat-Signature: xngxejwz7xfgw5bie6un11jb6dahn15y X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 1DFB6100013 X-Rspam-User: X-HE-Tag: 1707936598-941961 X-HE-Meta: U2FsdGVkX18/o9dJNFUbPKrtQDh5sREGY4jFO7NnDIcIX9i6TUypl7TwWlIGwH75TWch7yMLAIukTZx6SvWYtXzcDvRQR7jE3xaecwl5wm5p6Z+eUlfSINV2cB4EB7I34ZdR0/sy00UUrQJsGJ1afSzv4sq9dvNsuKdU8Gz/p8ukQijeHM1kUZZifgc/hvwGfqrYSY8LGJi9MeK6akiO6NK5QeIA6igeBDy05QDCbOpwEzZBknSE7Y1VBFIRR3a5JhS9DnASgV8YuuhlvJ9EQ1948hEJB2zw2NekniKnshvLNBGJvwGR7Mo09bj9Yk3FB5HKncouWg8MbOdDPhhn1COHb3hF54YFtOu2/88G8X/WTZVYmZv3BPxsUPCw+9wPjr1C3jpb6zdrNw2DqUqGVno/bhjwRZfRstUmzFUfFUlwtjfm6YD7y4ooRey93NdAx7cke9E18tBsWmxJceKO3Ygc8qyZ0xNHcm+wsFBRTsOrIfr+TzjUtH6933NPbCOkaV6CzVkvjZHw1P8l7RJdb5tflayldY42UvLR0t798Tt5Owm4SoQraBdKg/6vxr3BIf1X5b7fhNX7j4aJiRutaiO4TClIK/iOt+DzXFSA9iuImubaFwG8uI5DpaIwBBwT/VhDsxigjvITDrFsX7GX3LfQd7JmPXXbPl9GPfB+mDBXCG6uuCpatOELL5tOsmaUmdlwHB7KTUYjUvk3z0hXPWRCSG8UD4Wk40OS1tx6TD/TWeEBLt9o56GaoaZomTNR7ULBsS0TGmthcUXq2VlLsO3K+IuFqVRY0k79B2ZjVGQQkZssqOtpj1NtioD0X15J3r8Y60/KPPGqWALOcSn9yRxR3/ryATvGZcAIUyXGCvCL8vxKq5iBIjtr+f2mqu/yXHTnv+RWmSgxEJQPYh/2o52UyMYeUx9VM4Ws70DHagtNcb5TpU9AmSmIi1YMm2+2ZRnDbLCpPkFDOEgg9/c MAMBGfhW 1zRtnTPzBooEZgLJzuYpX+3PO8nUe9IX1bzX8ZaFqcEVJOJiifx8hpWtKqy1Q1plTx1pFA2bJTIbZ95Pd18xO7B9IeGKAYdgGR/3eJ+CQ28qaMf/JtQooFDHaomx1cZh7rouo4lkh6K1/eeQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 13, 2024 at 10:37:00AM +0100, Pankaj Raghav (Samsung) wrote: > +static inline void mapping_set_folio_orders(struct address_space *mapping, > + unsigned int min, unsigned int max) > +{ > + if (min == 1) > + min = 2; If you order the "support order-1 folios" patch first, you can drop these two lines. > +static inline unsigned int mapping_min_folio_nrpages(struct address_space *mapping) I'm not sure if you need this, but it should return unsigned long, not unsigned int. With 64KiB pages on Arm, a PMD page is 512MiB (order 13) and a PUD page will be order 26, which is far too close to 2^32 for my comfort.