From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C978BC48BC4 for ; Fri, 16 Feb 2024 17:18:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5FF446B0088; Fri, 16 Feb 2024 12:18:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5AFF36B008A; Fri, 16 Feb 2024 12:18:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 450696B008C; Fri, 16 Feb 2024 12:18:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 325A56B0088 for ; Fri, 16 Feb 2024 12:18:19 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A10161A027D for ; Fri, 16 Feb 2024 17:18:18 +0000 (UTC) X-FDA: 81798325476.18.EE0F819 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by imf07.hostedemail.com (Postfix) with ESMTP id 91EB04001F for ; Fri, 16 Feb 2024 17:18:16 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=NQTOabE5; spf=pass (imf07.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708103896; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wPLwlhY91L9qTZWCNsWjRuWkNsJGX2gH26bhSLROSnI=; b=6kccV3B5tK0WdfRua7eZJztoytgTDR8BAl34JrT6yxvcnllLYteA4S+XShRQzJOTFERVu7 kQH2EFySDTzm4T6hv7ML5D0mQ5X13UnbIMXn+zK10x4/d1+kborXNym8iGHoozxFZCqDpH BHo3prytzJ1T1LSn/cyKKFnAA/YR79A= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708103896; a=rsa-sha256; cv=none; b=LYWZF/OavXeawmMuihFswnljgSRAgmDLXCR5YKT/TkJkYjejqZ2HusOrbxjfIrbC19Czcp GNFJTrLxhHw+VXeGkcOSJcDMxcOXuZM4T0xUP9JPaYOsd1klkpmkcmd8XliOK5CJTd5aq6 fIVyWAA5Cb1lze9PIlFoPoK9YsBVlHA= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=NQTOabE5; spf=pass (imf07.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-511a04c837bso2724008e87.0 for ; Fri, 16 Feb 2024 09:18:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708103895; x=1708708695; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from:from:to :cc:subject:date:message-id:reply-to; bh=wPLwlhY91L9qTZWCNsWjRuWkNsJGX2gH26bhSLROSnI=; b=NQTOabE5FJr63O6Xy6OF+zF0MmBveTUXe/Jwvl+lH96Vb8dZ9cwhXrOTtt+r+3zgrj eUYrjFJl8DfouN3bLLVtO/7y/TgqRaudrRIy4S8lj+jDzbjcocWqymavO/CeV3S+cfZ2 8VZa4b7SDiH8To2DykrnaF7JXZqNaDyOMMKV4Em31MXrPhvzAAcYDfEvJFYjicgxGXN3 WLIIyOdEcjSz+9N0/ozoytWhjPPc50NvEZn3lhWCL8bHItWzVWPErPgp1unz/907NKHH ps0ezi8tAUYROHrpCBfmURnmFfo1o0YVik1WGCNrxWDLxkF0Mk5wQ7o9JCaSSK/NrEcA FxvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708103895; x=1708708695; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wPLwlhY91L9qTZWCNsWjRuWkNsJGX2gH26bhSLROSnI=; b=osGMPXZDLZjCRMSbk00RNFNHUPu3T/btAH8sz+IClAvg+kTrvQv7GOhZMvFGFO2VTw qS55F4hf8ifvAimmfmtVf70DFMGq1JHMoy9y0Z0kibbTULQj4e9UGNFhE/xh2n7CvaE+ 9DPMyFtEEhTGvKEcDFZxSqhkA8T7yeqJX4pFzjKLNX4CDhzwzoN1RqRbpg3JY+DsTh3n xHAkq6OKWjjwrSVFxQIcnvjBNP+M74/OsgEU9zX7GmseEpb4JEZkLK8zLtZwknx0u5SL 3zVof6/L0Pa7eMVvqnNOR7C3Kg6cwEP+RUyZnNct2SUx/kilDXpfwnlMkkGXURoBsnwv mVNA== X-Forwarded-Encrypted: i=1; AJvYcCXbXfkRN5ztrwqHAXIuOnGZnMChbYNuSkK2nU0Nec9N57tYtGQGbuJeMdpISefDfoHmsfDbUrXiVH1GNyWUJJU7c1I= X-Gm-Message-State: AOJu0YwMwFoCpqB1+1IIRk7/UVBmUa6sYBetdL+qtzqoCUPA2VwU4tzw 6g7VZsFw8P9x3mFCRC84Fj2XftoSTIc1iwpQNhnAwEZUiAxVkBVL X-Google-Smtp-Source: AGHT+IHv5z/KYz8K59TvIWSRmnoqhh/KI/68YnUgWMsLNgswIXXm4noNopRENorEe9kCplMhz+wWWw== X-Received: by 2002:ac2:4e81:0:b0:512:8777:1f3e with SMTP id o1-20020ac24e81000000b0051287771f3emr3390823lfr.43.1708103894460; Fri, 16 Feb 2024 09:18:14 -0800 (PST) Received: from pc636 (host-90-235-18-79.mobileonline.telia.com. [90.235.18.79]) by smtp.gmail.com with ESMTPSA id v7-20020a197407000000b005128c3561b4sm23519lfe.13.2024.02.16.09.18.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Feb 2024 09:18:13 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Fri, 16 Feb 2024 18:18:11 +0100 To: Alexei Starovoitov Cc: Christoph Hellwig , Linus Torvalds , bpf , Daniel Borkmann , Andrii Nakryiko , Kumar Kartikeya Dwivedi , Eddy Z , Tejun Heo , Barret Rhoden , Johannes Weiner , Lorenzo Stoakes , Andrew Morton , Uladzislau Rezki , linux-mm , Kernel Team Subject: Re: [PATCH v2 bpf-next 04/20] mm: Expose vmap_pages_range() to the rest of the kernel. Message-ID: References: <20240209040608.98927-1-alexei.starovoitov@gmail.com> <20240209040608.98927-5-alexei.starovoitov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 91EB04001F X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 365h7cbpejxibgyzxnfrz6xxtpwojz76 X-HE-Tag: 1708103896-706562 X-HE-Meta: U2FsdGVkX1/7e+6YBlxd+xE3nyF5P5Z/b7pn7fh/xgPZRVADCuL9B2f7e5o2zLgRxy7GacLzqrsQpBvT7oXU207+nWk96fm6ZKdC+biVdGP+EWfFjEoOLhtfDK7x4AlBmDYJLzaRZQM7y+XABqbcUGmiXwtfPCop1SxKK3mDhIWN8lXoKvh8cjRzC8wyPKkkB7JTeSDuK1iozjfrEC2YtIl17ctFg/xnH/PyE6ew+XVPGrt0KLYDcDj7WqiOdDojUg9wrM8TftnEydSRgw6wsNw1yT22zZ5gwpANmugMUnm8g4tLXPCMmJqocCXbP2IBsrXX5qatOPbXJkV138mnmbz0UTqkwKVJo5WhGrL8f//ivTAUrgq4LOTzDBrcqE/jJ46VAraJSDqoXJechRFsohGF0hlYwnzabCmL9AoV0ie1t5j92yxfaWkPurzHYhS6t7blI7KqufzvytP1coY1RT42e45vBdkg/PWe5nuW2BB+VQXHcW8z46V4eM+P1nB/SjjB1TA6te6SaAvHSFCWthlnlyaZCjpVxcPwxKh+jGECeHoE8vk54Y2jBktZ/YseMS8vyhxTbbBxNF1rWF7GWyHz6g4vdlTZ5Iq9ITUoeXA9UsFTPCX2NwFUPW4xZBlH7AbTb2CCwQ8p1iJGM1/jdHpyqp8jwePNB/BVIWfxWp133OmnXDP9CYl7lIg6qkm1GMgrKsbaQEbJReuIHgffApzx79Q7vHdDF6WmzfkdnyNjpoShnm2yQI2la91BFBaYwx6xPzPG4aNOA8zJSiCNjGc50SKtIKUj47wE3vBMPqH+tnX1/2TwNVuapH++CuFxNHaB6ormudd8kgY51jcp8w0mbGyXRD5qtCrwRS7Pve7LAhGF2RQHjFgD32DAWZ8zHnWsjSk6b5L8zGEM3eP1/vryJyTiYgcfO5/blLtna40tk81kWa330pJEwkUgxLYNEJ6cJNC8HSWK12vc0UW 4UKQpBE/ dlEIy6mh832AC1GKgLoStESrd/Z9WlkWR+VoGFjh7NOM4ZLXin805hriECPvrAY3+EauKZ20e9F+DfUxd50xe3C6vFbUIYd454y8nfHKLTpoBA1L5akx6cCOVJZkN5xrIEvt+PsoG+4dm64ra4phZXFkl4rI6tQGFpsyfQpm4WOyW2eiVkewBnVOYJ2zSbdK+F1rd0ueQ66aIkH5cD1giKEbZrK4P1BBPeuaEOxMIGRcrGXL45fF0HphBUW852XHpfYzodFRBym+DMNzDpL0FfOcDpr+VNuhjAK2UqUK1fn4c5uDHEY0u6pGlu6HrzxWmL2YJoNH06xlh2Idn6EU5/HBs4ev/Nf7iWu5P2GxvV3q7Bld/xZnSzx/BT9Af+DEXzGiE8H3HmLPQfHDE1oHm8ulSfwSimgLTaO6DjIIUi1SNDfLNcKnJrle3UDnPcI52S6CvmsrNgTFyusFa4NX1UkiAkb2qCtVgOS9CyK/O3TtWNqtAmLCA68ipbk+BRXQnZX8/n5WCEWrNWrTLjkxohsgVRss7QCqvMHMGPylfeBX8M1bwVeo2TQ9WRMz0l0Gi2qXaV+WisMw38eKrH67YkhUUh/lFo2NyzV15vZos4KO4Ay7tWI/YKy/Pyg/GeLAaZBjV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 16, 2024 at 08:54:08AM -0800, Alexei Starovoitov wrote: > On Fri, Feb 16, 2024 at 1:31 AM Christoph Hellwig wrote: > > > > On Thu, Feb 15, 2024 at 12:50:55PM -0800, Alexei Starovoitov wrote: > > > So, since apply_to_page_range() is available to the kernel > > > (xen, gpu, kasan, etc) then I see no reason why > > > vmap_pages_range() shouldn't be available as well, since: > > > > In case it wasn't clear before: apply_to_page_range is a bad API to > > be exported. We've been working on removing it but it stalled. > > Exposing something that allows a module to change arbitrary page table > > bits is not a good idea. > > I never said that that module should do that. > > > Please take a step back and think of how to expose a vmalloc like > > allocation that grows only when used as a proper abstraction. I could > > actually think of various other uses for it. > > "vmalloc like allocation that grows" is not what I'm after. > I need 4G+guard region at the start. > Please read my earlier email and reply to my questions and api proposals. > Replying to half of the sentence, and out of context, is not a > productive discussion. > 1. The concern here is that this interface, which you would like to add, exposes the "addr", "end" to upper layer, so fake values can easily be passed to vmap internals. 2. Other users can start using this API/function which is hidden now and is not supposed to be used outside of vmap code. Because it is a static helper. 3. It opens new dependencies which we would like to avoid. As a second step someone wants to dump "such region(4G+guard region)" over vmallocifo to see what is mapped what requires a certain tracking. -- Uladzislau Rezki