From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49157C48260 for ; Fri, 16 Feb 2024 19:36:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 706876B008A; Fri, 16 Feb 2024 14:36:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 68F506B008C; Fri, 16 Feb 2024 14:36:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 508976B0092; Fri, 16 Feb 2024 14:36:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3AA796B008A for ; Fri, 16 Feb 2024 14:36:35 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A8FC1A0210 for ; Fri, 16 Feb 2024 19:36:34 +0000 (UTC) X-FDA: 81798673908.17.5E310C1 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) by imf06.hostedemail.com (Postfix) with ESMTP id DB0FF180018 for ; Fri, 16 Feb 2024 19:36:31 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=wnSHTqxB; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of 3PrnPZQoKCCUZPTSZBINFEHPPHMF.DPNMJOVY-NNLWBDL.PSH@flex--yosryahmed.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3PrnPZQoKCCUZPTSZBINFEHPPHMF.DPNMJOVY-NNLWBDL.PSH@flex--yosryahmed.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708112191; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lfgjHKYjHP2121FLeMU5tIKbfb7QyfojO45shr+5tbw=; b=aSTootYPxD08Jlhg3OawwDb9uKYsu206x7Otc1qWCBPCz/H0SWNtkzHmrRcEPkItSHDMYp JDSEtOXfHbzRBY/FFCv/RmAMNqnl11qrlRR2xo+w33IEI0ofVMxpUs8eOmxiFa32ba1268 4YLep+yGyrU0FPHcX9KI0vEZTmpN4XQ= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=wnSHTqxB; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of 3PrnPZQoKCCUZPTSZBINFEHPPHMF.DPNMJOVY-NNLWBDL.PSH@flex--yosryahmed.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3PrnPZQoKCCUZPTSZBINFEHPPHMF.DPNMJOVY-NNLWBDL.PSH@flex--yosryahmed.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708112191; a=rsa-sha256; cv=none; b=2opEjHGhh/i0yZG/KrMFgcK+ZFyflpMkjEHjt8VM6YvtA0K0nHTsJ8Qzw9DYYn1p7u0pPb SauT6jzE5gIG0lewlGBd6ov3jR8Oz2NNRyOpB3BcPuGmim5vXiflXXCM42cmnXzwNVgm3g R/BQQLS1kJ3c8mXJsWpvSizPU2CTg7M= Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-dcbee93a3e1so1626645276.3 for ; Fri, 16 Feb 2024 11:36:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708112191; x=1708716991; darn=kvack.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=lfgjHKYjHP2121FLeMU5tIKbfb7QyfojO45shr+5tbw=; b=wnSHTqxBmiX4CffoWL7oD5PTntPdhuoo3hGqNYvVxbiMa0LI/HK924Kd1cS7ApTYWj T1OMuORIctrgc6PukHixxWfk6PyiUVXKvcfC+xTkvenDg5R3YSoR9RwjMExMBsdFFDl6 yx2aaI+kO67gVNxY83gOT6DOOkaTSHLgxg81zakrPYJ1MwT2pZXYdCeBMCV+XjxdZig2 thkFBYk1hbd6AiuvQqrtywh/GdKCOjjwIAjV96xyKO9Y35EWMjs6o9QbLnJz0pXFLdqX PDdug6gxp5g2UyHasykYrNN+wNwEGK38U9v+eOl+sbhqsD/nbhbKUlP+tYy7OK3ejFYk mwLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708112191; x=1708716991; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=lfgjHKYjHP2121FLeMU5tIKbfb7QyfojO45shr+5tbw=; b=WUDQBidBeT1AQJKNuMQf8uy49CfPlxQCXuQbEPElLYUrU6ztHX1ih+p91u3owm/wAY a2rhrOA8oAPG1X7wIDfpS39JBqhrTcqS51nGV8aHDgDSvK30nzd9VCVZR90LqK9KjfiF 4o58+6oBAz5cEQSJ4J3YVZv1rGQhfZH8pE+xer+6RxnkC/d3mFZtJeeJFthDvClr9S5Z EOJ1Knmeem2txldcX7Wgkp1gx2Xu9D/+Ve1LJZs9mQg7t20XSQ2mZd3vZ6VKT5E2ZS0o CSyqloB2wumUBGzpRwMRiajnsq50o/ROofmC7Rxn6VZo2ToLRPZNh1h14i1PDKtCdMdl eulg== X-Forwarded-Encrypted: i=1; AJvYcCVuezYF0DH8ozrnyFygkoJehsWU6GmiPmWEkOE6WY8vAR7K0vE6ZZyF8Fq+pQ0gOvmMpHiNKRPryc2EpUfEeyGQlQY= X-Gm-Message-State: AOJu0YwhIJGDU078GMmEurdA4p9tqfXHWwD/66/ClggYl7p+piOrvLnZ GQBDwTyVSYgBPnIjM8/fEQHWvKx5cPZb8wdNmY25YL5XiHSps3mjKTB7gEfDlcmMy7dO2r8KLfT 2napHLZVJItBDL3/m3Q== X-Google-Smtp-Source: AGHT+IGkoSHjnXot+loB1N5ZuNRt5N8VxUGJ6/UFaoxop8ccs97PBa1BIdb79SyTS7sUrIplfqaWWprqqLC4kVNf X-Received: from yosry.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:29b4]) (user=yosryahmed job=sendgmr) by 2002:a05:6902:1504:b0:dcc:8be2:7cb0 with SMTP id q4-20020a056902150400b00dcc8be27cb0mr351960ybu.0.1708112190960; Fri, 16 Feb 2024 11:36:30 -0800 (PST) Date: Fri, 16 Feb 2024 19:36:29 +0000 In-Reply-To: Mime-Version: 1.0 References: <20240216040815.114202-1-21cnbao@gmail.com> <20240216040815.114202-3-21cnbao@gmail.com> Message-ID: Subject: Re: [PATCH v2 2/3] mm/zswap: remove the memcpy if acomp is not sleepable From: Yosry Ahmed To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, davem@davemloft.net, hannes@cmpxchg.org, herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org, linux-mm@kvack.org, nphamcs@gmail.com, zhouchengming@bytedance.com, chriscli@google.com, chrisl@kernel.org, ddstreet@ieee.org, linux-kernel@vger.kernel.org, sjenning@redhat.com, vitaly.wool@konsulko.com, Barry Song Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: DB0FF180018 X-Stat-Signature: 9cd55jj95fsrn9ycdenwy3nhxod8smnq X-Rspam-User: X-HE-Tag: 1708112191-431891 X-HE-Meta: U2FsdGVkX1/gAwCX/jVAjqIBY+yvPNY50Frw0ktnW6rokqqxCI3OiHllsdwNtTc+INUETkIa6okdELcp3BeOLjHkZCsTJOE5gEwpDck/UXUzCyVfnyUY9tgPlZ94i2Y0OgRGYq45Ab8rHl1Vnwy+G1PIAmvRpT1lyG+8+WYipJWLBwYmi1smz7otpsgGYumdBMYZO2OQfhBOTqR1jIomP/qdg4YHFJx9Zoez8986ccamIvFP3FCOskObiDdpjvjyEMnRtLpyfn934cx6Ns7E/dzCBthNeg76PoaFY7sU4DwN2F1Si4CoIFecl0ZBlbA+tDGa1mfxXCZ3qgK6XuRKcIXhJSGH0uxswkJhicYY1/L8+dmChddzgRkUeIR/NKJp9CtQZdMWZFx/aRGkoRxNmydT0Uc3JXkmH26dmmd/vl9FGSo+a8nkksL+HP7VzVDb62xGjBriT5349vqAth88qUDoRTh298S6rQZ7tIyN/7uzumF745ycQdsARISN30IKoE7PxonGwEanGggdUoQpjrms0HWi213I9b9ETO1WuNYe5PoPsH48/82lyhUyhxVZKdk5+IAIPHrjhBKbREbWVCXXugVL/ROLP7lUC4wL7gPVo3fYhnnTShvHqfcOn5UhjGDgEFLf0pKYWaVDRCSYbXR4O5ajcvWkd9bOMq2SNvKpNaare9kv+HA7mXcw6MNnTrCdtjuQCWL3bN4SuYbtgxwJMfZD4mC20bZucDpI53l5gfk8PQpbRJ+/F27XsxnyLpmAsqkCjfhr11RIcb1cMT5694unn5MLkgeL9rIk1TfZCDlHgOHV+vhImFqlnvxKjIQ2lt+S5M1IiHlnseer94YPCE74l2s4rPMBIJ1kYU/OIg+3F+Hshh1q90kS+GEWT3kRMARECgE42g75khLiD+AQVnqbfuF1v7+m7n/VzvFzPCUAaKb9PTN9uJvY/14IUWiZYRL7m1OzImJj34S CerzWiVN 2eesSHFPaGvvoMN+hxWH80d8NpeV2u1cZtZwy5wANxEtDDGIg9LhDuapEyWh1ECxslBiT/oGIoi4IT1Y63e5uud7AGSDJvgfxZWbY20D6vTYv1RltODo8tuxBBdnakdI14fNrS9VfJ4rbwAdXJVfxVgF9gPjwrDUPCWv+rLoOwemSO+W/3qDeVbR3YL5+BDD1V3/OFFZ9ZauGbuVZzRyLn1s8RIwomr/IKbxLz+yQcrxe5mx8GD7N6uEBbQp2T3jbCriKn/xuFYowIAjrGypUl0xY1Co5SsZiXoEZVbetUiUMiOqM2RjNDwfvBjYjpqNRbSFuHG3X4BfuaUKEQftjWJUS7h4rDU6WYICPUf0ikG1IqH6SNTqGxXGa16RJESu8XIwkWOtCVzaSWOSwrXnOKgC1ut9Gw28vy25dOg6nfxrwmybtE8jdnNIlkoYNGSsBcCe9eMH3I4DSQiluxHh4p/2jP0WfXN1YQN9KEKm/rLah8wFVYV/ucPDV+xtEcv1/q/FQeJxtfJ8DmcbCNuZ18jV92W5JHlol39RVSKNRGldYCudOwdVgsN5tMTcaeVkd3HEoHBFbrn5Jrox40dDQtF9sKqbUZVvePImbn0SRYPCnqBRdvA+VxjBNCcT33jS6aLgjDH9vClqIHgkLIUj4Ei8am6FzqNb61nhijwUApRaMtwmhfWfKfwgFGyMuWr6DVR+sWCRuB7/m/UEcDES37GkYSB0VK+SDacTmxscIffMuZ+lH7Xtb9jr3pluRUaPDk5CzNci37ZeCdV40GXITHnvdK3+dSd5sWd8C X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 16, 2024 at 11:10:04PM +1300, Barry Song wrote: > On Fri, Feb 16, 2024 at 9:30=E2=80=AFPM Yosry Ahmed wrote: > > > > On Fri, Feb 16, 2024 at 05:08:14PM +1300, Barry Song wrote: > > > From: Barry Song > > > > > > Most compressors are actually CPU-based and won't sleep during > > > compression and decompression. We should remove the redundant > > > memcpy for them. > > > > > > Signed-off-by: Barry Song > > > Tested-by: Chengming Zhou > > > Reviewed-by: Nhat Pham > > > --- > > > mm/zswap.c | 6 ++++-- > > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > > > diff --git a/mm/zswap.c b/mm/zswap.c > > > index 350dd2fc8159..6319d2281020 100644 > > > --- a/mm/zswap.c > > > +++ b/mm/zswap.c > > > @@ -168,6 +168,7 @@ struct crypto_acomp_ctx { > > > struct crypto_wait wait; > > > u8 *buffer; > > > struct mutex mutex; > > > + bool is_sleepable; > > > }; > > > > > > /* > > > @@ -716,6 +717,7 @@ static int zswap_cpu_comp_prepare(unsigned int cp= u, struct hlist_node *node) > > > goto acomp_fail; > > > } > > > acomp_ctx->acomp =3D acomp; > > > + acomp_ctx->is_sleepable =3D acomp_is_sleepable(acomp); > > > > Just one question here. In patch 1, sleepable seems to mean "not async"= . > > IIUC, even a synchronous algorithm may sleep (e.g. if there is a > > cond_resched or waiting for a mutex). Does sleepable in acomp terms the > > same as "atomic" in scheduling/preemption terms? >=20 > I think the answer is yes though async and sleepable are slightly > different semantically > generally speaking. but for comp cases, they are equal. >=20 > We have two backends for compression/ decompression - scomp and acomp. if= comp > is using scomp backend, we can safely think they are not sleepable at > least from the > below three facts. >=20 > 1. in zRAM, we are using scomp APIs only - crypto_comp_decompress()/ > crypto_comp_compress(), which are definitely scomp, we have never consid= ered > sleeping problem in zram drivers: > static int zram_read_from_zspool(struct zram *zram, struct page *page, > u32 index) > { > struct zcomp_strm *zstrm; > unsigned long handle; > unsigned int size; > void *src, *dst; > u32 prio; > int ret; >=20 > handle =3D zram_get_handle(zram, index); > ... > src =3D zs_map_object(zram->mem_pool, handle, ZS_MM_RO); > if (size =3D=3D PAGE_SIZE) { > dst =3D kmap_local_page(page); > memcpy(dst, src, PAGE_SIZE); > kunmap_local(dst); > ret =3D 0; > } else { > dst =3D kmap_local_page(page); > ret =3D zcomp_decompress(zstrm, src, size, dst); > kunmap_local(dst); > zcomp_stream_put(zram->comps[prio]); > } > zs_unmap_object(zram->mem_pool, handle); > return ret; > } >=20 > 2. zswap used to only support scomp before we moved to use > crypto_acomp_compress() > and crypto_acomp_decompress() APIs whose backends can be either scomp > or acomp, thus new hardware-based compression drivers can be used in zswa= p. >=20 > But before we moved to these new APIs in commit 1ec3b5fe6eec782 ("mm/zsw= ap: > move to use crypto_acomp API for hardware acceleration") , zswap had > never considered > sleeping problems just like zRAM. >=20 > 3. There is no sleeping in drivers using scomp backend. >=20 > $ git grep crypto_register_scomp > crypto/842.c: ret =3D crypto_register_scomp(&scomp); > crypto/deflate.c: ret =3D crypto_register_scomp(&scomp); > crypto/lz4.c: ret =3D crypto_register_scomp(&scomp); > crypto/lz4hc.c: ret =3D crypto_register_scomp(&scomp); > crypto/lzo-rle.c: ret =3D crypto_register_scomp(&scomp); > crypto/lzo.c: ret =3D crypto_register_scomp(&scomp); > crypto/zstd.c: ret =3D crypto_register_scomp(&scomp); > drivers/crypto/cavium/zip/zip_main.c: ret =3D > crypto_register_scomp(&zip_scomp_deflate); > drivers/crypto/cavium/zip/zip_main.c: ret =3D > crypto_register_scomp(&zip_scomp_lzs); >=20 > which are the most common cases. Thanks for explaining. Ideally we should be able to catch any violations with proper debug options as you mentioned. Please include more info the commit message about sleepability, a summarized version of what you described above.