From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DADDC47DB3 for ; Fri, 2 Feb 2024 12:57:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2ED676B007E; Fri, 2 Feb 2024 07:57:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 29E8C6B0080; Fri, 2 Feb 2024 07:57:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 13E806B0083; Fri, 2 Feb 2024 07:57:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0399B6B007E for ; Fri, 2 Feb 2024 07:57:41 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B632E1605AF for ; Fri, 2 Feb 2024 12:57:40 +0000 (UTC) X-FDA: 81746865480.14.E16E8E0 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf27.hostedemail.com (Postfix) with ESMTP id 9155740005 for ; Fri, 2 Feb 2024 12:57:38 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=SfEGVhzA; dkim=pass header.d=suse.com header.s=susede1 header.b=SfEGVhzA; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf27.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.131 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706878659; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xkocaXXNFKl7hAfPf4SUUuTnxj5Wea1E5uFH8/dmago=; b=n4PVSS0SXtyCz2TvsWNu8JHKkX+YacHYieue70M1ZdZEf/02TRclZxWO79nfDNHmaiAsb1 kkCUp2fCV4jUaWKe8U1Fr6Zt3K8OKu0RwngE4HRnC17WTKtsSR3rSRjXQc4V0nBSLwNdOn 8U7HMgv5vJEnZ/DQuXBLE47tJXCIhao= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=SfEGVhzA; dkim=pass header.d=suse.com header.s=susede1 header.b=SfEGVhzA; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf27.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.131 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706878659; a=rsa-sha256; cv=none; b=f+4jcX3L9MXQ1t6XOFi6SKTBk8g5ZuJTDpim9GGFAlE18ctZQ3TTzwPN3fDwXT79JCoujD +Nv6U/j+z7BpyERvo17f+8c8jYIKX74li4Vcgv7sLdVPn/Lc/UmNbgbifZR+Kk+/zZ13vc JyNUV19vrH0HU30dEbyibRPvQYJyO50= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B476E1F788; Fri, 2 Feb 2024 12:57:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1706878656; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xkocaXXNFKl7hAfPf4SUUuTnxj5Wea1E5uFH8/dmago=; b=SfEGVhzAZZvEuFOvB6k2vXVDbElIUgKy5N5WsGyTtSH5s+cpMf/5GwpKUOfeHhHB391gcu QD6nqLBZk5NlscjCrLXvUP4j0oMcAXI7SFgGRVVx6sI6sAEd04x5v6nR+HPKtE9UEHx/12 4GO3mfh5KoGQwqDH0Njua1Nsr1ZCg98= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1706878656; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xkocaXXNFKl7hAfPf4SUUuTnxj5Wea1E5uFH8/dmago=; b=SfEGVhzAZZvEuFOvB6k2vXVDbElIUgKy5N5WsGyTtSH5s+cpMf/5GwpKUOfeHhHB391gcu QD6nqLBZk5NlscjCrLXvUP4j0oMcAXI7SFgGRVVx6sI6sAEd04x5v6nR+HPKtE9UEHx/12 4GO3mfh5KoGQwqDH0Njua1Nsr1ZCg98= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8BA1C13A58; Fri, 2 Feb 2024 12:57:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id OwcUH8DmvGX6CAAAD6G6ig (envelope-from ); Fri, 02 Feb 2024 12:57:36 +0000 Date: Fri, 2 Feb 2024 13:57:35 +0100 From: Michal Hocko To: Lance Yang Cc: akpm@linux-foundation.org, zokeefe@google.com, david@redhat.com, songmuchun@bytedance.com, shy828301@gmail.com, peterx@redhat.com, minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] mm/khugepaged: skip copying lazyfree pages on collapse Message-ID: References: <20240201125226.28372-1-ioworker0@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 9155740005 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: zozgfxzws4yas8s5nbjsh4x14ccydozp X-HE-Tag: 1706878658-80623 X-HE-Meta: U2FsdGVkX1+PbWWBoXz80AMxA2Yyi9B3aw/+tD6hU1OJlObtuv49pEknx9e2trIidKDcvrfGDVnLadTO4hc/SMH0hVbWmP+fxlW0I0LtKqnhLpyGbr64u1ld4mZ6lFL/j8ChE4Gxnuy+KlnQrM/Sz5EZlJ6gmBQta1jtBGvBUpz13h8gaB+ZTSd8syshYLD0XHjb5f4lUlYz+M1B+iaJAx35G7Cz20ubZNzxtlxF8YXPEXNJqveTUcsUeIuwyz/mrIOKTEetu5TN+v8wpRJy2SO2wy8jVC8nEM6bEQcsUX2PfiEG10dHTzMEgQ5nn1Phr8WEoZgqCbufj8oor09fxgncRZhu/H2OlZWhYLvHMO/o0LHT97x1928LmFoUVTF642KEKP0LMns3XnTkTC2080sMIVtLifN4TeWUKh5qOdeSFSR0bmNXB65NB09SJOZEr6oYUFm9IrwlvYsA6RPYJr7iZSEvkuiSq0dT/P0dqoevoF4mcBJ2w2FprOK5a4gfsrCR75ZKMxpBvIj3p/yyNXuLKMNw+jg9oQsdkTLUKQXeh1Elu3FK/7rr4N/bhln5u9ChKlwUsGenIW4eau9i2tdbEcXoZOxzwXQ+Bdv31lXJzkaf4A/qkF6BdnQH01Ayf+5QIOtRMu6fXbAC5McmBb3/w26CtYNyC1Ps9S2MzdF3ea0QnLsT3QDaoBIeR68H9CLW9tiwQJxFoeGuOHCdYdRoAXALFCDYML0GIBlWbnJKeJ23oQxtR2tgDO84+1x4mO40q9XVY3VPSe+idQe3vufJrup4XbZApZpaFBJSVibFiu3ZusIXXAw/O0IMhcO9mH567FSdb6P8+3PspWX6NltB1KLqDmE3HFFOddPVuRDhtQ6mVut5kUrLkRc2Pje55SUcFBSDEMk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000036, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri 02-02-24 20:52:48, Lance Yang wrote: > On Fri, Feb 2, 2024 at 8:27 PM Michal Hocko wrote: > > > > On Fri 02-02-24 19:18:31, Lance Yang wrote: > > > IMO, since it's treated the same as pte_none, > > > perhaps lazyfree pages shouldn't be copied to > > > the new huge page. > > > > Why? The content of MADV_FREE page is valid until it is reclaimed. > > IMO, if MADV_FREE pages are considered valid until > reclaimed, treating them the same as pte_none might > pose a conflict. What kind of conflict? -- Michal Hocko SUSE Labs