From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DA0EC47258 for ; Fri, 2 Feb 2024 04:43:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 91C346B0071; Thu, 1 Feb 2024 23:43:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8CCEF6B0072; Thu, 1 Feb 2024 23:43:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7BB356B0074; Thu, 1 Feb 2024 23:43:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6D3476B0071 for ; Thu, 1 Feb 2024 23:43:16 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3677C1402F8 for ; Fri, 2 Feb 2024 04:43:16 +0000 (UTC) X-FDA: 81745619592.18.2A7A6A7 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) by imf08.hostedemail.com (Postfix) with ESMTP id 2B73416000A for ; Fri, 2 Feb 2024 04:43:13 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf08.hostedemail.com: domain of msnitzer@redhat.com designates 209.85.222.170 as permitted sender) smtp.mailfrom=msnitzer@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706848994; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hpbVH2T0wltjnZkqMBBaWFJ/E+D1lvYVrdtxC3+idLI=; b=6erdnxGyVEPf6tJ7JRI6oPcvXEId3xkoJgSJz8IwkVlQASFAjI+REKlULZKxpZomrHaFR5 sKkn8sqxlGncFhQt88rzOlSPXrXHA7ftx+B2WtJmLDWJ+PS+c2qhU84RemnRWNsplGLF4I R06NHwoDlOzPL2e/8kvjr/c3lhjU9/8= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf08.hostedemail.com: domain of msnitzer@redhat.com designates 209.85.222.170 as permitted sender) smtp.mailfrom=msnitzer@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706848994; a=rsa-sha256; cv=none; b=l1E9v2UixzqmFBquWz8qt4gPmY+8obletaKZ2A25g8QTlJHP4+Bj0r47i2sbibVGZwWzFc D11GCJHrCvJ8Hf9YNn5q0+HbSrWD1ualGObRQgZFFN3Hm8Z1sbZb+L7gtATAdvnRzujo9k qhezB88yJqnAJRv6J0ciajJVeiGRjlM= Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-783da26489aso115386285a.3 for ; Thu, 01 Feb 2024 20:43:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706848993; x=1707453793; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hpbVH2T0wltjnZkqMBBaWFJ/E+D1lvYVrdtxC3+idLI=; b=mzqv6SycZvqm3RFbftMe/6os1f97iThGwf2ErE/S1Ghh0ANYGJlSdzB85tQQAWvnbi Op+9B96BI+RNBHtAxZTBVgLS+9OheKzS6dpAScfUzKRaJvlJCmYTJbJrxbKSET6+MUle qR/3gEqhWr++9UWIhm+1CLvLeeHC/3s/R5EnpAAoo7LcP2/AwH6G9PwNS7PfFJy3BVlW YC0WyDdym7ebFru8TmaEGBOU4rkeENbhdgW7LrHSroTkLMsBJ8iaDSt9nOgeaa+l1yHW +QSOekp8eTKr7KGcdSV4bkOlZsuRII3g0w4wcdDFICcn2pkMU/Vt2rNcyKygNibiWS9r gpMA== X-Gm-Message-State: AOJu0YzXoeN+3zJ6Dpodupifo3prhqg3Qq10cHassbfOo0Z4VO899OBX 4sd2FsUXjLXRtJUOUbnTD5+BNL9dQs4w9pYCjqkn1wVjnR29DYYSvIO9OSv3iw== X-Google-Smtp-Source: AGHT+IFkfgQQl6ScAsRKVY+kYHICcKa/8Aap2tR0uxRTjTowwMAG4fOOLe8DmmPudwYqaj/ngdwZLg== X-Received: by 2002:a0c:f108:0:b0:68c:668d:a671 with SMTP id i8-20020a0cf108000000b0068c668da671mr4471350qvl.7.1706848993232; Thu, 01 Feb 2024 20:43:13 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCWxDF2cihEXJ7LLzKJJwE8WhiB/Szmvo9Pe1CG4D9R9oobsPLZeUSaO5F9I3teoYkkwNRR5KARS2kmo9oi0op83C2LvpaP92YiLP7SfHSJO1yjkSSlxuWtHz93m/pz2sn0fUp4R9bukGtCaTO7NoHy04nmhtq+5fAMiiXiG29p3pZwLqMoe9HqhYlefxKyUuyk3v5rbhd1IKj5Ljp7JyEkvNXKMgxfVNWfnzCfPacOkCbu5Y8VQO/LOIo2Eo8gTBbVDxi+2BIshKNIpFwMUeS1j0yb1UA1wKJLj+bd1B/1dk5LpzqLrbrxkOkJj8JLUusqbnVer9+fQNEUjPNwI8cCARRTFm1k4KqrlfosUuITU/g== Received: from localhost (pool-68-160-141-91.bstnma.fios.verizon.net. [68.160.141.91]) by smtp.gmail.com with ESMTPSA id bm13-20020a05620a198d00b0078409ed9030sm384126qkb.124.2024.02.01.20.43.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Feb 2024 20:43:12 -0800 (PST) Date: Thu, 1 Feb 2024 23:43:11 -0500 From: Mike Snitzer To: Ming Lei Cc: Andrew Morton , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, David Hildenbrand , Matthew Wilcox , Alexander Viro , Christian Brauner , Don Dutile , Rafael Aquini , Dave Chinner Subject: Re: mm/madvise: set ra_pages as device max request size during ADV_POPULATE_READ Message-ID: References: <20240202022029.1903629-1-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240202022029.1903629-1-ming.lei@redhat.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 2B73416000A X-Stat-Signature: ouiz6by13z1o4wkx6ac1rpp7a79i3sqf X-Rspam-User: X-HE-Tag: 1706848993-442335 X-HE-Meta: U2FsdGVkX18tO/jJn0Hl7dFYfcL48uo8kV63sRRkxA24kLYp70vM1f3shh+8BH/7qPdi7wNJvCTLpFsj1WM3+N7VqbB4gNBw7PZ9tX9oy9ibD1joixNfKU6uv+phlbLIqV5BsG7JHk7LlPh7IzpGU8nGF/lbZAVj1r2IC2u+ZAGvU8tTm68rFH8X0/U1G9Ii2DSwnUjqcTNXt0jVENiKM9bzMUT+70VhwIKvWAxoa7vcuRzancBQK4rvqluYIQLd5gt0CcGQL/9x5B75cIW7tKYc1zcmltTib3DWb8EH4G2DqSxLookwgBJvqg/0Z/AzT+WH97F9SEf0FXr7asP00TuVevsnmqP57M+s8XjLQlC38ntwoseDDIxOUc0VTBshPiqZ3dAxXISbw5s33mjyRY1g4SeWK3EPFvCjC04rf0oQhyiqlnIWE2BY3c0sbVU5TPLJGIU3SOOJx8vAwNTwqZuKn8+OsgVSrx9OZP2P7EBd6RHKExpfrRaeK5CO/ZhfhoLRRyEphVkqCTaRTGAwR6UMmlIfU2oWLn4hmPmoiNiWR29iW9knb8BQbvx8w55JtYu5OPpSuruTnMegKIwa1fJBPQS1IkbzMGSdt3TBDL/MUua3kUd6gAgQkMNAx3M8zElmOX9yU1FyqKDWXkFkJ4aA6Y9k0XB/CFLvZfHwAdJvAfTpCxcgKr0TCyWVx4rdaZEwMxYWeRF07oPlWMcbPe530zgkX2h42gcMNyeJRGECFEhxlXxtQZWlnBsqWLIzx2OFvLNVEqNEHs9vb7IPk5S1wxZwWsxIecwHCkf21NmJzVj8eoS/AuQJ86dPbWUmozBTrtNBzIgaRXkwwJQoN+Wj5eO+8WT80//Ph10AYMLiJ3f0B1lXC2TgkGAbF8KbItkhraL4cLQ0++Uamfe+pyHGVM7T7B7QfbG8OlKwz5DXMVi3KYgZrSMXHsFNbjyLX1O+q/C802qc8YKiHsd DTK3eiOc zZRB4eb+M+qvIvxUhZRdRB42RvKFXdsI4TLFSlSiXctNLj2+6YLDcRQR6exzwjP5BuJakl5+0Ott1yhruw4mDB/5GOeLiSAn0Mq7rnilU/CO3RcAe/1eALJBC6yQRoxFivF5PTkTqmYz1HaSMlKE2sV/NU7uXnC1y5TmYvnOsOF1L6xCc/uZXRPBygC3RErG9VeE7v+yi8D+5e/JB3rA4Tomy4uVvBkUgOBaTbBkZnLV0zPyD9/XBzOgljVBOAqvXwcaF6VyoYkifky2GTD6dS1wFZnOLfL90T1WRyGImFN87FmI4GxHAChwQ4tcYaKBKn8eb970gs5LEhe5Pnn3DoVLwAaSoeQUrXBQRXTn88E0RAi40gmm2N2igRC6umMUJtS4OZ96Jx6qcCLgQf4En7xMPGF3j/J5BvSn2iVRg8Vw2flmNz1cHEh0k3IpPjDgDxphRoJ0EaMhlk9eK4UvJ+7q+zTK1kGL14vt4tQQqB83Kzaqftnv/bj6cN54QzKmhTHpVVl4QYrLiQgmMUo69DUyL4NOYaDPCZo5PCov3rejRffcYdypXdxi700YU2a5bgYlEogTuSzAWwpGjZ3Urj/mAiHQ1sj0kOU99X9r7K26rHLdhyVv7l/6+XxPhUPmc5uofTFtZ1DyscwUHq9JM0qLyp1jfm2tq41jfUqFZudlvMB3NxelcrlvDo7Ob1j/YnOFwCcxSSUJNNU2aefQ0AfQFRcQN2K+J4KyYoF2eBvVWFeGiltRd08z1X9OluEKDDQ4BzJi2r3yD+yUe3I0rcG9fg6xo71o897JKVlqYiJelPTsEKFSpbh0BNpFZ0t5ukeIdEm6Z8uiMdS8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 01 2024 at 9:20P -0500, Ming Lei wrote: > madvise(MADV_POPULATE_READ) tries to populate all page tables in the > specific range, so it is usually sequential IO if VMA is backed by > file. > > Set ra_pages as device max request size for the involved readahead in > the ADV_POPULATE_READ, this way reduces latency of madvise(MADV_POPULATE_READ) > to 1/10 when running madvise(MADV_POPULATE_READ) over one 1GB file with > usual(default) 128KB of read_ahead_kb. > > Cc: David Hildenbrand > Cc: Matthew Wilcox > Cc: Alexander Viro > Cc: Christian Brauner > Cc: Don Dutile > Cc: Rafael Aquini > Cc: Dave Chinner > Cc: Mike Snitzer > Cc: Andrew Morton > Signed-off-by: Ming Lei > --- > mm/madvise.c | 52 +++++++++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 51 insertions(+), 1 deletion(-) > > diff --git a/mm/madvise.c b/mm/madvise.c > index 912155a94ed5..db5452c8abdd 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -900,6 +900,37 @@ static long madvise_dontneed_free(struct vm_area_struct *vma, > return -EINVAL; > } > > +static void madvise_restore_ra_win(struct file **file, unsigned int ra_pages) > +{ > + if (*file) { > + struct file *f = *file; > + > + f->f_ra.ra_pages = ra_pages; > + fput(f); > + *file = NULL; > + } > +} > + > +static struct file *madvise_override_ra_win(struct file *f, > + unsigned long start, unsigned long end, > + unsigned int *old_ra_pages) > +{ > + unsigned int io_pages; > + > + if (!f || !f->f_mapping || !f->f_mapping->host) > + return NULL; > + > + io_pages = inode_to_bdi(f->f_mapping->host)->io_pages; > + if (((end - start) >> PAGE_SHIFT) < io_pages) > + return NULL; > + > + f = get_file(f); > + *old_ra_pages = f->f_ra.ra_pages; > + f->f_ra.ra_pages = io_pages; > + > + return f; > +} > + Does this override imply that madvise_populate resorts to calling filemap_fault() and here you're just arming it to use the larger ->io_pages for the duration of all associated faulting? Wouldn't it be better to avoid faulting and build up larger page vectors that get sent down to the block layer in one go and let the block layer split using the device's limits? (like happens with force_page_cache_ra) I'm concerned that madvise_populate isn't so efficient with filemap due to excessive faulting (*BUT* I haven't traced to know, I'm just inferring that is why twiddling f->f_ra.ra_pages helps improve madvise_populate by having it issue larger IO. Apologies if I'm way off base) Mike