From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACD63C47DB3 for ; Fri, 2 Feb 2024 04:15:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 25CB96B007E; Thu, 1 Feb 2024 23:15:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 209DC6B0080; Thu, 1 Feb 2024 23:15:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F9536B0083; Thu, 1 Feb 2024 23:15:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id F34616B007E for ; Thu, 1 Feb 2024 23:15:46 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9EC801601D9 for ; Fri, 2 Feb 2024 04:15:46 +0000 (UTC) X-FDA: 81745550292.17.5B05923 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf22.hostedemail.com (Postfix) with ESMTP id EAAC7C0014 for ; Fri, 2 Feb 2024 04:15:43 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=lalX4tc9; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706847345; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=p3ixc7xOxGnAntqDXaoDdSsv0shKrOpuXUN8Nh+tsrM=; b=AtKn2js5uVCa0b/nSdtvJmnmxmRdaLWAUIYJiZhv/3IPiCV1AiPbbSm5n3iIoBqh2epd2X gnhSH4oSkM1ov0IXQM7kx8x7sTi5APsCryK/iqabDYTYrVUNR87jM1MG79fs9zR7d/xI8D smtAzgJjs9jaBfNAiQFovQGB1bBeMxA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706847345; a=rsa-sha256; cv=none; b=u0emSVC8xhhcJQNqhKSfAw+CTwbbvFQs5X8TjDUGQQxuLFmFPIS35Y4MQaG5nK8fxc/lDE Dfio+7/AiNX43i5THOG4uFcUX9HHlfhzaKAm352fv940Azn94R/i92f+jY2H5j7y09LPuj jvQIFe+e8Ifu1nKjZdWud2Lp8qYjSOw= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=lalX4tc9; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=p3ixc7xOxGnAntqDXaoDdSsv0shKrOpuXUN8Nh+tsrM=; b=lalX4tc9Vfkolj7JczpTxRNVwo pHdD2uo9pRSZmmrBqYvCRuQ+OEV+AFi40Ssv8tjbePX/mCMI4DdTUWenA1YKVXUkFvZFITgSknIs2 Xylq03WiiyzsFc5lc1GMDRSvx5PXh89KBRqDEeOdP12R0RzDmNAlc6LMgR2xcrxuzF+cveQ5Dd5F+ fjthmkCRvEAdugiZsj0XdbkuiiNGGAGEAQ9HjxQ0O1TCxHuNSVtL1iEA6F5Vuy8hdItMq8ByTIGt+ Xu2xxpqBuOfZ26W9jtzpI7eWDiHinmyRD5ct4azlN7cIHOPKigOuWjwUNDkj6CWmGufBEXw6XgizO E91ERloQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rVkxn-000000004Er-3S5p; Fri, 02 Feb 2024 04:15:39 +0000 Date: Fri, 2 Feb 2024 04:15:39 +0000 From: Matthew Wilcox To: Ming Lei Cc: Andrew Morton , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, David Hildenbrand , Alexander Viro , Christian Brauner , Don Dutile , Rafael Aquini , Dave Chinner , Mike Snitzer Subject: Re: [PATCH] mm/madvise: set ra_pages as device max request size during ADV_POPULATE_READ Message-ID: References: <20240202022029.1903629-1-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240202022029.1903629-1-ming.lei@redhat.com> X-Rspamd-Queue-Id: EAAC7C0014 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: fkh31afntbybu79gcurcaaozcyekhoda X-HE-Tag: 1706847343-260987 X-HE-Meta: U2FsdGVkX1/sWQ/nX6Qg8B4uwiUHkq24cR/uK+EBIsoAeHcNLImusIPOIGrGk6RXuxkhf7iMtMv+Jl6pHhbdqJUWI3sAbyVclEVAjpygGg+M3aOpKyDkB+UJjz8gAWeqApGecDyl+Vy7CG9lOZSHs+cv8PfkW/d6RVzHFTShLYPZpKwQo/HzS50iM3czPhvUbnT3w42h+kPWB+AdF+3h26CD4EfcgAKOLBLWmcy3nDq6r4lirEZPf4C/ca9C4Du3z9tkMDP67+fDecsMtUYNU7Iruhxfqxc9zPYevy0gBs7pv/HlGbc5KsG1mTS71xVS6UTnY9o93PvQ6cAsq6o3493kwO9aT8VOVnHBG7eZQQsuurHzSGj3+fhsFIWuiYLY3fpJgfdNztlS7OGEBlrVESk5G/e+BR1s2rN6/sV+CyCiVcD3aUUVoiIWjJi9QeZG9Rdtvvewbffu1UsF17YS67VhBk4gXXxHnBRvudxaRsVCOUXBR7Sef/NDfluwviRERtAb4aSlNkGA1umVYlHnCD6JMgVrKjauBEREnCaq86zNMI7NTCQguGHzj+lVfuuukILYZKEBM4Vns6YZDnDBFF4oKO1SnAcmpmkiIjUjuoLtVm8p/aJPh/v1wjllSYhWSr4nrBg2vtPEIewtPcljO0YQlRZxipCRWICgIM5Qq5ow+/rPYl8JKpBcsNAJzZ/TY527CasKrADleTgqiFSM8V4aMvpWPd3Hen54IQc3HsTRQLOpFyY42/ht/P2j4CMtgnNk83cOtIOz/yPXo4AQt6VqKSQAgpehZmxDqmd5SePtTRHyp7fbpi4WMi+XELyUaLBf9fyAUrkPqPbT1KLDlFk9xdCEBoQcHPnOcMJLNg7NwwaXfXDqPDT3eH0jRuXWAX2CN6tJ0lybPF+o/GvqkoMIRYQwST/nnSKxXXn0tlTTZbVHzga8nsvy+kryBNKtfPh5H55b6K8+UvVO9xd 4357Xk58 JsgUFmtNtmWSPTVS+zmBHRXYzI2UdWjMMudF/tW5KZy5axsfY5kZQtSUVCYesBC5TW9UNRDOAHJtqHahBETfJNu6P/U8bdChYgMtagwYwQfKeiSLtHEuAl2ykSZxGo/yuQrKyBdmhqTz5KAHR+ungb+aCW5C0lXi+jqbWV0AjrnJ4aB3kBszmCklqBQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 02, 2024 at 10:20:29AM +0800, Ming Lei wrote: > +static struct file *madvise_override_ra_win(struct file *f, > + unsigned long start, unsigned long end, > + unsigned int *old_ra_pages) > +{ > + unsigned int io_pages; > + > + if (!f || !f->f_mapping || !f->f_mapping->host) > + return NULL; How can ->f_mapping be NULL? How can f_mapping->host be NULL?