From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84B83C48286 for ; Thu, 1 Feb 2024 23:55:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E63876B0072; Thu, 1 Feb 2024 18:55:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E131E6B0074; Thu, 1 Feb 2024 18:55:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CDB586B0075; Thu, 1 Feb 2024 18:55:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BD93F6B0072 for ; Thu, 1 Feb 2024 18:55:11 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 915641C09D6 for ; Thu, 1 Feb 2024 23:55:11 +0000 (UTC) X-FDA: 81744893622.13.6317EAD Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) by imf24.hostedemail.com (Postfix) with ESMTP id D902918000A for ; Thu, 1 Feb 2024 23:55:09 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="ek/c+7bA"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf24.hostedemail.com: domain of 3XS-8ZQoKCOAaQUTaCJOGFIQQING.EQONKPWZ-OOMXCEM.QTI@flex--yosryahmed.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3XS-8ZQoKCOAaQUTaCJOGFIQQING.EQONKPWZ-OOMXCEM.QTI@flex--yosryahmed.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706831709; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oPoNxScY22KtGi7I65v3KQkSSA7OlIpnXFGU1MLqXvc=; b=WQKzm0RGdAE0UsJyqXlHVcH2osb0IUAW1CIxExhM14uSgrA1akFDYy3HDh9Y3TwLfR0XMr IELWjxNEdaQ/h13ZvHxMV9x0f1P9R+1J2jYze2ux17KXHYdFUAurcnc2ClJsTVCX3gPcwZ vcgSnT4FaImWNp4nRj7uCcYJR2hwmBE= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="ek/c+7bA"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf24.hostedemail.com: domain of 3XS-8ZQoKCOAaQUTaCJOGFIQQING.EQONKPWZ-OOMXCEM.QTI@flex--yosryahmed.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3XS-8ZQoKCOAaQUTaCJOGFIQQING.EQONKPWZ-OOMXCEM.QTI@flex--yosryahmed.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706831709; a=rsa-sha256; cv=none; b=O7errz2wUQMuL6vu4cRiu9XGfPiwIYpfky98O2DzOnan7w5fBbdPh1YYseUoNiqwOAmpPg silE0tmjZnIABIqumK8cVlttaRLgfw1JQOe8tamWwm+WsTHXvq8osxJMOSkQq81LSSiTZr Og1N67IWJkaGFPAdrkaP/3zC815ZK+8= Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-5ffee6fcdc1so24800647b3.2 for ; Thu, 01 Feb 2024 15:55:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1706831709; x=1707436509; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=oPoNxScY22KtGi7I65v3KQkSSA7OlIpnXFGU1MLqXvc=; b=ek/c+7bAydCk8nCVFnDILoVdhuGSJVZ1cYRRPaTTy52UrK1XS21PohoZwtLNZFoWFI fAnSegu/vywQVS+n8sOI8N5T46F926wT/k+lv3GBskJjCYLzNQXtFgYSYcrg+tmZRIsi 4+PoMQmcxpibUlm9RG36u4MeflQ+GFE5/Qe2QSxVGh93beAARzoXpr0QrPKe/ZgT97Ni CjFdgu896RKly9UYe731bXxKatMbyYc+q2wInCx6Sq8x6qs9iKgfC2KXL3h4AY5WbOCv Ws39LIxvctJAUYdqx5tmXL/oAxMs5eOpyXKgHZswYUqVV+TyqmbEiM6Sm9gz5WUF7trh gYtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706831709; x=1707436509; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oPoNxScY22KtGi7I65v3KQkSSA7OlIpnXFGU1MLqXvc=; b=IWMI/kCC2EEYabxCUMAy+QdZYOEPlTqcNCYK4xCMrNbYS4ixiITT2lTOAcYcCgatUT hUc5dk6DJERTRPyEc4+W0K6J8qWQTWmZ60WKedGTKzy37Qt+y6akkaP/+BflnGZAVkh6 42gmfT9pRxfkDJnIZtS733u8Mi/V9UuxzLtv4vNLxvvRJytLp3BIQAWUI/wna9/EDnFZ p2mSRz+H3pH1NrAgDhNpztuGWRIjp3Y/QvZoGlKD+q5iiXrsvfXNGs2SV6eLlDdozFUZ BPRqirZvTXiK1Wghozsmg5xve9rPlhNFT+JMPZzTqmRCBfIDc3PzyFQwjFpIbDH2FSxY aM1A== X-Forwarded-Encrypted: i=0; AJvYcCWjrlW6L5W8lGh3Jy7Lr/Wla/eo12X+aVtBAeFVZMmsz5uMakcnXApwwrukpk5rXVOvDc3owQYQbgu0MH0MknsGe+Y= X-Gm-Message-State: AOJu0YxVUfIw371tf/i+RJbhzqGo9lxr8rDyeIvS/irKHYE9mGivqG4m PINI4B64V07vC6VgX5PV7ZlsuWbUTZ2AWl/6V0baK+eTzdPdyJ3OtA4qjH5RMpELC6fz5AyQTek TaFgP0Z1O6YF8dnflsw== X-Google-Smtp-Source: AGHT+IG0Fv23ZgCY0CHImU4dZeK5t4BDFJrvm5cDaOWQ1ybBxaiIZOJmLus4rv7+9kwhmE0sOETzG495mLcxEt5r X-Received: from yosry.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:29b4]) (user=yosryahmed job=sendgmr) by 2002:a05:690c:12:b0:5fc:4ef9:9d6b with SMTP id bc18-20020a05690c001200b005fc4ef99d6bmr116493ywb.9.1706831709102; Thu, 01 Feb 2024 15:55:09 -0800 (PST) Date: Thu, 1 Feb 2024 23:55:07 +0000 In-Reply-To: <20240201-b4-zswap-invalidate-entry-v1-1-56ed496b6e55@bytedance.com> Mime-Version: 1.0 References: <20240201-b4-zswap-invalidate-entry-v1-0-56ed496b6e55@bytedance.com> <20240201-b4-zswap-invalidate-entry-v1-1-56ed496b6e55@bytedance.com> Message-ID: Subject: Re: [PATCH 1/6] mm/zswap: add more comments in shrink_memcg_cb() From: Yosry Ahmed To: Chengming Zhou Cc: Nhat Pham , Johannes Weiner , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="us-ascii" X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: D902918000A X-Stat-Signature: ouu7k8d8abw8wn47gkqs6m7qbgnoi8j7 X-Rspam-User: X-HE-Tag: 1706831709-214217 X-HE-Meta: U2FsdGVkX19VUWtoaxYeu8Vs/a1vPIH+LRalu7LR5rpJHF2f1ollOILVkWDAS7zV+duD2LWVIRZMt6ZNUXKNlYY+7Zi2dQQhYzMPdcFIy3b57NK7Mn7Yju49Cy2mg1Q7h+4K6RXN8aR4hUuY+4XX4+5DZZevEv3fvGXOhTP/FeuFwKFN1d+Zt4KIXmnR7sASchu0Hjco9Q7Yz6M6dsISrQb9/puSHWcFWDPMLgVWHla5cucfZOf+cf1925QyGygdrzDNoYcyoEMVR2MuOBxAoO67j43BOQZb7fYPwT9kGjE0kH5SumpAkTGU8DgO5OvXWqMuqJ01R0PlP/kGOLrJGJEkahP62uWU1DX7uBr8DoDYlxjfENqUWIdeCVTeiUV2nSN87XLaT9IGQqz0kcu+8CtvaUVndoN/cnnfbQFYIKs+zwHzdYApUf0Gvtu8/xe4QugfEKQLryrYY0gIbuW8ALKAj8C6LAzXtG0bQN/wzqxN8JqwsUWejSQeh4LXfr7YQU6u7whm8f00GSwaOorBjEl29g94IFPJqxmdNZ8f2qX7r2FaZbiJPknhfqh6DkAHOjnMFxk3VdMnJlrxWoSq976rYHjJQxTDUHnAFHpf+XRcViM5NVD/51ysbR9LEY6yykZBXvTRmbqoLwFZiY0Yl3oqSbGnewUf0QSEqVOG/wtuzp+tu/LPoxPUi6moOwfjh7X/LUHqq7m4EmAd9+j3LhL4EwGpDLtcDZW9+1R62BTudhjZ5Jng/s0OZNBl4yhF7qPGK/jSW+S/MVDfvsla5Bs2mqACOut6iJXzjOKwpbe3/zfyV8BjZjJJL5ymKK4triLZ5osRcQfi7O0Kc9IvV53MTY2zsHcEdULfws9UjEvWn+8vNRwiqjyCgb6JwhipoAECQspmwjZuGUaG26ojec5D+Q2wTwmwWsdLvDCIVDIrCpkf9dA08Ll/5XCvr3xDAifQj8n3+RQwo08pXva PLam8r1E R+qBUYs89SPsXXQ/+neV0vUe6VBMi4WUz+ZvwUDubejJ5b00fevsnHLK1bhLZkHPlDXWLwE3Bjt74tbqzBgkiQCRhh0R/ZrbiHfwjIUwaWRaPnrRlJ5abbLCHrFsGCDvEXGsXxMDmZ0xbURCsJxbCwxt2lOqMhfzuuzGYewJSwT7pvDtmMzu2XoczE7BP1veB5gd5IP1Gv9TodRZXf+jDoRmKp903xk6OWxgDZVKJASNkfqJJHxAa9vMFMuUchySpXz1YctTqIqeoZXX7Au+wvT41MqERZHJBQFvolia1IEPTvJyARpTupHsq4lN+kessSvQzEqUzTfS2vtS1orf2lQ2WkryH5KVnREmVHhr76r5zpiim0ETHpSdA8vENhVrODhfnZbYMmNfgC9sKVVeJ42N/1MRl2LRRI6WGu2EP3xh3MCjOaZ0njNxllVBUovQR1LoESe1sqmwmarVmexPWlv4aZgL0oVrGCft/zxM0teBrY/2in1nWyqlZJjnzXGUjlTLUdMlSEO2/OzPaQH6BL2ZMqPQvgH8dCdDI8dMX02jgLy+LhBZhYqJQpyBvPYASAuhzyesAT4v3vqZdud00NrfEzZrlUERjRfgX/PdTMOdsNuKW2+uUVHdHeniUtpOuZPfuf7mKo9pLmVqNzSHwpkAoqz4W7/GwtyTH/at3wmrLeDq1cBa4J2fNqDPCdq1rhQObQYlmGA+pCFtzjrNdrnfKgfaOEtbfwXeCwbQ2ZkpHS8oo9fIPmvr5MqQhv3pin42bHx6289bziiiOa1it8TI3X7ASY9aGlOL9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000028, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 01, 2024 at 03:49:01PM +0000, Chengming Zhou wrote: > Add more comments in shrink_memcg_cb() to describe the deref dance > which is implemented to fix race problem between lru writeback and > swapoff, and the reason why we rotate the entry at the beginning. > > Also fix the stale comments in zswap_writeback_entry(), and add > more comments to state that we only deref the tree after we get > the swapcache reference. > > Suggested-by: Yosry Ahmed > Suggested-by: Johannes Weiner > Signed-off-by: Chengming Zhou Acked-by: Yosry Ahmed Thanks!