From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26680C4828D for ; Fri, 2 Feb 2024 00:15:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 98C586B0075; Thu, 1 Feb 2024 19:15:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 93CBB6B0078; Thu, 1 Feb 2024 19:15:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8041E6B007B; Thu, 1 Feb 2024 19:15:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 709616B0075 for ; Thu, 1 Feb 2024 19:15:31 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 394141403A2 for ; Fri, 2 Feb 2024 00:15:31 +0000 (UTC) X-FDA: 81744944862.01.2BDBA03 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) by imf10.hostedemail.com (Postfix) with ESMTP id 84874C001E for ; Fri, 2 Feb 2024 00:15:29 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=AR+dRD7u; spf=pass (imf10.hostedemail.com: domain of 3IDS8ZQoKCK0lbfelNUZRQTbbTYR.PbZYVahk-ZZXiNPX.beT@flex--yosryahmed.bounces.google.com designates 209.85.128.201 as permitted sender) smtp.mailfrom=3IDS8ZQoKCK0lbfelNUZRQTbbTYR.PbZYVahk-ZZXiNPX.beT@flex--yosryahmed.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706832929; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0B2dcyelbSjs2I6WfMab+Sv7WVPwcbYFuCtOi9mUo08=; b=kqI4n+xYmnS2Lu6Ta8vxlx5ZKV/yXE8XNBhZMYlbRfLWcN1TNmSaPYSG9RPUBKFHmWvsvi gPto3InSi1FV/QlgKNHgb0/U3NsJe5zINk9lHJUR5VPFdo/dFdFb/K/lZh9L/vdxuiYu/3 FcpjUyybdXKrKjf0nVZmYCGdvbEY1qc= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=AR+dRD7u; spf=pass (imf10.hostedemail.com: domain of 3IDS8ZQoKCK0lbfelNUZRQTbbTYR.PbZYVahk-ZZXiNPX.beT@flex--yosryahmed.bounces.google.com designates 209.85.128.201 as permitted sender) smtp.mailfrom=3IDS8ZQoKCK0lbfelNUZRQTbbTYR.PbZYVahk-ZZXiNPX.beT@flex--yosryahmed.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706832929; a=rsa-sha256; cv=none; b=538XbpfpSpNZOYnMk/2ist8DMrp8zqUDxJ5FtDAwPIkrd2W3XFDXt+kiKpKmgnzSfbtk0I UxoeTHmP6X8t50NRrAMtqQ5eJIs1Wif13KlunTkpyI30bzFhXqq2JacDHn+EggEC3Jmh/T lWjkB1lj8F90MwK0PVXcKMxHRmOUmyo= Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-60406626b50so33784777b3.0 for ; Thu, 01 Feb 2024 16:15:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1706832928; x=1707437728; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=0B2dcyelbSjs2I6WfMab+Sv7WVPwcbYFuCtOi9mUo08=; b=AR+dRD7u/I8GbsENqyVLL8w5YIA3P8ulY7Ey/L9bSIAPJdXdRvYgMzE/A3VpcgC9nV +mDmSKBbVT011jx5MhYd/a8z3c9yZYqCgub3YTp5GWMfn9BO5pM97PE19B57C5k8p08l 9fPQTSQO0t2a6IKF+HQoexOOgBE3c4/esn50XCdo/qM3c1VRdH7bEfDp9E8ClYFTnpv6 oxWqw1ZxHbvRPjouNrhd5ZEyNC7T77gIYh3WD5fH8tPp7dabODYKWBebC3I0yLQDfVHu kQ4v6e21MAfxjLup2j46dZnp8Ap+RTS8J1CQIoldY2l+yta3eTQkPPVWb/GMk39hA89E SzmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706832928; x=1707437728; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0B2dcyelbSjs2I6WfMab+Sv7WVPwcbYFuCtOi9mUo08=; b=PhcPAKCbEloEKVO6cXP2Ef3CrowKDTOMxFEgaTQSqGnSc9Pjf9ispQJi5l51QqCcWD s/x/aWKKfgbv/Ur14I0L7HlIPX3eFB6wyF3ukGY00skIStsL9G7Kr7tM66bKC28greLY s3D9rUmKXM9L59qwEO46WQYP6KLF/WN+7ZgeHiVM7lPKup3BANLV8YC+2IpyW1p9EWdx PoySkgS0swE1Htk/V3jhFjBzxbv6xKPKZhqs6VuA7zVhlRpnGwaLRpBOw+8sC65L+N6x bCeFsnzTpcxCMPFTrw8NjTUNrfAaHU5krgPSK3IjX3szMq6+gDyFOmzwMCQXtQIHZTns bF8g== X-Gm-Message-State: AOJu0YxXbFsreA5cciA0ngyQ+5CZWnrwJMbta4q8SD9TO4Gnls2C858U tU1EpzJulGjOb+kFtUh5fi4hxxk2VzDDI2Xlr4FHx8dbrF1gF/Ltahe7H37wvHptwhuzF+j9T+v 1u1Lza4tDfrh9dqK+QQ== X-Google-Smtp-Source: AGHT+IHsamGJvXtCbMOl776g6wlVHKIs36LmCDtrhwIx3m6h+fOkPx31v6CnKtR0J1ZIqN//bOCU1+Av2EJLRnM0 X-Received: from yosry.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:29b4]) (user=yosryahmed job=sendgmr) by 2002:a05:690c:9:b0:5d3:5a95:2338 with SMTP id bc9-20020a05690c000900b005d35a952338mr161854ywb.9.1706832928736; Thu, 01 Feb 2024 16:15:28 -0800 (PST) Date: Fri, 2 Feb 2024 00:15:26 +0000 In-Reply-To: <20240201-b4-zswap-invalidate-entry-v1-3-56ed496b6e55@bytedance.com> Mime-Version: 1.0 References: <20240201-b4-zswap-invalidate-entry-v1-0-56ed496b6e55@bytedance.com> <20240201-b4-zswap-invalidate-entry-v1-3-56ed496b6e55@bytedance.com> Message-ID: Subject: Re: [PATCH 3/6] mm/zswap: stop lru list shrinking when encounter warm region From: Yosry Ahmed To: Chengming Zhou Cc: Nhat Pham , Johannes Weiner , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="us-ascii" X-Rspamd-Queue-Id: 84874C001E X-Rspam-User: X-Stat-Signature: mweieag6mji13txqqebbufop3g4wwn8q X-Rspamd-Server: rspam01 X-HE-Tag: 1706832929-340752 X-HE-Meta: U2FsdGVkX1/b/8yI/1rJf7xSLZWFU7JM56y1u6ubdXC5H/DJNPnp55eRNC/7On8xR3+jDJa4hIXygM81tEmgG5qNTlNILu0oL1EvdNjJAziPip/ROFxoGhYqahBrMQo2kaZ+w+sDE0C3uan+J11veyza07gBIDkAoVkPm6q6gP3kD9Ps5/LCPFRPvO1jsWBvvk2AEFpPWZ/lQQ5ve4XAM3TFyiTvmPB6eAL+ogeMWP8nleHWJLazS8qf6mgwza3zgl8tuRNbIPg1KTuQVWKfbbQiw/uZ9KVRtqzvrqRVIT2KZLKMdKkxNDNtzjW2xbyk7KaZbKa9zcSQGxILpFf+bDQ9yv8d0OKViVh9Oct1o+mZIUf6hfoQhWdeWSxkK1VBHCkECtKewL+1SuB+LmScvEcJpVMDU7JVRyg/WAFip1j+aGhtzdFlV6P//kLm1q4UTIqmxCuNKDnpGNJCUGc3DBJnsQf5g28oMByJ9OuIWUIDI9PASi58zz4epzjaIbWmd9GNiO9soLCR91DpO9YYimWpMpi54qEh1kse+mXV2+/UrZydmDT/bfEfNJPqzMjN5Fsnt4buRgTBdJZba7VnHDKBr5ipM41hOlzu6SMs3nMyPaxPWLTB8eY3EE1zAntPYzVsUio0TxtDRNNrtB8gPgbhXvsFEdra5lJC7vvYXcafBYLdsh2ubwy0/HqzI/ycK8djVGDXA5Ldd3UYXL/OV19085w5vOyMjiF+MlqChjaM5XUCHXjq9LbXT8owUIxYBtah5MvqV7Q2xonJOgd/YPh+l6qrPrlEAdGBZDI76ALlNLRhgNG1nyFVX2dZnYyB2WIURIQ4ecJjINMn5wA+yJZE9QeZS8gkLf0qOkVSZLxrAiDX3uspW5hvJXif0l6RrpBjjOm8zJH4X3/478+k0CALPAhxIxh4nDAej0vTI0iMLVvNmFz7uOl544LnYdkNEBrHUkL6m6Aoi0T5yMS mJ8GJLdM XtfX3WiN0CuX9cW/MXg9/hzxHSlMk3EXC7a8u291fJDadYRmXP/unsKh9NO4jFXPuravW1SGchXDflp6jXq9NDLAvU4Jcwp3oBu/dTNp6lMhGgcZ9+MtcMq+oOGn06AeK3zR/UPpv2K0naJE/qdBp7LfNoSLNN1UOo8iLo3tCGiPJoVrcsgm55+t/9S+7Z3LshAhjrzgT3B1OTHTSoC5/vX/YE8TjbvIN70CreRlvYf2KCMNn/lYwEsqb600EOcAS4oVGYn453LA4iaPj7zTyHts1xLIPDJbOfLS3V0RVH6J3nREd+J6UfOyUBfp7G+qC0N0WcuwVRSAGW6IMK9J1sQru2YF6gnnkuMbsFpxhFGnLPdJKyKCdSSkgLJvpn9WFQgm+RZQ8nkOGvBTTsitlsRUvMYjZh7vaEJAd8/3tf2Y6dsobbE2VtYab+lsiJjMMD0zUDCvDclDfiEkb7/IsZUgU9gxAC1ICt0D2lVYsTCusgeYvHqkKhhIl9BIZEGQOe4UClk09nw5INF+QdDTtGqjOs1eyOaCp2oboLO+ig3JPW7g+qnUlCL/YPahh+opJ2DdzEv+BM/g8UG4Mu5VQgi0Ml8suzkvBiu8P4HBu1TZvZ6MjhjZ1GA22+ObhpAfdiJLXh2kVsnzdJOd2jBG7V0e8Hldz2djzmfjGUjdIHCoFDdhbP9FIHQ8Si0O2kYWNQ0nL X-Bogosity: Ham, tests=bogofilter, spamicity=0.002313, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 01, 2024 at 03:49:03PM +0000, Chengming Zhou wrote: > When the shrinker encounter an existing folio in swap cache, it means > we are shrinking into the warmer region. We should terminate shrinking > if we're in the dynamic shrinker context. > > This patch add LRU_STOP to support this, to avoid overshrinking. > > Signed-off-by: Chengming Zhou LGTM with one comment below. Reviewed-by: Yosry Ahmed > --- > include/linux/list_lru.h | 1 + > mm/list_lru.c | 3 +++ > mm/zswap.c | 4 +++- > 3 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/include/linux/list_lru.h b/include/linux/list_lru.h > index f2882a820690..5633e970144b 100644 > --- a/include/linux/list_lru.h > +++ b/include/linux/list_lru.h > @@ -24,6 +24,7 @@ enum lru_status { > LRU_SKIP, /* item cannot be locked, skip */ > LRU_RETRY, /* item not freeable. May drop the lock > internally, but has to return locked. */ > + LRU_STOP, /* stop lru list walking */ nit: Should we add "May drop the lock internally, but has to return locked" like LRU_RETRY and LRU_REMOVED_RETRY? > }; > > struct list_lru_one { [..]