From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 294BCC48286 for ; Thu, 1 Feb 2024 19:28:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 77A5E6B0078; Thu, 1 Feb 2024 14:28:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 707566B0081; Thu, 1 Feb 2024 14:28:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 580B16B007B; Thu, 1 Feb 2024 14:28:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 431C76B0078 for ; Thu, 1 Feb 2024 14:28:01 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 946B61C1877 for ; Thu, 1 Feb 2024 19:28:00 +0000 (UTC) X-FDA: 81744220320.09.0013B70 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf12.hostedemail.com (Postfix) with ESMTP id E94804001E; Thu, 1 Feb 2024 19:27:57 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=scU5HmOE; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706815678; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ADGbXG1wyb/0DBh6Pfwj1Ti/Ouskw0VrsGb11D2Ftm8=; b=EpJct86UBiZOWlb/n/HDyzMoiZ1puvi/lHld7wJm8uibL38wrMX+rgc1s6DQlrYfReMLcV kCZbv2z/w1r5lQbugoKKLJHz1FdoKztDqDvh774qZnRJk4RUbbvDe9sY2QJfAA1g0yNbdR +xvYZXR4YWl7X8kmUhPvQI5vNKgDXpI= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=scU5HmOE; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706815678; a=rsa-sha256; cv=none; b=Rw9h5Yol4X9hLIEuixmUOwQtRQkA09D27w4Um0fqwf9GTmW3FqAdwH3EOEf79MQYY87rd9 obmYW1fnpKK/j3hItE0s8zNePR98R/p0cT8CW4QU0G0VZxHHFdMl89paJx0YJyfctxofs/ 4YSUar3vZTKOplAqllw/5kAhoI+sTYs= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ADGbXG1wyb/0DBh6Pfwj1Ti/Ouskw0VrsGb11D2Ftm8=; b=scU5HmOEOMoGYz8fzJ9Tos4jyZ 51+5MbPjnCuB40Mx2v1HoUzB9NWNRcq4vD02VH2mG4NDFP1C3GZ/P+a+YfCi51s4odsl9JZcT1F4E WdGVctfRUdnSgeQxJ0Eycv/lwqd/eCCOM0XBqHPucd9hE+z68AhCcgmqOFlYRZBBht0rKC7PyrcqR uja1hHT6sU39uoAhCigaIoXTT2MsLDg87eYfWqL0xcRLbF+5tFtqMa5nnQ5rtkHYYm99MYJkJOvTP /oTithUW5PCD0FanmEk9Cx897gcpz+pzpZhveTL3qvKvpUMxFDHo2IcgTWMIYUnpZkTmBbXTprDvR AKlWwThw==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rVcj4-0000000GcXF-2Fr0; Thu, 01 Feb 2024 19:27:54 +0000 Date: Thu, 1 Feb 2024 19:27:54 +0000 From: Matthew Wilcox To: Kefeng Wang Cc: Andrew Morton , linux-mm@kvack.org, Tony Luck , Naoya Horiguchi , Miaohe Lin , David Hildenbrand , Muchun Song , Benjamin LaHaise , jglisse@redhat.com, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH rfc 2/9] mm: migrate_device: use more folio in __migrate_device_pages() Message-ID: References: <20240129070934.3717659-1-wangkefeng.wang@huawei.com> <20240129070934.3717659-3-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240129070934.3717659-3-wangkefeng.wang@huawei.com> X-Rspamd-Queue-Id: E94804001E X-Rspam-User: X-Stat-Signature: 1tq1tbnzesjia8dc7zwhpad5zz4enhus X-Rspamd-Server: rspam01 X-HE-Tag: 1706815677-178515 X-HE-Meta: U2FsdGVkX1+QX80obXFSfmiYPD45qcd8Hn7chBeWoanUySOSnG9Ai558nzzbm5zTEanvKul/EAftluijIJE9TJLgYMOYpJrU6n11QxrYY8yf6B+RKbmYapqWq96WdW/UEVs9o6ORwotcPKftmU2qc6TsuwAoGfwiYFW7v5eF8JJFcg8aGA52JNqAABP/wBt0ENJrCyp/lX5BhOe3dnUzZe8WAKwSmlVUEW8wdWdWB6U/Dk0d2DTYbvdOab7ikibe8tKogQlxSjjoDJ/tfSNuL/gStH1TKKQH40/O/Qc0f3a3ymjzHJr5VmuMwPQ6qKnM1fAxha1Ynk/N7yOM0zGSGep5G+rFzkkVX/U82aRJOVvjrh6s3+cB9Zy380ZwYGjyGXRhirOj2YBPrtpVjgqXsYRO2WHcFi/qltzLr724W19101l01f6EiME7TySISx5qvy7xbTKM8gKqsgh9ulC4cP4BER4QsU1BxBOfEGbYclm+jzoej8bhtPXWaYGzX5Z5gYY3Foi1l0TYbt7U34E05cJ4jkYxbS0cOzd/8rOxQGkB8P/3yKCPhPDbXrdVrGwxV1mtoCxiS1p/6GIJEoGafGnU25a/l1U+DbWNERtSqTHZXbFNgJQ8WNhu9DqEwQn3ehk/WeuBupDEwkP5juZ1sb0XPETSiHzMULzJnwkuAfzdyIOcfL519sXR5onzMFcEXCGn67XkM0xMs0fijVSE9/HBgWrMdxDhqS3L2EQSUqTs6+Mg55+WMJcymL9nO3cPOU7/uOumwDpY32wtThl1YEKJiezjH93wj4HE2MCeR1ftzSsF+edgfjjIfCjqIwmZlJE3BZqIXGk/AdegYKFMO7pgVRXGI+8ujOjKvPQhOO2ByH02h+0Aj0J1AW+KbxQUGXY80Ovygddy7qdP05Eq6oOhx522e322TBcp4U4/IFSYfzNBPQLGtl7C4R4nk7oo05Za5RAYzusClYCbwW1 JSCHDns+ swAPdOJrMdPmfJ8W+hhYxZkm6HRasot4U1lfSUP6WiVkvEokN/JGG2KFMR+oA0fYYF6mwGrOscIQM+LDmkQS2W14lOeurEeZtUEcSFyqugQatJ0Y8eaBaBrI0/q8bEJHjtEsCYRX5syDNXdJ3jHLzT1765wzjak5HJVQsr27EGUjzudlBHwMeo02DdawoVl+B0mgqwU2Cf8PWIfv/eQAGMe8Es6gJSHbFsixCDPOMJL5YBi85B77JJxu1hg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 29, 2024 at 03:09:27PM +0800, Kefeng Wang wrote: > Use newfolio/folio for migrate_folio_extra()/migrate_folio() to > save three compound_head() calls. I've looked at this function before and I get stuck on the question of whether a device page truly is a folio or not. I think for the moment, we've decided that it is, so .. Reviewed-by: Matthew Wilcox (Oracle) Although ... > @@ -729,13 +730,12 @@ static void __migrate_device_pages(unsigned long *src_pfns, > } > > mapping = page_mapping(page); > + folio = page_folio(page); > + newfolio = page_folio(newpage); you should save one more call to compound_head() by changing the page_mapping() to folio_mapping().