From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCF2BC4828F for ; Thu, 1 Feb 2024 13:47:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C995D6B007D; Thu, 1 Feb 2024 08:47:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C4AB96B0085; Thu, 1 Feb 2024 08:47:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B39126B0087; Thu, 1 Feb 2024 08:47:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A44796B007D for ; Thu, 1 Feb 2024 08:47:12 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6F40D1C0EF8 for ; Thu, 1 Feb 2024 13:47:12 +0000 (UTC) X-FDA: 81743361504.24.A958DE5 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf01.hostedemail.com (Postfix) with ESMTP id 26F6C4001B for ; Thu, 1 Feb 2024 13:47:09 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ZTZ1f+NB; spf=none (imf01.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706795230; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tYvzDfQFwKusRhTebIY0H6L6hobYf0zaXRaAkQ0RHv0=; b=YhDWGn6jWcyTZMhwZbT0ohXhOg56wjUtrhAEz0phqy9QI4hOrzWJR3Jiol7TqAj+CO2pya BDI0T3V6/Y/FmGuf/o9GwqmTQHF7ZLh/IuBrVJU7ocsnSf/RPMW9/4DpTuE17/8JYAQt0J 0h65zMSMyshHZYrT1gLnUtsa1MwwhMc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706795230; a=rsa-sha256; cv=none; b=rEmuwjqCb5oI0Bn7kgvwUktYzthfB+YnMMLVqToDWtnWwViqNxdAqCWWdVaI3XFFRYSleM wBYULBuCACJMgtnjzWAxxObNgge+9rEnouWxZtkE5vQyY24fRxY3bUTihfUdwfkFZ3O/wn SgQOMi7ho33uxQUQtOozanmW6k3KvQo= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ZTZ1f+NB; spf=none (imf01.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=tYvzDfQFwKusRhTebIY0H6L6hobYf0zaXRaAkQ0RHv0=; b=ZTZ1f+NBXyhYPNqdhJlWo2ZOEI R/PgLoYl3Eee9mq1bkdGmYgdsofoHdCGIMIHplMCeFEMN14Ee/o8MDdHGxDOo97AGNQ4KWkeOhSz8 Mc1liETjGH0RSzqfoTUWc18nQjpe8Eb/RA0YCjPwu09qbdoYEz90KpimVadd+QhkAXlZya91W96Sg P9G1m2TeVnCaobr8RXj5qAXdU5idsx33NPYyaYEJDHXZil8IiYak8DSKGLSwabiXHpLsDj05/0KbJ NjB9SMjRnQNle5b1DGFPL2d8rrRpyEfnetRXjcgalgNuhGyu8HR+hH4OpEiooAYv0AbUIKemBmACr v31qxLJQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rVXPD-0000000FwiQ-2CYU; Thu, 01 Feb 2024 13:47:03 +0000 Date: Thu, 1 Feb 2024 13:47:03 +0000 From: Matthew Wilcox To: Liu Shixin Cc: Alexander Viro , Christian Brauner , Jan Kara , Andrew Morton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/2] mm/readahead: stop readahead loop if memcg charge fails Message-ID: References: <20240201100835.1626685-1-liushixin2@huawei.com> <20240201100835.1626685-2-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240201100835.1626685-2-liushixin2@huawei.com> X-Rspamd-Queue-Id: 26F6C4001B X-Rspam-User: X-Stat-Signature: b9bf9uhw6h7h4adttr68u9u9oz74c3ge X-Rspamd-Server: rspam03 X-HE-Tag: 1706795229-25633 X-HE-Meta: U2FsdGVkX19/ZTLGBB6VZcNA3PILPN5QTsgDeW17J9t1bVuJzNwB5crUzx6AAIIrGTtb8KFytsmGZCShR4mUP4GZK7WIEwRrLOYqw9ifQd8RZXb9PwdzSDe6yWi3cixVSQ5biHijxwJO5mDkRKUjrWlBjEhrFrMHn78TpS8wlg+3xbXsPpGfJctsYhd2AU/hK7pG2lFZlHXZmuHeeNX4eGSADsWRsO/PQY8XULMkvezgoo8qvQI+Ai3KHVDj7lX1Kpout4TxDip4Z0eGQNXlghHQaht1R/xwLCM0ibOkt0wGp/Ae8Knq2L6VCU7TE/PvsBhZU6TysyxzBTRVhpHIEGi8bvp9cRIBxg8hekMGeBUiWzVQu/oGDobzQGW4x/vuGncM9WOqPYlFhA/KUqoSRB4OeJcn1MkgRSN43S2Ebm8wAtE2xMQHaFmmHne5RLMicsPMtrd1jUZjIXJc9MdQ6xO3OhB20xcKsUQWKJoRneO5TkBFeoEHDiUzx9EyHwpREU9y9gHPPOwnnqfw+yYnZARzdALcUH1p7uetROte9+9uOi7Q4UAR+Y5gmOiZqnzATmiY11GXZscdI+6mJU/tTj9mrHJbVLuOQ1qBJvsbBrfkh57sf/w7N2jZiO3waOjRwAg50yiwcQKseLXmAYfWgpzd7iDvW0NaCoELOUsZE9KX5XSVt4nigUBtF9r5WeGq3PrnUfoAzrTobXBm/smFK2uCyksi2AuC+0SPzOZKLwfCGRZz9F9cXej9jt/6sr9Q+c5nKrY6bmaDKdfGBY3i20EKeNCLD5/jOdzeiWkGyNmaMtIOh1jYcryVi2krlzA24DxiKnS0vMNN9SInOOzdU2CIa/4SIy6hIrykAgb3kFUqlUDWFsrv40idUxvukSbpR+Kh/YiFU3CFM5xLYxTvbajy/t2MIFjCHxXk5pcgLGZUtLxp66Ft+6vy/Y6KXxDymx0VKkzp1m0ycsjsrl0 CzkqT19d yHOq9rBnhrG2XsaqflHR3novDbcyG+/1Kv+I3juyuNYKccUNlbTkh9zU1n5CCC3JyzMNvLX09CJOIUDRRtq3pgPcyO6obyl46MN7PzTRVV8MK9vAlPz3mFd1yOkwkvxq82Ikh171IczTP9Z4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 01, 2024 at 06:08:34PM +0800, Liu Shixin wrote: > @@ -247,9 +248,12 @@ void page_cache_ra_unbounded(struct readahead_control *ractl, > folio = filemap_alloc_folio(gfp_mask, 0); > if (!folio) > break; > - if (filemap_add_folio(mapping, folio, index + i, > - gfp_mask) < 0) { > + > + ret = filemap_add_folio(mapping, folio, index + i, gfp_mask); > + if (ret < 0) { > folio_put(folio); > + if (ret == -ENOMEM) > + break; No, that's too early. You've still got a batch of pages which were successfully added; you have to read them. You were only off by one line though ;-) > read_pages(ractl); > ractl->_index++; > i = ractl->_index + ractl->_nr_pages - index - 1; > -- > 2.25.1 > >