From: Matthew Wilcox <willy@infradead.org>
To: Liu Shixin <liushixin2@huawei.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH 1/2] mm/readahead: stop readahead loop if memcg charge fails
Date: Thu, 1 Feb 2024 13:47:03 +0000 [thread overview]
Message-ID: <Zbug14NoOHFmfLst@casper.infradead.org> (raw)
In-Reply-To: <20240201100835.1626685-2-liushixin2@huawei.com>
On Thu, Feb 01, 2024 at 06:08:34PM +0800, Liu Shixin wrote:
> @@ -247,9 +248,12 @@ void page_cache_ra_unbounded(struct readahead_control *ractl,
> folio = filemap_alloc_folio(gfp_mask, 0);
> if (!folio)
> break;
> - if (filemap_add_folio(mapping, folio, index + i,
> - gfp_mask) < 0) {
> +
> + ret = filemap_add_folio(mapping, folio, index + i, gfp_mask);
> + if (ret < 0) {
> folio_put(folio);
> + if (ret == -ENOMEM)
> + break;
No, that's too early. You've still got a batch of pages which were
successfully added; you have to read them. You were only off by one
line though ;-)
> read_pages(ractl);
> ractl->_index++;
> i = ractl->_index + ractl->_nr_pages - index - 1;
> --
> 2.25.1
>
>
next prev parent reply other threads:[~2024-02-01 13:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 10:08 [PATCH 0/2] Fix I/O high when memory almost met memcg limit Liu Shixin
2024-02-01 10:08 ` [PATCH 1/2] mm/readahead: stop readahead loop if memcg charge fails Liu Shixin
2024-02-01 9:28 ` Jan Kara
2024-02-01 13:47 ` Matthew Wilcox [this message]
2024-02-01 13:52 ` Jan Kara
2024-02-01 13:53 ` Matthew Wilcox
2024-02-01 10:08 ` [PATCH 2/2] mm/readahead: limit sync readahead while too many active refault Liu Shixin
2024-02-01 9:37 ` Jan Kara
2024-02-01 10:41 ` Liu Shixin
2024-02-01 17:31 ` Jan Kara
2024-02-02 1:25 ` Liu Shixin
2024-02-02 9:02 ` Liu Shixin
2024-02-29 9:01 ` Liu Shixin
2024-03-05 7:07 ` Liu Shixin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zbug14NoOHFmfLst@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liushixin2@huawei.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox