From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35E93C47258 for ; Thu, 1 Feb 2024 02:01:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F29F6B0087; Wed, 31 Jan 2024 21:01:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A2FF6B0093; Wed, 31 Jan 2024 21:01:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 843736B0095; Wed, 31 Jan 2024 21:01:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 74A966B0087 for ; Wed, 31 Jan 2024 21:01:20 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1CEA7120213 for ; Thu, 1 Feb 2024 02:01:20 +0000 (UTC) X-FDA: 81741582720.26.391158B Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2110.outbound.protection.outlook.com [40.107.244.110]) by imf16.hostedemail.com (Postfix) with ESMTP id 465B9180004 for ; Thu, 1 Feb 2024 02:01:17 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=memverge.com header.s=selector2 header.b=E3UOeauO; dmarc=pass (policy=none) header.from=memverge.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf16.hostedemail.com: domain of gregory.price@memverge.com designates 40.107.244.110 as permitted sender) smtp.mailfrom=gregory.price@memverge.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706752877; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eVjVkooVbPRw3vwlMOqLorO9qpYDJaaMeOD0+bjpfzk=; b=eLOmbmWPjyYV+LB2+sZE0Q+sGhceE4j/3/DCkOw1+AdzYG1FMcsdfEL5ehsDUR598RuNdj E9R7kIDYBPkWWnoeS1/9ppT6/TeJnG4D1NK5zp9/qAUY/Vt7g/lAvN45kOhycY0HWLUX7a x3WZEo4nvuv28fm6iXgzmYy0LevjS0U= ARC-Authentication-Results: i=2; imf16.hostedemail.com; dkim=pass header.d=memverge.com header.s=selector2 header.b=E3UOeauO; dmarc=pass (policy=none) header.from=memverge.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf16.hostedemail.com: domain of gregory.price@memverge.com designates 40.107.244.110 as permitted sender) smtp.mailfrom=gregory.price@memverge.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1706752877; a=rsa-sha256; cv=pass; b=vTYkQgGLniyVAkTuW8osSaW5mulJxPyPJvfpVDRb+E+MAg0ZTJvPCiQL+sOJCK80Bg5LPT FbXUA00RIhtxjwYRi68gKW/swt0zwZNQKUMXpQVjP8vRcW3YC142FQnhDNW9mkjnPOBxGe +GhQszJhrQ8o6NRFizq91k1F4IQwr5g= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IuNUgMINKm/R7hEP9k6WAwuefdbcZnUU6ANm/7Jw1fqrHjti4nhafqxdITn4RlbuVxBwx+PLZmMwStiqyJs3HWsABjVfpU0dfqPjxv+7R/NTp/bx0qF+r9sYWDw6y046YYWbaEt5awqPB99oFGsquOiCYYLcsHCMFScT4KunxAXv0fa4GMnn2OqLjm9EU3qCno57UE4PV9OAH7NWUOngZO2OD3gAAno4YCsl9HduSHSWO1b50pDToUrSWABjXdNkuzU6yaBTeKX1k8GLG9K1zRcHYtCot/rJ4WK0XKrgMIheHFgK8M26Ga0r9o0sqXU9evUaU1j7IzgRaXAWeDGZHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eVjVkooVbPRw3vwlMOqLorO9qpYDJaaMeOD0+bjpfzk=; b=fYtwVpMyqV+eHV/IUyhlhEuLm4OjUMyZ61FTdTsj7GkJ2QotYI5Qv5wSTv/8oPqV6hVBq1DC/O2+/5eUA4GPFN1/5KdrdgsqCvi3A+QrkTQX5WK4P4xuqSCWWNrb24QtF1o7YohER4HNndE/dHQWNdNFXvFI4Hi0Gyn7Qrn5Y2HCVIMGl2qqzJHSp4NcRqsU04+udDydte8+ZXGKtqlnVIcRLO7n1MDr/flm0sXw7qmDEluotmYA3HKKMQNhD3ww1tyg5jC3uu9jtsPlIoXsnqzeUHWxm4Miyii5k6L5w21Y+GVAc4QngkAA077v7R/VNPZacVr2ca5Qx07sj4+a5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=memverge.com; dmarc=pass action=none header.from=memverge.com; dkim=pass header.d=memverge.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=memverge.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eVjVkooVbPRw3vwlMOqLorO9qpYDJaaMeOD0+bjpfzk=; b=E3UOeauOMRv8ujkD5PfN4yFadKE7KVorwj25jt0cm1K5xUz783Ek1LFbXxj/XvR5g57eO4x70OHc/mw/VH7XvqUReqSkeksTSQ5HDE/ks51P/fzjQt5J0zumeltURllNEnxiDlf0sc6WjgJK1E3b1SdPd2EAfF7VuQCFQ+uJNmA= Received: from SJ0PR17MB5512.namprd17.prod.outlook.com (2603:10b6:a03:394::19) by MW3PR17MB4217.namprd17.prod.outlook.com (2603:10b6:303:43::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.24; Thu, 1 Feb 2024 02:01:12 +0000 Received: from SJ0PR17MB5512.namprd17.prod.outlook.com ([fe80::7a04:dc86:2799:2f15]) by SJ0PR17MB5512.namprd17.prod.outlook.com ([fe80::7a04:dc86:2799:2f15%5]) with mapi id 15.20.7249.025; Thu, 1 Feb 2024 02:01:12 +0000 Date: Wed, 31 Jan 2024 21:01:07 -0500 From: Gregory Price To: "Huang, Ying" Cc: Gregory Price , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, corbet@lwn.net, akpm@linux-foundation.org, honggyu.kim@sk.com, rakie.kim@sk.com, hyeongtak.ji@sk.com, mhocko@kernel.org, vtavarespetr@micron.com, jgroves@micron.com, ravis.opensrc@micron.com, sthanneeru@micron.com, emirakhur@micron.com, Hasan.Maruf@amd.com, seungjun.ha@samsung.com, hannes@cmpxchg.org, dan.j.williams@intel.com, Srinivasulu Thanneeru Subject: Re: [PATCH v4 3/3] mm/mempolicy: introduce MPOL_WEIGHTED_INTERLEAVE for weighted interleaving Message-ID: References: <20240130182046.74278-1-gregory.price@memverge.com> <20240130182046.74278-4-gregory.price@memverge.com> <877cjqgfzz.fsf@yhuang6-desk2.ccr.corp.intel.com> <87y1c5g8qw.fsf@yhuang6-desk2.ccr.corp.intel.com> <871q9xeyo4.fsf@yhuang6-desk2.ccr.corp.intel.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871q9xeyo4.fsf@yhuang6-desk2.ccr.corp.intel.com> X-ClientProxiedBy: BYAPR02CA0015.namprd02.prod.outlook.com (2603:10b6:a02:ee::28) To SJ0PR17MB5512.namprd17.prod.outlook.com (2603:10b6:a03:394::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR17MB5512:EE_|MW3PR17MB4217:EE_ X-MS-Office365-Filtering-Correlation-Id: e981c151-c0e2-4185-5402-08dc22c9aa86 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4dHMDda+64xbKQBPWi63MHu+UgvlPmuxDdV7kVLz4URiaxkcoFJ3VG9licgntzuB/Dqn/Hd7DghM5KlZd/Dh9RPINMup+xCiog7AZQQQoPD6Q8TY3roSoQu6eoQeGTQEIpwIoWIH+Im+R/LxxG4TULrsTbIb3g368u26OVRK8GJTgye802LxvknTnx24J4A84Hli+bmZbvYK1P+5yOA6jYCOHhhB8WZ2ayThN8nBSBYotSlGgP9q12jO7KAeK8CGRA01ElbiIsaS323qkx/xTXbJr5fQIzxZTqTSLsENtxaHGDKHhJrbq6JoC0E7qWN5sHJdrL40O8GKL6HAQDjJxRQBFpOqQujWLPcDJe7QpkwNoz5/HHYCf70zpLX+GXbsl+aaQcvaWRpIKLrMj1Pnb7+iwbPJYRavYiTtHMQ0J60CqerRf6FFIDhaFrlqmP+0FT3xNKgnv5dMgMuX9jwaZjAZdU3KlnnTkytbWrPLz8EwtsTjbW3J+jo2xLR1f/cE1Ck3vp2lg+7TVYdtUZYjJyYR/+FTpScfXPTqb0VK/OvmWwOaeIJZA7ikbGaXL4FBP+mhbopuP/hcqqDPle4apwRXxmE7IBGYDAHEyGxkOjc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR17MB5512.namprd17.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(396003)(376002)(346002)(39850400004)(136003)(230922051799003)(186009)(64100799003)(451199024)(1800799012)(6666004)(316002)(66946007)(86362001)(54906003)(66556008)(6916009)(66476007)(38100700002)(4326008)(44832011)(8936002)(7416002)(8676002)(478600001)(2616005)(6512007)(26005)(6506007)(6486002)(5660300002)(966005)(83380400001)(36756003)(2906002)(41300700001)(16393002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1usUWRG110xduUaJ6+CUUNdEDudc+icOMzI2tfTe/xSp2jaSfZeHmMEaPaCy?= =?us-ascii?Q?LnA12d+Zn/1LTqv2WmAHqeGrSaOXdjROxMhZ5/U0p0bYgKewUHDcIb9mxJVV?= =?us-ascii?Q?XWoH+u2MENy1NwMAhjn33R+7eMxlWrSvtG+w44SeFad3TRsLK9zpW2ylYPGq?= =?us-ascii?Q?f3C7mfP3SWji6g04CUlTurMNeyczSHEVNH6Rd/Z0thpLzuLXBH4BFJvLsljh?= =?us-ascii?Q?xvXucyfxpTYaTHmum27PCYHRoEpX9i9+i8htDi4fi4iKZN70wQawTsy4xMEn?= =?us-ascii?Q?cAWNv0vvfxX4DlBIENuGe1YtjiTxA30mKRp0yPpnPRbvoGQWyAled5+OvXYd?= =?us-ascii?Q?yhQOedo5ArxsolahPGA5LSGKB+QydtApaZLtCIPW+owAq+PQdUog8Q3GjfLM?= =?us-ascii?Q?78W7Lkdivstk+GBUh1TQJChwx3y41kVlHovVHS46bXwneEDcB9Qg/RuC5LjQ?= =?us-ascii?Q?fy9Fr7wHdYMH1QTSRsrNcWzQX98JNjyazJdcrZi/F61zMwbev8gHhawCo9ZG?= =?us-ascii?Q?YgQDLsHh2ieS1IDckUrFevAixv/F3BGut7iFDj5TKIF28aqupJiR98DCDCeM?= =?us-ascii?Q?cd4w4Z0cBVXyuowVy/FnMAuNp6WKuhDu9a9A4+gY7/ih+ZHmG4vPI/l2ydds?= =?us-ascii?Q?xC1LS1SvKKeWzg0TY4wNFw6w2Uho8J6X3Xxdm5l+5/YZ1O1rNHQBGGtkQX+E?= =?us-ascii?Q?xrldUF9D4d8JDPYwdLFbtJUSkBs+dwfieZlKwMHgzqCMYf/Pe/TzwoN6nNCB?= =?us-ascii?Q?TvdGpqsJCMuu0mvUAY8iS8aqQ9uBM4rgwF05lTKPT9xeCeLKTMDeNmk/soa6?= =?us-ascii?Q?YFim75jLmhk5pCi/WMyFaawzv5awyKbicjIgxhoiZmxGQTHDzzuSBiKOsS3u?= =?us-ascii?Q?M3R9C/ofRqAwCTH3HjZDAZQcMIGeKpbAn5Sqo5k+fLLHMRxdno6lmVUw0h+Y?= =?us-ascii?Q?SCl2fp9+MFOo9v1wFqURtUR/XgXXxnwaQ1ueKZWZnid7WQibX7OLrAqPn2Y3?= =?us-ascii?Q?SQAbTJzlWFO9vKbPY0xFBtEZpw0ZpOQht1KAs3MJXLBClZkrpmzNTc/2SaUX?= =?us-ascii?Q?88Vs+yS9rMUIisHOvLc7FjZpoRwbM2HWAbsstMlkj/ANwidumnobKKoi2FAD?= =?us-ascii?Q?su+EpWrb/itFun63Gfge09iB9lmd9+r9MOLxaLT1LdRN27Kkj7Rl35kjWHRm?= =?us-ascii?Q?2fYGiWZ59nBy8kk0L5w565nWbJPD9Q6OwJA4wcxd/8QjnqBqBUvp6q/eIswT?= =?us-ascii?Q?EoP2CRRE+9WL/eNH1P+FJPqXHFQAGONyhluM4s54VfU+G7iYPjJmaqFGinp2?= =?us-ascii?Q?tLBoczCSLn6HMr+b/jkLI5pQcFHYJRJLQwBS/EGsxE/BDZDoqc/9JJnEfNrW?= =?us-ascii?Q?AFC713MNtjek5zmey8/dUOLOonlsE9TJgVXMfDMthIvefNTmSmzRi3hpVL+1?= =?us-ascii?Q?F5IILDJ5yaaIqyujJEziCC97BW+/OlOK/L+ns1W3yxEKX7jXktOfkeoI2dx3?= =?us-ascii?Q?cIx7+ncFAHZncT+vXL7Mtk2lgLNi7+V3xPDCEIW81pdhbe6A8VFRpBK+a43D?= =?us-ascii?Q?VioHhed7Nc5k69WjSeHBdEa0srWJGVL6HXqbcTajAt7LUXJM/PiaIHGl6o4b?= =?us-ascii?Q?eg=3D=3D?= X-OriginatorOrg: memverge.com X-MS-Exchange-CrossTenant-Network-Message-Id: e981c151-c0e2-4185-5402-08dc22c9aa86 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR17MB5512.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2024 02:01:12.5523 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5c90cb59-37e7-4c81-9c07-00473d5fb682 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 85Tl/0z3LQwgYidFQ/8172QgbvMADVkERUsl543WBFFHpgkgDPCqK2+0n1OJsBR5VKikkINBwQlJJSmSDoF3S7LPaJ60CwA+TTvsMcD6gYo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR17MB4217 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 465B9180004 X-Stat-Signature: kr3qgsmqgeiqkp51jd1ifynb971aoghm X-HE-Tag: 1706752877-677328 X-HE-Meta: U2FsdGVkX19R1e4z9381zrVywL/E0GbqhLEnM/Eg5CMyhHhGAU+C2pQi9PgR+C7uzI8j7dfKAlTaPyLO2VNkcAYC2ae+x112EnaHDN1dLvBNGvVOndlUsUntdI8668d7JkoiBMMGHD28nijlsZCYUIZR3pFWmJXvc8Q/FH9B461YpUb6bE4dCH1MGkK3suejtEStkcs40VfLnb8TRIyVC0dP/cqRiGbcwe2KJedYxrSom3yYkXVWqWexywyJ+KR3i3xsSdFlluaUwop4kv88fPItG5Gp8H2tRmKfoeohwHiGrs883FnQEkA1N4Kf3kInrbD1IONqAXSZiwFXEOY6DC0vcfYrLF5cfZS+Cg7vzQr07tO/62j4IvJDnFelHzvV1K/iwg41kTjeb4Z71EsnKT142VcsFKhxf8gTDDvlVG47F5ywiD+czOqQ8aI2mkfZP7moCrS+eI8HkMs1SS1Rnc5ckOUkEwK1WBkIVpgCyfe21LPEjLhCqLME0uPFtRPMJuGNKviFdWCV6xKv74AZc3b2cNd2smTS5o8adVHBUwYzwzuyJEa4w0vTpRvzALdpxkfuWIuiCKGTns/KXrWUvOtUp+Wr5qRp3WkIQ+kElvxvSnmCqiFpvd/zhMc3Y5EFvyD4OYIb39zAh+gZXlJCX1LQnzyYXTaEM/Wi7DZCR4KuYTo6A38D72t+T3zWWjInZv1JeTpWQtqFk9y3+j8MAvhbRTPVkGD/ITeiWsunfAhuRenV37T/CFQSTzDRk9ZtcouPddtAy/dj2QHzmf4GLDFdGalGYpI+hjdWvHIhzDQLw82iB+c06696DgkMwVJxT/3BLP1nNNfs3QGysuO8flClnMd6p9UzasyjpkoXU+QUZE2WK12axLk1m20wE9d7jqt+vCuW73ICIM/qXAob+45CxLzzKdNrKtxBAxtkoByAW2KWow326j7EV9lV6TWYK4SrzNkAMGlhIGnDtoo Un6Bqp2q NnhMBVRPpE77QlsEZkr4eMoIpQpeNPsd64Bw6KO2Gl4/C4fAYZkMKBC4up0yKmntQX5LcHWidyEcjZdWFaC+X/RMZ7L0hdmS18fnNQpDUqxpi0KNbZuctJo9Ps2OoEt/F5hREYQqDRBff9ya9jNRhHpGdjo7sAUKOVkRylcwJpkmHtvBIh7nD/NDIMRT0+TtmCZwGBgAcepTqBMlext04IYOVSB574tzhTuVNTDcJtF55w0DUp6+3UalpHuXDMo28sGU3Wp70kYBD9JH52V1w23rTjAcfVwSm96426InlwhFIItAxXe0mnTZAGQJiCPwBFDSWU6gep0CQ/FzvyQhPuPiaaAW91nSHGOzDkJxFwJtcMjWg6C2qrwGY+SJrEAfP76D+gco32YziB6i4pMrgD7p064cOw00V7DoYtUYixt+hK8J26LqsraM2PB5OIkf/7QvA4bmQ1oiRLKzLV7bpKzBf59ccxm8zWsBiYPWC23hbL0TjTcYHvP3GEw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 01, 2024 at 09:55:07AM +0800, Huang, Ying wrote: > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > > index b1437396c357..dfd097009606 100644 > > --- a/mm/mempolicy.c > > +++ b/mm/mempolicy.c > > @@ -2391,7 +2391,7 @@ static unsigned long alloc_pages_bulk_array_weighted_interleave(gfp_t gfp, > > unsigned long nr_allocated = 0; > > unsigned long rounds; > > unsigned long node_pages, delta; > > - u8 __rcu *table, *weights, weight; > > + u8 __rcu *table, __rcu *weights, weight; > > The __rcu usage can be checked with `sparse` directly. For example, > > make C=1 mm/mempolicy.o > > More details can be found in > > https://www.kernel.org/doc/html/latest/dev-tools/sparse.html > > Per my understanding, we shouldn't use "__rcu" here. Please search > "__rcu" in the following document. > > https://www.kernel.org/doc/html/latest/RCU/checklist.html > Thanks for this, I will sort this out and respond here with changes before v5. > > @@ -2460,17 +2454,10 @@ static unsigned long alloc_pages_bulk_array_weighted_interleave(gfp_t gfp, > > node_pages += weight; > > delta -= weight; > > } else if (delta) { > > + /* when delta is deleted, resume from that node */ > ~~~~~~~ > depleted? ack. > > +retry: > > + /* to prevent miscount use tsk->mems_allowed_seq to detect rebind */ > > + cpuset_mems_cookie = read_mems_allowed_begin(); > > if (!current->il_weight || !node_isset(node, policy->nodes)) { > > node = next_node_in(node, policy->nodes); > > node will be changed in the loop. So we need to change the logic here. > Good catch, stupid mistake. ack. > > @@ -2388,10 +2401,17 @@ static unsigned long alloc_pages_bulk_array_weighted_interleave(gfp_t gfp, > > int prev_node; > > int i; > > > > + > > Change by accident? > ack. ~Gregory